<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/ruby-gems/rack.git, branch main</title>
<subtitle>github.com: rack/rack.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/'/>
<entry>
<title>Fix comment about max Content-Disposition parameters</title>
<updated>2023-04-29T03:34:41+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-04-29T03:34:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=54990d39446caf046b5cbf19fd030204f850b480'/>
<id>54990d39446caf046b5cbf19fd030204f850b480</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Limit max size and number of parameters parsed for Content-Disposition</title>
<updated>2023-04-29T03:14:55+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-04-29T00:05:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=4f15681097997bd3f8b4f9ce1a7db296724e921a'/>
<id>4f15681097997bd3f8b4f9ce1a7db296724e921a</id>
<content type='text'>
Not strictly necessary, but this limits the damage in pathological
cases.  These limits are probably already too generous, we could
probably get by with 8 params and 1024 bytes.  One of tests uses
more than 1024 bytes, though.  Still, it seems unlikely any
legitimate requests would exceed these limits.  We could make the
limits configurable via an accessor method, if desired.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Not strictly necessary, but this limits the damage in pathological
cases.  These limits are probably already too generous, we could
probably get by with 8 params and 1024 bytes.  One of tests uses
more than 1024 bytes, though.  Still, it seems unlikely any
legitimate requests would exceed these limits.  We could make the
limits configurable via an accessor method, if desired.
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle invalid Content-Disposition filename encodings</title>
<updated>2023-04-28T23:53:00+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-04-28T22:22:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=a54b61511e1d08919ae2c6392fa3084290f70dd8'/>
<id>a54b61511e1d08919ae2c6392fa3084290f70dd8</id>
<content type='text'>
Use BINARY for this, as we do for multipart encodings.  Extract a
find_encoding method for this.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use BINARY for this, as we do for multipart encodings.  Extract a
find_encoding method for this.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Content-Disposition parameter parser</title>
<updated>2023-04-28T22:10:10+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-04-28T20:29:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=51b0c26bedf3b876188ff11d011d5c84e4941c49'/>
<id>51b0c26bedf3b876188ff11d011d5c84e4941c49</id>
<content type='text'>
The ReDoS fix in ee25ab9a7ee981d7578f559701085b0cf39bde77 breaks valid
requests, because colons are valid inside parameter values.  You cannot
use a regexp scan and ensure correct behavior, since values inside
parameters can be escaped.  Issues like this are the reason for the
famous "now they have two problems" quote regarding regexps.

Add a basic parser for parameters in Content-Disposition.  This parser
is based purely on String#{index,slice!,[],==}, usually with string
arguments for #index (though one case uses a simple regexp).  There
are two loops (one nested in the other), but the use of slice! ensures
that forward progress is always made on each loop iteration.

In addition to fixing the bug introduced by the security fix, this
removes multiple separate passes over the mime head, one pass to get
the parameter name for Content-Disposition, and a separate pass to get
the filename. It removes the get_filename method, though some of the
code is kept in a smaller normalize_filename method.

This removes 18 separate regexp contents that were previously used
just for the separate parse to find the filename for the content
disposition.

Fixes #2076
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The ReDoS fix in ee25ab9a7ee981d7578f559701085b0cf39bde77 breaks valid
requests, because colons are valid inside parameter values.  You cannot
use a regexp scan and ensure correct behavior, since values inside
parameters can be escaped.  Issues like this are the reason for the
famous "now they have two problems" quote regarding regexps.

Add a basic parser for parameters in Content-Disposition.  This parser
is based purely on String#{index,slice!,[],==}, usually with string
arguments for #index (though one case uses a simple regexp).  There
are two loops (one nested in the other), but the use of slice! ensures
that forward progress is always made on each loop iteration.

In addition to fixing the bug introduced by the security fix, this
removes multiple separate passes over the mime head, one pass to get
the parameter name for Content-Disposition, and a separate pass to get
the filename. It removes the get_filename method, though some of the
code is kept in a smaller normalize_filename method.

This removes 18 separate regexp contents that were previously used
just for the separate parse to find the filename for the content
disposition.

Fixes #2076
</pre>
</div>
</content>
</entry>
<entry>
<title>Add specs for underscore in host (#2072)</title>
<updated>2023-04-25T02:12:13+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-04-25T02:12:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=ab360dd5ba16361c562bdf482af8ab14141807a6'/>
<id>ab360dd5ba16361c562bdf482af8ab14141807a6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Limit file extension length of multipart tempfiles (#2069)</title>
<updated>2023-04-25T01:41:12+00:00</updated>
<author>
<name>Patrik Ragnarsson</name>
<email>patrik@starkast.net</email>
</author>
<published>2023-04-25T01:41:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=ccd445d7de85c4d5771e860add87104258b16f01'/>
<id>ccd445d7de85c4d5771e860add87104258b16f01</id>
<content type='text'>
- Fixes #1968 </content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Fixes #1968 </pre>
</div>
</content>
</entry>
<entry>
<title>Update MIME types associated to font extensions `.ttf`, `.woff`, `.woff2`, and `.otf` (#2065)</title>
<updated>2023-04-03T05:21:13+00:00</updated>
<author>
<name>David Stosik</name>
<email>davidstosik@users.noreply.github.com</email>
</author>
<published>2023-04-03T05:21:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=f5666bc8cb13b8d731ea0222fbd3ada670f2cd55'/>
<id>f5666bc8cb13b8d731ea0222fbd3ada670f2cd55</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle string reuse by body.each when buffering bodies in Rack::Response (#2044)</title>
<updated>2023-03-25T00:01:03+00:00</updated>
<author>
<name>Jeremy Evans</name>
<email>code@jeremyevans.net</email>
</author>
<published>2023-03-25T00:01:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=b172805895fc0490bf81e942487233e6771f4643'/>
<id>b172805895fc0490bf81e942487233e6771f4643</id>
<content type='text'>
An alternative approach would be using a single string inside an array
and appending to that.  This approach is more backwards compatible,
but results in more memory usage.

Fixes #1957</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
An alternative approach would be using a single string inside an array
and appending to that.  This approach is more backwards compatible,
but results in more memory usage.

Fixes #1957</pre>
</div>
</content>
</entry>
<entry>
<title>Fix borked changelog.</title>
<updated>2023-03-23T09:16:53+00:00</updated>
<author>
<name>Samuel Williams</name>
<email>samuel.williams@oriontransfer.co.nz</email>
</author>
<published>2023-03-23T09:16:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=d4c159f66a0bbf92be2512df2099698097d42120'/>
<id>d4c159f66a0bbf92be2512df2099698097d42120</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Changelog: fix typo in version number (#2063)</title>
<updated>2023-03-23T09:11:14+00:00</updated>
<author>
<name>Patrik Ragnarsson</name>
<email>patrik@starkast.net</email>
</author>
<published>2023-03-23T09:11:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/rack.git/commit/?id=2214807032fac90437e409afbccc3242fbc94ea9'/>
<id>2214807032fac90437e409afbccc3242fbc94ea9</id>
<content type='text'>
https://rubygems.org/gems/rack/versions says 3.0.4.2 was released March 02, 2023

[ci skip]</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://rubygems.org/gems/rack/versions says 3.0.4.2 was released March 02, 2023

[ci skip]</pre>
</div>
</content>
</entry>
</feed>
