From 96758e813d3e3ff1d03073e8b7badb2535c5ab76 Mon Sep 17 00:00:00 2001
From: Laurent Arnoud <laurent@spkdev.net>
Date: Sun, 29 Dec 2019 17:04:27 +0000
Subject: Add error unimplemented (#51)

* Add test for unimplemented error
* Add UnimplementedElementError exception
---
 lib/plist/parser.rb | 7 ++++++-
 test/test_parser.rb | 6 ++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/lib/plist/parser.rb b/lib/plist/parser.rb
index 144e795..f325988 100755
--- a/lib/plist/parser.rb
+++ b/lib/plist/parser.rb
@@ -13,6 +13,9 @@
 #
 #   r = Plist.parse_xml(filename_or_xml)
 module Plist
+  # Raised when an element is not implemented
+  class UnimplementedElementError < RuntimeError; end
+
   # Note that I don't use these two elements much:
   #
   #  + Date elements are returned as DateTime objects.
@@ -81,6 +84,8 @@ module Plist
     DOCTYPE_PATTERN = /\s*<!DOCTYPE\s+(.*?)(\[|>)/m
     COMMENT_START = /\A<!--/
     COMMENT_END = /.*?-->/m
+    UNIMPLEMENTED_ERROR = 'Unimplemented element. ' \
+      'Consider reporting via https://github.com/patsplat/plist/issues'
 
     def parse
       plist_tags = PTag.mappings.keys.join('|')
@@ -114,7 +119,7 @@ module Plist
         elsif @scanner.scan(end_tag)
           @listener.tag_end(@scanner[1])
         else
-          raise "Unimplemented element"
+          raise UnimplementedElementError.new(UNIMPLEMENTED_ERROR)
         end
       end
     end
diff --git a/test/test_parser.rb b/test/test_parser.rb
index f110a9f..7b692a5 100755
--- a/test/test_parser.rb
+++ b/test/test_parser.rb
@@ -116,4 +116,10 @@ class TestParser < Test::Unit::TestCase
       assert_equal("\u0099", data["non-ascii-but-utf8-character"])
     end
   end
+
+  def test_unimplemented_element
+    assert_raise Plist::UnimplementedElementError do
+      Plist.parse_xml('<string>Fish &amp; Chips</tring>')
+    end
+  end
 end
-- 
cgit v1.2.1