From b07e284bd64750150d38bd207e9b7b37a1f15e83 Mon Sep 17 00:00:00 2001 From: Florian Wininger Date: Fri, 29 Apr 2022 14:32:19 +0200 Subject: update rubocop config --- .rubocop_todo.yml | 39 ++++++++++++++++++++++++--------------- net-ssh.gemspec | 2 +- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b7eb90f..ff2f2fa 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-04-12 08:30:13 UTC using RuboCop version 1.27.0. +# on 2022-04-29 12:31:14 UTC using RuboCop version 1.28.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -309,7 +309,7 @@ Naming/ConstantName: - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb' - 'lib/net/ssh/transport/openssl.rb' -# Offense count: 12 +# Offense count: 15 # Configuration parameters: ForbiddenDelimiters. # ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) Naming/HeredocDelimiterNaming: @@ -330,7 +330,7 @@ Naming/MemoizedInstanceVariableName: - 'test/authentication/test_key_manager.rb' # Offense count: 32 -# Configuration parameters: EnforcedStyle, IgnoredPatterns. +# Configuration parameters: EnforcedStyle, AllowedPatterns, IgnoredPatterns. # SupportedStyles: snake_case, camelCase Naming/MethodName: Exclude: @@ -557,6 +557,20 @@ Style/ExplicitBlockArgument: - 'test/integration/mitm_server.rb' - 'test/integration/test_forward.rb' +# Offense count: 12 +# This cop supports safe auto-correction (--auto-correct). +# Configuration parameters: AllowedVars. +Style/FetchEnvVar: + Exclude: + - 'lib/net/ssh.rb' + - 'lib/net/ssh/authentication/agent.rb' + - 'lib/net/ssh/authentication/methods/hostbased.rb' + - 'test/authentication/test_agent.rb' + - 'test/common.rb' + - 'test/start/test_options.rb' + - 'test/test_all.rb' + - 'test/test_config.rb' + # Offense count: 1 # This cop supports safe auto-correction (--auto-correct). Style/FileWrite: @@ -572,7 +586,7 @@ Style/FormatString: - 'lib/net/ssh/authentication/pageant.rb' - 'lib/net/ssh/loggable.rb' -# Offense count: 173 +# Offense count: 174 # This cop supports safe auto-correction (--auto-correct). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -586,7 +600,7 @@ Style/GlobalStdStream: - 'lib/net/ssh.rb' # Offense count: 35 -# Configuration parameters: MinBodyLength. +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Enabled: false @@ -797,7 +811,7 @@ Style/PercentLiteralDelimiters: - 'net-ssh.gemspec' - 'test/test_config.rb' -# Offense count: 16 +# Offense count: 17 # This cop supports safe auto-correction (--auto-correct). Style/PerlBackrefs: Exclude: @@ -858,11 +872,6 @@ Style/RedundantFileExtensionInRequire: Exclude: - 'lib/net/ssh/transport/cipher_factory.rb' -# Offense count: 1 -Style/RedundantInitialize: - Exclude: - - 'lib/net/ssh/prompt.rb' - # Offense count: 2 # This cop supports safe auto-correction (--auto-correct). Style/RedundantInterpolation: @@ -876,7 +885,7 @@ Style/RedundantPercentQ: Exclude: - 'net-ssh.gemspec' -# Offense count: 9 +# Offense count: 11 # This cop supports safe auto-correction (--auto-correct). Style/RedundantRegexpEscape: Exclude: @@ -986,7 +995,7 @@ Style/SoleNestedConditional: # Offense count: 18 # This cop supports safe auto-correction (--auto-correct). # Configuration parameters: RequireEnglish, EnforcedStyle. -# SupportedStyles: use_perl_names, use_english_names +# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names Style/SpecialGlobalVars: Exclude: - 'lib/net/ssh/authentication/agent.rb' @@ -1020,7 +1029,7 @@ Style/StringConcatenation: - 'test/test_buffer.rb' - 'test/test_key_factory.rb' -# Offense count: 1846 +# Offense count: 1849 # This cop supports safe auto-correction (--auto-correct). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -1029,7 +1038,7 @@ Style/StringLiterals: # Offense count: 6 # This cop supports unsafe auto-correction (--auto-correct-all). -# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods. +# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods, AllowComments. # IgnoredMethods: respond_to, define_method Style/SymbolProc: Exclude: diff --git a/net-ssh.gemspec b/net-ssh.gemspec index dcb832b..e98bc66 100644 --- a/net-ssh.gemspec +++ b/net-ssh.gemspec @@ -40,5 +40,5 @@ Gem::Specification.new do |spec| spec.add_development_dependency "minitest", "~> 5.10" spec.add_development_dependency "mocha", "~> 1.11.2" spec.add_development_dependency "rake", "~> 12.0" - spec.add_development_dependency "rubocop", "~> 1.27.0" + spec.add_development_dependency "rubocop", "~> 1.28.0" end -- cgit v1.2.1