From c9831237b01eb672e1f59cf607a9a57bbcd61476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Tarti=C3=A8re?= Date: Sat, 19 Mar 2016 11:30:36 +0100 Subject: Highlight bug: eql? is not aliased to the overridden ==. ~~~ IPAddress.parse('::1') == IPAddress.parse('::1') #=> true IPAddress.parse('::1').eql? IPAddress.parse('::1') #=> false ~~~ --- test/ipaddress/ipv4_test.rb | 2 ++ test/ipaddress/ipv6_test.rb | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/test/ipaddress/ipv4_test.rb b/test/ipaddress/ipv4_test.rb index 19264e2..3fc808b 100644 --- a/test/ipaddress/ipv4_test.rb +++ b/test/ipaddress/ipv4_test.rb @@ -361,8 +361,10 @@ class IPv4Test < Minitest::Test assert_equal false, ip3 < ip1 # ip1 should be equal to itself assert_equal true, ip1 == ip1 + assert_equal true, ip1.eql?(ip1) # ip1 should be equal to ip4 assert_equal true, ip1 == ip4 + assert_equal true, ip1.eql?(ip4) # test sorting arr = ["10.1.1.1/8","10.1.1.1/16","172.16.1.1/14"] assert_equal arr, [ip1,ip2,ip3].sort.map{|s| s.to_string} diff --git a/test/ipaddress/ipv6_test.rb b/test/ipaddress/ipv6_test.rb index dcfb601..a1cd072 100644 --- a/test/ipaddress/ipv6_test.rb +++ b/test/ipaddress/ipv6_test.rb @@ -247,6 +247,11 @@ class IPv6Test < Minitest::Test assert_equal false, ip3 < ip1 # ip1 should be equal to itself assert_equal true, ip1 == ip1 + assert_equal true, ip1.eql?(ip1) + # ip1 should be equal to a copy of itself + other = ip1.dup + assert_equal true, ip1 == other + assert_equal true, ip1.eql?(other) # ip4 should be greater than ip1 assert_equal true, ip1 < ip4 assert_equal false, ip1 > ip4 -- cgit v1.2.1 From 9b8d8fdd6489472349843d4607f8be8e05024857 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Tarti=C3=A8re?= Date: Sat, 19 Mar 2016 11:31:57 +0100 Subject: Alias eql? and == ~~~ IPAddress.parse('::1') == IPAddress.parse('::1') #=> true IPAddress.parse('::1').eql? IPAddress.parse('::1') #=> true ~~~ --- lib/ipaddress/ipv4.rb | 1 + lib/ipaddress/ipv6.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/ipaddress/ipv4.rb b/lib/ipaddress/ipv4.rb index 7d8e0d3..3ad2c15 100644 --- a/lib/ipaddress/ipv4.rb +++ b/lib/ipaddress/ipv4.rb @@ -512,6 +512,7 @@ module IPAddress; return prefix <=> oth.prefix if to_u32 == oth.to_u32 to_u32 <=> oth.to_u32 end + alias eql? == # # Returns the number of IP addresses included diff --git a/lib/ipaddress/ipv6.rb b/lib/ipaddress/ipv6.rb index 88098bc..2dda4d2 100644 --- a/lib/ipaddress/ipv6.rb +++ b/lib/ipaddress/ipv6.rb @@ -490,6 +490,7 @@ module IPAddress; return prefix <=> oth.prefix if to_u128 == oth.to_u128 to_u128 <=> oth.to_u128 end + alias eql? == # # Returns the address portion of an IP in binary format, -- cgit v1.2.1