<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/ruby-gems/chef.git/spec/unit/shell, branch https</title>
<subtitle>github.com: opscode/chef.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/'/>
<entry>
<title>Remove copyright dates</title>
<updated>2020-04-13T22:47:17+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2020-04-13T22:21:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=4d3b847aee1b917bb139862c623e9633d180fb31'/>
<id>4d3b847aee1b917bb139862c623e9633d180fb31</id>
<content type='text'>
Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix 4 cops</title>
<updated>2019-07-05T20:41:00+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2019-07-05T20:41:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=174a2748b54a5dbd746005e2aead59221b80f2b9'/>
<id>174a2748b54a5dbd746005e2aead59221b80f2b9</id>
<content type='text'>
- Layout/MultilineMethodCallBraceLayout
- Layout/ClosingParenthesisIndentation
- Layout/IndentFirstArgument
  EnforcedStyle: consistent
- Layout/BlockEndNewline

the first of these autocorrected to horrible looking code which exposed
that we really needed the other three as well, which also cleaned up a
bunch of other terrible looking code.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Layout/MultilineMethodCallBraceLayout
- Layout/ClosingParenthesisIndentation
- Layout/IndentFirstArgument
  EnforcedStyle: consistent
- Layout/BlockEndNewline

the first of these autocorrected to horrible looking code which exposed
that we really needed the other three as well, which also cleaned up a
bunch of other terrible looking code.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Style/SymbolProc</title>
<updated>2019-07-05T20:26:53+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2019-07-05T20:26:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=3b10f9ca503dcbce747241281b9151d3d010f9ef'/>
<id>3b10f9ca503dcbce747241281b9151d3d010f9ef</id>
<content type='text'>
enforce pretzels.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
enforce pretzels.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix Layout/AlignArguments</title>
<updated>2019-07-02T18:13:54+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2019-07-02T18:11:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=77f8739a4741e2370e40ec39345a92a6ea393a1a'/>
<id>77f8739a4741e2370e40ec39345a92a6ea393a1a</id>
<content type='text'>
this is using:

Layout/AlignArguments:
  Enabled: true
  EnforcedStyle: with_fixed_indentation

the default style can use really excessive whitespace.  on starting
lines which are already long, it fully indents across to where the
arguments start and then begins the line there.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
this is using:

Layout/AlignArguments:
  Enabled: true
  EnforcedStyle: with_fixed_indentation

the default style can use really excessive whitespace.  on starting
lines which are already long, it fully indents across to where the
arguments start and then begins the line there.

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Work around rspec 3.8.0 issues</title>
<updated>2018-09-26T05:33:30+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2018-09-26T05:33:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=9fb62cda391591e0369ce32b8c8ec1afd3dfb8af'/>
<id>9fb62cda391591e0369ce32b8c8ec1afd3dfb8af</id>
<content type='text'>
Problem is described in detail here:

https://github.com/rspec/rspec-expectations/issues/1068#issuecomment-424580564

Note that this is self-inflicted damage and our pattern of having #to_hash
on objects be called by #to_json and to produce a serialized 'flavor' of
the object breaks what ruby's semantics are supposed to be and those
should all be `#to_h` methods, and we should deprecate `#to_hash` but I
imagine that will be a reasonably large breaking change (Although
hopefully most of the use by users will be Node#to_hash which is
entirely correct usage since that thing is actually a kind of glorified
Hash-like monster).

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem is described in detail here:

https://github.com/rspec/rspec-expectations/issues/1068#issuecomment-424580564

Note that this is self-inflicted damage and our pattern of having #to_hash
on objects be called by #to_json and to produce a serialized 'flavor' of
the object breaks what ruby's semantics are supposed to be and those
should all be `#to_h` methods, and we should deprecate `#to_hash` but I
imagine that will be a reasonably large breaking change (Although
hopefully most of the use by users will be Node#to_hash which is
entirely correct usage since that thing is actually a kind of glorified
Hash-like monster).

Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix Layout/LeadingCommentSpace</title>
<updated>2018-07-02T17:31:50+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2018-07-02T17:31:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=cdad2f684debda15e8cf773185e78f93892eda35'/>
<id>cdad2f684debda15e8cf773185e78f93892eda35</id>
<content type='text'>
Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix Style/HashSyntax</title>
<updated>2018-07-02T17:25:16+00:00</updated>
<author>
<name>Lamont Granquist</name>
<email>lamont@scriptkiddie.org</email>
</author>
<published>2018-07-02T17:25:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=35603c7ce1bd3ccf35334ed65152140f0ecaf080'/>
<id>35603c7ce1bd3ccf35334ed65152140f0ecaf080</id>
<content type='text'>
Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lamont Granquist &lt;lamont@scriptkiddie.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add the ability to inject log objects</title>
<updated>2018-03-19T21:36:23+00:00</updated>
<author>
<name>Thom May</name>
<email>thom@chef.io</email>
</author>
<published>2018-02-14T12:22:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=94222a8a0a1cda16d35c8f08c731a3f902449391'/>
<id>94222a8a0a1cda16d35c8f08c731a3f902449391</id>
<content type='text'>
meaning that we can have inheritable metadata

Signed-off-by: Thom May &lt;thom@chef.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
meaning that we can have inheritable metadata

Signed-off-by: Thom May &lt;thom@chef.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Unit tests for json attribs and chef-shell</title>
<updated>2017-08-10T20:27:32+00:00</updated>
<author>
<name>Bryan McLellan</name>
<email>btm@chef.io</email>
</author>
<published>2017-08-10T17:40:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=ee865c15a8c26962a0d5bfe5b386d7959f77af2c'/>
<id>ee865c15a8c26962a0d5bfe5b386d7959f77af2c</id>
<content type='text'>
Minor refactor to newer rspec style, except for the last class which has really
complex ordering so I gaveup.

Signed-off-by: Bryan McLellan &lt;btm@chef.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Minor refactor to newer rspec style, except for the last class which has really
complex ordering so I gaveup.

Signed-off-by: Bryan McLellan &lt;btm@chef.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Update Chef::Shell tests</title>
<updated>2017-03-17T16:46:12+00:00</updated>
<author>
<name>Salim Afiune</name>
<email>afiune@chef.io</email>
</author>
<published>2017-03-13T16:12:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ruby-gems/chef.git/commit/?id=8dffb0360593377710a2b71ae6493ed6bb30acd7'/>
<id>8dffb0360593377710a2b71ae6493ed6bb30acd7</id>
<content type='text'>
Signed-off-by: Salim Afiune &lt;afiune@chef.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Salim Afiune &lt;afiune@chef.io&gt;
</pre>
</div>
</content>
</entry>
</feed>
