Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

* Chef-16 resource cleanup + unified_mode

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

zero args methods don't get parens.

this certainly reads better than the inverse.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

this will wind up replacing shell_out_with_systems_locale.

also fixes an issue in the sysctl provider.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This may be a breaking change for some users coming from 13.0/13.1
but this was the intended way that this API would function in Chef 13.0.

With this change we stop inserting environment variables into
execute resources.  That means that whatever users type into the
execute resource should much more exactly agree with the response
on the command line, which will close a shedload of bugs and is how
Chef 13.0 was intended to operate.  We no longer globally mangle the
PATH or the LANG/LC_ locale environment variables.

The way that it worked in Chef 13.0/13.1 resulted in the internal
chef embedded/bin directory being prepended to the PATH environment
variable in the `execute` resource, which was never intended.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

* removes the DSL from InlineResources class
* ActionClass is now responsible for mixing the DSL into
  action classes
* apt_update provider converted over to use new syntax
   - does not need to mixin DeclareResource DSL
   - declares use_inline_resources
   - uses declare_resource instead of build_resource
   - converts def action_stuff to action :stuff
   - uses an execute resource instead of shell_out!
   - does not need the converge_by to update the action