Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

consistency with Unchain here:

https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24

and with SimpleDelegator:

https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

if anyone is using these directly this might be a breaking change,
although it makes it considerably easier to use VividMash and IMO
ImmutableMash is an implementation detail of the deep merge cache
and Chef::Node object.

we definitely have never documented these APIs, so I think the onus
is on the consumer to update their code.

VividMash.new() should now work.

VividMash.new({ foo: :bar }) should also now work.

IDK what object people would have been passing in as the root object
before.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

slightly more succinct and strict about types, also trying to keep
the attributes tests associated with attributes even though we mix
them all up like crazy anyway...

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

note that the node_spec test in this commit is not red on master
so it ain't testing the right thing yet, but this fixes the
issue in chef-shell...

- fixes *_unless behavior and set_unless_value_present hack from Chef 12
- simplifies rm_* code
- introduces functional read/write/unlink/exist? API
- deprecates method_missing access to attributes for Chef 13
- deprecates set/set_unless aliases for Chef 14
- removes MultiMash mess that I wrote for Chef 13

https://github.com/chef/chef/pull/5029 for more details

no enforced trailing comma on arguments...