Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

this is using:

Layout/AlignArguments:
  Enabled: true
  EnforcedStyle: with_fixed_indentation

the default style can use really excessive whitespace.  on starting
lines which are already long, it fully indents across to where the
arguments start and then begins the line there.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

includes backcompat for 2.5

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

to_hash on a lot of these objects should go away, but even eliminating
all our calls to to_hash on these objects internally is difficult.

(e.g. converting the knife ui code to call #to_h means we wind up
calling nil#to_h which "helpfully" becomes '{}' which is hilarious and
i don't know why someone thought that was a good idea).

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Thom May <thom@chef.io>

department of redundancy department

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This adds URLs to each class of deprecation, and correctly prints and
formats them for maximum user efficiency. We also provide the URL to the
data collector for Visibility to ingest.

Signed-off-by: Thom May <thom@chef.io>