delta/ruby-gems/chef.git/lib/chef/property.rb, branch https

Use .key? instead of keys.include

2020-08-03T23:23:27+00:00

We don't need to create an array that we then search when we can just search the hash.

Also disable a few hash like calls that are false positives

Signed-off-by: Tim Smith

Get lib/ free of spelling violations.

2020-05-19T03:29:40+00:00

Signed-off-by: Pete Higgins

Force requiring properties

2020-04-17T23:23:51+00:00

All required properties are now required for all actions by default
even if the action does not reference the property.

In order to only make the property required for a subset of the
actions, specify them as an array of symbols to the required
options on the property.

```
property :whatever, String, required: %i{start stop}

action :start do
end

action :stop do
end

action :enable do
end

action :disable do
end
```

That property will be required for start+stop but not for
enable+disable.

There's an unaddressed edge case here where if you reference the
property in an action which was not specified that it will also
fail validation.  That is correct behavior.  We should probably
dig into how to warn the user that they must either remove the
reference to the property from that action or else to add the
action to the list of required actions on the property.

Signed-off-by: Lamont Granquist

Remove copyright dates

2020-04-13T22:47:17+00:00

Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist

Fix typo

2020-04-06T17:16:26+00:00

Signed-off-by: Vivek Singh

Change name_property to be identity and not desired_state by default

2020-04-03T02:52:21+00:00

If no other property is an identity property then the name_property is
the default identity property.  The name_property is also marked as not
being desired state by default (the 'name' should never change).

Signed-off-by: Lamont Granquist

Expose equal_to values in property / chef-resource-inspector

2020-03-09T22:58:22+00:00

We need this information so we can generator documentation that includes these values.

Signed-off-by: Tim Smith

Fix most Ruby 2.7 test failures

2020-01-22T04:43:09+00:00

Signed-off-by: Lamont Granquist

Add comment to property call method order

2019-08-07T23:31:44+00:00

Let's make sure we don't revert this by accident

Signed-off-by: Tim Smith

Property: Reorder comparison with NOT_PASSED.

2019-07-27T08:04:04+00:00

The original comparison `value == NOT_PASSED` ends up calling `.<=>` on
value under the hood. This relies on the implementation of `<=>`/`cmp`
not being broken in that class.

Unfortunately, some classes like OpenSSL::X509::Name have broken
implementations of `<=>` that raise TypeError instead of returning nil
for mismatched types. https://github.com/ruby/openssl/pull/264

As a result, currently, if you attempt to set a resource property to an
OpenSSL::X509::Name object, the result is a TypeError.

With this change, we use the implementation of comparison from the
NOT_PASSED object instead, which we know will work no matter what.

Signed-off-by: Andy Brody