nod to @jaymzh for finding this one.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

similarly to fixing to_hash.

kind of feels like we should return a VividMash instead of a Mash
here, to get a writable thing that behaves like an attribute...

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

previously to_hash allowed mutating non-container elements, now
they get properly dup'd.

fixes a 2.5 year old pending spec test.

also fills out the API so that there is to_h/to_hash/to_a/to_array
instead of the weird mix-and-match we had before.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

So again the reasons why we break this:

- node.class vs. node['class'] kinds of problems
- adding node#foo to Chef::Node as an extension to the API and
  breaking node.foo meaning node["foo"] (we can't make exensions
  to that class without possibly breaking someone)
- crazy things like the old CHEF-3799 issue in the old ticketing
  system where IO#puts in ruby blindly calls #to_ary on stuff and
  expects it to raise -- whereas we would potentially autovivify
  a 'to_ary' hash key and return nil which breaks the world.

This also has caused issues with the hashie gem and they've gone to
spamming warnings by default to try to deal with it:

https://github.com/berkshelf/berkshelf/issues/1665

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

department of redundancy department

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

closes #5556

corrects behavior to 12.11.x behavior which was lost in the refactor

may address #5715

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Core: fix Lint/UnifiedInteger cop

This adds URLs to each class of deprecation, and correctly prints and
formats them for maximum user efficiency. We also provide the URL to the
data collector for Visibility to ingest.

Signed-off-by: Thom May <thom@chef.io>