nod to @jaymzh for finding this one.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

So again the reasons why we break this:

- node.class vs. node['class'] kinds of problems
- adding node#foo to Chef::Node as an extension to the API and
  breaking node.foo meaning node["foo"] (we can't make exensions
  to that class without possibly breaking someone)
- crazy things like the old CHEF-3799 issue in the old ticketing
  system where IO#puts in ruby blindly calls #to_ary on stuff and
  expects it to raise -- whereas we would potentially autovivify
  a 'to_ary' hash key and return nil which breaks the world.

This also has caused issues with the hashie gem and they've gone to
spamming warnings by default to try to deal with it:

https://github.com/berkshelf/berkshelf/issues/1665

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

department of redundancy department

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

closes #5556

corrects behavior to 12.11.x behavior which was lost in the refactor

may address #5715

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This adds URLs to each class of deprecation, and correctly prints and
formats them for maximum user efficiency. We also provide the URL to the
data collector for Visibility to ingest.

Signed-off-by: Thom May <thom@chef.io>

Obvious fix.
Introduced in: e57e29b96b75ff7fc04abb7f9db73920b2a5894a

Signed-off-by: Adam Ward <adamw@subdesigns.net>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

consistency with Unchain here:

https://github.com/chef/chef/blob/master/lib/chef/decorator/unchain.rb#L23-L24

and with SimpleDelegator:

https://ruby-doc.org/stdlib-2.1.0/libdoc/delegate/rdoc/SimpleDelegator.html#method-i-__getobj__

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

if anyone is using these directly this might be a breaking change,
although it makes it considerably easier to use VividMash and IMO
ImmutableMash is an implementation detail of the deep merge cache
and Chef::Node object.

we definitely have never documented these APIs, so I think the onus
is on the consumer to update their code.

VividMash.new() should now work.

VividMash.new({ foo: :bar }) should also now work.

IDK what object people would have been passing in as the root object
before.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>