We generally always do protocol negotiation on the get of the node
object and the Chef::Node is an unversioned API, so we need to
test that we backoff the API version to the highest version the server
offers and then retry again.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Autocorrected from RuboCop Performance which is now smart enough to detect when you use the match and when you don't. Using match? does not create any objects so it's slightly faster and uses less memory.

Signed-off-by: Tim Smith <tsmith@chef.io>

Add ssl_verify option for remote_file

Signed-off-by: Pete Higgins <pete@peterhiggins.org>

Different servers have different https requirements and enforcing
the API policy on all `remote_file` resources isn't reasonable.

The logic around the HTTP clients and policies in Chef is... complex.
This approach seemed like the best one, but I'm open to others.

By default here if the user specifies nothing, `remote_file`'s http
clients will fall back to the API policy, otherwise, it'll use whatever
the specify.

This fixes #8897

Signed-off-by: Phil Dibowitz <phil@ipom.com>

Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

fix ruby 2.7 URI.unescape deprecation

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>