Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

this is the result of changes to rules we already previously had
enabled.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Remove the lazy loading of chef provisioning resources

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This makes nameless resources work in the DSL:

```ruby
apt_update
```

It does it by giving it an empty-string name of ""

It also drops support for multi-arg resources, that has been deprecated
for some time:

```ruby
some_resource "foo", "bar", "baz"
```

Note that multipackage package resources do not use multiple args, but a
single argument which is an arry:

```ruby
package [ "lsof", "strace", "tcpdump" ]
```

So this change does not affect that usage.  Multi-arg has been
deprecated for some time now and its not clear that it was ever used by
anyone.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

we did actually have tests around creating actions with spaces and
hyphens in their names.  we had fallback code for properties, but it
was broken and threw a "private method define_resource called" and then
it created a closure and didn't have the `name` in the binding so it
called itself and blew up the stack.

this change walks that back.  it does prove that we still support
UTF-8 in property names, actions and DSL names, which i'd argue is
more than enough.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Likely nobody cares about this change, I added it and then a
release or two later introduced the better edit_resource style
of API.

I also changed "created_at" to be a proper named parameter, instead
of a positional parameter, which is a breaking change in an API that
has been around for quite some time -- makes the API consistent since
I added it as a named parameter to the new APIs when I wrote them.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

department of redundancy department

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

This adds URLs to each class of deprecation, and correctly prints and
formats them for maximum user efficiency. We also provide the URL to the
data collector for Visibility to ingest.

Signed-off-by: Thom May <thom@chef.io>