From 1057239e68bfde5355b084c7848c8045fedcd9a3 Mon Sep 17 00:00:00 2001 From: Hubert Plociniczak Date: Fri, 9 Jan 2009 01:28:24 +0100 Subject: Use --gecos option in adduser to add user's comments field, instead of running usermod. --- packaging/debs/Debian/debian/postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packaging/debs/Debian/debian/postinst b/packaging/debs/Debian/debian/postinst index 495b8331..93d1c096 100644 --- a/packaging/debs/Debian/debian/postinst +++ b/packaging/debs/Debian/debian/postinst @@ -25,8 +25,8 @@ fi # create rabbitmq user if ! getent passwd rabbitmq >/dev/null; then - adduser --system --ingroup rabbitmq --home /var/lib/rabbitmq --no-create-home rabbitmq - usermod -c "RabbitMQ messaging server" rabbitmq + adduser --system --ingroup rabbitmq --home /var/lib/rabbitmq \ + --no-create-home rabbitmq --gecos "RabbitMQ messaging server" fi chown -R rabbitmq:rabbitmq /var/lib/rabbitmq -- cgit v1.2.1 From 1ab002d33e0e05312d94651faaa259c576ec73c5 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Fri, 9 Jan 2009 15:12:18 +0000 Subject: the #amqqueue.pid is 'none', so return self() instead --- src/rabbit_amqqueue_process.erl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rabbit_amqqueue_process.erl b/src/rabbit_amqqueue_process.erl index 709e355e..6282a8fb 100644 --- a/src/rabbit_amqqueue_process.erl +++ b/src/rabbit_amqqueue_process.erl @@ -488,7 +488,8 @@ i(name, #q{q = #amqqueue{name = Name}}) -> Name; i(durable, #q{q = #amqqueue{durable = Durable}}) -> Durable; i(auto_delete, #q{q = #amqqueue{auto_delete = AutoDelete}}) -> AutoDelete; i(arguments, #q{q = #amqqueue{arguments = Arguments}}) -> Arguments; -i(pid, #q{q = #amqqueue{pid = Pid}}) -> Pid; +i(pid, _) -> + self(); i(messages_ready, #q{message_buffer = MessageBuffer}) -> queue:len(MessageBuffer); i(messages_unacknowledged, _) -> -- cgit v1.2.1 From 081bd947d4731f3f9c8cebbf618a4d3efba482aa Mon Sep 17 00:00:00 2001 From: Hubert Plociniczak Date: Fri, 9 Jan 2009 17:41:44 +0100 Subject: Moved user name to the end of the command. --- packaging/debs/Debian/debian/postinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/debs/Debian/debian/postinst b/packaging/debs/Debian/debian/postinst index 93d1c096..05fb179c 100644 --- a/packaging/debs/Debian/debian/postinst +++ b/packaging/debs/Debian/debian/postinst @@ -26,7 +26,7 @@ fi # create rabbitmq user if ! getent passwd rabbitmq >/dev/null; then adduser --system --ingroup rabbitmq --home /var/lib/rabbitmq \ - --no-create-home rabbitmq --gecos "RabbitMQ messaging server" + --no-create-home --gecos "RabbitMQ messaging server" rabbitmq fi chown -R rabbitmq:rabbitmq /var/lib/rabbitmq -- cgit v1.2.1 From c9e9c8e947b36433460aa4969cf8f51e81309302 Mon Sep 17 00:00:00 2001 From: Emile Joubert Date: Sun, 11 Jan 2009 22:02:52 +0000 Subject: Report node instead of pid in rabbitmqctl --- src/rabbit_control.erl | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/rabbit_control.erl b/src/rabbit_control.erl index ecc285a5..419d71d9 100644 --- a/src/rabbit_control.erl +++ b/src/rabbit_control.erl @@ -138,7 +138,7 @@ The list_queues, list_exchanges and list_bindings commands accept an optional virtual host parameter for which to display results. The default value is \"/\". must be a member of the list [name, durable, auto_delete, -arguments, pid, messages_ready, messages_unacknowledged, messages_uncommitted, +arguments, node, messages_ready, messages_unacknowledged, messages_uncommitted, messages, acks_uncommitted, consumers, transactions, memory]. The default is to display name and (number of) messages. @@ -148,7 +148,7 @@ auto_delete, arguments]. The default is to display name and type. The output format for \"list_bindings\" is a list of rows containing exchange name, routing key, queue name and arguments, in that order. - must be a member of the list [pid, address, port, + must be a member of the list [node, address, port, peer_address, peer_port, state, channels, user, vhost, timeout, frame_max, recv_oct, recv_cnt, send_oct, send_cnt, send_pend]. The default is to display user, peer_address and peer_port. @@ -242,7 +242,8 @@ action(list_vhost_users, Node, Args = [_VHostPath], Inform) -> action(list_queues, Node, Args, Inform) -> Inform("Listing queues", []), {VHostArg, RemainingArgs} = parse_vhost_flag(Args), - ArgAtoms = default_if_empty(RemainingArgs, [name, messages]), + ArgAtoms = list_replace(node, pid, + default_if_empty(RemainingArgs, [name, messages])), display_info_list(rpc_call(Node, rabbit_amqqueue, info_all, [VHostArg, ArgAtoms]), ArgAtoms); @@ -267,7 +268,8 @@ action(list_bindings, Node, Args, Inform) -> action(list_connections, Node, Args, Inform) -> Inform("Listing connections", []), - ArgAtoms = default_if_empty(Args, [user, peer_address, peer_port]), + ArgAtoms = list_replace(node, pid, + default_if_empty(Args, [user, peer_address, peer_port])), display_info_list(rpc_call(Node, rabbit_networking, connection_info_all, [ArgAtoms]), ArgAtoms). @@ -311,6 +313,8 @@ format_info_item(Items, Key) -> {Key, IpAddress} when Key =:= address; Key =:= peer_address andalso is_tuple(IpAddress) -> inet_parse:ntoa(IpAddress); + {pid, _} -> + atom_to_list(node(Value)); _ when is_binary(Value) -> url_encode(Value); _ -> @@ -357,3 +361,6 @@ url_encode_char([], Acc) -> d2h(N) when N<10 -> N+$0; d2h(N) -> N+$a-10. +list_replace(Find, Replace, List) -> + [case X of Find -> Replace; _ -> X end || X <- List]. + -- cgit v1.2.1 From d809b57f7db18757ae0c8a3e3a780bfa40c3bf0c Mon Sep 17 00:00:00 2001 From: Emile Joubert Date: Sun, 11 Jan 2009 22:24:33 +0000 Subject: Better dispatching while formatting results in rabbitmqctl --- src/rabbit_control.erl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/rabbit_control.erl b/src/rabbit_control.erl index 419d71d9..1e07f6d2 100644 --- a/src/rabbit_control.erl +++ b/src/rabbit_control.erl @@ -310,10 +310,9 @@ format_info_item(Items, Key) -> case Info of {_, #resource{name = Name}} -> url_encode(Name); - {Key, IpAddress} when Key =:= address; Key =:= peer_address - andalso is_tuple(IpAddress) -> - inet_parse:ntoa(IpAddress); - {pid, _} -> + _ when Key =:= address; Key =:= peer_address andalso is_tuple(Value) -> + inet_parse:ntoa(Value); + _ when is_pid(Value) -> atom_to_list(node(Value)); _ when is_binary(Value) -> url_encode(Value); -- cgit v1.2.1