From b1b57225dbc8733935697e1895631969e9a95376 Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@kdab.com>
Date: Sun, 4 Sep 2016 16:55:29 +0200
Subject: Eradicate Java-style loops (II): QSetIterator -> C++11 ranged for

Java-style iterators are slower than STL-style ones, so they
should not be used in library code.

Replaced them with C++11 ranged for loops, adding qAsConst()
as needed.

Change-Id: I21b59daceafc62b94ebba56bfef1f050988b9c9f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
---
 src/xmlpatterns/schema/qxsdschemachecker.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'src/xmlpatterns/schema/qxsdschemachecker.cpp')

diff --git a/src/xmlpatterns/schema/qxsdschemachecker.cpp b/src/xmlpatterns/schema/qxsdschemachecker.cpp
index b6e51f3..0898848 100644
--- a/src/xmlpatterns/schema/qxsdschemachecker.cpp
+++ b/src/xmlpatterns/schema/qxsdschemachecker.cpp
@@ -1694,9 +1694,8 @@ void XsdSchemaChecker::checkDuplicatedAttributeUses()
 void XsdSchemaChecker::checkElementConstraints()
 {
     const QSet<XsdElement::Ptr> elements = collectAllElements(m_schema);
-    QSetIterator<XsdElement::Ptr> it(elements);
-    while (it.hasNext()) {
-        const XsdElement::Ptr element = it.next();
+
+    for (const XsdElement::Ptr &element : elements) {
 
         // @see http://www.w3.org/TR/xmlschema11-1/#e-props-correct
 
-- 
cgit v1.2.1