From 5b4b3fb34679c2768d5c830cb8b9c88506aca75b Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 29 Aug 2013 13:41:42 +0200 Subject: QtXmlPatterns: Fix (!a == b) bug The ! applies to a only, so the result of this expression is most likely not what was expected. Clang warned about this one. Change-Id: I600c1ec70fa22313eee70ecce8995afd83713de6 Reviewed-by: Lars Knoll --- src/xmlpatterns/schema/qxsdschemaparser.cpp | 2 +- src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xmlpatterns/schema/qxsdschemaparser.cpp b/src/xmlpatterns/schema/qxsdschemaparser.cpp index dbe0e39..f8327f7 100644 --- a/src/xmlpatterns/schema/qxsdschemaparser.cpp +++ b/src/xmlpatterns/schema/qxsdschemaparser.cpp @@ -5974,7 +5974,7 @@ QString XsdSchemaParser::readXPathAttribute(const QString &attributeName, XPathT const QList namespaceBindings = m_namespaceSupport.namespaceBindings(); for (int i = 0; i < namespaceBindings.count(); ++i) { - if (!namespaceBindings.at(i).prefix() == StandardPrefixes::empty) + if (namespaceBindings.at(i).prefix() != StandardPrefixes::empty) queryPrivate->addAdditionalNamespaceBinding(namespaceBindings.at(i)); } diff --git a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp index c8c911e..a004705 100644 --- a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp +++ b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp @@ -1084,7 +1084,7 @@ QXmlQuery XsdValidatingInstanceReader::createXQuery(const QList &names QXmlQueryPrivate *queryPrivate = query.d; for (int i = 0; i < namespaceBindings.count(); ++i) { - if (!namespaceBindings.at(i).prefix() == StandardPrefixes::empty) + if (namespaceBindings.at(i).prefix() != StandardPrefixes::empty) queryPrivate->addAdditionalNamespaceBinding(namespaceBindings.at(i)); } -- cgit v1.2.1