From bf49d9f0d41c3be802dbdd2c23dfe7c5fd86f4b0 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Thu, 26 Sep 2013 09:50:57 +0200 Subject: Handle new QtTraceMsg type, fix warnings about unhandled enumeration value. Change-Id: Ia908aa03e0f6a0e4f92013ae84fc68ac73919d08 Reviewed-by: hjk --- src/xmlpatterns/api/qcoloringmessagehandler.cpp | 3 ++- tests/auto/xmlpatternssdk/ErrorHandler.cpp | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xmlpatterns/api/qcoloringmessagehandler.cpp b/src/xmlpatterns/api/qcoloringmessagehandler.cpp index f55f96d..59be099 100644 --- a/src/xmlpatterns/api/qcoloringmessagehandler.cpp +++ b/src/xmlpatterns/api/qcoloringmessagehandler.cpp @@ -136,11 +136,12 @@ void ColoringMessageHandler::handleMessage(QtMsgType type, break; } case QtCriticalMsg: + case QtTraceMsg: /* Fallthrough. */ case QtDebugMsg: { Q_ASSERT_X(false, Q_FUNC_INFO, - "message() is not supposed to receive QtCriticalMsg or QtDebugMsg."); + "message() is not supposed to receive QtCriticalMsg, QtTraceMsg or QtDebugMsg."); return; } } diff --git a/tests/auto/xmlpatternssdk/ErrorHandler.cpp b/tests/auto/xmlpatternssdk/ErrorHandler.cpp index 74a6a6d..5b21d83 100644 --- a/tests/auto/xmlpatternssdk/ErrorHandler.cpp +++ b/tests/auto/xmlpatternssdk/ErrorHandler.cpp @@ -88,8 +88,7 @@ void qMessageHandler(QtMsgType type, const QMessageLogContext &, const QString & return; } case QtDebugMsg: /* This enum is handled above in the if-clause. */ - /* Fallthrough. */ - default: + case QtTraceMsg: { Q_ASSERT(false); return; -- cgit v1.2.1 From 11b150d935ebdd422e3d3edb698f2e08c45e2229 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Fri, 27 Sep 2013 14:10:56 +0200 Subject: Remove QtAlgorithms usage from QtXmlPatterns. QtAlgorithms is getting deprecated, see http://www.mail-archive.com/development@qt-project.org/msg01603.html Change-Id: I4e2c7bf7970ba59ca9443c545b66db9f509d946b Reviewed-by: Giuseppe D'Angelo --- src/xmlpatterns/expr/qnodesort.cpp | 4 +++- src/xmlpatterns/expr/qorderby.cpp | 6 ++++-- src/xmlpatterns/expr/qtemplatemode.cpp | 4 +++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/xmlpatterns/expr/qnodesort.cpp b/src/xmlpatterns/expr/qnodesort.cpp index 58e33d0..9dd1bed 100644 --- a/src/xmlpatterns/expr/qnodesort.cpp +++ b/src/xmlpatterns/expr/qnodesort.cpp @@ -43,6 +43,8 @@ #include "qdeduplicateiterator_p.h" #include "qnodesort_p.h" +#include + QT_BEGIN_NAMESPACE using namespace QPatternist; @@ -83,7 +85,7 @@ Item::Iterator::Ptr NodeSortExpression::evaluateSequence(const DynamicContext::P return makeListIterator(nodes); else { - qSort(nodes.begin(), nodes.end(), lessThanUsingNodeModel); + std::sort(nodes.begin(), nodes.end(), lessThanUsingNodeModel); return Item::Iterator::Ptr(new DeduplicateIterator(nodes)); } diff --git a/src/xmlpatterns/expr/qorderby.cpp b/src/xmlpatterns/expr/qorderby.cpp index a5c395d..46ac7a3 100644 --- a/src/xmlpatterns/expr/qorderby.cpp +++ b/src/xmlpatterns/expr/qorderby.cpp @@ -51,6 +51,8 @@ #include "qorderby_p.h" +#include + QT_BEGIN_NAMESPACE using namespace QPatternist; @@ -182,11 +184,11 @@ Item::Iterator::Ptr OrderBy::evaluateSequence(const DynamicContext::Ptr &context /* On one hand we could just disregard stability and always use qStableSort(), but maybe qSort() * is a bit faster? */ if(m_stability == StableOrder) - qStableSort(tuples.begin(), tuples.end(), sorter); + std::stable_sort(tuples.begin(), tuples.end(), sorter); else { Q_ASSERT(m_stability == UnstableOrder); - qSort(tuples.begin(), tuples.end(), sorter); + std::sort(tuples.begin(), tuples.end(), sorter); } return makeSequenceMappingIterator(ConstPtr(this), diff --git a/src/xmlpatterns/expr/qtemplatemode.cpp b/src/xmlpatterns/expr/qtemplatemode.cpp index f2a5b2a..a90efbc 100644 --- a/src/xmlpatterns/expr/qtemplatemode.cpp +++ b/src/xmlpatterns/expr/qtemplatemode.cpp @@ -41,6 +41,8 @@ #include "qtemplatemode_p.h" +#include + QT_BEGIN_NAMESPACE using namespace QPatternist; @@ -53,7 +55,7 @@ bool TemplateMode::lessThanByPriority(const TemplatePattern::Ptr &t1, void TemplateMode::finalize() { - qSort(templatePatterns.begin(), templatePatterns.end(), lessThanByPriority); + std::sort(templatePatterns.begin(), templatePatterns.end(), lessThanByPriority); /* Now we have a list of patterns sorted by priority. */ } -- cgit v1.2.1