2012-10-17 Keishi Hattori Localized date should be based on LDML https://bugs.webkit.org/show_bug.cgi?id=99570 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: (TEST_F): Updated expectations. * tests/LocaleWinTest.cpp: (TEST_F): Updated expectations. 2012-10-16 MORITA Hajime [Shadow DOM][V8] WebCore::V8DOMWindow::installPerContextProperties() is slow when shadowDOMEnabled flag is on. https://bugs.webkit.org/show_bug.cgi?id=99428 Reviewed by Adam Barth. * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): 2012-10-16 Alec Flett IndexedDB: Stub out chromium success handlers for integers and undefined values https://bugs.webkit.org/show_bug.cgi?id=99527 Reviewed by Adam Barth. Add onSuccess stubs so that chromium IPC glue can land. * public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess): 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-16 Jian Li Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION https://bugs.webkit.org/show_bug.cgi?id=98975 Reviewed by Adam Barth. Renaming is needed to better match with the draggable region code. * features.gypi: * src/ChromeClientImpl.cpp: (WebKit): * src/ChromeClientImpl.h: (ChromeClientImpl): * src/WebDocument.cpp: (WebKit::WebDocument::draggableRegions): 2012-10-16 Min Qin Fix a bug that we are using scaled damage rect for plugins inside an iframe https://bugs.webkit.org/show_bug.cgi?id=99488 Reviewed by Adam Barth. There is a bug with a previous webkit patch: https://bugs.webkit.org/show_bug.cgi?id=98468 In that patch, we incorrectly applied the main frame's scale factor to inner iframes. However, the damageRect is not scaled inside an iFrame. So doing the intersect will retrieve wrong result here. In WebPluginContainerImpl::calculateGeometry, the windowRect also does not apply main frame's scale factor. * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): 2012-10-16 Xianzhu Wang [Chromium] Android: Need a way to get appropriate font for some specific characters. https://bugs.webkit.org/show_bug.cgi?id=67587 Reviewed by Adam Barth. Define ENABLE_OPENTYPE_VERTICAL=1 on Android. * features.gypi: 2012-10-16 Tommy Widenflycht MediaStream API: Add the chromium API for RTCDataChannel https://bugs.webkit.org/show_bug.cgi?id=99435 Reviewed by Adam Barth. Adding checks for RTCDataChannel. * src/AssertMatchingEnums.cpp: 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-15 Peter Beverloo [Chromium] Enable FAST_MOBILE_SCROLLING for Android https://bugs.webkit.org/show_bug.cgi?id=99401 Reviewed by Adam Barth. * features.gypi: Add the define to the Android-only section. 2012-10-15 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-15 Peter Beverloo [Chromium] The default target for Android builds should be "all" instead of "All" https://bugs.webkit.org/show_bug.cgi?id=98879 Reviewed by Adam Barth. The default gyp target for Android builds is being overridden in Chromium's envsetup_functions.sh to "All" (whereas the rest of Chromium and WebKit use "all"), because Android wants to use a different list of main targets. There is no need to do this for the WebKit project, and it's breaking ninja. * gyp_webkit: 2012-10-15 Kent Tamura LocaleMacTest.formatDate is failing on Mac 10.8 https://bugs.webkit.org/show_bug.cgi?id=99330 It seems OS X 10.8 and 10.7 return different date formats for ja_JP locale. We should not test such locales. * tests/LocaleMacTest.cpp: (TEST_F): Remove a test for ja_JP locale. 2012-10-15 Joshua Bell IndexedDB: Pass type of error causing abort to IDBTransaction::onAbort https://bugs.webkit.org/show_bug.cgi?id=99097 Reviewed by Tony Chang. Plumbing to pass details about the cause of the transaction abort through to the front end. * public/WebIDBTransactionCallbacks.h: (WebKit): (WebKit::WebIDBTransactionCallbacks::onAbort): * src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::onAbort): * src/IDBTransactionCallbacksProxy.h: (IDBTransactionCallbacksProxy): * src/WebIDBTransactionCallbacksImpl.cpp: (WebKit::WebIDBTransactionCallbacksImpl::onAbort): * src/WebIDBTransactionCallbacksImpl.h: (WebIDBTransactionCallbacksImpl): 2012-10-15 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-14 Sam Weinig Make UserScript and UserStyleSheet value objects that are copyable https://bugs.webkit.org/show_bug.cgi?id=99275 Reviewed by Tim Horton. * src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet): Update for new PageGroup function signatures. 2012-10-12 Adam Barth [Chromium] Remove used frameForEnteredContext API https://bugs.webkit.org/show_bug.cgi?id=99201 Reviewed by Eric Seidel. No one in Chromium-land understands the difference between frameForEnteredContext and frameForCurrentContext. Rather than give folks a confusing choice, let's just expose the one we most often want to use. I've already removed all callers of frameForEnteredContext downstream. * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit): 2012-10-12 Joshua Bell [Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script https://bugs.webkit.org/show_bug.cgi?id=99193 Reviewed by Adam Barth. Add database error (code, message) to payload for back-end to front-end abort call, so that scripts can determine why the abort occurred - e.g. ConstraintError during indexing. This API change allows the Chromium plumbing to land; the real implementation is in http://webkit.org/b/99097 and will land later. * public/WebIDBTransactionCallbacks.h: (WebKit): (WebIDBTransactionCallbacks): (WebKit::WebIDBTransactionCallbacks::onAbort): 2012-10-12 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-12 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-11 Kenichi Ishibashi [Chromium] Use harfbuzz-ng by default on Linux https://bugs.webkit.org/show_bug.cgi?id=97281 Reviewed by Tony Chang. * features.gypi: Enable WTF_USE_HARFBUZZ_NG when use_x11 == 1. 2012-10-11 Nat Duca Expose high-resolution on requestAnimationFrame callback https://bugs.webkit.org/show_bug.cgi?id=66683 This changes requestAnimationFrame's animationStartTime argument to be a high resolution DOM timestamp, per disucssion here: http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html Reviewed by James Robinson. * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::animate): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::updateAnimations): 2012-10-11 Jay Civelli Test for a fix for a crasher when generating MHTML for a page containing SVG images. https://bugs.webkit.org/show_bug.cgi?id=99105 Reviewed by Adam Barth. * page/PageSerializer.cpp: (WebCore::PageSerializer::serializeCSSStyleSheet): (WebCore::PageSerializer::addImageToResources): 2012-10-11 Adam Barth [Chromium] Improve the comment describing mainWorldScriptContext https://bugs.webkit.org/show_bug.cgi?id=99092 Reviewed by James Robinson. * public/WebFrame.h: (WebFrame): - Add some more text about what this API does so that folks who call it know what they need to worry about. 2012-10-11 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-11 Mihai Balan Always enable the experiments tab for WebKit nightly Web Inspector: Enabling experiments tab in WebKit nightly. https://bugs.webkit.org/show_bug.cgi?id=98923 Reviewed by Pavel Feldman. Enabling Web Inspector experiments tab in WebKit nightly. This is done by adding a new Preference key, Preferences.experimentsEnabled. Default values are true for WebKit and false for Chromium. They can also be overridden as before (in Chromium) * src/js/DevTools.js: 2012-10-11 Kent Tamura Introduce Localizer::isRTL, and use it in DateTimeChooserImpl https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): Re-enabled isRTL test. 2012-10-11 Kent Tamura [Chromium] Disable LocalizedDateICUTest.isRTL https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): Disabled. 2012-10-11 Kent Tamura [Chromium] Attempt to fix LocalizedDateICUTest.isRTL https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): 2012-10-11 Kent Tamura Introduce Localizer::isRTL, and use it in DateTimeChooserImpl https://bugs.webkit.org/show_bug.cgi?id=98992 Reviewed by Kentaro Hara. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Use Localizer::isRTL. * tests/LocaleMacTest.cpp: (LocaleMacTest::isRTL): Added a helper function. (TEST_F): Added tests. * tests/LocaleWinTest.cpp: (LocaleWinTest::isRTL): Added a helper function. (TEST_F): Added tests. * tests/LocalizedDateICUTest.cpp: (LocalizedDateICUTest::isRTL): Added a helper function. (TEST_F): Added tests. 2012-10-10 Kent Tamura [Chromium] Calendar picker: should use consistent Localizer object https://bugs.webkit.org/show_bug.cgi?id=98983 Reviewed by Kentaro Hara. In Source/WebKit/chromium/src/DateTimeChooserImpl.cpp, we used two Localizer objects, one was m_localizer and another was 'localizer' local object in writeDocument. We should use single Localizer object. Also, Localizer::create(nullAtom) had unexpected behaviors in ICU environment; e.g. Month labels in a calendar picker were numeric. This patch fixes it, and this is covered by fast/forms/date/calendar-picker-appearance.html. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Use m_localizer. 2012-10-10 Justin Novosad [Chromium] Smoother animation for non-RAF 2D canvas animations https://bugs.webkit.org/show_bug.cgi?id=97918 Reviewed by Stephen White. New unit test to verify the automatic flushing of deferred 2d canvas layers when scripted animations are more than one full frame ahead of the compositor. Also verifies that automatic flushing does not kick-in when the skip on clear optimization fires * DEPS: * tests/Canvas2DLayerManagerTest.cpp: (FakeCanvas2DLayerBridge::fakeSkipPendingDrawCommands): To fake the skip on clear optimization (FakeCanvas2DLayerBridge): (Canvas2DLayerManagerTest): (Canvas2DLayerManagerTest::doDeferredFrameTestTask): Method that simulates a javascript scheduled action that draws to a 2D canvas layer (DeferredFrameTestTask): Task object to simulate a scheduled action. This is so the unit test can cover the TaskObserver behavior of Canvas2DLayerManager. (Canvas2DLayerManagerTest::DeferredFrameTestTask::DeferredFrameTestTask): (Canvas2DLayerManagerTest::deferredFrameTest): The unit test implementation, which uses the WebThread run loop to post tasks that touch the canvas layer. 2012-10-10 Leandro Gracia Gil [Chromium] Update selection on long press to match normal delimiters. https://bugs.webkit.org/show_bug.cgi?id=98947 Reviewed by Adam Barth. Make the long press selection behaviour consistent. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebKit::WebViewImpl::detectContentOnTouch): * src/WebViewImpl.h: (WebViewImpl): * tests/WebViewTest.cpp: 2012-10-10 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-10 Jon Lee [WK2] Activate plugins when user clicks on snapshot https://bugs.webkit.org/show_bug.cgi?id=98328 Reviewed by Brady Eidson. * src/FrameLoaderClientImpl.h: (WebKit::FrameLoaderClientImpl::recreatePlugin): Stub implementation of recreatePlugin(). 2012-10-10 David Barton Turn on ENABLE_MATHML for Chromium https://bugs.webkit.org/show_bug.cgi?id=96960 Reviewed by Adam Barth. * features.gypi: 2012-10-10 Varun Jain [chromium] Spelling and grammar markers are pixelated in hidpi. https://bugs.webkit.org/show_bug.cgi?id=98339 Reviewed by Stephen White. We create separate bitmaps for markers in normal and hidpi mode as per specification from UX and choose the right bitmap based on the current device scale factor. * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::paint): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paintRootLayer): 2012-10-10 Simon Fraser Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText https://bugs.webkit.org/show_bug.cgi?id=98839 Reviewed by Sam Weinig. Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::layerTreeAsText): 2012-10-08 Kent Tamura [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName https://bugs.webkit.org/show_bug.cgi?id=98714 Reviewed by Abhishek Arya. * public/WebElement.h: (WebElement): - Add a comment to tagName(). - Add a comment to hasTagName(). - Declare hasHTMLTagName(), which is useful to check HTML tags. * src/WebElement.cpp: (WebKit::WebElement::hasHTMLTagName): Added. 2012-10-09 Jian Li Update the CSS property used to support draggable regions. https://bugs.webkit.org/show_bug.cgi?id=97156 Reviewed by Adam Barth. Update the code to use the new name annotatedRegions to work for both features. * public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions. (WebDraggableRegion): * src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions. (WebKit::ChromeClientImpl::annotatedRegionsChanged): * src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions. (ChromeClientImpl): * src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions. (WebKit::WebDocument::draggableRegions): 2012-10-09 Sadrul Habib Chowdhury [chromium] Add drop event for plugins. https://bugs.webkit.org/show_bug.cgi?id=98827 Reviewed by Adam Barth. Add conversion for drop events. * public/WebDragStatus.h: * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleDragEvent): 2012-10-09 Sheriff Bot Unreviewed, rolling out r130811 and r130821. http://trac.webkit.org/changeset/130811 http://trac.webkit.org/changeset/130821 https://bugs.webkit.org/show_bug.cgi?id=98831 Broke date-suggestion-picker-appearance-with-scroll-bar.html (Requested by abarth|gardening on #webkit). * src/FindInPageCoordinates.cpp: (WebKit::toNormalizedRect): * src/LinkHighlight.cpp: (WebKit::convertTargetSpaceQuadToCompositedLayer): * src/WebInputEventConversion.cpp: (WebKit::convertLocationForRenderObject): 2012-10-09 Ben Murdoch [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() https://bugs.webkit.org/show_bug.cgi?id=97689 Reviewed by Adam Barth. This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources() function to the Chromium WebKit API layer. This is needed in Chromium to implement the Android WebView.loadDataWithBaseUrl function in a compatible manner. Please see crbug.com/152223 for further information and the chromium side patch. * public/WebSecurityOrigin.h: (WebSecurityOrigin): Add grantLoadLocalResources() API. * src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::grantLoadLocalResources): Implement the API by calling through to the WebCore function of the same name. (WebKit): 2012-10-09 Julien Chaffraix [Chromium] Chromium DEPS has a stray directory, turning our Win bots red https://bugs.webkit.org/show_bug.cgi?id=98817 Reviewed by Dirk Pranke. * DEPS: Removed the stray directory which solved the redness on several of our bots. 2012-10-09 Sadrul Habib Chowdhury [chromium] Make sure events are transformed correctly for plugins. https://bugs.webkit.org/show_bug.cgi?id=89250 Reviewed by Tony Chang. The events arriving in WebPluginContainerImpl are in the coordinate space of the page containing the plugin. Before the events are dispatched to the plugin, it is necessary to convert them into the plugin's own coordinate system. * src/WebInputEventConversion.cpp: (WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject. (WebKit): (WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events. (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder): (WebKit::addTouchPoints): (WebKit::WebTouchEventBuilder::WebTouchEventBuilder): (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): * src/WebInputEventConversion.h: (WebCore): (WebKit): (WebMouseEventBuilder): (WebMouseWheelEventBuilder): (WebTouchEventBuilder): (WebGestureEventBuilder): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): 2012-10-09 Garrett Casto Allow users to specify a different hover image for TextFieldDecorationElement https://bugs.webkit.org/show_bug.cgi?id=93662 Reviewed by Kent Tamura. * public/WebTextFieldDecoratorClient.h: (WebTextFieldDecoratorClient): (WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover. * src/TextFieldDecoratorImpl.cpp: (WebKit::TextFieldDecoratorImpl::imageForReadonlyState): (WebKit::TextFieldDecoratorImpl::imageForHoverState): (WebKit): * src/TextFieldDecoratorImpl.h: (TextFieldDecoratorImpl): 2012-10-09 Keishi Hattori Page popup should be smarter about its layout https://bugs.webkit.org/show_bug.cgi?id=98499 Reviewed by Kent Tamura. * src/ColorChooserUIController.cpp: (WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver. (WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more. * src/WebPagePopupImpl.h: (WebPagePopupImpl): 2012-10-08 Dirk Pranke Chromium DEPS roll r160657:160764. Unreviewed. * DEPS: 2012-10-08 Alec Flett IndexedDB: remove autogenerated objectStore/index id code https://bugs.webkit.org/show_bug.cgi?id=98085 Reviewed by Tony Chang. Remove support for unused createObjectStore/createIndex. These methods will go away entirely when https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed. * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-10-08 Sami Kyostila Some non-scrollable elements are added to non-fast-scrollable region https://bugs.webkit.org/show_bug.cgi?id=97927 Reviewed by James Robinson. Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable region. The test in this patch consists of a web page where both the html and body elements clip horizontal overflow. This results in a hierarchy where the body element gets a scrollable RenderLayer. However, that layer isn't (interactively) scrollable because while the scroll geometry is calculated based on the amount of overflow, the scroll bars are hidden because of the "overflow-x: hidden" style. Previously this layer would have made the entire page part of the non-fast scrollable region. With this patch, RenderLayer::allowScrolling() is used as a pre-requisite for expanding the region, thus avoiding the problem. * tests/ScrollingCoordinatorChromiumTest.cpp: (WebKit::TEST_F): (WebKit): * tests/data/clipped-body.html: Added. 2012-10-08 Sailesh Agrawal Mac Chromium: Ignore system numpad modifier https://bugs.webkit.org/show_bug.cgi?id=97161 Reviewed by Tony Chang. On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms. My fix is to only rely on keycode to decide when to set the numpad modifier. This code is not exersided by layout tests so I added a new unit test for this. * WebKit.gypi: * WebKitUnitTests.gyp: * src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent): Removed check for numpad modifier. * tests/WebInputEventFactoryTestMac.mm: Added. (TEST): Added new test for WebInputEventFactory::keyboardEvent(). 2012-10-08 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-07 Caio Marcelo de Oliveira Filho Rename first/second to key/value in HashMap iterators https://bugs.webkit.org/show_bug.cgi?id=82784 Reviewed by Eric Seidel. * src/WebGeolocationPermissionRequestManager.cpp: (WebGeolocationPermissionRequestManager::remove): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): * src/WebIntent.cpp: (WebKit::WebIntent::extrasValue): * tests/MemoryInstrumentationTest.cpp: * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore::TEST_F): 2012-10-06 Ilya Tikhonovsky Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964 https://bugs.webkit.org/show_bug.cgi?id=98500 Reviewed by Benjamin Poulain. Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter(). Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1. * tests/MemoryInstrumentationTest.cpp: 2012-10-05 Terry Anderson [chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS https://bugs.webkit.org/show_bug.cgi?id=98526 Reviewed by Stephen White. This is causing some problems with picture serialization between chrome and the mainline skia tools. (Once this change lands and is gardened in, I will make the corresponding change in chromium/skia/skia.gyp) * features.gypi: 2012-10-05 Adam Barth Unreviewed. Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on some code that is conditionally compiled and therefore fails in some configurations. * tests/WebFrameTest.cpp: 2012-10-05 W. James MacLean [chromium] Enhance support for transforms in LinkHighlight. https://bugs.webkit.org/show_bug.cgi?id=94355 Reviewed by Adrienne Walker. Improved handling of transformed highlight targets, where the transform goes beyond simple translation. * src/LinkHighlight.cpp: (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates. (WebKit): (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path. (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::bestTouchLinkNode): 2012-10-05 Julien Chaffraix Unreviewed build fix after r130545. * tests/WebFrameTest.cpp: Avoid a warning about truncating the double constant on Windows. While touching the variable, changed it to be proper camelCase. 2012-10-05 Oli Lan Allow EventHandler to handle longpress gestures, including longpress selection on Android. https://bugs.webkit.org/show_bug.cgi?id=98173 Reviewed by Ryosuke Niwa. This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent. The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour required for Android. This means that a long press gesture performed on word (that is not part of a link) selects the word, without generating a context menu event. A new test, WebViewTest.LongPressSelection has been added to test this. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebViewImpl): * tests/WebViewTest.cpp: * tests/data/longpress_selection.html: Added. 2012-10-05 Yusuf Ozuysal [chromium] Support zooming focused node for mobile devices https://bugs.webkit.org/show_bug.cgi?id=97958 Reviewed by Adam Barth. This unforks the Android version of scrollFocusedNodeIntoRect().A new setting autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all platforms with ENABLE(GESTURE_EVENTS) want this. Test: WebFrameTest.DivScrollIntoEditableTest * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollFocusedNodeIntoRect): * tests/WebFrameTest.cpp: * tests/data/get_scale_for_zoom_into_editable_test.html: Added. 2012-10-05 W. James MacLean [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel. https://bugs.webkit.org/show_bug.cgi?id=97355 Reviewed by Adrienne Walker. This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if interrupted by GestureTap, and animate away if interrupted by GestureTapCancel. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::LinkHighlight): (WebKit::LinkHighlight::startHighlightAnimationIfNeeded): * src/LinkHighlight.h: (LinkHighlight): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebKit::WebViewImpl::enableTouchHighlight): 2012-10-05 Mark Pilgrim [Chromium] Update some more #includes for Platform/ directory https://bugs.webkit.org/show_bug.cgi?id=98534 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/WebFormElement.cpp: * src/WebFrameImpl.cpp: * src/WebGeolocationClientMock.cpp: * src/WebGeolocationError.cpp: * src/WebGeolocationPermissionRequest.cpp: * src/WebHistoryItem.cpp: * src/WebHitTestResult.cpp: * src/WebIDBTransactionImpl.h: * src/WebIconLoadingCompletionImpl.h: * src/WebImageDecoder.cpp: * src/WebImageSkia.cpp: * src/WebInputElement.cpp: * src/WebKit.cpp: * src/WebLabelElement.cpp: * src/WebMediaStreamRegistry.cpp: * src/WebNode.cpp: * src/WebNotification.cpp: * src/WebOptionElement.cpp: * src/WebPageSerializer.cpp: * src/WebPageSerializerImpl.cpp: * src/WebPageSerializerImpl.h: * src/WebPluginListBuilderImpl.cpp: * src/WebPluginLoadObserver.h: * src/WebPopupMenuImpl.cpp: * src/WebPopupMenuImpl.h: * src/WebRange.cpp: * src/WebRegularExpression.cpp: * src/WebScriptController.cpp: * src/WebSecurityOrigin.cpp: * src/WebSecurityPolicy.cpp: * src/WebSelectElement.cpp: * src/WebSerializedScriptValue.cpp: * src/WebSessionDescriptionDescriptor.cpp: * src/WebSettingsImpl.cpp: * src/WebSocketImpl.cpp: * src/WebSocketImpl.h: * src/WebStorageEventDispatcherImpl.cpp: * src/WebSurroundingText.cpp: * src/WebURLLoadTiming.cpp: * src/WorkerAsyncFileWriterChromium.cpp: * src/WorkerFileSystemCallbacksBridge.cpp: 2012-10-05 Sadrul Habib Chowdhury [chromium] Allow dragging into plugins. https://bugs.webkit.org/show_bug.cgi?id=98277 Reviewed by Tony Chang. Allow plugins to receive drag events. This will make it possible to perform drag-n-drop into browser plugins (and other plugins if desired). * public/WebDragStatus.h: Added. (WebKit): * public/WebPlugin.h: (WebKit): (WebPlugin): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleDragEvent): (WebKit): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-10-04 Kenichi Ishibashi [WebSocket] ExtensionParser should have its own file https://bugs.webkit.org/show_bug.cgi?id=98475 Reviewed by Yuta Kitamura. Add a test for parsing Sec-WebSocket-Extensions field. * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore): (WebCore::TEST_F): 2012-10-04 Kenichi Ishibashi [Chromium] Improve SocketStreamHandle::send() stability https://bugs.webkit.org/show_bug.cgi?id=98459 Reviewed by Yuta Kitamura. Avoid null dereference in SocketStreamHandleInternal::send(). No changes in behavior. * src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::send): 2012-10-04 Dirk Pranke Chromium DEPS roll r160281:160322 Unreviewed. * DEPS: 2012-10-04 Alexandre Elias [chromium] Scale plugin container by frameScaleFactor https://bugs.webkit.org/show_bug.cgi?id=98468 Reviewed by Adam Barth. Plugin containers (for invalid plugins) weren't taking into account frameScaleFactor, looking cut off when that was non-1. * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): 2012-10-04 Alpha Lam Unreviewd. Chromium DEPS roll. Update to r160281. * DEPS: 2012-10-04 Mark Pilgrim [Chromium] Update some #includes for Platform directory https://bugs.webkit.org/show_bug.cgi?id=98440 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/ApplicationCacheHost.cpp: * src/AssociatedURLLoader.h: * src/AsyncFileWriterChromium.cpp: * src/AudioDestinationChromium.h: * src/AutofillPopupMenuClient.cpp: * src/ChromeClientImpl.cpp: * src/ContextMenuClientImpl.cpp: * src/DeliveredIntentClientImpl.h: * src/DragClientImpl.cpp: * src/DragScrollTimer.h: * src/FrameLoaderClientImpl.cpp: * src/InspectorClientImpl.cpp: * src/InspectorClientImpl.h: * src/InspectorFrontendClientImpl.cpp: * src/NotificationPresenterImpl.cpp: * src/PageWidgetDelegate.h: * src/SocketStreamHandle.cpp: * src/SocketStreamHandleInternal.h: * src/SpeechInputClientImpl.cpp: * src/StorageAreaProxy.cpp: * src/StorageNamespaceProxy.cpp: * src/UserMediaClientImpl.cpp: * src/WebAccessibilityObject.cpp: * src/WebAnimationControllerImpl.cpp: * src/WebCommon.cpp: * src/WebDOMEventListenerPrivate.h: * src/WebDOMMessageEvent.cpp: * src/WebDOMStringList.cpp: * src/WebDataSourceImpl.cpp: * src/WebDatabase.cpp: * src/WebDevToolsAgentImpl.cpp: * src/WebDevToolsAgentImpl.h: * src/WebDocument.cpp: * src/WebDocumentType.cpp: * src/WebDragData.cpp: * src/WebElement.cpp: * src/WebEntities.cpp: * src/WebFileChooserCompletionImpl.h: * src/WebFileSystemCallbacksImpl.cpp: * src/WebFontImpl.cpp: 2012-10-04 Alec Flett IndexedDB: promote objectstore/index backend ids to the frontend https://bugs.webkit.org/show_bug.cgi?id=97834 Reviewed by Tony Chang. Support for marshalling additional IDBMetadata and new calls to createObjectStore/createIndex. * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): * public/WebIDBMetadata.h: (ObjectStore): (Index): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit): * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): * src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-10-04 Simon Fraser Standardize on "flush" terminology for compositing layer flushing/syncing https://bugs.webkit.org/show_bug.cgi?id=98321 Reviewed by Simon Fraser. Rename compositing-related methods that refer to "syncing" to instead refer to "flushing". * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleCompositingLayerFlush): * src/ChromeClientImpl.h: (ChromeClientImpl): 2012-10-05 Kent Tamura [Chromium] Enable the multiple fields UI for input[type=date] https://bugs.webkit.org/show_bug.cgi?id=98351 Reviewed by Hajime Morita. * features.gypi: Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI. 2012-10-04 Kent Tamura Add code for input[type=date] with the multiple fields UI https://bugs.webkit.org/show_bug.cgi?id=98340 Reviewed by Hajime Morita. * features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android. 2012-10-03 Keishi Hattori Implement localizeValue for TimeInputType https://bugs.webkit.org/show_bug.cgi?id=98237 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: (LocaleMacTest::timeComponents): (LocaleMacTest): (LocaleMacTest::formatTime): Tests formatDateTime() for time. (TEST_F): 2012-10-03 Dirk Pranke Roll chromium to r160008 Unreviewed, deps roll. * DEPS: 2012-10-03 Adam Barth Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER) https://bugs.webkit.org/show_bug.cgi?id=98301 Reviewed by Eric Seidel. * features.gypi: 2012-10-03 Jeff Timanus [chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor. The flag defaults to disabled, so this change should be a no-op for scaling/scrolling behaviour. https://bugs.webkit.org/show_bug.cgi?id=93292 Reviewed by James Robinson. * public/WebSettings.h: * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setApplyPageScaleFactorInCompositor): (WebKit): (WebKit::WebSettingsImpl::applyPageScaleFactorInCompositor): * src/WebSettingsImpl.h: (WebSettingsImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setPageScaleFactor): (WebKit::WebViewImpl::applyScrollAndScale): 2012-10-03 Hans Wennborg Speech JavaScript API: Add SpeechRecognition.interimResults attribute https://bugs.webkit.org/show_bug.cgi?id=98279 Reviewed by Adam Barth. Plumb interimResults through to Chromium. * public/WebSpeechRecognitionParams.h: (WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams): (WebKit::WebSpeechRecognitionParams::interimResults): (WebSpeechRecognitionParams): * src/SpeechRecognitionClientProxy.cpp: (WebKit::SpeechRecognitionClientProxy::start): * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): 2012-10-03 Hans Wennborg Speech JavaScript API: Remove resultdeleted event https://bugs.webkit.org/show_bug.cgi?id=98272 Reviewed by Adam Barth. Remove didDeleteResult. This was never used, and has been removed from the spec draft. * public/WebSpeechRecognizerClient.h: * src/SpeechRecognitionClientProxy.cpp: * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): 2012-10-02 Anders Carlsson Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory https://bugs.webkit.org/show_bug.cgi?id=98217 Reviewed by Andreas Kling. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): 2012-10-03 Tommy Widenflycht MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation. https://bugs.webkit.org/show_bug.cgi?id=98149 Reviewed by Adam Barth. Adding willStartUsingPeerConnectionHandler to the WebFrameClient. * public/WebFrameClient.h: (WebKit): (WebFrameClient): (WebKit::WebFrameClient::willStartUsingPeerConnectionHandler): * src/FrameLoaderClientImpl.cpp: (WebKit): (WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler): * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): 2012-10-03 Peter Kotwicz WebImage::framesFromData should skip corrupted frames https://bugs.webkit.org/show_bug.cgi?id=98214 Reviewed by Adam Barth. WebImage::framesFromData() should only return bitmaps for valid frames of a .ico file. * src/WebImageSkia.cpp: (WebKit::WebImage::framesFromData): * tests/WebImageTest.cpp: (WebKit::TEST): (WebKit): * tests/data/valid_header_missing_bitmap.ico: Added. 2012-10-02 Yury Semikhatsky Provide memory instrumentation for HashCountedSet https://bugs.webkit.org/show_bug.cgi?id=98138 Reviewed by Pavel Feldman. Added unit test for HashCountedSet memory instrumentation. * tests/MemoryInstrumentationTest.cpp: 2012-10-02 Kent Tamura [Chromium-Win] Implement LocaleWin::dateFormat https://bugs.webkit.org/show_bug.cgi?id=98117 Reviewed by Kentaro Hara. * tests/LocaleWinTest.cpp: (TEST_F): Add tests for LocaleWin::dateFormat. == Rolled over to ChangeLog-2012-10-02 ==