2012-11-29 Tommy Widenflycht Speech Recognition API: Update SpeechRecognitionEvent to match the specification https://bugs.webkit.org/show_bug.cgi?id=103407 Reviewed by Adam Barth. Adding the new didReceiveResults method. * public/WebSpeechRecognizerClient.h: * src/SpeechRecognitionClientProxy.cpp: (WebKit::SpeechRecognitionClientProxy::didReceiveResults): (WebKit): * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): 2012-11-30 Keishi Hattori [Chromium] Page popup doesn't change mouse cursor https://bugs.webkit.org/show_bug.cgi?id=97454 Reviewed by Kent Tamura. The mouse cursor should change based on the page popup content and not the main window content. On Mac the mousemove event propagates to both the page popup and main window causing the cursor to flicker. The change to ChromeClientImpl stops that. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::setCursor): On Mac, don't update the mouse cursor if a popup is open. * src/WebPagePopupImpl.cpp: Implement setCursor so the mouse cursor gets set based on the page popup content. 2012-11-30 Mihai Maerean [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled https://bugs.webkit.org/show_bug.cgi?id=101192 Reviewed by Hajime Morita. Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures. Tests: No new tests because there is no functional change. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): * public/WebSettings.h: moved setExperimentalCSSRegionsEnabled to the bottom of the interface and made it a no-op. After this patch lands and Chromium's webkit_rev is increased, we'll remove any callers in Chromium. Once the Chromium callers are gone and WebKit's chromium_rev is increased, we'll remove the deprecated API. * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableCSSRegions): (WebKit): (WebKit::WebRuntimeFeatures::isCSSRegionsEnabled): * src/WebSettingsImpl.cpp: * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-11-29 Rafael Weinstein [HTMLTemplateElement] Add feature flag https://bugs.webkit.org/show_bug.cgi?id=103694 Reviewed by Adam Barth. This flag will guard the implementation of the HTMLTemplateElement. http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html * features.gypi: 2012-11-29 David Grogan IndexedDB: Propagate more leveldb errors to script https://bugs.webkit.org/show_bug.cgi?id=103580 Reviewed by Tony Chang. * tests/IDBFakeBackingStore.h: Update method signatures. 2012-11-29 Sheriff Bot Unreviewed, rolling out r136171. http://trac.webkit.org/changeset/136171 https://bugs.webkit.org/show_bug.cgi?id=103695 Likely caused ReOpenedWithID and ReOpenedWithURL to fail in linux/chromeos (Requested by zhenyao on #webkit). * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::startMainThreadMonitoring): (WebKit): (WebKit::InspectorClientImpl::stopMainThreadMonitoring): (WebKit::InspectorClientImpl::willProcessTask): (WebKit::InspectorClientImpl::didProcessTask): * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): * src/WebDevToolsAgentImpl.h: (WebDevToolsAgentImpl): 2012-11-29 Sadrul Habib Chowdhury [chromium] Remove deprecated API since it is no longer used https://bugs.webkit.org/show_bug.cgi?id=103570 Reviewed by Adam Barth. Remove WebPluginContainer::setIsAcceptingTouchEvents, since this is not used anymore, in favour of WebPluginContainer::requestTouchEventType. * public/WebPluginContainer.h: (WebPluginContainer): * src/WebPluginContainerImpl.cpp: * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-11-29 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-29 Eugene Klyuchnikov Web Inspector: Make main-thread monitoring go through InspectorController. https://bugs.webkit.org/show_bug.cgi?id=103550 Reviewed by Pavel Feldman. InspectorInstrumentation was a wrong path * src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and listen/unlisten methods. * src/InspectorClientImpl.h: Ditto. * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): Subscribe for main thread activity events. (WebKit::WebDevToolsAgentImpl::detach): Unsubscribe for main thread activity events. (WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TaskObserver interface. Froward to InspectorController. (WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto. * src/WebDevToolsAgentImpl.h: Implement TaskObserver interface. 2012-11-29 Stephen Chenney [Chromium] Add code supppression flags for skia Unreviewed addition of Skia build flags to allow for their removal from Chromium's skia.gyp. * skia_webkit.gyp: Added defines for SK_DISABLE_DITHER_32BIT_GRADIENT and SK_DISABLE_DASHING_OPTIMIZATION 2012-11-29 Florin Malita [Skia] Add missing OpaqueRegionSkia notifier calls https://bugs.webkit.org/show_bug.cgi?id=102824 Reviewed by Stephen White. Add opaque region tracking unit tests for the new PlatformContextSkia draw methods. * tests/PlatformContextSkiaTest.cpp: (WebCore::TEST): (WebCore): 2012-11-29 Miguel Garcia Fix typo in description of openDateTimeChooser documentation https://bugs.webkit.org/show_bug.cgi?id=103622 Reviewed by Kent Tamura. * public/WebViewClient.h: (WebViewClient): 2012-11-28 Robert Kroeger remove unused PlatformGestureCurve code https://bugs.webkit.org/show_bug.cgi?id=103296 Reviewed by Adam Barth. Previous CLs have made the Chromium embedder provide gesture fling curve implementation to WebKit. Consequently no platform uses the gestural fling code currently found in WebKit. This CL removes this code. Code removal only: covered by existing tests. * WebKit.gypi: * tests/PlatformGestureCurveTest.cpp: Removed. 2012-11-28 Mark Pilgrim [Chromium] Remove pluginsScriptableObject from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=103542 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/PlatformSupport.cpp: (WebCore): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-11-28 Mark Pilgrim [Chromium][Win] Remove ensureFontLoaded from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=97696 Reviewed by Adam Barth. Move ensureFontLoaded() from PlatformSupport to FontPlatformDataChromiumWin. Part of a refactoring series; see tracking bug 82948. * src/PlatformSupport.cpp: (WebCore): 2012-11-28 Eric Uhrhane [chromium] Add unit tests for ChromeClientImpl::getNavigationPolicy https://bugs.webkit.org/show_bug.cgi?id=102424 Reviewed by Adam Barth. This tests a bunch of basic scenarios regarding what will produce a popup, a new foreground/background tab, or a new window. * WebKit.gypi: Added test file. * src/WebViewImpl.h: (WebViewImpl): Added friend declaration for setCurrentInputEventForTest. * tests/ChromeClientImplTest.cpp: Added. 2012-11-28 Alexandre Elias [chromium] Handle pinch correctly in slow-scrolling area https://bugs.webkit.org/show_bug.cgi?id=102740 Reviewed by James Robinson. With the nonmodal gesture event model, pinch zoom gestures involve interleaved pinch and scroll events. This caused a bug on slow-scroll areas: the scroll events were sent to the main thread and the pinch events were handled in the impl thread. This patch makes it so that scroll events are always handled in the impl thread if a pinch is active. * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl): (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): * src/WebCompositorInputHandlerImpl.h: * tests/WebCompositorInputHandlerImplTest.cpp: (WebKit::TEST_F): (WebKit): 2012-11-28 Sadrul Habib Chowdhury [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events. https://bugs.webkit.org/show_bug.cgi?id=103092 Reviewed by Tony Chang. A plugin can now request to receive raw touch events, or to receive mouse events synthesized from the touch events, or to not receive any touch events at all. * public/WebPluginContainer.h: (WebPluginContainer): * src/WebInputEventConversion.cpp: (WebKit::updateWebMouseEventFromWebCoreMouseEvent): (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit): * src/WebInputEventConversion.h: (WebMouseEventBuilder): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): (WebKit): (WebKit::WebPluginContainerImpl::requestTouchEventType): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl): (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-11-28 David Grogan IndexedDB: Remove setVersion from WK API https://bugs.webkit.org/show_bug.cgi?id=103456 Reviewed by Darin Fisher. These are the last vestiges of this ancient API. The bulk of the removal was done in bug 94972. * public/WebIDBCallbacks.h: * public/WebIDBDatabase.h: 2012-11-28 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-27 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadData): * src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::initializeLoader): 2012-11-27 Eberhard Graether [chromium] Add WebLayerTreeViewClient API to request font atlas https://bugs.webkit.org/show_bug.cgi?id=102958 Reviewed by James Robinson. This change makes the font atlas creation accessible to the WebLayerTreeView. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::createFontAtlas): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-27 Joshua Bell IndexedDB: Simplify transaction timers and event tracking https://bugs.webkit.org/show_bug.cgi?id=102984 Reviewed by Tony Chang. Remove now-unused didCompleteTaskEvents() method. * src/IDBTransactionBackendProxy.cpp: * src/IDBTransactionBackendProxy.h: (IDBTransactionBackendProxy): * src/WebIDBTransactionImpl.cpp: * src/WebIDBTransactionImpl.h: 2012-11-27 Alpha Lam [chromium] Implement full-featured image cache https://bugs.webkit.org/show_bug.cgi?id=99784 Reviewed by Stephen White. Added ImageFrameGeneratorTest to test cache logic and generation of new cache entries. ImageFrameGeneratorTest.cacheHit Test that a complete cached entry is reused. ImageFrameGeneratorTest.cacheMissWithScale Cache miss for a scaled image but cache hit on a full size image. Scaled image is created from cached full size image. ImageFrameGeneratorTest.cacheMissWithDecodeAndScale Cache miss for both scaled image and full size image. ImageFrameGeneratorTest.cacheMissWithIncompleteDecode Test the logic for handling incomplete cache objects. * WebKit.gypi: * src/WebKit.cpp: (WebKit::initializeWithoutV8): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled): * tests/DeferredImageDecoderTest.cpp: (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::decoderBeingDestroyed): (WebCore::DeferredImageDecoderTest::frameBufferRequested): (DeferredImageDecoderTest): (WebCore::DeferredImageDecoderTest::frameStatus): * tests/ImageFrameGeneratorTest.cpp: Added. (WebCore): (WebCore::fullSize): (WebCore::scaledSize): (MockImageDecoderFactory): (WebCore::MockImageDecoderFactory::create): (WebCore::MockImageDecoderFactory::MockImageDecoderFactory): (ImageFrameGeneratorTest): (WebCore::ImageFrameGeneratorTest::SetUp): (WebCore::ImageFrameGeneratorTest::TearDown): (WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed): (WebCore::ImageFrameGeneratorTest::frameBufferRequested): (WebCore::ImageFrameGeneratorTest::frameStatus): (WebCore::ImageFrameGeneratorTest::createCompleteImage): (WebCore::ImageFrameGeneratorTest::setFrameStatus): (WebCore::TEST_F): * tests/MockImageDecoder.h: (MockImageDecoderClient): (WebCore::MockImageDecoder::frameBufferAtIndex): 2012-11-27 David Grogan IndexedDB: Remove IDBDatabase.setVersion API https://bugs.webkit.org/show_bug.cgi?id=94972 Reviewed by Tony Chang. * src/IDBCallbacksProxy.cpp: * src/IDBCallbacksProxy.h: (IDBCallbacksProxy): * src/IDBDatabaseBackendProxy.cpp: * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/WebIDBCallbacksImpl.cpp: * src/WebIDBCallbacksImpl.h: (WebIDBCallbacksImpl): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): 2012-11-27 Eberhard Graether Plumbing showPaintRects out of InspectorPageAgent to use a different drawing implementation if available. https://bugs.webkit.org/show_bug.cgi?id=102452 Reviewed by Pavel Feldman. This change makes the showPaintRects setting in the Web Inspector's settings notify InspectorClient when changed. And the default paint rects drawing is not used if an alternative is available. This allows Chromium to draw the paint rects in the compositor's HUDLayer. * public/WebView.h: (WebView): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::overridesShowPaintRects): (WebKit): (WebKit::InspectorClientImpl::setShowPaintRects): * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setShowPaintRects): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-27 Tony Chang [chromium] Unreviewed build fix on Linux clang. ../../third_party/WebKit/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1055:63: error: C++98 requires an accessible copy constructor for class 'WebKit::WebCachedURLRequest' when binding a reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy] * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillRequestResource): 2012-11-27 Marja Hölttä Add callbacks to the FrameLoaderClient when a resource is requested https://bugs.webkit.org/show_bug.cgi?id=92761 Reviewed by Adam Barth. In Chromium, when an extension script cancels a network request (which happens out of process), we'd like to notify content scripts running on the current page about which elements failed to load because the requests were cancelled (as opposed to e.g. the network request just didn't work). Since the resource request itself does not carry any information what DOM element is was made for, currently a content script has to search the DOM tree and guess which requests will be cancelled by its counter part. By adding these callbacks, the embedder can make this connection explictly. * WebKit.gyp: * public/WebCachedURLRequest.h: Added. (WebKit): (WebCachedURLRequest): (WebKit::WebCachedURLRequest::~WebCachedURLRequest): * public/WebFrameClient.h: (WebKit): (WebFrameClient): (WebKit::WebFrameClient::willRequestResource): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillRequestResource): (WebKit): * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): * src/WebCachedURLRequest.cpp: Added. (WebKit): (WebKit::WebCachedURLRequest::reset): (WebKit::WebCachedURLRequest::urlRequest): (WebKit::WebCachedURLRequest::charset): (WebKit::WebCachedURLRequest::forPreload): (WebKit::WebCachedURLRequest::initiatorName): (WebKit::WebCachedURLRequest::initiatorElement): (WebKit::WebCachedURLRequest::WebCachedURLRequest): 2012-11-27 Keishi Hattori Add WebLocalizedString for validation type badinput https://bugs.webkit.org/show_bug.cgi?id=103381 Reviewed by Kent Tamura. * src/LocalizedStrings.cpp: (WebCore::validationMessageBadInputForNumberText): Using the newly added WebLocalizedString enum. (WebCore::validationMessageBadInputForDateTimeText): Ditto. 2012-11-27 Alec Flett IndexedDB: stub out IDBDatabaseBackendInterface::createTransaction https://bugs.webkit.org/show_bug.cgi?id=102730 Reviewed by Darin Fisher. Add support for new createTransaction() method in both sides of the WebKit API. * public/WebIDBDatabase.h: (WebIDBDatabase): (WebKit::WebIDBDatabase::createTransaction): * src/IDBDatabaseBackendProxy.cpp: (WebKit): (WebKit::IDBDatabaseBackendProxy::createTransaction): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createTransaction): (WebKit): * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): 2012-11-27 Sheriff Bot Unreviewed, rolling out r135786. http://trac.webkit.org/changeset/135786 https://bugs.webkit.org/show_bug.cgi?id=103379 It made 3 plugin tests timeout on several platforms (Requested by Ossy on #webkit). * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadData): * src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::initializeLoader): 2012-11-25 Kent Tamura Implement ValidityState::badInput https://bugs.webkit.org/show_bug.cgi?id=102861 Reviewed by Hajime Morita. * src/LocalizedStrings.cpp: Add placeholder implementations for new localized string functions. We'll update them in another patch. (WebCore::validationMessageBadInputForNumberText): (WebCore::validationMessageBadInputForDateTimeText): 2012-11-26 Sheriff Bot Unreviewed, rolling out r135798. http://trac.webkit.org/changeset/135798 https://bugs.webkit.org/show_bug.cgi?id=103354 Broke the chrome mac build (Requested by noel_ on #webkit). * WebKit.gypi: * src/WebKit.cpp: (WebKit::initializeWithoutV8): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled): * tests/DeferredImageDecoderTest.cpp: (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::decoderBeingDestroyed): * tests/ImageFrameGeneratorTest.cpp: Removed. * tests/MockImageDecoder.h: (MockImageDecoderClient): (WebCore::MockImageDecoder::frameBufferAtIndex): 2012-11-26 Alexandre Elias [chromium] Touchscreen fling handling https://bugs.webkit.org/show_bug.cgi?id=103278 Reviewed by James Robinson. The fling logic for touchpad can fall through to bad performance in several ways. This patch introduces an alternate path for touchscreen fling that simplifies it as follows: - Stop generating wheel events, to prevent unnecessary scrollBegin hit tests and to avoid falling back to slow path if a wheel handler is registered. - Drop the event on ScrollStatusIgnored. There's no real reason to send the event to the WebKit thread here. - Don't call transferActiveWheelFlingAnimation. This type of transition shouldn't be needed with touchscreen flings. * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): (WebKit::WebCompositorInputHandlerImpl::animate): (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling): (WebKit::WebCompositorInputHandlerImpl::scrollBy): * src/WebCompositorInputHandlerImpl.h: 2012-11-26 Kentaro Hara [V8] Remove WorkerContextExecutionProxy.{h,cpp} https://bugs.webkit.org/show_bug.cgi?id=103325 Reviewed by Adam Barth. Now WorkerContextExecutionProxy.{h,cpp} are empty. No tests. No change in behavior. * src/WebKit.cpp: * src/WebWorkerClientImpl.cpp: 2012-11-26 James Robinson [chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls https://bugs.webkit.org/show_bug.cgi?id=103322 Reviewed by Adam Barth. * src/WebViewImpl.cpp: * src/WebViewImpl.h: (WebViewImpl): 2012-11-26 Alpha Lam [chromium] Implement full-featured image cache https://bugs.webkit.org/show_bug.cgi?id=99784 Reviewed by James Robinson. Added ImageFrameGeneratorTest to test cache logic and generation of new cache entries. ImageFrameGeneratorTest.cacheHit Test that a complete cached entry is reused. ImageFrameGeneratorTest.cacheMissWithScale Cache miss for a scaled image but cache hit on a full size image. Scaled image is created from cached full size image. ImageFrameGeneratorTest.cacheMissWithDecodeAndScale Cache miss for both scaled image and full size image. ImageFrameGeneratorTest.cacheMissWithIncompleteDecode Test the logic for handling incomplete cache objects. * WebKit.gypi: * src/WebKit.cpp: (WebKit::initializeWithoutV8): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled): * tests/DeferredImageDecoderTest.cpp: (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::decoderBeingDestroyed): (WebCore::DeferredImageDecoderTest::frameBufferRequested): (DeferredImageDecoderTest): (WebCore::DeferredImageDecoderTest::frameStatus): * tests/ImageFrameGeneratorTest.cpp: Added. (WebCore): (WebCore::fullSize): (WebCore::scaledSize): (MockImageDecoderFactory): (WebCore::MockImageDecoderFactory::create): (WebCore::MockImageDecoderFactory::MockImageDecoderFactory): (ImageFrameGeneratorTest): (WebCore::ImageFrameGeneratorTest::SetUp): (WebCore::ImageFrameGeneratorTest::TearDown): (WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed): (WebCore::ImageFrameGeneratorTest::frameBufferRequested): (WebCore::ImageFrameGeneratorTest::frameStatus): (WebCore::ImageFrameGeneratorTest::createCompleteImage): (WebCore::ImageFrameGeneratorTest::setFrameStatus): (WebCore::TEST_F): * tests/MockImageDecoder.h: (MockImageDecoderClient): (WebCore::MockImageDecoder::frameBufferAtIndex): 2012-11-26 Varun Jain LongPress and LongTap gestures should start drag/drop and open context menu respectively. https://bugs.webkit.org/show_bug.cgi?id=101545 Reviewed by Antonio Gomes. For LongPress, we simulate drag by sending a mouse down and mouse drag events. If a drag is not started (because maybe there is no draggable element), then we show context menu instead (which is the current behavior for LongPress). For LongTap, we use the existing functions that LongPress uses to summon the context menu. LongPress initiated drag and drop can be enabled/disabled by the platform using the Setting touchDragDropEnabled which is disabled by default. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setTouchDragDropEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-11-26 Yusuf Ozuysal Add hasTouchEventhandlersAt to WebView API https://bugs.webkit.org/show_bug.cgi?id=102541 Reviewed by James Robinson. Adds hasTouchEventHandlersAt to WebWidget API to check for touch event handlers at a given point. This will be used to distinguish between events not processed by touch event handlers and event not hitting any touch event handlers. Both are returning the same ACK message currently. Default implementation returns true to continue the same behavior as we currently have. * public/WebWidget.h: (WebWidget): (WebKit::WebWidget::hasTouchEventHandlersAt): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::hasTouchEventHandlersAt): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-26 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadData): * src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::initializeLoader): 2012-11-26 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-26 Sheriff Bot Unreviewed, rolling out r135743. http://trac.webkit.org/changeset/135743 https://bugs.webkit.org/show_bug.cgi?id=103280 Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT' macro redefined (Requested by rjkroege on #webkit). * skia_webkit.gyp: 2012-11-26 Mike Reed add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining https://bugs.webkit.org/show_bug.cgi?id=103272 Reviewed by NOBODY. Unreviewed. No behavior change, as this define already exists on the chrome side in SkUserConfig.h * skia_webkit.gyp: 2012-11-26 Sheriff Bot Unreviewed, rolling out r135735. http://trac.webkit.org/changeset/135735 https://bugs.webkit.org/show_bug.cgi?id=103270 Caused breakage across the Chromium tree. (Requested by rjkroege_ on #webkit). * skia_webkit.gyp: 2012-11-26 Mike Reed add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining https://bugs.webkit.org/show_bug.cgi?id=103269 Reviewed by NOBODY. Unreviewed. No behavior change, as this define already exists on the chrome side in SkUserConfig.h * skia_webkit.gyp: 2012-11-26 Scott Violet [chromium] Make use_default_render_theme compile the right set of files https://bugs.webkit.org/show_bug.cgi?id=102952 Reviewed by Kent Tamura. * WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them. * features.gypi: Removes use_default_render_theme default values as common.gypi sets them. * public/default: Added. * public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h * src/default: Added. * src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp 2012-11-24 Silvia Pfeiffer [chromium] Remove traces of MediaControlRootElement https://bugs.webkit.org/show_bug.cgi?id=103174 Reviewed by Adam Barth. Now that nothing is using MediaControlRootElement any more, we can remove the FIXME and MediaControlRootElement enum left over from bug 88871. * public/WebContextMenuData.h: 2012-11-23 Robert Kroeger Remove unused ScrollByPixelVelocity https://bugs.webkit.org/show_bug.cgi?id=102840 Reviewed by Sam Weinig. Removed test for deleted code. * tests/ScrollAnimatorNoneTest.cpp: 2012-11-23 Alexis Menard [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing. https://bugs.webkit.org/show_bug.cgi?id=102104 Reviewed by Julien Chaffraix. Protect the new feature behind a feature flag. * features.gypi: 2012-11-23 Yury Semikhatsky Unreviewed. Fix Chromium Win compilation after r135580. https://bugs.webkit.org/show_bug.cgi?id=101772 * tests/WebFrameTest.cpp: 2012-11-23 Sami Kyostila [chromium] Remove WebScreenInfo.{horizontal,vertical}DPI https://bugs.webkit.org/show_bug.cgi?id=101772 Reviewed by Adam Barth. Now that nothing is using WebScreenInfo.{horizontal,vertical}DPI we can simply remove them. * src/mac/WebScreenInfoFactory.mm: (WebKit::WebScreenInfoFactory::screenInfo): * src/win/WebScreenInfoFactory.cpp: (WebKit::WebScreenInfoFactory::screenInfo): * src/x11/WebScreenInfoFactory.cpp: (WebKit::WebScreenInfoFactory::screenInfo): 2012-11-22 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-22 Dana Jansens [chromium] Add OS!="ios" to guard for gcc_version in WebKit.gyp https://bugs.webkit.org/show_bug.cgi?id=103007 Reviewed by Adam Barth. This matches the guards used in chromium's chrome/chrome_browser.gypi. * WebKit.gyp: 2012-11-22 Stephen Chenney [Chromium]: Removing gyp flags controlling Skia features. Unreviewed, pre-tested rendering changes that have been waiting for a chance to rebaseline tests. Enabled fixes for test rendering, and fast patsh for anti-aliased primitives. * skia_webkit.gyp: 2012-11-22 Dan Carney IDBRequestTest needs a v8 context https://bugs.webkit.org/show_bug.cgi?id=102941 Reviewed by Jochen Eisinger. Added v8 context to IDBRequestTest tests. * tests/IDBRequestTest.cpp: (IDBRequestTest): (WebKit::IDBRequestTest::IDBRequestTest): (WebKit::IDBRequestTest::context): (WebKit::IDBRequestTest::scriptExecutionContext): (WebKit): (WebKit::TEST_F): 2012-11-21 Tien-Ren Chen [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0 https://bugs.webkit.org/show_bug.cgi?id=100061 Reviewed by Adam Barth. On Android we're using a different pixel scaling implementation (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other platforms. In this mode, we don't make use of device-independent pixels. Device scale factor is provided to WebKit and get merged into page scale factor. Other than that device scale factor should have no effects on rendering. * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::paint): * src/PageWidgetDelegate.h: * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::paint): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::shouldApplyDeviceScaleFactorInCompositor): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-21 Tien-Ren Chen Use m_webView->size() for viewport update https://bugs.webkit.org/show_bug.cgi?id=102764 Reviewed by Adam Barth. m_webView->client()->windowRect() returns the outer rect of the browser window, which includes the decorations such as the title bar. We should use the size of the WebView for layout and rendering purpose. Existing tests are updated to work without windowRect(). * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): * tests/WebFrameTest.cpp: 2012-11-21 Peter Beverloo [Chromium] webkit_unit_tests should depend on forwarder2 for Android https://bugs.webkit.org/show_bug.cgi?id=102934 Reviewed by Tony Chang. Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer to the test runner used by Chromium, which in turn relies on forwarder2. forwarder2 will eventually be required by layout tests as well. * WebKitUnitTests.gyp: 2012-11-21 Sheriff Bot Unreviewed, rolling out r135409. http://trac.webkit.org/changeset/135409 https://bugs.webkit.org/show_bug.cgi?id=102959 This patch causes compiling error to Chromium build (Requested by jianli_ on #webkit). * tests/IDBRequestTest.cpp: (WebCore::TEST): 2012-11-21 Kevin Ellis [chromium] Add flag to enable/disable touch adjustment at runtime. https://bugs.webkit.org/show_bug.cgi?id=102534 Reviewed by Antonio Gomes. Add setting for enabling or disabling touch adjustment. For touch adjustemnt to apply, the compile option must also be enabled. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setEnableTouchAdjustment): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-11-21 Dan Carney IDBRequestTest needs a v8 context https://bugs.webkit.org/show_bug.cgi?id=102941 Reviewed by Jochen Eisinger. Added v8 context to IDBRequestTest tests. * tests/IDBRequestTest.cpp: (IDBRequestTest): (WebKit::IDBRequestTest::IDBRequestTest): (WebKit::IDBRequestTest::context): (WebKit::IDBRequestTest::scriptExecutionContext): (WebKit): (WebKit::TEST_F): 2012-11-21 Peter Beverloo Unreviewed. Rolled DEPS. * DEPS: 2012-11-21 Allan Sandfeld Jensen Disambiguate innerNodeFramePoint and mainFramePoint https://bugs.webkit.org/show_bug.cgi?id=98139 Reviewed by Julien Chaffraix. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::mouseDidMoveOverElement): * src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::characterIndexForPoint): 2012-11-21 W. James MacLean [chromium] Link highlight should display for at least 100ms, and fadeout on GestureTap/Longpress. https://bugs.webkit.org/show_bug.cgi?id=102823 Reviewed by Adrienne Walker. Link highlights sometimes disappear so quickly they barely display. Modify so that the highlight is displayed for minimum 100ms before fading out, and also fadeout (as opposed to abrupt clear) on GestureTap and GestureLongPress. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::LinkHighlight): (WebKit::LinkHighlight::startHighlightAnimationIfNeeded): Check if min duration achieved, if not add time to fadeout animation. * src/LinkHighlight.h: (LinkHighlight): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): Fadeout instead of clear on GestureTap and GestureLongPress. 2012-11-21 Yury Semikhatsky Unreviewed. Now that offending patch has been rolled out reenable IDBRequestTest.EventsAfterStopping https://bugs.webkit.org/show_bug.cgi?id=102929 * tests/IDBRequestTest.cpp: (WebCore::TEST): 2012-11-21 Yury Semikhatsky Unreviewed. Disable failing test. https://bugs.webkit.org/show_bug.cgi?id=102929 * tests/IDBRequestTest.cpp: (WebCore::TEST): 2012-11-21 Florin Malita [Skia] Encapsulate access to PlatformContextSkia's SkCanvas https://bugs.webkit.org/show_bug.cgi?id=102694 Reviewed by Stephen White. Use PlatformContextSkia's wrapper methods instead of accessing the canvas directly. * tests/TransparencyWinTest.cpp: (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::TEST): 2012-11-20 Rachel Blum [Chromium] Need spellcheck suggestions even if continuous check is off. https://bugs.webkit.org/show_bug.cgi?id=102535 Reviewed by Hajime Morita. Make sure the context menu always has suggestions for misspelled words. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): 2012-11-20 Robert Kroeger [chromium] Use embedder-supported gesture curves https://bugs.webkit.org/show_bug.cgi?id=100884 Reviewed by James Robinson. Use embedder-provided gesture animation curves via WebKit api interfaces. Tested by existing tests. * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): (WebKit::WebCompositorInputHandlerImpl::scrollBy): * src/WebCompositorInputHandlerImpl.h: (WebCompositorInputHandlerImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollBy): (WebKit::WebViewImpl::handleGestureEvent): (WebKit::WebViewImpl::transferActiveWheelFlingAnimation): * src/WebViewImpl.h: (WebCore): (WebKit): (WebViewImpl): 2012-11-20 Tony Chang When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet https://bugs.webkit.org/show_bug.cgi?id=102835 Reviewed by Ojan Vafai. After r135082, Chromium browser_tests were triggering the ASSERT in StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will trigger earlier and make it clear in the Chromium code that we're always inserting user level styles. * src/WebDocument.cpp: (WebKit::WebDocument::insertUserStyleSheet): 2012-11-20 Istiaque Ahmed Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer. https://bugs.webkit.org/show_bug.cgi?id=102339 Reviewed by Adam Barth. This change will allow converting a page's window coordinates to plugins's local coordinates, taking CSS transformations into account. Embedder page of the plugin can use this information for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the local coordinate position inside plugin). * WebKit.gyp: * WebKit.gypi: * public/WebNode.h: (WebKit): * public/WebPluginContainer.h: (WebKit): (WebPluginContainer): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): * src/WebNode.cpp: (WebKit::WebNode::pluginContainer): (WebKit): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::windowToLocalPoint): (WebKit): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): * tests/FakeWebPlugin.cpp: Added. (WebKit): (WebKit::FakeWebPlugin::FakeWebPlugin): (WebKit::FakeWebPlugin::~FakeWebPlugin): (WebKit::FakeWebPlugin::initialize): (WebKit::FakeWebPlugin::destroy): * tests/FakeWebPlugin.h: Added. (WebKit): (FakeWebPlugin): * tests/WebPluginContainerTest.cpp: Added. (WebKit): (WebPluginContainerTest): (WebKit::WebPluginContainerTest::WebPluginContainerTest): (WebKit::WebPluginContainerTest::TearDown): (WebKit::getWebPluginContainer): (WebKit::TEST_F): * tests/data/plugin_container.html: Added. 2012-11-20 Alpha Lam [chromium] Make lazy image decoding thread-safe https://bugs.webkit.org/show_bug.cgi?id=102721 Reviewed by Stephen White. Added a new unit test to verify that lazy image decoding operates correctly on non-main threads. * tests/DeferredImageDecoderTest.cpp: (Rasterizer): (WebCore): (WebCore::rasterizeMain): (WebCore::TEST_F): 2012-11-20 Sheriff Bot Unreviewed, rolling out r135295. http://trac.webkit.org/changeset/135295 https://bugs.webkit.org/show_bug.cgi?id=102834 This patch causes assertion to some layout tests on chromium (Requested by jianli on #webkit). * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadData): * src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::initializeLoader): 2012-11-20 Eberhard Graether [Chromium] fix FPS counter disappearing when changing page https://bugs.webkit.org/show_bug.cgi?id=102532 Reviewed by Pavel Feldman. When changing the page with opened WebInspector and active FPS counter the WebInspector is reloaded before the WebView switches to accelerated compositing, so the showFPSCounter call to WebLayerTreeView is not yet possible. This fix saves the showFPSCounter value in the WebSettings so it can be read when accelerated compositing is activated. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setShowFPSCounter): 2012-11-20 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadData): * src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::initializeLoader): 2012-11-19 Yury Semikhatsky Unreviewed. Fix Chromium Win compilation after r135196. https://bugs.webkit.org/show_bug.cgi?id=102021 * tests/DeferredImageDecoderTest.cpp: changed char to unsigned char in the array declaration to avoid 'warning C4309' on MSVS when initializing from hex literals. (WebCore): 2012-11-19 Miguel Garcia [Chromium] Remove the dependency of INPUT_TYPE_COLOR on PAGE_POPUP https://bugs.webkit.org/show_bug.cgi?id=102525 Reviewed by Kent Tamura. INPUT_TYPE_COLOR should not depend on PAGE_POPUP, with this change we allow platforms like android to implement the former without depending on the latter. Tested by compiling chromium with and without ENABLE_PAGE_POPUP and made sure that forms with input type color would load in both cases. * WebKit.gyp: * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createColorChooser): * src/ColorChooserUIController.cpp: (WebKit::ColorChooserUIController::ColorChooserUIController): (WebKit::ColorChooserUIController::openUI): (WebKit): (WebKit::ColorChooserUIController::endChooser): * src/ColorChooserUIController.h: (ColorChooserUIController): 2012-11-19 Alpha Lam [chromium] Lazy image decoding without cache https://bugs.webkit.org/show_bug.cgi?id=102021 Reviewed by Stephen White. Updated two test cases using real image data. The tests demonstrates that original image decoder is not used and image is decoded lazily with correct pixel results. * tests/DeferredImageDecoderTest.cpp: (WebCore): (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::decoderBeingDestroyed): (DeferredImageDecoderTest): (WebCore::TEST_F): * tests/MockImageDecoder.h: (MockImageDecoderClient): (WebCore): (WebCore::MockImageDecoder::MockImageDecoder): (WebCore::MockImageDecoder::~MockImageDecoder): (MockImageDecoder): 2012-11-19 Sheriff Bot Unreviewed, rolling out r135180. http://trac.webkit.org/changeset/135180 https://bugs.webkit.org/show_bug.cgi?id=102700 breaks ui/compositor build (Requested by danakj on #webkit). * tests/GraphicsLayerChromiumTest.cpp: (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): 2012-11-19 Yusuke Sato [Chromium] Flash cannot receive scroll events when threaded compositing is in use https://bugs.webkit.org/show_bug.cgi?id=101423 Reviewed by James Robinson. Add setWantsWheelEvents() to Chromium's WebPluginContainer interface so that a plugin can tell the container that the plugin always wants to handle wheel events even when a scroll bar is not shown. * public/WebPluginContainer.h: (WebPluginContainer): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setWantsWheelEvents): (WebKit): (WebKit::WebPluginContainerImpl::wantsWheelEvents): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-11-19 Alec Flett IndexedDB: simplify RecordIdentifier https://bugs.webkit.org/show_bug.cgi?id=102018 Reviewed by Tony Chang. Update IDBFakeBackingStore to match its parent class. * tests/IDBFakeBackingStore.h: 2012-11-19 Vincent Scheib [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock. https://bugs.webkit.org/show_bug.cgi?id=96946 Reviewed by Adam Barth. The runtime flag functionality has already been removed. Now that Chromium no longer has a compile dependency on this API, it can be removed as well. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): * src/WebRuntimeFeatures.cpp: 2012-11-19 Kihong Kwon Add PROXIMITY_EVENTS feature https://bugs.webkit.org/show_bug.cgi?id=102658 Reviewed by Kentaro Hara. Add PROXIMITY_EVENTS feature to chromium port. * features.gypi: 2012-11-19 Sami Kyostila [chromium] Use devicePixelRatio instead of screen DPI for computing viewport attributes https://bugs.webkit.org/show_bug.cgi?id=101767 Reviewed by Adam Barth. Use the newly introduced device scale factor to calculate viewport properties instead of using the screen DPI. No functional changes, because Chromium platforms that have VIEWPORT enabled now also initialize the device scale factor accordingly. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): * tests/WebFrameTest.cpp: 2012-11-18 Kentaro Hara Unreviewed, rolling out r135047. http://trac.webkit.org/changeset/135047 https://bugs.webkit.org/show_bug.cgi?id=102339 it broke Chromium Windows/Mac build * WebKit.gyp: * WebKit.gypi: * public/WebNode.h: (WebKit): * public/WebPluginContainer.h: (WebKit): (WebPluginContainer): * src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode): (WebKit): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): * src/WebNode.cpp: * src/WebPluginContainerImpl.cpp: * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): * tests/FakeWebPlugin.cpp: Removed. * tests/FakeWebPlugin.h: Removed. * tests/WebPluginContainerTest.cpp: Removed. * tests/data/plugin_container.html: Removed. 2012-11-18 Rick Byers [chromium] add WebCursorInfo::imageScaleFactor https://bugs.webkit.org/show_bug.cgi?id=102612 Reviewed by Adam Barth. Add cursor image scale factor (currently always 1) to chromium API, in preparation for high-dpi cursor support in bug 99493. * public/WebCursorInfo.h: (WebKit::WebCursorInfo::WebCursorInfo): * src/WebCursorInfo.cpp: (WebKit::WebCursorInfo::WebCursorInfo): 2012-11-17 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-17 Istiaque Ahmed Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer. https://bugs.webkit.org/show_bug.cgi?id=102339 Reviewed by Adam Barth. This change will allow converting a page's window coordinates to plugins's local coordinates, taking CSS transformations into account. Embedder page of the plugin can use this information for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the local coordinate position inside plugin). Attempting to re-land after Windows build fix. * WebKit.gyp: * WebKit.gypi: * public/WebNode.h: (WebKit): * public/WebPluginContainer.h: (WebKit): (WebPluginContainer): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): * src/WebNode.cpp: (WebKit::WebNode::pluginContainer): (WebKit): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::windowToLocalPoint): (WebKit): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): * tests/FakeWebPlugin.cpp: Added. (WebKit): (WebKit::FakeWebPlugin::FakeWebPlugin): (WebKit::FakeWebPlugin::~FakeWebPlugin): (WebKit::FakeWebPlugin::initialize): (WebKit::FakeWebPlugin::destroy): * tests/FakeWebPlugin.h: Added. (WebKit): (FakeWebPlugin): * tests/WebPluginContainerTest.cpp: Added. (WebKit): (WebPluginContainerTest): (WebKit::WebPluginContainerTest::WebPluginContainerTest): (WebKit::WebPluginContainerTest::TearDown): (WebKit::getWebPluginContainer): (WebKit::TEST_F): * tests/data/plugin_container.html: Added. 2012-11-16 Raman Kumar Add setChecked API in WebInputElement https://bugs.webkit.org/show_bug.cgi?id=102422 Reviewed by Adam Barth. * public/WebInputElement.h: (WebInputElement): Add setChecked(bool, bool) API * src/WebInputElement.cpp: (WebKit::WebInputElement::setChecked): Implement setChecked by calling underlying HTMLInputElement's setChecked. (WebKit): 2012-11-16 Tony Chang Remove ENABLE_CSS_HIERARCHIES since it's no longer in use https://bugs.webkit.org/show_bug.cgi?id=102554 Reviewed by Andreas Kling. As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 , we're going to revist this feature once additional vendor support is achieved. * features.gypi: 2012-11-16 Mark Pilgrim [Chromium] Remove cookie-related functions from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=99340 Reviewed by Adam Barth. Move cookie-related functions out of PlatformSupport and implement new PlatformCookieJar interface via NetworkContext. * WebKit.gyp: * src/FrameNetworkingContextImpl.cpp: Added. (WebKit): (WebKit::FrameNetworkingContextImpl::cookieJar): * src/FrameNetworkingContextImpl.h: (FrameNetworkingContextImpl): * src/PlatformSupport.cpp: 2012-11-16 Tien-Ren Chen Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor https://bugs.webkit.org/show_bug.cgi?id=102462 Reviewed by James Robinson. As we no longer have this "default" device scale factor. * public/WebSettings.h: (WebKit::WebSettings::setApplyDefaultDeviceScaleFactorInCompositor): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDeviceScaleFactor): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): 2012-11-16 Jon Lee Fix build error on Chromium due to r134995. * src/WebNode.cpp: (WebKit::WebNode::simulateClick): Pass in NULL pointer instead. 2012-11-16 Michael Pruett IndexedDB: Propagate DOMRequestState to IndexedDB binding utility functions https://bugs.webkit.org/show_bug.cgi?id=102430 Reviewed by Adam Barth. DOMRequestState is currently propagated to some but not all of the IndexedDB binding utility functions. In order to implement these functions for JSC, this state must be propagated to all of the utility functions. * tests/IDBBindingUtilitiesTest.cpp: (WebKit::checkKeyFromValueAndKeyPathInternal): (WebKit::injectKey): 2012-11-16 Tommy Widenflycht MediaStream API: Update RTCPeerConnection states to match the latest editors draft https://bugs.webkit.org/show_bug.cgi?id=102382 Reviewed by Adam Barth. Updating readyState & iceState, and adding iceGatheringState. * src/AssertMatchingEnums.cpp: 2012-11-16 Dimitri Glazkov Unreviewed, rolling out r134973. http://trac.webkit.org/changeset/134973 https://bugs.webkit.org/show_bug.cgi?id=99340 Broke compile on at least Mac and Linux. * WebKit.gyp: * src/FrameNetworkingContextImpl.h: * src/PlatformSupport.cpp: (WebCore::getCookieJar): (WebCore): (WebCore::PlatformSupport::setCookies): (WebCore::PlatformSupport::cookies): (WebCore::PlatformSupport::cookieRequestHeaderFieldValue): (WebCore::PlatformSupport::rawCookies): (WebCore::PlatformSupport::deleteCookie): (WebCore::PlatformSupport::cookiesEnabled): 2012-11-16 Mark Pilgrim [Chromium] Remove cookie-related functions from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=99340 Reviewed by Adam Barth. Move cookie-related functions out of PlatformSupport and implement new PlatformCookieJar interface via NetworkContext. * WebKit.gyp: * src/FrameNetworkingContextImpl.cpp: Added. (WebKit): (WebKit::FrameNetworkingContextImpl::cookieJar): * src/FrameNetworkingContextImpl.h: (FrameNetworkingContextImpl): * src/PlatformSupport.cpp: 2012-11-16 Scott Violet [chromium] Copy linux theme related files to default https://bugs.webkit.org/show_bug.cgi?id=102403 Reviewed by Tony Chang Transitional patch that copies linux WebThemeEngine to default directory. No new tests, refactoring only. * features.gypi: * public/platform/default: Added. * public/platform/default/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/platform/linux/WebThemeEngine.h. * src/PlatformSupport.cpp: Includes correct theme files when DEFAULT_RENDER_THEME is set. (WebCore): * src/WebViewImpl.cpp: Includes correct theme files when DEFAULT_RENDER_THEME is set. (WebKit::WebViewImpl::setScrollbarColors): Calls to default theme as necessary. (WebKit::WebViewImpl::setSelectionColors): Calls to default theme as necessary. 2012-11-16 Robert Flack Handle gesture events on scrollbars. https://bugs.webkit.org/show_bug.cgi?id=101516 Reviewed by Antonio Gomes. Adds a gesture event handler to scrollbars and sends gestures beginning over a scrollbar to this handler to allow touch scrolling scrollbars. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-11-16 Peter Beverloo Unreviewed. Rolled DEPS. * DEPS: 2012-11-15 Kentaro Hara Unreviewed, rolling out r134880. http://trac.webkit.org/changeset/134880 https://bugs.webkit.org/show_bug.cgi?id=102339 it broke Chromium Windows build * WebKit.gyp: * WebKit.gypi: * public/WebNode.h: (WebKit): * public/WebPluginContainer.h: (WebKit): (WebPluginContainer): * src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode): (WebKit): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): * src/WebNode.cpp: * src/WebPluginContainerImpl.cpp: * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): * tests/FakeWebPlugin.cpp: Removed. * tests/FakeWebPlugin.h: Removed. * tests/WebPluginContainerTest.cpp: Removed. * tests/data/plugin_container.html: Removed. 2012-11-15 Istiaque Ahmed Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer. https://bugs.webkit.org/show_bug.cgi?id=102339 Reviewed by Adam Barth. This change will allow converting a page's window coordinates to plugins's local coordinates, taking CSS transformations into account. Embedder page of the plugin can use this information for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the local coordinate position inside plugin). * WebKit.gyp: * WebKit.gypi: * public/WebNode.h: (WebKit): * public/WebPluginContainer.h: (WebKit): (WebPluginContainer): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): * src/WebNode.cpp: (WebKit::WebNode::pluginContainer): (WebKit): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::windowToLocalPoint): (WebKit): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): * tests/FakeWebPlugin.cpp: Added. (WebKit): (WebKit::FakeWebPlugin::FakeWebPlugin): (WebKit::FakeWebPlugin::~FakeWebPlugin): (WebKit::FakeWebPlugin::initialize): (WebKit::FakeWebPlugin::destroy): * tests/FakeWebPlugin.h: Added. (WebKit): (FakeWebPlugin): * tests/WebPluginContainerTest.cpp: Added. (WebKit): (WebPluginContainerTest): (WebKit::WebPluginContainerTest::WebPluginContainerTest): (WebKit::WebPluginContainerTest::TearDown): (WebKit::getWebPluginContainer): (WebKit::TEST_F): * tests/data/plugin_container.html: Added. 2012-11-15 Tien-Ren Chen Add Settings to disable custom scrollbars on main frame https://bugs.webkit.org/show_bug.cgi?id=102323 Reviewed by Adam Barth. Custom scrollbars on main frame don't really work well on touch devices. Add a setting to inhibit their creation. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAllowCustomScrollbarInMainFrame): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-11-15 Yue Zhang Ignore autocomplete=off for chrome generated passwords. https://bugs.webkit.org/show_bug.cgi?id=102426 Reviewed by Adam Barth. Record the autocomplete attribute in the web password form data, so that we can handle autocomplete in chromium code. The motivation/background is: we should ignore autocomplete=off field for password forms with chrome generated passwords (has passed security review). By handling autocomplete in chromium code we can distinguish password forms with chrome generated passwords and those normal password forms. Note that we haven't turned off checking autocomplete=off in the Webkit code for now so there is no behavior change after this CL, and we will turn off after we make the chromium side change to be safe. * public/WebPasswordFormData.h: (WebPasswordFormData): * src/WebPasswordFormData.cpp: 2012-11-15 Scott Violet [chromium] Create default directory so that cq can apply patch https://bugs.webkit.org/show_bug.cgi?id=102421 Reviewed by Tony Chang. Done in hopes of patch that copies files to this directory working. * public/platform/default: Added. 2012-11-15 Sheriff Bot Unreviewed, rolling out r134800 and r134805. http://trac.webkit.org/changeset/134800 http://trac.webkit.org/changeset/134805 https://bugs.webkit.org/show_bug.cgi?id=102417 This patch broke chromium port (Requested by jianli on #webkit). * src/AssertMatchingEnums.cpp: 2012-11-15 Sadrul Habib Chowdhury [chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled. https://bugs.webkit.org/show_bug.cgi?id=102246 Reviewed by James Robinson. * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): * tests/WebCompositorInputHandlerImplTest.cpp: (MockWebInputHandlerClient): (WebKit::TEST_F): 2012-11-15 Tommy Widenflycht MediaStream API: Update RTCPeerConnection states to match the latest editors draft https://bugs.webkit.org/show_bug.cgi?id=102382 Reviewed by Adam Barth. Updating readyState & iceState, and adding iceGatheringState. * src/AssertMatchingEnums.cpp: 2012-11-15 Tien-Ren Chen Use correct unscaled document size when calculating scale limits https://bugs.webkit.org/show_bug.cgi?id=102028 Reviewed by Adam Barth. Fixes bug http://crbug.com/160581 Using contentsSize / pageScaleFactor as unscaled contents size results in rounding errors. This can cause scale factor to oscillate indefinitely. * src/WebViewImpl.cpp: (WebKit::unscaledContentsSize): (WebKit): (WebKit::WebViewImpl::computePageScaleFactorLimits): * tests/WebFrameTest.cpp: * tests/data/scale_oscillate.html: Added. 2012-11-15 Kenneth Russell [chromium] Move allowWebGL query to WebFrameClient https://bugs.webkit.org/show_bug.cgi?id=102319 Reviewed by Adam Barth. Moved allowWebGL query to WebFrameClient to avoid polluting content/ API. * public/WebFrameClient.h: (WebFrameClient): (WebKit::WebFrameClient::allowWebGL): * public/WebPermissionClient.h: * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowWebGL): 2012-11-15 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-15 Stephen Chenney [Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp Unreviewed non-funtional, behavior-neutral change * skia_webkit.gyp: Add SK_DISABLE_FAST_AA_STROKE_RECT=1 so that it can be removed from Chromium's skia.gyp 2012-11-15 Stephen Chenney [Chromium] Disable SK_IGNORE_FAST_BLURRECT Unreviewed test update. This flag is enabled purely to simplify rebaselining. I am now removing it and doing the rebaslining. * skia_webkit.gyp: Remove the line for SK_IGNORE_FAST_BLURRECT 2012-11-15 Kent Tamura Support stand-alone month names in calendar picker https://bugs.webkit.org/show_bug.cgi?id=102196 Reviewed by Kentaro Hara. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): We don't need to pass monthLabels any more. 2012-11-14 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-14 Joshua Bell IndexedDB: Remove magic numbers in record comparator, handle missing case https://bugs.webkit.org/show_bug.cgi?id=102255 Reviewed by Tony Chang. Add test keys for various metadata types. * tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST): 2012-11-14 Eric Uhrhane [chromium] Don't let shift-click turn popup into tab. https://bugs.webkit.org/show_bug.cgi?id=102254 Reviewed by Adam Barth. Change http://trac.webkit.org/changeset/132399 broke shift-click on compose in GMail. We didn't want to change behavior that people were depending on, and this quick fix seems a good compromise between user intent and developer intent. * src/ChromeClientImpl.cpp: (WebKit::updatePolicyForEvent): 2012-11-14 Mike Reed Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice(). https://bugs.webkit.org/show_bug.cgi?id=102242 Reviewed by Stephen White. This change should not change any test results, it is an equivalent implementation that avoids using a (now) DEPRECATED function. * tests/DeferredImageDecoderTest.cpp: (WebCore::createRasterCanvas): (WebCore): (WebCore::DeferredImageDecoderTest::SetUp): (DeferredImageDecoderTest): (WebCore::TEST_F): 2012-11-14 Sheriff Bot Unreviewed, rolling out r134523. http://trac.webkit.org/changeset/134523 https://bugs.webkit.org/show_bug.cgi?id=102218 brake chrome windows build, as it references a non existing header js/DOMRequestState.h (Requested by jochen__ on #webkit). * src/WebIDBKey.cpp: 2012-11-14 Kent Tamura Support for localization tests of calendar picker https://bugs.webkit.org/show_bug.cgi?id=102181 Reviewed by Kentaro Hara. * src/DateTimeChooserImpl.cpp: Use DateTimeChooserParameters::locale. (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): (WebKit::DateTimeChooserImpl::writeDocument): 2012-11-14 Sheriff Bot Unreviewed, rolling out r134566. http://trac.webkit.org/changeset/134566 https://bugs.webkit.org/show_bug.cgi?id=102197 "it broke Chromium Android Release build" (Requested by haraken on #webkit). * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): (WebKit::DateTimeChooserImpl::writeDocument): 2012-11-14 Kent Tamura Support for localization tests of calendar picker https://bugs.webkit.org/show_bug.cgi?id=102181 Reviewed by Kentaro Hara. * src/DateTimeChooserImpl.cpp: Use DateTimeChooserParameters::locale. (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): (WebKit::DateTimeChooserImpl::writeDocument): 2012-11-14 Yury Semikhatsky Remove MemoryInstrumentationTest.ImageObserver https://bugs.webkit.org/show_bug.cgi?id=102185 Reviewed by Pavel Feldman. Removed obsolete memory instrumenation unit test. * WebKit.gypi: * tests/MemoryInstrumentationTest.cpp: Removed. 2012-11-14 Kent Tamura [Chromium] Add API to expose WebCore::DateTimeChooser https://bugs.webkit.org/show_bug.cgi?id=101196 Reviewed by Hajime Morita. Add ability to open date/time choosers to WebViewClient. - ExternalDateTimeChooser forwards DateTimeChooser requests from WebCore to WebViewClient, and waits for WebDateTimeChooerCompletion notifications. - WebDateTimeChooserParams contains various information to create chooser UI. - WebDateTimeChooserCompletion informs value selection by users to ExternalDateTimeChooser. The design is very similar to existing WebFileChooserParams and WebFileChooserCompletion. These interfaces are used only if ENABLE_INPUT_MULTIPLE_FIELDS_UI is not enabled, that is to say, in Chromium-Android port. Non-Android Chromium ports use DateTimeChooserImpl and WebKit-internal choosers. * WebKit.gyp: Add WebDateTimeChooserCompletion.h, WebDateTimeChooserParams.h, ExternalDateTimeChooser.cpp, and ExternalDateTimeChooser.h. * public/WebDateTimeChooserCompletion.h: Added. (WebDateTimeChooserCompletion): (WebKit::WebDateTimeChooserCompletion::~WebDateTimeChooserCompletion): * public/WebDateTimeChooserParams.h: Added. (WebDateTimeChooserParams): (WebKit::WebDateTimeChooserParams::WebDateTimeChooserParams): * public/WebViewClient.h: (WebKit): Add some forward declarations. (WebKit::WebViewClient::openDateTimeChooser): Added. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::openDateTimeChooser): Creates ExternalDateTimeChooser if !ENABLE(INPUT_MULTIPLE_FIELDS_UI). * src/ExternalDateTimeChooser.cpp: Added. (WebDateTimeChooserCompletionImpl): An implementation of WebDateTimeChooserCompletion. When didChooseValue or didCancelChooser is called, it notifies to an ExternalDateTimeChooser and kill itself. (WebKit::ExternalDateTimeChooser::~ExternalDateTimeChooser): Added. (WebKit::ExternalDateTimeChooser::ExternalDateTimeChooser): Added. (WebKit::ExternalDateTimeChooser::create): Cretes an object, then asks the WebViewClient to open date/time chooser. If an open request fails, an empty PassRefPtr<> is returned. We don't ask to open in the constructor because open requests might fail and it's hard for the constructor to tell the failure. (WebKit::ExternalDateTimeChooser::openDateTimeChooser): Prepares a WebDateTimeChooserParams and a WebDateTimeChooserCompletion, calls WebViewClient::openDateTimeChooser, and kill the WebDateTimeChooserCompletion if openDateTimeChooser fails. (WebKit::ExternalDateTimeChooser::didChooseValue): Called by WebDateTimeChooserCompletion. We need to check m_client because the requester is already dead. (WebKit::ExternalDateTimeChooser::didCancelChooser): Ditto. (WebKit::ExternalDateTimeChooser::endChooser): Called by the requester when it wants to close the chooser. We don't close the chooser here, and just disconnect the association of the client and this object. * src/ExternalDateTimeChooser.h: Added. 2012-11-13 Vincent Scheib Remove RuntimeEnabledFeatures::isPointerLockEnabled. https://bugs.webkit.org/show_bug.cgi?id=102107 Reviewed by Adam Barth. The runtime flag is always true now that the feature is enabled by default in Chromium. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): * src/WebRuntimeFeatures.cpp: (WebKit): (WebKit::WebRuntimeFeatures::enablePointerLock): 2012-11-13 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-13 Dana Jansens [chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the GraphicsLayer border width setting. https://bugs.webkit.org/show_bug.cgi?id=102130 Reviewed by James Robinson. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): 2012-11-13 Keishi Hattori Enable datalist UI for input types week and month https://bugs.webkit.org/show_bug.cgi?id=102041 Reviewed by Kent Tamura. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): If the type supports calendar picker show the "Other..." option. 2012-11-13 Eberhard Graether checkbox to toggle FPS counter in the inspector's settings https://bugs.webkit.org/show_bug.cgi?id=99660 Reviewed by Pavel Feldman. Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true. * public/WebView.h: (WebView): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::canShowFPSCounter): (WebKit): (WebKit::InspectorClientImpl::setShowFPSCounter): * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setShowFPSCounter): (WebKit): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::loadFontAtlasIfNecessary): * src/WebViewImpl.h: (WebViewImpl): 2012-11-13 Dana Jansens [chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport https://bugs.webkit.org/show_bug.cgi?id=102146 Reviewed by James Robinson. Add accelerated animation and per-tile painting to the WebSettings structure. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled): (WebKit): (WebKit::WebSettingsImpl::setPerTilePaintingEnabled): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::gestureTapHighlightEnabled): (WebKit::WebSettingsImpl::doubleTapToZoomEnabled): (WebKit::WebSettingsImpl::perTilePaintingEnabled): (WebKit::WebSettingsImpl::acceleratedAnimationEnabled): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): 2012-11-13 Kenneth Russell Notify embedder of lost contexts and allow overriding of WebGL support https://bugs.webkit.org/show_bug.cgi?id=101826 Reviewed by Adam Barth. Expose new FrameLoaderClient hooks through Chromium's WebPermissionClient and WebFrameClient. Downstream browser tests will exercise this new functionality. * public/WebFrameClient.h: (WebFrameClient): (WebKit::WebFrameClient::didLoseWebGLContext): * public/WebPermissionClient.h: (WebPermissionClient): (WebKit::WebPermissionClient::allowWebGL): * src/FrameLoaderClientImpl.cpp: (WebKit): (WebKit::FrameLoaderClientImpl::allowWebGL): (WebKit::FrameLoaderClientImpl::didLoseWebGLContext): * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): 2012-11-13 Chris Fleizach AX: MathML types need to be semantically identified in AX tree https://bugs.webkit.org/show_bug.cgi?id=101263 Reviewed by Beth Dakin. * public/WebAccessibilityRole.h: * src/AssertMatchingEnums.cpp: Add new accessibility role. 2012-11-13 Silvia Pfeiffer Clean up the inheritance tree under the MediaControls Class. https://bugs.webkit.org/show_bug.cgi?id=88871 Reviewed by Eric Carlson. This patch removes code duplication between the Chromium and Safari media controls shadow DOMs. The derived classes are renamed based on their platform: - MediaControlRootElement to MediaControlsApple. - MediaControlRootElementChromium to MediaControlsChromium. - MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid. * public/WebContextMenuData.h: Move MediaControlRootElement to MediaControls. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Move MediaControlRootElement to MediaControls. 2012-11-13 Dimitri Glazkov Unreviewed, rolling out r134446. http://trac.webkit.org/changeset/134446 https://bugs.webkit.org/show_bug.cgi?id=101968 Need to try a different strategy for landing a two-sided patch (3/3). * public/WebSettings.h: * src/WebSettingsImpl.cpp: * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::gestureTapHighlightEnabled): (WebKit::WebSettingsImpl::doubleTapToZoomEnabled): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): 2012-11-13 Dan Carney [V8] More efficient wrapper dispatch https://bugs.webkit.org/show_bug.cgi?id=102082 Reviewed by Adam Barth. * src/WebArrayBuffer.cpp: (WebKit::WebArrayBuffer::toV8Value): * src/WebBlob.cpp: (WebKit::WebBlob::toV8Value): 2012-11-12 Dana Jansens [chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings https://bugs.webkit.org/show_bug.cgi?id=101968 Reviewed by James Robinson. This adds perTilePainting and acceleratedAniamtions to the WebSettings classes, so that DRT can turn these on via WebLayerTreeSettings. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled): (WebKit): (WebKit::WebSettingsImpl::setPerTilePaintingEnabled): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::gestureTapHighlightEnabled): (WebKit::WebSettingsImpl::doubleTapToZoomEnabled): (WebKit::WebSettingsImpl::perTilePaintingEnabled): (WebKit::WebSettingsImpl::acceleratedAnimationEnabled): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): 2012-11-13 Alec Flett IndexedDB: remove legacy string-based backend methods https://bugs.webkit.org/show_bug.cgi?id=102004 Reviewed by Adam Barth. This is the final stage in a refactor, preceded by https://bugs.webkit.org/show_bug.cgi?id=100426 * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): * public/WebIDBTransaction.h: * src/IDBDatabaseBackendProxy.cpp: * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBTransactionBackendProxy.cpp: * src/IDBTransactionBackendProxy.h: (IDBTransactionBackendProxy): 2012-11-13 Dimitri Glazkov Unreviewed, rolling out r134391. http://trac.webkit.org/changeset/134391 https://bugs.webkit.org/show_bug.cgi?id=99660 Speculative rollout, trying to fix browser_tests failure. * public/WebView.h: (WebView): * src/InspectorClientImpl.cpp: * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-13 Ilya Tikhonovsky Unreviewed: temporary disable failing test. * tests/MemoryInstrumentationTest.cpp: 2012-11-13 Eberhard Graether checkbox to toggle FPS counter in the inspector's settings https://bugs.webkit.org/show_bug.cgi?id=99660 Reviewed by Pavel Feldman. Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true. * public/WebView.h: (WebView): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::canShowFPSCounter): (WebKit): (WebKit::InspectorClientImpl::setShowFPSCounter): * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setShowFPSCounter): (WebKit): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::loadFontAtlasIfNecessary): * src/WebViewImpl.h: (WebViewImpl): 2012-11-12 Kent Tamura Unable to set valid time value to input[type=time] with user interaction in some cases https://bugs.webkit.org/show_bug.cgi?id=102048 Reviewed by Kentaro Hara. * tests/DecimalTest.cpp: (TEST_F): Update and add tests. 2.1 % 3 should be 2.1 10 % -3 should be 1 -10 % -3 should be -1 3.6 % 1.3 should be 1 500 % 1000 should be 500 -500 % 1000 should be -500 2012-11-12 Min Qin Fix windowRect calculation for webplugin due to page scale factors https://bugs.webkit.org/show_bug.cgi?id=100182 Reviewed by Adam Barth. The current calculaton of windowRect in WebPluginContainerImpl is wrong. Even after some of our latest changes. The problem is caused by page scale factor. For example, windowToContents(IntPoint) will return an unscaled offset for an iframe, but will return a scaled offset for the main frame. So in order to obtain the correct window coordinate, we need to use contentsToWindow(). Since webview_plugin.cc is expecting window coordinates, we need to use contentsToWindow(IntRect) to calculate the windowRect so that the rect size can get correctly scaled. It is difficult to write a test for this because it's pixel-based, and plugin placeholder is managed on the Chromium side (webview_plugin.cc). * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): 2012-11-12 Adam Barth Unreviewed. Roll Chromium DEPS. 2012-11-12 Stephen Chenney [chromium] Supressing a Skia change to prevent layout test breakage. Unreviewed expectations management. * skia_webkit.gyp: Added supression 'SK_IGNORE_FAST_BLURRECT=1' 2012-11-12 Alexandre Elias [chromium] Delete WebCompositor.h https://bugs.webkit.org/show_bug.cgi?id=101137 Reviewed by James Robinson. The implementation of this class is getting deleted and all WebKit-side users are already going via WebCompositorSupport instead. * tests/WebCompositorInputHandlerImplTest.cpp: 2012-11-12 Dirk Pranke Fix Chromium DEPS version after accidentally checking in HEAD a couple days ago. Unreviewed, build fix. * DEPS: 2012-11-12 Keishi Hattori Add support for week/month to Locale::formatDateTime() https://bugs.webkit.org/show_bug.cgi?id=101878 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: (LocaleMacTest::formatWeek): Takes ISO string and returns localized string. (LocaleMacTest): (LocaleMacTest::formatMonth): Ditto. (TEST_F): 2012-11-11 Sadrul Habib Chowdhury [chromium] Expose CustomEvent through WebDOMCustomEvent. https://bugs.webkit.org/show_bug.cgi?id=101293 Reviewed by Adam Barth. * WebKit.gyp: * public/WebDOMCustomEvent.h: Added. (WebKit): (WebDOMCustomEvent): (WebKit::WebDOMCustomEvent::WebDOMCustomEvent): * src/WebDOMCustomEvent.cpp: Added. (WebKit): (WebKit::WebDOMCustomEvent::initCustomEvent): 2012-11-09 Rick Byers Move chromium to USE(LAZY_NATIVE_CURSOR) https://bugs.webkit.org/show_bug.cgi?id=101501 Reviewed by Adam Barth. Update conversion from Cursor to WebCursorInfo to remove the intermediate (and useless) step of PlatformCursor. * src/AssertMatchingEnums.cpp: * src/WebCursorInfo.cpp: (WebKit::WebCursorInfo::WebCursorInfo): 2012-11-09 Alec Flett IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore https://bugs.webkit.org/show_bug.cgi?id=101415 Reviewed by Tony Chang. Remove method that is no longer in the base class. * tests/IDBFakeBackingStore.h: 2012-11-09 Sheriff Bot Unreviewed, rolling out r134101. http://trac.webkit.org/changeset/134101 https://bugs.webkit.org/show_bug.cgi?id=101790 IDBDatabaseBackendTest.BackingStoreRetention failing (Requested by jsbell|gardener on #webkit). * tests/IDBFakeBackingStore.h: 2012-11-09 Alec Flett IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore https://bugs.webkit.org/show_bug.cgi?id=101415 Reviewed by Tony Chang. Remove method that is no longer in the base class. * tests/IDBFakeBackingStore.h: 2012-11-09 Alec Flett IndexedDB: switch frontend to use int64_t-based references https://bugs.webkit.org/show_bug.cgi?id=100426 Reviewed by Tony Chang. Remove implementation stubs from chromium API for methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425 * src/IDBObjectStoreBackendProxy.cpp: * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-11-09 Tommy Widenflycht MediaStream API: Deleting all files relating to the deprecated PeerConnection00 https://bugs.webkit.org/show_bug.cgi?id=101730 Reviewed by Adam Barth. Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all files relating to the old API. * WebKit.gyp: * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): * public/platform/WebICECandidateDescriptor.h: Removed. * public/platform/WebICEOptions.h: Removed. * public/platform/WebMediaHints.h: Removed. * public/platform/WebPeerConnection00Handler.h: Removed. * public/platform/WebPeerConnection00HandlerClient.h: Removed. * public/platform/WebPeerConnectionHandler.h: Removed. * public/platform/WebPeerConnectionHandlerClient.h: Removed. * public/platform/WebSessionDescriptionDescriptor.h: Removed. * src/AssertMatchingEnums.cpp: * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::isPeerConnectionEnabled): * src/WebSessionDescriptionDescriptor.cpp: Removed. 2012-11-08 Sheriff Bot Unreviewed, rolling out r134010. http://trac.webkit.org/changeset/134010 https://bugs.webkit.org/show_bug.cgi?id=101716 Broke the chromium windows build. (Requested by noel_ on #webkit). * src/IDBCallbacksProxy.cpp: * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::transaction): (WebKit): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys): (WebKit): (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::deleteObjectStore): (WebKit): (WebKit::WebIDBDatabaseImpl::transaction): * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::putWithIndexKeys): (WebKit): (WebKit::WebIDBObjectStoreImpl::setIndexKeys): (WebKit::WebIDBObjectStoreImpl::setIndexesReady): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::deleteIndex): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): * src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore): (WebKit): * src/WebIDBTransactionImpl.h: * tests/IDBRequestTest.cpp: 2012-11-08 Alec Flett IndexedDB: switch frontend to use int64_t-based references https://bugs.webkit.org/show_bug.cgi?id=100426 Reviewed by Tony Chang. Remove implementation stubs from chromium API for methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425 * src/IDBObjectStoreBackendProxy.cpp: * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-11-08 Keishi Hattori WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close https://bugs.webkit.org/show_bug.cgi?id=93800 Reviewed by Kent Tamura. We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent. * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::close): Set m_closing to true. 2012-11-08 Sheriff Bot Unreviewed, rolling out r133984. http://trac.webkit.org/changeset/133984 https://bugs.webkit.org/show_bug.cgi?id=101684 windows build error. (Requested by hayato on #webkit). * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys): (WebKit): (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::deleteObjectStore): (WebKit): (WebKit::WebIDBDatabaseImpl::transaction): * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::putWithIndexKeys): (WebKit): (WebKit::WebIDBObjectStoreImpl::setIndexKeys): (WebKit::WebIDBObjectStoreImpl::setIndexesReady): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::deleteIndex): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): * src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore): (WebKit): * src/WebIDBTransactionImpl.h: 2012-11-08 Alec Flett IndexedDB: switch frontend to use int64_t-based references https://bugs.webkit.org/show_bug.cgi?id=100426 Reviewed by Tony Chang. Remove implementation stubs from chromium API for methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425 * src/IDBObjectStoreBackendProxy.cpp: * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-11-07 Kent Tamura [Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements https://bugs.webkit.org/show_bug.cgi?id=101537 Reviewed by Abhishek Arya. We should not do ignore-case comparison for tagName, which is always upper-case and createElementNS(xhtmlNS, "INPUT") doesn't create an HTMLInputElement object. We need to check if localName is equal to "input" in this case. * src/WebElement.cpp: (WebKit::WebElement::hasHTMLTagName): 2012-11-08 Joshua Bell Expose snapshots in platform/leveldb wrapper API https://bugs.webkit.org/show_bug.cgi?id=100786 Reviewed by Tony Chang. Add unit tests for transactions/snapshots. * tests/LevelDBTest.cpp: (WebCore::encodeString): Don't append to pre-sized vector. (WebCore::TEST): (WebCore): 2012-11-08 Adam Barth Unreviewed. Roll Chromium DEPS: 166678 => 166755 * DEPS: 2012-11-08 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-08 Sami Kyostila Introduce WebScreenInfo.deviceScaleFactor https://bugs.webkit.org/show_bug.cgi?id=101613 Reviewed by Adam Barth. Introduce the WebScreenInfo.deviceScaleFactor property, which specifies the ratio between physical and logical pixels. This is the first step in replacing horizontalDPI/verticalDPI in favor of the deviceScaleFactor. For now, this value is only initialized on Mac, because the other ports that use it initialize the value in Chromium, whereas Windows and X11 default to a factor of 1. The value on Mac is truncated to an integer to match the expectation in Chromium's RenderWidget. * src/mac/WebScreenInfoFactory.mm: (WebKit::WebScreenInfoFactory::screenInfo): 2012-11-08 Dan Carney Cleanup IDBBindingUtilitiesTest https://bugs.webkit.org/show_bug.cgi?id=100860 Reviewed by Adam Barth. Small cleanup of IDBBindingUtilitiesTest as per https://bugs.webkit.org/show_bug.cgi?id=99975#c38 * tests/IDBBindingUtilitiesTest.cpp: (IDBKeyFromValueAndKeyPathTest): (WebKit::IDBKeyFromValueAndKeyPathTest::IDBKeyFromValueAndKeyPathTest): (WebKit::IDBKeyFromValueAndKeyPathTest::context): (WebKit): (WebKit::TEST_F): 2012-11-08 Keishi Hattori Add properties for week/month picker in DateTimeChooserImpl::writeDocument https://bugs.webkit.org/show_bug.cgi?id=101552 Reviewed by Kent Tamura. Changing the arguments for calendar picker to support week/month picker. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): 2012-11-08 Dimitri Glazkov Unreviewed, rolling out r133429. http://trac.webkit.org/changeset/133429 https://bugs.webkit.org/show_bug.cgi?id=101173 Speculative roll out, investigating perf regression. * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): 2012-11-08 Yury Semikhatsky Web Inspector: move front-end methods called from native part to InspectorFrontendAPI https://bugs.webkit.org/show_bug.cgi?id=101463 Reviewed by Vsevolod Vlasov. Moved Web Inspector methods called from native code to InspectorFrontendAPI. Updated WebDevToolsFrontendImpl appropriately. * src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): 2012-11-08 Alec Flett IndexedDB: Rename methods and remove dead code from IDBBackingStore https://bugs.webkit.org/show_bug.cgi?id=101488 Reviewed by Ojan Vafai. Update IDBFakeBackingStore to reflect method changes in IDBBackingStore. * tests/IDBFakeBackingStore.h: 2012-08-20 Taiju Tsuiki Web Inspector: Drop dimmed crumb handling https://bugs.webkit.org/show_bug.cgi?id=94457 Reviewed by Vsevolod Vlasov. * src/js/devTools.css: 2012-11-07 Adam Barth [V8] We should hide the DOMWrapperMaps inside DOMDataStore https://bugs.webkit.org/show_bug.cgi?id=101430 Reviewed by Kentaro Hara. Remove unneeded header includes. * src/WebScriptController.cpp: 2012-11-07 Varun Jain Add new gesture type, LongTap, which is basically the completion of a GestureLongPress https://bugs.webkit.org/show_bug.cgi?id=101385 Reviewed by Adam Barth. Test: Only creating the new enum. No functionality change, hence no tests required. * public/WebInputEvent.h: (WebKit::WebInputEvent::isGestureEventType): * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::handleInputEvent): * src/WebInputEventConversion.cpp: (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): * src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::handleInputEvent): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-11-05 Emil A Eklund Remove LayoutTypes abstraction https://bugs.webkit.org/show_bug.cgi?id=93050 Reviewed by Levi Weintraub. Remove LayoutTypes abstraction and rename FractionalLayout* to Layout* now that all platforms use the FractionalLayout version (albeit with different fractions). No new tests, no change in functionality. * src/LinkHighlight.cpp: 2012-11-07 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-07 Kenneth Rohde Christiansen Remove support for "desktop-width" in the viewport meta tag https://bugs.webkit.org/show_bug.cgi?id=101217 Reviewed by Gyuyoung Kim. Remove some code trying to use the set desktop width (say 980) for sites not using a viewport meta element. Removing this code should have no effect as it ends up being set to desktop width in that case anyway, by the ViewportArguments algorithm. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): 2012-11-06 Dan Beam Enable REQUEST_AUTOCOMPLETE for chromium port https://bugs.webkit.org/show_bug.cgi?id=101376 Reviewed by Adam Barth. This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use HTMLFormElement#requestAutocomplete as the chrome-side work progresses further. * features.gypi: Turned on the *compile* time flag for REQUEST_AUTOCOMPLETE in chromium's webkit port but also added a *run* time flag that functionally enables the behavior. This means the chromium port will compile in support but will require a run time flag to enable. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): Added a method to the public chromium run time features interface to allow chrome to enable/disable this feature. * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableRequestAutocomplete): (WebKit): A setter than can be called from chrome code to change the enable/disable requestAutocomplete and associated events at runtime. (WebKit::WebRuntimeFeatures::isRequestAutocompleteEnabled): A getter that returns whether the requestAutocomplete run time feature is enabled. 2012-11-06 Sheriff Bot Unreviewed, rolling out r133526. http://trac.webkit.org/changeset/133526 https://bugs.webkit.org/show_bug.cgi?id=101388 May have caused 15% memory regression in Chromium (Requested by jsbell|gardener on #webkit). * src/WebScriptController.cpp: 2012-11-06 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-06 Peter Beverloo [Chromium] Enable the JavaScript i18n API for Android https://bugs.webkit.org/show_bug.cgi?id=101357 Reviewed by Adam Barth. Enable the JavaScript i18n API for Chromium on Android. This adds a grand total of 18.7 KiB of data to the content shell apk. * features.gypi: 2012-11-06 Stephen White Unreviewed. Rolled DEPS. * DEPS: 2012-11-05 Adam Barth [V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes https://bugs.webkit.org/show_bug.cgi?id=101110 Reviewed by Kentaro Hara. * src/WebScriptController.cpp: - Remove unneeded include of deleted file. 2012-11-05 Simon Fraser Fix layer borders to cleaning appear and disappear on switching https://bugs.webkit.org/show_bug.cgi?id=101136 Reviewed by Sam Weinig. Remove the GraphicsLayerClient methods showDebugBorders() and showRepaintCounter(). * src/NonCompositedContentHost.cpp: * src/NonCompositedContentHost.h: (NonCompositedContentHost): * src/PageOverlay.cpp: * tests/GraphicsLayerChromiumTest.cpp: * tests/ImageLayerChromiumTest.cpp: 2012-11-05 Bo Liu Expose hit test related methods in public chromium port https://bugs.webkit.org/show_bug.cgi?id=101204 Reviewed by Adam Barth. The methods are needed in implementating hit test related methods in the Android WebView API. The specific methods are: [Web]HitTestResult::urlElement [Web]HitTestResult::absoluteImageURL [Web]HitTestResult::absoluteLinkURL [Web]HitTestResult::isContentEditable WebViewImpl::hitTestResultAt * public/WebHitTestResult.h: (WebKit): (WebHitTestResult): * public/WebView.h: (WebKit): (WebView): * src/WebHitTestResult.cpp: (WebKit::WebHitTestResult::urlElement): (WebKit): (WebKit::WebHitTestResult::absoluteImageURL): (WebKit::WebHitTestResult::absoluteLinkURL): (WebKit::WebHitTestResult::isContentEditable): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::hitTestResultAt): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-11-05 Alok Priyadarshi [chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents https://bugs.webkit.org/show_bug.cgi?id=99083 Reviewed by Stephen White. Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::paintContents): * src/LinkHighlight.h: (LinkHighlight): * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): (WebKit::NonCompositedContentHost::setOpaque): (WebKit::NonCompositedContentHost::paintContents): * src/NonCompositedContentHost.h: (NonCompositedContentHost): * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: (WebCore::TEST_F): 2012-11-05 Alok Priyadarshi Unreviewed. Rolled DEPS. * DEPS: 2012-11-05 Miguel Garcia [Chromium] Disable registerProtocolHandler on Android https://bugs.webkit.org/show_bug.cgi?id=101199 Reviewed by Julien Chaffraix. Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't actually wired up internally. Disable the feature to avoid breaking feature detection until we can implement it properly. * features.gypi: 2012-11-04 MORITA Hajime Shadow DOM should be able to be disabled per context. https://bugs.webkit.org/show_bug.cgi?id=101173 Reviewed by Dimitri Glazkov. * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): 2012-11-03 Dan Beam Implement HTMLFormElement#requestAutocomplete and associated events https://bugs.webkit.org/show_bug.cgi?id=100557 Reviewed by Adam Barth. Implements an initial version of the proposal for interactive autocomplete outlined in this email: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously after a small delay to behave consistently in all situations and implementations. Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled. Test: fast/forms/form-request-autocomplete.html * public/WebAutofillClient.h: (WebKit): (WebAutofillClient): (WebKit::WebAutofillClient::didRequestAutocomplete): Added WebAutofillClient::didRequestAutocomplete to chrome's public WebKit interface. * public/WebFormElement.h: Added an enum that matches HTMLFormElement::AutocompleteResult (and added compile time assert) and a public method (WebFormElement::finishRequestAutocomplete) to WebFormElement's public interface. * src/AssertMatchingEnums.cpp: Added a compile time assert to guarantee the HTMLFormElement::AutocompleteResult enum matches the WebFormElement::AutocompleteResult enum. * src/FrameLoaderClientImpl.cpp: (WebKit): (WebKit::FrameLoaderClientImpl::didRequestAutocomplete): Implemented the added FrameLoaderClient::didRequestAutocomplete, which simply passes through to the WebAutofillClient. * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): Implementing FrameLoaderClient::didRequestAutocomplete. * src/WebFormElement.cpp: (WebKit::WebFormElement::finishRequestAutocomplete): (WebKit): Added WebFormElement::finishRequestAutocomplete to allow chromium's renderer a public API to call to finish the autocomplete request on a WebFormElement. 2012-11-02 Anders Carlsson Add a PluginInactive plug-in unavailability reason https://bugs.webkit.org/show_bug.cgi?id=101089 Reviewed by Sam Weinig. * src/LocalizedStrings.cpp: (WebCore::inactivePluginText): (WebCore): 2012-11-02 Ian Vollick Support invalidation tracking for composited layers https://bugs.webkit.org/show_bug.cgi?id=97801 Reviewed by Simon Fraser. GraphicsLayers now store invalidated rects and can include them in the layer tree dump. (WebKit::WebWidget::isTrackingRepaints): Used by the NonCompositedContentHost to determine if we are tracking repaint rects. (WebKit::WebWidget::isTrackingRepaints): * src/LinkHighlight.cpp: (WebKit::LinkHighlight::updateGeometry): Now calls GraphicsLayer::addRepaintRect when invalidated. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::isTrackingRepaints): Required as this is a GraphicsLayerClient. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::isTrackingRepaints): Implementation of WebWidget::isTrackingRepaints. 2012-11-02 Stephen White Unreviewed. Rolled DEPS. * DEPS: 2012-11-02 Kent Tamura Optimize DateTimeFormat::quoteAndAppendLiteral output https://bugs.webkit.org/show_bug.cgi?id=101040 Reviewed by Kentaro Hara. * tests/LocaleWinTest.cpp: (TEST_F): Update test results. 2012-11-01 Kent Tamura Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags https://bugs.webkit.org/show_bug.cgi?id=101007 Reviewed by Kentaro Hara. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::openDateTimeChooser): Follow the ChromeClient::openDateTimeChooser flag change. Also, add an empty implemenatation for Android. * src/ChromeClientImpl.h: Follow the ChromeClient::openDateTimeChooser flag change. * src/DateTimeChooserImpl.cpp: Wrapped with ENABLE(INPUT_MULTIPLE_FIELDS_UI). This class is not used in Android. * src/DateTimeChooserImpl.h: Ditto. * src/LocalizedStrings.cpp: Follow the LocalizedString.h change. 2012-11-01 Alec Flett IndexedDB: add methods to support id-based backend APIs https://bugs.webkit.org/show_bug.cgi?id=100425 Reviewed by Tony Chang. Chromium Proxy and WebIDB* support for new int64_t-based methods. * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::deleteObjectStore): (WebKit::WebIDBDatabase::transaction): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::setIndexKeys): (WebKit::WebIDBObjectStore::setIndexesReady): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::deleteIndex): * public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore): * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit): (WebKit::IDBDatabaseBackendProxy::transaction): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::put): (WebKit): (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::objectStore): * src/IDBTransactionBackendProxy.h: (IDBTransactionBackendProxy): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): * src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore): (WebKit): * src/WebIDBTransactionImpl.h: * tests/IDBDatabaseBackendTest.cpp: 2012-11-01 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-01 Pavel Feldman Web Inspector: expose Inspector.detached event factory to the embedder. https://bugs.webkit.org/show_bug.cgi?id=100967 Reviewed by Vsevolod Vlasov. That way embedder will be able to send messages on behalf of the backend being destructed. * public/WebDevToolsAgent.h: (WebDevToolsAgent): * src/WebDevToolsAgentImpl.cpp: (SerializingFrontendChannel): (WebKit::SerializingFrontendChannel::sendMessageToFrontend): (WebKit::WebDevToolsAgent::inspectorDetachedEvent): (WebKit): (WebKit::WebDevToolsAgent::workerDisconnectedFromWorkerEvent): (WebKit::WebDevToolsAgent::disconnectEventAsText): 2012-11-01 Vsevolod Vlasov [Chromium] debug builds: Use after free under ~PageOverlay() https://bugs.webkit.org/show_bug.cgi?id=100930 Reviewed by Pavel Feldman. Changed members order in PageOverlay so that GraphicsLayer is destroyed before GraphicsLayerClient. * src/PageOverlay.h: (PageOverlay): 2012-11-01 James Robinson [chromium] Avoid attempting to defer commits when they are already deferred https://bugs.webkit.org/show_bug.cgi?id=100913 Reviewed by Adrienne Walker. In threaded compositing mode, it's possible to load and unload FrameViews without any intervening invalidations. In this case, we enter setIsAcceleratedCompositingActive with commits already deferred. There's no need to defer again and doing so trips an assertion in the implementation. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): 2012-11-01 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-11-01 Yury Semikhatsky Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase https://bugs.webkit.org/show_bug.cgi?id=100497 Reviewed by Alexander Pavlov. Updated MemoryInstrumentationTest.ImageObserver so that it doesn't fail when instrumentation of objects referenced by CachedImage changes. * tests/MemoryInstrumentationTest.cpp: 2012-11-01 Kent Tamura Remove unused Locale::parseDateTime https://bugs.webkit.org/show_bug.cgi?id=100910 Reviewed by Kentaro Hara. * tests/LocaleMacTest.cpp: Remove tests for parseDateTime. * tests/LocaleWinTest.cpp: Ditto. 2012-10-31 Keishi Hattori [Chromium] Page popup shows up at wrong locations when root view is scrolled https://bugs.webkit.org/show_bug.cgi?id=100830 Reviewed by Kent Tamura. We need to account for the scroll position when calculating the root view rectangle in the screen. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): 2012-10-31 Stephen White Unreviewed, rolling out r133122. http://trac.webkit.org/changeset/133122 https://bugs.webkit.org/show_bug.cgi?id=99083 Broke Chromium Win, Android, ChromeOS builds * src/LinkHighlight.cpp: (WebKit::LinkHighlight::paintContents): * src/LinkHighlight.h: (LinkHighlight): * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): (WebKit::NonCompositedContentHost::setOpaque): (WebKit::NonCompositedContentHost::paintContents): * src/NonCompositedContentHost.h: (NonCompositedContentHost): * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: (WebCore::TEST_F): 2012-10-31 Alok Priyadarshi [chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents https://bugs.webkit.org/show_bug.cgi?id=99083 Reviewed by James Robinson. Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::paintContents): * src/LinkHighlight.h: (LinkHighlight): * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): (WebKit::NonCompositedContentHost::setOpaque): (WebKit::NonCompositedContentHost::paintContents): * src/NonCompositedContentHost.h: (NonCompositedContentHost): * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: (WebCore::TEST_F): 2012-10-31 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-31 Stephen White Unreviewed, rolling out r133107. http://trac.webkit.org/changeset/133107 https://bugs.webkit.org/show_bug.cgi?id=100425 Broke compile on Chromium Win * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::index): * public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore): * src/IDBDatabaseBackendProxy.cpp: * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/IDBTransactionBackendProxy.cpp: * src/IDBTransactionBackendProxy.h: (IDBTransactionBackendProxy): * src/WebIDBCallbacksImpl.cpp: * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): * src/WebIDBTransactionImpl.cpp: * src/WebIDBTransactionImpl.h: * tests/IDBDatabaseBackendTest.cpp: 2012-10-31 Alec Flett IndexedDB: add methods to support id-based backend APIs https://bugs.webkit.org/show_bug.cgi?id=100425 Reviewed by Tony Chang. Chromium Proxy and WebIDB* support for new int64_t-based methods. * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::deleteObjectStore): (WebKit::WebIDBDatabase::transaction): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::setIndexKeys): (WebKit::WebIDBObjectStore::setIndexesReady): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::deleteIndex): * public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore): * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit): (WebKit::IDBDatabaseBackendProxy::transaction): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::put): (WebKit): (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::objectStore): * src/IDBTransactionBackendProxy.h: (IDBTransactionBackendProxy): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): * src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore): (WebKit): * src/WebIDBTransactionImpl.h: * tests/IDBDatabaseBackendTest.cpp: 2012-10-31 Tien-Ren Chen Apply transformation for highlights on non-composited contents https://bugs.webkit.org/show_bug.cgi?id=100438 Reviewed by Adam Barth. Non-composited content host layer "steals" the contents on the RenderView layer, including the highlight layer. The transformation for regular contents are applied by the paint function of the non-composited content host however the highlight uses its own WebLayer. Need to apply the same transformation to the highlight layer as well. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::computeEnclosingCompositingLayer): * src/LinkHighlight.h: (LinkHighlight): 2012-10-31 Mike West Prefer document->addConsoleMessage to document->domWindow->console->addMessage. https://bugs.webkit.org/show_bug.cgi?id=100850 Reviewed by Adam Barth. For historical reasons, a few places in WebCore talk to Console directly via 'document()->domWindow()->console()->addMessage(...)'. This is more safely wrapped by calling 'addConsoleMessage' on the Document itself. No visible functionality should change; we'll simply avoid potential null dereferences in the future. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMessageToConsole): 2012-10-31 Kent Tamura Remove code to hide/reshow text caret for PagePopups https://bugs.webkit.org/show_bug.cgi?id=100834 Reviewed by Hajime Morita. All of form controls supporting PagePopups don't have a text caret. We don't need to hide a text caret on opening a PagePopup, and don't need to reshow it on closing the PagePopup. We had this code because an old UI of input[type=date] had a text caret. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::openPagePopup): (WebKit::WebViewImpl::closePagePopup): 2012-10-31 Mike West Script run from an isolated world should bypass a page's CSP. https://bugs.webkit.org/show_bug.cgi?id=97398 Reviewed by Adam Barth. * public/WebFrame.h: (WebFrame): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin): (WebKit): (WebKit::WebFrameImpl::setIsolatedWorldContentSecurityPolicy): * src/WebFrameImpl.h: (WebFrameImpl): Piping a Content Security Policy through WebFrame, in the same way we're currently doing for SecurityOrigin. As a drive-by, this also uses the static method on DOMWrapperWindow to set the security origin, rather than routing through the frame's ScriptController. 2012-10-30 W. James MacLean [chromium] Transform mouse/gesture event coordinates to account for pinch-zoom in compositor. https://bugs.webkit.org/show_bug.cgi?id=100542 Reviewed by James Robinson. Pinch-zoom in the compositor applies a transformation that WebCore does not know about. We need to adjust mouse and gesture event coordinates to account for this in order that hit testing work properly for these types while zoomed. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent): Modified to adjoint event coordinates to account for zoom. 2012-10-30 W. James MacLean [chromium] Restrict link highlights to targets that display a hand-cursor https://bugs.webkit.org/show_bug.cgi?id=99862 Reviewed by James Robinson. To avoid applying highlights to inappropriate targets, such as large divs with click handlers installed, test candidate targets and only highlight them if they would normally display a hand cursor on mouse over. This is a heuristic, but has been tested and found effective in practice. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebKit::invokesHandCursor): (WebKit::WebViewImpl::bestTouchLinkNode): (WebKit::WebViewImpl::enableTouchHighlight): * src/WebViewImpl.h: (WebViewImpl): * tests/LinkHighlightTest.cpp: (WebCore::TEST): * tests/data/test_touch_link_highlight.html: 2012-10-30 Alok Priyadarshi Unreviewed. Rolled DEPS. * DEPS: 2012-10-30 Dan Carney Remove ensureAuxiliaryContext https://bugs.webkit.org/show_bug.cgi?id=99975 Reviewed by Adam Barth. Updated tests to use correct v8 context. * tests/IDBBindingUtilitiesTest.cpp: (WebKit::checkKeyFromValueAndKeyPathInternal): (WebKit::checkKeyPathNullValue): (WebKit::injectKey): (WebKit::checkInjection): (WebKit::checkInjectionFails): (WebKit::checkKeyPathStringValue): (WebKit::checkKeyPathNumberValue): (WebKit::scriptExecutionContext): (WebKit): (WebKit::TEST): 2012-10-30 Kent Tamura Remove unused code for old input[type=date] UI https://bugs.webkit.org/show_bug.cgi?id=100734 Reviewed by Hajime Morita. * src/LocalizedStrings.cpp: Follow the LocalizedStrings.h change. * tests/LocaleMacTest.cpp: (LocaleMacTest): Remove tests for Locale::dateFormatText. * tests/LocaleWinTest.cpp: (LocaleWinTest): Ditto. 2012-10-30 Kent Tamura Fix crash by calendar picker or suggestion picker https://bugs.webkit.org/show_bug.cgi?id=100728 Reviewed by Hajime Morita. * src/DateTimeChooserImpl.h: (DateTimeChooserImpl): Add a factory function, and made the constructor private. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::create): Added. (WebKit::DateTimeChooserImpl::setValueAndClosePopup): Protect this because JavaScript code might run during didChooseValue. * src/ChromeClientImpl.h: (ChromeClientImpl): Follow the ChromeClient change. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::openDateTimeChooser): Use DateTimeChooserImpl::create. 2012-10-29 James Robinson [chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it https://bugs.webkit.org/show_bug.cgi?id=100716 Reviewed by Dirk Pranke. This check was accidentally removed in r132862 and the value is null in at least some unit tests. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::invalidateRect): 2012-10-29 Vincent Scheib Unreviewed, rolling out r132845. http://trac.webkit.org/changeset/132845 https://bugs.webkit.org/show_bug.cgi?id=99975 Broke chromium builds, linker errors from IDBBindingUtilitiesTest * tests/IDBBindingUtilitiesTest.cpp: (WebCore::TEST): 2012-10-29 James Robinson [chromium] Defer commits between page unload and first invalidation in threaded compositing mode https://bugs.webkit.org/show_bug.cgi?id=100702 Reviewed by Adrienne Walker. In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving the first invalidation for the new page since the document is likely not loaded enough to paint usefully. This defers commits from the time compositing is deactivated (which in force compositing mode only happens at FrameView destruction) until we get the first invalidation from WebCore. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::invalidateContentsAndRootView): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::invalidateRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-10-29 Stephen White Unreviewed. Rolled DEPS. * DEPS: 2012-10-29 Dan Carney Remove ensureAuxiliaryContext https://bugs.webkit.org/show_bug.cgi?id=99975 Reviewed by Adam Barth. Updated tests to use correct v8 context. * tests/IDBBindingUtilitiesTest.cpp: (WebKit::checkKeyFromValueAndKeyPathInternal): (WebKit::checkKeyPathNullValue): (WebKit::injectKey): (WebKit::checkInjection): (WebKit::checkInjectionFails): (WebKit::checkKeyPathStringValue): (WebKit::checkKeyPathNumberValue): (WebKit::scriptExecutionContext): (WebKit): (WebKit::TEST): 2012-10-29 Patrick Dubroy Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac. https://bugs.webkit.org/show_bug.cgi?id=100683 Reviewed by Pavel Feldman. When in compact mode, style the Web Inspector toolbar using the same colors & gradients as the Chromium toolbar (Chromium port only). * src/js/devTools.css: (body.compact.platform-mac #toolbar): (body.compact.platform-mac.inactive #toolbar): (body.platform-mac.inactive #toolbar .toolbar-label): 2012-10-29 Eugene Klyuchnikov Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers https://bugs.webkit.org/show_bug.cgi?id=100530 Reviewed by Yury Semikhatsky. Motivation: cpu-monitoring feature looks like a glitch, when it is not supported by browser. * src/InspectorClientImpl.cpp: Implemented capability getter. * src/InspectorClientImpl.h: 2012-10-29 Kent Tamura [Chromium] Merge LocalizedNumberICUTest into LocaleICUTest https://bugs.webkit.org/show_bug.cgi?id=100648 Reviewed by Kentaro Hara. LocalizedNumberICU was removed some months ago, and its features were merged to LocaleICU. We merge the test too. * WebKit.gypi: Remove LocalizedNumberICUTest.cpp * tests/LocaleICUTest.cpp: Move a #if because some headers are used unconditionally. (testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp. (TEST_F): Ditto. (testNumberIsReversible): Ditto. (testNumbers): Ditto. * tests/LocalizedNumberICUTest.cpp: Removed. 2012-10-29 Kent Tamura [Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp https://bugs.webkit.org/show_bug.cgi?id=100643 Reviewed by Kentaro Hara. LocalizedDateICU was removed some months ago, and LocalizedDateICUTest actually had tests for LocaleICU. * WebKit.gypi: * tests/LocaleICUTest.cpp: - Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp. - Rename LocalizedDateICUTest class to LocaleICUTest. 2012-10-29 Kent Tamura [Chromium-linux] Fix build. * tests/LocalizedNumberICUTest.cpp: (testNumberIsReversible): Rename an argument. (testDecimalSeparator): Ditto. 2012-10-28 Kent Tamura Rename Localizer to Locale https://bugs.webkit.org/show_bug.cgi?id=100634 Reviewed by Kentaro Hara. * src/ColorChooserUIController.h: (ColorChooserUIController): Rename m_localizer to m_locale, and follow other renamings. * src/ColorChooserUIController.cpp: (WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings. (WebKit::ColorChooserUIController::locale): Ditto. * src/DateTimeChooserImpl.h: (DateTimeChooserImpl): Rename m_localizer to m_locale, and follow other renamings. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings. (WebKit::DateTimeChooserImpl::writeDocument): Ditto. (WebKit::DateTimeChooserImpl::locale): Ditto. * tests/LocaleMacTest.cpp: (LocaleMacTest::formatTime): Ditto. (testNumberIsReversible): Ditto. * tests/LocalizedNumberICUTest.cpp: (testNumberIsReversible): Ditto. (testDecimalSeparator): Ditto. 2012-10-29 Kent Tamura Unreviewed. Rolled DEPS. * DEPS: 2012-10-28 Kent Tamura Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h} https://bugs.webkit.org/show_bug.cgi?id=100627 Reviewed by Yuta Kitamura. * src/ColorChooserUIController.h: Follow the file name renaming. * src/DateTimeChooserImpl.cpp: Ditto. 2012-10-27 Adam Barth [Chromium] Find-in-page reports matches in hidden iframes https://bugs.webkit.org/show_bug.cgi?id=100604 Reviewed by Eric Seidel. This is actually a regression caused by http://trac.webkit.org/changeset/128784. This patch adds back some code removed in WebFrameImpl::shouldScopeMatches in r128784. This patch also introduces a test so that we don't make this mistake again. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches): * tests/WebFrameTest.cpp: * tests/data/find_in_hidden_frame.html: Added. 2012-10-26 Kent Tamura [Chromium] Convert Chromium template string to an LDML date format https://bugs.webkit.org/show_bug.cgi?id=100128 Reviewed by Tony Chang. * src/LocalizedStrings.cpp: (WebCore): Include WebCore/platform/text/DateTimeFormat.h. (WebCore::weekFormatInLDML): Replace $1 with yyyy, $2 with ww, and quote other parts. 2012-10-26 James Robinson [chromium] Allow embedder to enter/leave force compositing mode https://bugs.webkit.org/show_bug.cgi?id=100458 Reviewed by Adrienne Walker. This adds API for the embedder to decide when to enter and leave force compositing mode since it's more efficient to only toggle this setting when the embedder is about to produce a frame. * public/WebWidget.h: (WebWidget): (WebKit::WebWidget::enterForceCompositingMode): * src/WebFrameImpl.cpp: (WebKit::WebViewImpl::enterForceCompositingMode): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 2012-10-26 Dominic Mazzoni AX: Notification should be sent when accessibilityIsIgnored changes https://bugs.webkit.org/show_bug.cgi?id=99547 Reviewed by Chris Fleizach. Adds new accessibility notifications. * public/WebAccessibilityNotification.h: * src/AssertMatchingEnums.cpp: 2012-10-26 Thiago Marcos P. Santos Add feature flags for CSS Device Adaptation https://bugs.webkit.org/show_bug.cgi?id=95960 Reviewed by Kenneth Rohde Christiansen. * features.gypi: 2012-10-26 Kent Tamura Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android https://bugs.webkit.org/show_bug.cgi?id=100457 Reviewed by Kentaro Hara. It was enabled accidentally. Week input is not implemented in Android. * features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block, add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add ENABLE_INPUT_TYPE_WEEK=1 in non-Android block. 2012-10-26 Kent Tamura [Chromium-Win] Support shortTimeFormat https://bugs.webkit.org/show_bug.cgi?id=100471 Reviewed by Kentaro Hara. * tests/LocaleWinTest.cpp: (TEST_F): Update test expectations for the behavior change. 2012-10-25 Sheriff Bot Unreviewed, rolling out r132514. http://trac.webkit.org/changeset/132514 https://bugs.webkit.org/show_bug.cgi?id=100440 "Broke chromium content_browsertests AccessibilityAriaMenu AccessibilityInputRange AccessibilityListMarkers" (Requested by scheib on #webkit). * public/WebAccessibilityNotification.h: * src/AssertMatchingEnums.cpp: 2012-10-25 James Robinson [chromium] Regression: navigating between composited pages doesn't cause redraw until scrolled https://bugs.webkit.org/show_bug.cgi?id=100396 Reviewed by Adrienne Walker. This partially reverts r132173. It's not valid to suppress invalidations in commitDocumentData since for small or cached pages this could load up the whole document. Also adds and improves some of the tracing. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData): (WebKit::WebFrameImpl::createFrameView): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::scheduleComposite): 2012-10-25 Sami Kyostila Composited/HW content have the red and blue channels inverted in DRT on Chromium Android https://bugs.webkit.org/show_bug.cgi?id=98647 Reviewed by James Robinson. WebLayerTreeView::compositeAndReadback() always gives back data in BGRA ordering (i.e., the first byte in memory is blue). This matches Skia's SkBitmap::kARGB_8888_Config ordering on all platforms except Android, where Skia's native format is RGBA (i.e., red comes first in memory). This mismatch causes layout test pixel comparison failures. This patch fixes the problem by reordering the channels right after readback. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): 2012-10-25 Dominic Mazzoni AX: Notification should be sent when accessibilityIsIgnored changes https://bugs.webkit.org/show_bug.cgi?id=99547 Reviewed by Chris Fleizach. Adds new accessibility notifications. * public/WebAccessibilityNotification.h: * src/AssertMatchingEnums.cpp: 2012-10-25 Dominik Röttsches Conditionalize XHR timeout support https://bugs.webkit.org/show_bug.cgi?id=100356 Reviewed by Adam Barth. Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support. Defaults to off on chromium until webkit.org/b/98397 is solved. * features.gypi: 2012-10-25 Ben Wagner Remove SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX define from skia_webkit.gyp, as it has been rebaselined. https://bugs.webkit.org/show_bug.cgi?id=100394 Reviewed by Dirk Pranke. The define has been removed from the Skia code and the Chromium skia.gyp. The pixel tests affected have already been rebaselined. * skia_webkit.gyp: 2012-10-22 Mikhail Naganov [Chromium] Add supportMultipleWindows setting, needed for Android https://bugs.webkit.org/show_bug.cgi?id=99716 Reviewed by Adam Barth. Add supportMultipleWindows settings for reusing the same view when opening popups. This is required for emulating the behavior of Android WebView. Adding into WebCore, as other ports might want to use this setting in the future. * public/WebSettings.h: * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchCreatePage): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setSupportsMultipleWindows): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-10-24 Mihai Parparita [Chromium] Allow pushState and related history APIs to be disabled per context https://bugs.webkit.org/show_bug.cgi?id=99780 Reviewed by Adam Barth. Add pushState context feature. * public/WebPermissionClient.h: (WebPermissionClient): (WebKit::WebPermissionClient::allowPushState): * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): 2012-10-24 Mark Pilgrim [Chromium] Remove screen-related functions from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=97474 Reviewed by Adam Barth. Screen-related functions like screenHorizontalDPI that used to be on PlatformSupport are now accessed through a new PlatformPageClient attached to Widget in WebCore-land, which is implemented by ChromeClientImpl in WebKit-land, which proxies calls to WebWidgetClient, which is actually implemented in Chromium-land. * public/WebScreenInfo.h: * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::screenInfo): (WebKit): * src/ChromeClientImpl.h: (WebKit): (WebKit::ChromeClientImpl::platformPageClient): (ChromeClientImpl): * src/PlatformSupport.cpp: (WebCore): * src/WebPagePopupImpl.cpp: 2012-10-24 Sailesh Agrawal Incorrect keycodes for numpad /, -, +, . https://bugs.webkit.org/show_bug.cgi?id=99188 Reviewed by Tony Chang. In r57951 we switched to mapping keys by character code. This regressed the numpad keys which no longer match the Windows virtual key codes. This CL fixes this by never mapping numpad keys by character code. * src/mac/WebInputEventFactory.mm: Disallow mapping numpad keys by character code. (WebKit::windowsKeyCodeForKeyEvent): * tests/WebInputEventFactoryTestMac.mm: Test to verify that all numpad keys are correctly mapped. (TEST): 2012-10-24 Terry Anderson Handle two-finger tap gestures in the same way as long-press gestures https://bugs.webkit.org/show_bug.cgi?id=99947 Reviewed by Adam Barth. Set the area of a two-finger tap gesture to be the area of the enclosing rectangle for the first finger down. * src/WebInputEventConversion.cpp: (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): 2012-10-24 Eric Uhrhane https://bugs.webkit.org/show_bug.cgi?id=99202 [Chromium] shift-click fails to spawn new window with target=_blank Reviewed by Adam Barth No new tests in WebKit-land--see https://codereview.chromium.org/11235048/ for tests that I'll submit once this lands. * src/ChromeClientImpl.cpp: Change currentEventShouldCauseBackgroundTab to updatePolicyForEvent; we were looking up the right policy, then throwing it away if it wasn't forcing a background tab. (WebKit::ChromeClientImpl::updatePolicyForEvent): (WebKit::ChromeClientImpl::getNavigationPolicy): 2012-10-24 Ben Wagner Create skia_webkit.gyp to improve rebaselining. https://bugs.webkit.org/show_bug.cgi?id=99759 Reviewed by Dirk Pranke. This allows for code suppressions to be lifted atomically with new baselines. * skia_webkit.gyp: Added. 2012-09-27 Yury Semikhatsky Web Inspector: provide memory instrumentation for ListHashSet https://bugs.webkit.org/show_bug.cgi?id=97786 Reviewed by Vsevolod Vlasov. Added a test for ListHashSet memory instrumentation. * tests/MemoryInstrumentationTest.cpp: (WebCore::TEST): (WebCore): 2012-10-24 Noel Gordon [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings https://bugs.webkit.org/show_bug.cgi?id=100197 Reviewed by Kent Tamura. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShouldRespectImageOrientation): set the WebCore page setting for shouldRespectImageOrientation. (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): 2012-10-23 Varun Jain Context menu generated from touch gestures on textareas has context of the cursor position instead of the position where the event occurs. https://bugs.webkit.org/show_bug.cgi?id=99520 Reviewed by Kenneth Rohde Christiansen. Send a synthetic mouse down event for context menu-summoning-gesture events so that textareas can correctly set cursors before receiving the context menu event. Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-10-23 Alec Flett IndexedDB: refactor backend to use IDB*Metadata https://bugs.webkit.org/show_bug.cgi?id=100055 Reviewed by Tony Chang. Update tests to reflect refactoring. * tests/IDBDatabaseBackendTest.cpp: * tests/IDBFakeBackingStore.h: 2012-10-23 Stephen White [chromium] Roll chromium DEPS r163297:163557 https://bugs.webkit.org/show_bug.cgi?id=100146 Reviewed by Adrienne Walker. 2012-10-23 Kenneth Rohde Christiansen Add support for resolution media query https://bugs.webkit.org/show_bug.cgi?id=99077 Reviewed by Antti Koivisto. Add support for the RESOLUTION_MEDIA_QUERY feature flag. * features.gypi: 2012-10-23 Kent Tamura Support full month names in DateTimeEditElement, and use them in input[type=month] by default https://bugs.webkit.org/show_bug.cgi?id=100060 Reviewed by Kentaro Hara. * tests/LocaleMacTest.cpp: (TEST_F): Follow LocaleMac::monthFormat change. * tests/LocalizedDateICUTest.cpp: (TEST_F): Follow LocaleICU::monthFormat change. 2012-10-23 Dan Carney When blocking localStorage, Firefox throws a security exception on access, and maybe so should we https://bugs.webkit.org/show_bug.cgi?id=63257 Reviewed by Jochen Eisinger. Add security check and security check cache. * src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains): (WebCore::StorageAreaProxy::canAccessStorage): * src/StorageAreaProxy.h: (StorageAreaProxy): (WebCore::StorageAreaProxy::canAccessStorage): 2012-10-22 James Robinson [chromium] Suppress compositor invalidations during FrameView recreation in force-compositing-mode https://bugs.webkit.org/show_bug.cgi?id=99882 Reviewed by Adrienne Walker. In force compositing mode, page navigation temporarily takes us in and out of compositing mode because the root GraphicsLayer is owned by the FrameView which is destroyed and recreated. These changes generate invalidations on the WebViewClient that trigger frames but aren't actually terribly useful. WebCore suppresses repaints too early during page load to avoid flashing white or mostly white and to avoid impacting page load time. This suppresses compositor invalidations during FrameView recreation. Covered by chromium's page cycler performance tests. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData): (WebKit::WebFrameImpl::createFrameView): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::suppressInvalidations): (WebKit): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::scheduleComposite): * src/WebViewImpl.h: (WebViewImpl): 2012-10-22 Kent Tamura Introduce Localizer::standAloneMonthLabels https://bugs.webkit.org/show_bug.cgi?id=99963 Reviewed by Kentaro Hara. Note that we don't add tests to LocaleWinTest because new function LocaleWin::standAloneMonthLabels is equivalent to monthLabels. * tests/LocaleMacTest.cpp: (LocaleMacTest::standAloneMonthLabel): Added a helper function. (TEST_F): Add some tests. We don't test ru_ru locale because it has different data on OSX versions. * tests/LocalizedDateICUTest.cpp: (LocalizedDateICUTest::standAloneMonthLabel): Added a helper function. (TEST_F): Add some tests. 2012-10-22 Sheriff Bot Unreviewed, rolling out r132119. http://trac.webkit.org/changeset/132119 https://bugs.webkit.org/show_bug.cgi?id=100019 Fails its own test on Mac platforms. (Requested by leviw on #webkit). * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-10-22 Varun Jain Context menu generated from touch gestures on textareas has context of the cursor position instead of the position where the event occurs. https://bugs.webkit.org/show_bug.cgi?id=99520 Reviewed by Kenneth Rohde Christiansen. Send a synthetic mouse down event for context menu-summoning-gesture events so that textareas can correctly set cursors before receiving the context menu event. Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-10-22 Adam Barth [Chromium] Roll Chromium DEPS to get new version of V8 https://bugs.webkit.org/show_bug.cgi?id=100015 Unreviewed. * DEPS: - Bigger is better. 2012-10-22 Keishi Hattori Remove monthFormatInLDML https://bugs.webkit.org/show_bug.cgi?id=99971 Reviewed by Kent Tamura. * src/LocalizedStrings.cpp: 2012-10-22 Keishi Hattori [Chromium] Rename WeekFormatInLDML to WeekFormatTemplate https://bugs.webkit.org/show_bug.cgi?id=99972 Reviewed by Kent Tamura. * src/LocalizedStrings.cpp: (WebCore::weekFormatInLDML): 2012-10-22 Jocelyn Turcotte [Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page https://bugs.webkit.org/show_bug.cgi?id=98514 Reviewed by Kenneth Rohde Christiansen. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFrameView): 2012-10-22 Pavel Feldman Web Inspector: merge "docked" state into the "dock side" enum. https://bugs.webkit.org/show_bug.cgi?id=99717 Reviewed by Vsevolod Vlasov. Otherwise, it is hard to manage these inter-dependent flags. * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::requestSetDockSide): * src/InspectorFrontendClientImpl.h: (InspectorFrontendClientImpl): 2012-10-21 Kent Tamura Page popup: Fix crash by events after closing https://bugs.webkit.org/show_bug.cgi?id=99951 Reviewed by Hajime Morita. - We should not handle events after closePopup call. - We should uninstall a DOMWindowPagePopup supplement in closePopup. * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::WebPagePopupImpl): Initialize m_closing. (WebKit::WebPagePopupImpl::handleGestureEvent): Don't handle events if m_closing. (WebKit::WebPagePopupImpl::handleInputEvent): Ditto. (WebKit::WebPagePopupImpl::handleKeyEvent): Ditto. (WebKit::WebPagePopupImpl::closePopup): - Uninstall a DOMWindowPagePopup supplement. - Set m_closing. * src/WebPagePopupImpl.h: (WebPagePopupImpl): Declare m_closing. 2012-10-21 Terry Anderson [chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap https://bugs.webkit.org/show_bug.cgi?id=99763 Reviewed by Adam Barth. Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth| and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a two-finger tap gesture. Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the first touch point. * public/WebInputEvent.h: 2012-10-19 Yusuf Ozuysal [chromium] Double-tap defaults to zoom (should only do this on Android) https://bugs.webkit.org/show_bug.cgi?id=99600 Reviewed by Adam Barth. Adds a web setting for enabling DoubleTapToZoom on a doubleTap gesture. This gesture was just needed for mobile, and the patch that implemented it caused regressions on other platforms. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setDoubleTapToZoomEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::doubleTapToZoomEnabled): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): * tests/WebFrameTest.cpp: 2012-10-19 Sheriff Bot Unreviewed, rolling out r131944. http://trac.webkit.org/changeset/131944 https://bugs.webkit.org/show_bug.cgi?id=99891 On second thoughts, not such a great idea (Requested by jamesr on #webkit). * public/WebView.h: (WebKit): (WebView): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): * src/WebViewImpl.h: (WebViewImpl): * tests/GraphicsLayerChromiumTest.cpp: (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): 2012-10-19 Jochen Eisinger [chromium] when building a shared library component build, we must not depend on WebCore Unreviewed build fix. * WebKit.gyp: 2012-10-19 Tony Chang Unreviewed, rolling out r131936. http://trac.webkit.org/changeset/131936 https://bugs.webkit.org/show_bug.cgi?id=99717 Broke the clang build * public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow): (WebKit::WebDevToolsFrontendClient::requestUndockWindow): * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::requestAttachWindow): (WebKit): (WebKit::InspectorFrontendClientImpl::requestDetachWindow): (WebKit::InspectorFrontendClientImpl::requestSetDockSide): * src/InspectorFrontendClientImpl.h: (InspectorFrontendClientImpl): 2012-10-19 Alexandre Elias [chromium] API to pass impl thread via WebLayerTreeView https://bugs.webkit.org/show_bug.cgi?id=99863 Reviewed by James Robinson. This adds an API to pass the compositor impl thread via WebView and WebLayerTreeView. This is currently a no-op change, but in the future this codepath will supercede WebCompositor. The goal is to avoid statics in compositor initialization. * public/WebView.h: (WebKit): (WebView): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setCompositorImplThread): (WebKit): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): * src/WebViewImpl.h: (WebViewImpl): * tests/GraphicsLayerChromiumTest.cpp: (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): 2012-10-19 Pavel Feldman Web Inspector: merge "docked" state into the "dock side" enum. https://bugs.webkit.org/show_bug.cgi?id=99717 Reviewed by Vsevolod Vlasov. * public/WebDevToolsFrontendClient.h: * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::requestSetDockSide): * src/InspectorFrontendClientImpl.h: (InspectorFrontendClientImpl): 2012-09-08 Alpha Lam [chromium] Implement deferred image decoding https://bugs.webkit.org/show_bug.cgi?id=94240 Reviewed by Stephen White. Adding new unit tests for deferred image decoding. These tests are defined in DeferredImageDecoderTest.cpp. They verify image decoding happens only when SkPicture is rasterized for both scaled and non-scaled cases. Tests: DeferredImageDecoderTest.drawIntoSkPicture DeferredImageDecoderTest.drawScaledIntoSkPicture * WebKit.gypi: * public/WebSettings.h: * src/WebKit.cpp: (WebKit::shutdown): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): * tests/DeferredImageDecoderTest.cpp: Added. (WebCore): (DeferredImageDecoderTest): (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::TearDown): (WebCore::TEST_F): * tests/MockImageDecoder.h: Added. (WebCore): (MockImageDecoder): (WebCore::MockImageDecoder::MockImageDecoder): (WebCore::MockImageDecoder::filenameExtension): (WebCore::MockImageDecoder::frameBufferAtIndex): (WebCore::MockImageDecoder::frameBufferRequestCount): 2012-10-19 Alpha Lam [chromium] Roll DEPS Unreviewed DEPS roll. * DEPS: 2012-10-19 Dongwoo Joshua Im Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT https://bugs.webkit.org/show_bug.cgi?id=99804 Reviewed by Julien Chaffraix. CSS3 text related properties will be implemented under this flag, including text decoration, text-align-last, and text-justify. * features.gypi: 2012-10-19 Jochen Eisinger [chromium] fix the fix Unreviewed build fix. Forgot to invert the condition when to set the type to none in the previous attempt. * WebKit.gyp: 2012-10-19 Jochen Eisinger [chromium] Fix inside chromium build on Mac Unreviewed build fix. Xcode won't create a static library without any sources. So instead of ommitting the sources, just override the webkit_test_support's type with 'none'. * WebKit.gyp: 2012-10-17 Ilya Tikhonovsky Web Inspector: NMI provide data for mixing with tcmalloc heap dumps. https://bugs.webkit.org/show_bug.cgi?id=99457 Reviewed by Yury Semikhatsky. Embedder's code wraps the map with counted objects info into InstrumentedObjectSizeProvider and forces downstream code to make tcmalloc heap snapshot. The default implementation is empty. * public/WebDevToolsAgentClient.h: (InstrumentedObjectSizeProvider): (WebKit::WebDevToolsAgentClient::InstrumentedObjectSizeProvider::~InstrumentedObjectSizeProvider): (WebKit::WebDevToolsAgentClient::dumpUncountedAllocatedObjects): (WebDevToolsAgentClient): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::dumpUncountedAllocatedObjects): (WebKit): * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::getAllocatedObjects): (WebKit::WebDevToolsAgentImpl::dumpUncountedAllocatedObjects): (WebKit): * src/WebDevToolsAgentImpl.h: (WebDevToolsAgentImpl): 2012-10-18 Kent Tamura Add shortMonthLabels and shortStandAloneMonthLabels to Localizer https://bugs.webkit.org/show_bug.cgi?id=99787 * tests/LocaleMacTest.cpp: (TEST_F): Disable tests depends on OS X versions. 2012-10-18 Kent Tamura Add shortMonthLabels and shortStandAloneMonthLabels to Localizer https://bugs.webkit.org/show_bug.cgi?id=99787 Reviewed by Kentaro Hara. * tests/LocaleMacTest.cpp: (LocaleMacTest::shortMonthLabel): A helper. (LocaleMacTest::shortStandAloneMonthLabel): Ditto. (TEST_F): Added tests for some locales. * tests/LocaleWinTest.cpp: (LocaleWinTest::shortMonthLabel): A helper. (TEST_F): Added tests for some locales. We don't test LocaleWin::shortStandAloneMonthLabels because it is identical to shortMonthLabels. * tests/LocalizedDateICUTest.cpp: (LocalizedDateICUTest::shortMonthLabel): A helper. (LocalizedDateICUTest::shortStandAloneMonthLabel): Ditto. (TEST_F): Added tests for some locales. 2012-10-18 Jochen Eisinger [chromium] Add a webkit_test_support target that WebTestingSupport https://bugs.webkit.org/show_bug.cgi?id=99772 Reviewed by Adam Barth. Before, embedders would need to compile the WebTestingSupport.cpp themselves, which in turn depends on WebCore headers. * WebKit.gyp: 2012-10-18 W. James MacLean [chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression. https://bugs.webkit.org/show_bug.cgi?id=99632 Reviewed by James Robinson. Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): 2012-10-18 Sheriff Bot Unreviewed, rolling out r131810. http://trac.webkit.org/changeset/131810 https://bugs.webkit.org/show_bug.cgi?id=99762 Broke linux debug webkit_unit_tests (Requested by danakj|gardening on #webkit). * WebKit.gypi: * public/WebSettings.h: * src/WebKit.cpp: (WebKit::shutdown): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): * src/WebSettingsImpl.h: (WebSettingsImpl): * tests/DeferredImageDecoderTest.cpp: Removed. * tests/MockImageDecoder.h: Removed. 2012-10-18 Alpha Lam [chromium] Implement deferred image decoding https://bugs.webkit.org/show_bug.cgi?id=94240 Reviewed by Stephen White. Adding new unit tests for deferred image decoding. These tests are defined in DeferredImageDecoderTest.cpp. They verify image decoding happens only when SkPicture is rasterized for both scaled and non-scaled cases. Tests: DeferredImageDecoderTest.drawIntoSkPicture DeferredImageDecoderTest.drawScaledIntoSkPicture * WebKit.gypi: * public/WebSettings.h: * src/WebKit.cpp: (WebKit::shutdown): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): * tests/DeferredImageDecoderTest.cpp: Added. (WebCore): (DeferredImageDecoderTest): (WebCore::DeferredImageDecoderTest::SetUp): (WebCore::DeferredImageDecoderTest::TearDown): (WebCore::TEST_F): * tests/MockImageDecoder.h: Added. (WebCore): (MockImageDecoder): (WebCore::MockImageDecoder::MockImageDecoder): (WebCore::MockImageDecoder::filenameExtension): (WebCore::MockImageDecoder::frameBufferAtIndex): (WebCore::MockImageDecoder::frameBufferRequestCount): 2012-10-18 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-18 Pablo Flouret Implement css3-conditional's @supports rule https://bugs.webkit.org/show_bug.cgi?id=86146 Reviewed by Antti Koivisto. * features.gypi: Add an ENABLE_CSS3_CONDITIONAL_RULES flag. 2012-10-18 Kent Tamura Add Localizer::monthFormat and implementations https://bugs.webkit.org/show_bug.cgi?id=99704 * tests/LocaleMacTest.cpp: (TEST_F): Remove tests for fr_FR and ru locales for a compatibility reason. 2012-10-18 Kent Tamura Add Localizer::monthFormat and implementations https://bugs.webkit.org/show_bug.cgi?id=99704 Reviewed by Kentaro Hara. * tests/LocaleMacTest.cpp: (LocaleMacTest::monthFormat): A helper function. (TEST_F): Added some tests. * tests/LocaleWinTest.cpp: (LocaleWinTest::monthFormat): A helper function. (TEST_F): Added some tests. * tests/LocalizedDateICUTest.cpp: (LocalizedDateICUTest::monthFormat): A helper function. (TEST_F): Added some tests. 2012-10-17 Mike West Move mixed content logic out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=45638 Reviewed by Eric Seidel. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::checkIfRunInsecureContent): Use the new method location. 2012-10-17 Shashi Shekhar Remove redundant sdk_build parameter. https://bugs.webkit.org/show_bug.cgi?id=99648 Reviewed by Adam Barth. sdk_build parameter is no longer needed. * WebKitUnitTests.gyp: 2012-10-17 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-17 Alec Flett IndexedDB: Explicitly send null/undefined/integers to frontend IDBCallbacks https://bugs.webkit.org/show_bug.cgi?id=99619 Reviewed by Adam Barth. Hook up new undefined/integer-based onSuccess handlers. * src/IDBCallbacksProxy.cpp: (WebKit::IDBCallbacksProxy::onSuccess): (WebKit): * src/IDBCallbacksProxy.h: (IDBCallbacksProxy): * src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onSuccess): (WebKit): * src/WebIDBCallbacksImpl.h: (WebIDBCallbacksImpl): * tests/IDBAbortOnCorruptTest.cpp: * tests/IDBDatabaseBackendTest.cpp: 2012-10-17 Sadrul Habib Chowdhury plugins: Allow a plugin to dictate whether it can receive drag events or not. https://bugs.webkit.org/show_bug.cgi?id=99355 Reviewed by Tony Chang. Introduce WebPlugin::canProcessDrag() and use that to implement PluginViewBase::canProcessDrag. * public/WebPlugin.h: (WebKit::WebPlugin::canProcessDrag): (WebPlugin): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::canProcessDrag): (WebKit): (WebKit::WebPluginContainerImpl::handleMouseEvent): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-10-17 Jian Li [chromium] Remove legacy members from WebDraggableRegion https://bugs.webkit.org/show_bug.cgi?id=99612 Reviewed by Adam Barth. Those legacy members to support old syntax are not longer needed after chromium side changes landed. * public/WebDraggableRegion.h: (WebDraggableRegion): 2012-10-17 Joshua Bell [Chromium] IndexedDB: Delete obsolete public API method https://bugs.webkit.org/show_bug.cgi?id=99603 Reviewed by Dimitri Glazkov. Remove a stub that was necessary while the Chromium side of webkit.org/b/99097 was landing. * public/WebIDBTransactionCallbacks.h: 2012-10-17 Keishi Hattori Localized date should be based on LDML https://bugs.webkit.org/show_bug.cgi?id=99570 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: (TEST_F): Updated expectations. * tests/LocaleWinTest.cpp: (TEST_F): Updated expectations. 2012-10-16 MORITA Hajime [Shadow DOM][V8] WebCore::V8DOMWindow::installPerContextProperties() is slow when shadowDOMEnabled flag is on. https://bugs.webkit.org/show_bug.cgi?id=99428 Reviewed by Adam Barth. * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): 2012-10-16 Alec Flett IndexedDB: Stub out chromium success handlers for integers and undefined values https://bugs.webkit.org/show_bug.cgi?id=99527 Reviewed by Adam Barth. Add onSuccess stubs so that chromium IPC glue can land. * public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess): 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-16 Jian Li Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION https://bugs.webkit.org/show_bug.cgi?id=98975 Reviewed by Adam Barth. Renaming is needed to better match with the draggable region code. * features.gypi: * src/ChromeClientImpl.cpp: (WebKit): * src/ChromeClientImpl.h: (ChromeClientImpl): * src/WebDocument.cpp: (WebKit::WebDocument::draggableRegions): 2012-10-16 Min Qin Fix a bug that we are using scaled damage rect for plugins inside an iframe https://bugs.webkit.org/show_bug.cgi?id=99488 Reviewed by Adam Barth. There is a bug with a previous webkit patch: https://bugs.webkit.org/show_bug.cgi?id=98468 In that patch, we incorrectly applied the main frame's scale factor to inner iframes. However, the damageRect is not scaled inside an iFrame. So doing the intersect will retrieve wrong result here. In WebPluginContainerImpl::calculateGeometry, the windowRect also does not apply main frame's scale factor. * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): 2012-10-16 Xianzhu Wang [Chromium] Android: Need a way to get appropriate font for some specific characters. https://bugs.webkit.org/show_bug.cgi?id=67587 Reviewed by Adam Barth. Define ENABLE_OPENTYPE_VERTICAL=1 on Android. * features.gypi: 2012-10-16 Tommy Widenflycht MediaStream API: Add the chromium API for RTCDataChannel https://bugs.webkit.org/show_bug.cgi?id=99435 Reviewed by Adam Barth. Adding checks for RTCDataChannel. * src/AssertMatchingEnums.cpp: 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-16 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-15 Peter Beverloo [Chromium] Enable FAST_MOBILE_SCROLLING for Android https://bugs.webkit.org/show_bug.cgi?id=99401 Reviewed by Adam Barth. * features.gypi: Add the define to the Android-only section. 2012-10-15 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-15 Peter Beverloo [Chromium] The default target for Android builds should be "all" instead of "All" https://bugs.webkit.org/show_bug.cgi?id=98879 Reviewed by Adam Barth. The default gyp target for Android builds is being overridden in Chromium's envsetup_functions.sh to "All" (whereas the rest of Chromium and WebKit use "all"), because Android wants to use a different list of main targets. There is no need to do this for the WebKit project, and it's breaking ninja. * gyp_webkit: 2012-10-15 Kent Tamura LocaleMacTest.formatDate is failing on Mac 10.8 https://bugs.webkit.org/show_bug.cgi?id=99330 It seems OS X 10.8 and 10.7 return different date formats for ja_JP locale. We should not test such locales. * tests/LocaleMacTest.cpp: (TEST_F): Remove a test for ja_JP locale. 2012-10-15 Joshua Bell IndexedDB: Pass type of error causing abort to IDBTransaction::onAbort https://bugs.webkit.org/show_bug.cgi?id=99097 Reviewed by Tony Chang. Plumbing to pass details about the cause of the transaction abort through to the front end. * public/WebIDBTransactionCallbacks.h: (WebKit): (WebKit::WebIDBTransactionCallbacks::onAbort): * src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::onAbort): * src/IDBTransactionCallbacksProxy.h: (IDBTransactionCallbacksProxy): * src/WebIDBTransactionCallbacksImpl.cpp: (WebKit::WebIDBTransactionCallbacksImpl::onAbort): * src/WebIDBTransactionCallbacksImpl.h: (WebIDBTransactionCallbacksImpl): 2012-10-15 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-14 Sam Weinig Make UserScript and UserStyleSheet value objects that are copyable https://bugs.webkit.org/show_bug.cgi?id=99275 Reviewed by Tim Horton. * src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet): Update for new PageGroup function signatures. 2012-10-12 Adam Barth [Chromium] Remove used frameForEnteredContext API https://bugs.webkit.org/show_bug.cgi?id=99201 Reviewed by Eric Seidel. No one in Chromium-land understands the difference between frameForEnteredContext and frameForCurrentContext. Rather than give folks a confusing choice, let's just expose the one we most often want to use. I've already removed all callers of frameForEnteredContext downstream. * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit): 2012-10-12 Joshua Bell [Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script https://bugs.webkit.org/show_bug.cgi?id=99193 Reviewed by Adam Barth. Add database error (code, message) to payload for back-end to front-end abort call, so that scripts can determine why the abort occurred - e.g. ConstraintError during indexing. This API change allows the Chromium plumbing to land; the real implementation is in http://webkit.org/b/99097 and will land later. * public/WebIDBTransactionCallbacks.h: (WebKit): (WebIDBTransactionCallbacks): (WebKit::WebIDBTransactionCallbacks::onAbort): 2012-10-12 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-12 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-11 Kenichi Ishibashi [Chromium] Use harfbuzz-ng by default on Linux https://bugs.webkit.org/show_bug.cgi?id=97281 Reviewed by Tony Chang. * features.gypi: Enable WTF_USE_HARFBUZZ_NG when use_x11 == 1. 2012-10-11 Nat Duca Expose high-resolution on requestAnimationFrame callback https://bugs.webkit.org/show_bug.cgi?id=66683 This changes requestAnimationFrame's animationStartTime argument to be a high resolution DOM timestamp, per disucssion here: http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html Reviewed by James Robinson. * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::animate): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::updateAnimations): 2012-10-11 Jay Civelli Test for a fix for a crasher when generating MHTML for a page containing SVG images. https://bugs.webkit.org/show_bug.cgi?id=99105 Reviewed by Adam Barth. * page/PageSerializer.cpp: (WebCore::PageSerializer::serializeCSSStyleSheet): (WebCore::PageSerializer::addImageToResources): 2012-10-11 Adam Barth [Chromium] Improve the comment describing mainWorldScriptContext https://bugs.webkit.org/show_bug.cgi?id=99092 Reviewed by James Robinson. * public/WebFrame.h: (WebFrame): - Add some more text about what this API does so that folks who call it know what they need to worry about. 2012-10-11 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-11 Mihai Balan Always enable the experiments tab for WebKit nightly Web Inspector: Enabling experiments tab in WebKit nightly. https://bugs.webkit.org/show_bug.cgi?id=98923 Reviewed by Pavel Feldman. Enabling Web Inspector experiments tab in WebKit nightly. This is done by adding a new Preference key, Preferences.experimentsEnabled. Default values are true for WebKit and false for Chromium. They can also be overridden as before (in Chromium) * src/js/DevTools.js: 2012-10-11 Kent Tamura Introduce Localizer::isRTL, and use it in DateTimeChooserImpl https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): Re-enabled isRTL test. 2012-10-11 Kent Tamura [Chromium] Disable LocalizedDateICUTest.isRTL https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): Disabled. 2012-10-11 Kent Tamura [Chromium] Attempt to fix LocalizedDateICUTest.isRTL https://bugs.webkit.org/show_bug.cgi?id=98992 * tests/LocalizedDateICUTest.cpp: (TEST_F): 2012-10-11 Kent Tamura Introduce Localizer::isRTL, and use it in DateTimeChooserImpl https://bugs.webkit.org/show_bug.cgi?id=98992 Reviewed by Kentaro Hara. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Use Localizer::isRTL. * tests/LocaleMacTest.cpp: (LocaleMacTest::isRTL): Added a helper function. (TEST_F): Added tests. * tests/LocaleWinTest.cpp: (LocaleWinTest::isRTL): Added a helper function. (TEST_F): Added tests. * tests/LocalizedDateICUTest.cpp: (LocalizedDateICUTest::isRTL): Added a helper function. (TEST_F): Added tests. 2012-10-10 Kent Tamura [Chromium] Calendar picker: should use consistent Localizer object https://bugs.webkit.org/show_bug.cgi?id=98983 Reviewed by Kentaro Hara. In Source/WebKit/chromium/src/DateTimeChooserImpl.cpp, we used two Localizer objects, one was m_localizer and another was 'localizer' local object in writeDocument. We should use single Localizer object. Also, Localizer::create(nullAtom) had unexpected behaviors in ICU environment; e.g. Month labels in a calendar picker were numeric. This patch fixes it, and this is covered by fast/forms/date/calendar-picker-appearance.html. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Use m_localizer. 2012-10-10 Justin Novosad [Chromium] Smoother animation for non-RAF 2D canvas animations https://bugs.webkit.org/show_bug.cgi?id=97918 Reviewed by Stephen White. New unit test to verify the automatic flushing of deferred 2d canvas layers when scripted animations are more than one full frame ahead of the compositor. Also verifies that automatic flushing does not kick-in when the skip on clear optimization fires * DEPS: * tests/Canvas2DLayerManagerTest.cpp: (FakeCanvas2DLayerBridge::fakeSkipPendingDrawCommands): To fake the skip on clear optimization (FakeCanvas2DLayerBridge): (Canvas2DLayerManagerTest): (Canvas2DLayerManagerTest::doDeferredFrameTestTask): Method that simulates a javascript scheduled action that draws to a 2D canvas layer (DeferredFrameTestTask): Task object to simulate a scheduled action. This is so the unit test can cover the TaskObserver behavior of Canvas2DLayerManager. (Canvas2DLayerManagerTest::DeferredFrameTestTask::DeferredFrameTestTask): (Canvas2DLayerManagerTest::deferredFrameTest): The unit test implementation, which uses the WebThread run loop to post tasks that touch the canvas layer. 2012-10-10 Leandro Gracia Gil [Chromium] Update selection on long press to match normal delimiters. https://bugs.webkit.org/show_bug.cgi?id=98947 Reviewed by Adam Barth. Make the long press selection behaviour consistent. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebKit::WebViewImpl::detectContentOnTouch): * src/WebViewImpl.h: (WebViewImpl): * tests/WebViewTest.cpp: 2012-10-10 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-10 Jon Lee [WK2] Activate plugins when user clicks on snapshot https://bugs.webkit.org/show_bug.cgi?id=98328 Reviewed by Brady Eidson. * src/FrameLoaderClientImpl.h: (WebKit::FrameLoaderClientImpl::recreatePlugin): Stub implementation of recreatePlugin(). 2012-10-10 David Barton Turn on ENABLE_MATHML for Chromium https://bugs.webkit.org/show_bug.cgi?id=96960 Reviewed by Adam Barth. * features.gypi: 2012-10-10 Varun Jain [chromium] Spelling and grammar markers are pixelated in hidpi. https://bugs.webkit.org/show_bug.cgi?id=98339 Reviewed by Stephen White. We create separate bitmaps for markers in normal and hidpi mode as per specification from UX and choose the right bitmap based on the current device scale factor. * src/PageWidgetDelegate.cpp: (WebKit::PageWidgetDelegate::paint): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paintRootLayer): 2012-10-10 Simon Fraser Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText https://bugs.webkit.org/show_bug.cgi?id=98839 Reviewed by Sam Weinig. Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::layerTreeAsText): 2012-10-08 Kent Tamura [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName https://bugs.webkit.org/show_bug.cgi?id=98714 Reviewed by Abhishek Arya. * public/WebElement.h: (WebElement): - Add a comment to tagName(). - Add a comment to hasTagName(). - Declare hasHTMLTagName(), which is useful to check HTML tags. * src/WebElement.cpp: (WebKit::WebElement::hasHTMLTagName): Added. 2012-10-09 Jian Li Update the CSS property used to support draggable regions. https://bugs.webkit.org/show_bug.cgi?id=97156 Reviewed by Adam Barth. Update the code to use the new name annotatedRegions to work for both features. * public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions. (WebDraggableRegion): * src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions. (WebKit::ChromeClientImpl::annotatedRegionsChanged): * src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions. (ChromeClientImpl): * src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions. (WebKit::WebDocument::draggableRegions): 2012-10-09 Sadrul Habib Chowdhury [chromium] Add drop event for plugins. https://bugs.webkit.org/show_bug.cgi?id=98827 Reviewed by Adam Barth. Add conversion for drop events. * public/WebDragStatus.h: * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleDragEvent): 2012-10-09 Sheriff Bot Unreviewed, rolling out r130811 and r130821. http://trac.webkit.org/changeset/130811 http://trac.webkit.org/changeset/130821 https://bugs.webkit.org/show_bug.cgi?id=98831 Broke date-suggestion-picker-appearance-with-scroll-bar.html (Requested by abarth|gardening on #webkit). * src/FindInPageCoordinates.cpp: (WebKit::toNormalizedRect): * src/LinkHighlight.cpp: (WebKit::convertTargetSpaceQuadToCompositedLayer): * src/WebInputEventConversion.cpp: (WebKit::convertLocationForRenderObject): 2012-10-09 Ben Murdoch [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() https://bugs.webkit.org/show_bug.cgi?id=97689 Reviewed by Adam Barth. This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources() function to the Chromium WebKit API layer. This is needed in Chromium to implement the Android WebView.loadDataWithBaseUrl function in a compatible manner. Please see crbug.com/152223 for further information and the chromium side patch. * public/WebSecurityOrigin.h: (WebSecurityOrigin): Add grantLoadLocalResources() API. * src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::grantLoadLocalResources): Implement the API by calling through to the WebCore function of the same name. (WebKit): 2012-10-09 Julien Chaffraix [Chromium] Chromium DEPS has a stray directory, turning our Win bots red https://bugs.webkit.org/show_bug.cgi?id=98817 Reviewed by Dirk Pranke. * DEPS: Removed the stray directory which solved the redness on several of our bots. 2012-10-09 Sadrul Habib Chowdhury [chromium] Make sure events are transformed correctly for plugins. https://bugs.webkit.org/show_bug.cgi?id=89250 Reviewed by Tony Chang. The events arriving in WebPluginContainerImpl are in the coordinate space of the page containing the plugin. Before the events are dispatched to the plugin, it is necessary to convert them into the plugin's own coordinate system. * src/WebInputEventConversion.cpp: (WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject. (WebKit): (WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events. (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder): (WebKit::addTouchPoints): (WebKit::WebTouchEventBuilder::WebTouchEventBuilder): (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): * src/WebInputEventConversion.h: (WebCore): (WebKit): (WebMouseEventBuilder): (WebMouseWheelEventBuilder): (WebTouchEventBuilder): (WebGestureEventBuilder): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): 2012-10-09 Garrett Casto Allow users to specify a different hover image for TextFieldDecorationElement https://bugs.webkit.org/show_bug.cgi?id=93662 Reviewed by Kent Tamura. * public/WebTextFieldDecoratorClient.h: (WebTextFieldDecoratorClient): (WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover. * src/TextFieldDecoratorImpl.cpp: (WebKit::TextFieldDecoratorImpl::imageForReadonlyState): (WebKit::TextFieldDecoratorImpl::imageForHoverState): (WebKit): * src/TextFieldDecoratorImpl.h: (TextFieldDecoratorImpl): 2012-10-09 Keishi Hattori Page popup should be smarter about its layout https://bugs.webkit.org/show_bug.cgi?id=98499 Reviewed by Kent Tamura. * src/ColorChooserUIController.cpp: (WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. * src/DateTimeChooserImpl.cpp: (WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver. (WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more. * src/WebPagePopupImpl.h: (WebPagePopupImpl): 2012-10-08 Dirk Pranke Chromium DEPS roll r160657:160764. Unreviewed. * DEPS: 2012-10-08 Alec Flett IndexedDB: remove autogenerated objectStore/index id code https://bugs.webkit.org/show_bug.cgi?id=98085 Reviewed by Tony Chang. Remove support for unused createObjectStore/createIndex. These methods will go away entirely when https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed. * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): * src/WebIDBDatabaseImpl.cpp: * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBObjectStoreImpl.cpp: * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-10-08 Sami Kyostila Some non-scrollable elements are added to non-fast-scrollable region https://bugs.webkit.org/show_bug.cgi?id=97927 Reviewed by James Robinson. Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable region. The test in this patch consists of a web page where both the html and body elements clip horizontal overflow. This results in a hierarchy where the body element gets a scrollable RenderLayer. However, that layer isn't (interactively) scrollable because while the scroll geometry is calculated based on the amount of overflow, the scroll bars are hidden because of the "overflow-x: hidden" style. Previously this layer would have made the entire page part of the non-fast scrollable region. With this patch, RenderLayer::allowScrolling() is used as a pre-requisite for expanding the region, thus avoiding the problem. * tests/ScrollingCoordinatorChromiumTest.cpp: (WebKit::TEST_F): (WebKit): * tests/data/clipped-body.html: Added. 2012-10-08 Sailesh Agrawal Mac Chromium: Ignore system numpad modifier https://bugs.webkit.org/show_bug.cgi?id=97161 Reviewed by Tony Chang. On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms. My fix is to only rely on keycode to decide when to set the numpad modifier. This code is not exersided by layout tests so I added a new unit test for this. * WebKit.gypi: * WebKitUnitTests.gyp: * src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent): Removed check for numpad modifier. * tests/WebInputEventFactoryTestMac.mm: Added. (TEST): Added new test for WebInputEventFactory::keyboardEvent(). 2012-10-08 Sheriff Bot Unreviewed. Rolled DEPS. * DEPS: 2012-10-07 Caio Marcelo de Oliveira Filho Rename first/second to key/value in HashMap iterators https://bugs.webkit.org/show_bug.cgi?id=82784 Reviewed by Eric Seidel. * src/WebGeolocationPermissionRequestManager.cpp: (WebGeolocationPermissionRequestManager::remove): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): * src/WebIntent.cpp: (WebKit::WebIntent::extrasValue): * tests/MemoryInstrumentationTest.cpp: * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore::TEST_F): 2012-10-06 Ilya Tikhonovsky Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964 https://bugs.webkit.org/show_bug.cgi?id=98500 Reviewed by Benjamin Poulain. Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter(). Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1. * tests/MemoryInstrumentationTest.cpp: 2012-10-05 Terry Anderson [chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS https://bugs.webkit.org/show_bug.cgi?id=98526 Reviewed by Stephen White. This is causing some problems with picture serialization between chrome and the mainline skia tools. (Once this change lands and is gardened in, I will make the corresponding change in chromium/skia/skia.gyp) * features.gypi: 2012-10-05 Adam Barth Unreviewed. Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on some code that is conditionally compiled and therefore fails in some configurations. * tests/WebFrameTest.cpp: 2012-10-05 W. James MacLean [chromium] Enhance support for transforms in LinkHighlight. https://bugs.webkit.org/show_bug.cgi?id=94355 Reviewed by Adrienne Walker. Improved handling of transformed highlight targets, where the transform goes beyond simple translation. * src/LinkHighlight.cpp: (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates. (WebKit): (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path. (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::bestTouchLinkNode): 2012-10-05 Julien Chaffraix Unreviewed build fix after r130545. * tests/WebFrameTest.cpp: Avoid a warning about truncating the double constant on Windows. While touching the variable, changed it to be proper camelCase. 2012-10-05 Oli Lan Allow EventHandler to handle longpress gestures, including longpress selection on Android. https://bugs.webkit.org/show_bug.cgi?id=98173 Reviewed by Ryosuke Niwa. This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent. The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour required for Android. This means that a long press gesture performed on word (that is not part of a link) selects the word, without generating a context menu event. A new test, WebViewTest.LongPressSelection has been added to test this. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebViewImpl): * tests/WebViewTest.cpp: * tests/data/longpress_selection.html: Added. 2012-10-05 Yusuf Ozuysal [chromium] Support zooming focused node for mobile devices https://bugs.webkit.org/show_bug.cgi?id=97958 Reviewed by Adam Barth. This unforks the Android version of scrollFocusedNodeIntoRect().A new setting autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all platforms with ENABLE(GESTURE_EVENTS) want this. Test: WebFrameTest.DivScrollIntoEditableTest * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollFocusedNodeIntoRect): * tests/WebFrameTest.cpp: * tests/data/get_scale_for_zoom_into_editable_test.html: Added. 2012-10-05 W. James MacLean [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel. https://bugs.webkit.org/show_bug.cgi?id=97355 Reviewed by Adrienne Walker. This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if interrupted by GestureTap, and animate away if interrupted by GestureTapCancel. * src/LinkHighlight.cpp: (WebKit::LinkHighlight::LinkHighlight): (WebKit::LinkHighlight::startHighlightAnimationIfNeeded): * src/LinkHighlight.h: (LinkHighlight): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleGestureEvent): (WebKit::WebViewImpl::enableTouchHighlight): 2012-10-05 Mark Pilgrim [Chromium] Update some more #includes for Platform/ directory https://bugs.webkit.org/show_bug.cgi?id=98534 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/WebFormElement.cpp: * src/WebFrameImpl.cpp: * src/WebGeolocationClientMock.cpp: * src/WebGeolocationError.cpp: * src/WebGeolocationPermissionRequest.cpp: * src/WebHistoryItem.cpp: * src/WebHitTestResult.cpp: * src/WebIDBTransactionImpl.h: * src/WebIconLoadingCompletionImpl.h: * src/WebImageDecoder.cpp: * src/WebImageSkia.cpp: * src/WebInputElement.cpp: * src/WebKit.cpp: * src/WebLabelElement.cpp: * src/WebMediaStreamRegistry.cpp: * src/WebNode.cpp: * src/WebNotification.cpp: * src/WebOptionElement.cpp: * src/WebPageSerializer.cpp: * src/WebPageSerializerImpl.cpp: * src/WebPageSerializerImpl.h: * src/WebPluginListBuilderImpl.cpp: * src/WebPluginLoadObserver.h: * src/WebPopupMenuImpl.cpp: * src/WebPopupMenuImpl.h: * src/WebRange.cpp: * src/WebRegularExpression.cpp: * src/WebScriptController.cpp: * src/WebSecurityOrigin.cpp: * src/WebSecurityPolicy.cpp: * src/WebSelectElement.cpp: * src/WebSerializedScriptValue.cpp: * src/WebSessionDescriptionDescriptor.cpp: * src/WebSettingsImpl.cpp: * src/WebSocketImpl.cpp: * src/WebSocketImpl.h: * src/WebStorageEventDispatcherImpl.cpp: * src/WebSurroundingText.cpp: * src/WebURLLoadTiming.cpp: * src/WorkerAsyncFileWriterChromium.cpp: * src/WorkerFileSystemCallbacksBridge.cpp: 2012-10-05 Sadrul Habib Chowdhury [chromium] Allow dragging into plugins. https://bugs.webkit.org/show_bug.cgi?id=98277 Reviewed by Tony Chang. Allow plugins to receive drag events. This will make it possible to perform drag-n-drop into browser plugins (and other plugins if desired). * public/WebDragStatus.h: Added. (WebKit): * public/WebPlugin.h: (WebKit): (WebPlugin): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleDragEvent): (WebKit): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): 2012-10-04 Kenichi Ishibashi [WebSocket] ExtensionParser should have its own file https://bugs.webkit.org/show_bug.cgi?id=98475 Reviewed by Yuta Kitamura. Add a test for parsing Sec-WebSocket-Extensions field. * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore): (WebCore::TEST_F): 2012-10-04 Kenichi Ishibashi [Chromium] Improve SocketStreamHandle::send() stability https://bugs.webkit.org/show_bug.cgi?id=98459 Reviewed by Yuta Kitamura. Avoid null dereference in SocketStreamHandleInternal::send(). No changes in behavior. * src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::send): 2012-10-04 Dirk Pranke Chromium DEPS roll r160281:160322 Unreviewed. * DEPS: 2012-10-04 Alexandre Elias [chromium] Scale plugin container by frameScaleFactor https://bugs.webkit.org/show_bug.cgi?id=98468 Reviewed by Adam Barth. Plugin containers (for invalid plugins) weren't taking into account frameScaleFactor, looking cut off when that was non-1. * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): 2012-10-04 Alpha Lam Unreviewd. Chromium DEPS roll. Update to r160281. * DEPS: 2012-10-04 Mark Pilgrim [Chromium] Update some #includes for Platform directory https://bugs.webkit.org/show_bug.cgi?id=98440 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/ApplicationCacheHost.cpp: * src/AssociatedURLLoader.h: * src/AsyncFileWriterChromium.cpp: * src/AudioDestinationChromium.h: * src/AutofillPopupMenuClient.cpp: * src/ChromeClientImpl.cpp: * src/ContextMenuClientImpl.cpp: * src/DeliveredIntentClientImpl.h: * src/DragClientImpl.cpp: * src/DragScrollTimer.h: * src/FrameLoaderClientImpl.cpp: * src/InspectorClientImpl.cpp: * src/InspectorClientImpl.h: * src/InspectorFrontendClientImpl.cpp: * src/NotificationPresenterImpl.cpp: * src/PageWidgetDelegate.h: * src/SocketStreamHandle.cpp: * src/SocketStreamHandleInternal.h: * src/SpeechInputClientImpl.cpp: * src/StorageAreaProxy.cpp: * src/StorageNamespaceProxy.cpp: * src/UserMediaClientImpl.cpp: * src/WebAccessibilityObject.cpp: * src/WebAnimationControllerImpl.cpp: * src/WebCommon.cpp: * src/WebDOMEventListenerPrivate.h: * src/WebDOMMessageEvent.cpp: * src/WebDOMStringList.cpp: * src/WebDataSourceImpl.cpp: * src/WebDatabase.cpp: * src/WebDevToolsAgentImpl.cpp: * src/WebDevToolsAgentImpl.h: * src/WebDocument.cpp: * src/WebDocumentType.cpp: * src/WebDragData.cpp: * src/WebElement.cpp: * src/WebEntities.cpp: * src/WebFileChooserCompletionImpl.h: * src/WebFileSystemCallbacksImpl.cpp: * src/WebFontImpl.cpp: 2012-10-04 Alec Flett IndexedDB: promote objectstore/index backend ids to the frontend https://bugs.webkit.org/show_bug.cgi?id=97834 Reviewed by Tony Chang. Support for marshalling additional IDBMetadata and new calls to createObjectStore/createIndex. * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): * public/WebIDBMetadata.h: (ObjectStore): (Index): * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): * src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit): * src/IDBDatabaseBackendProxy.h: (IDBDatabaseBackendProxy): * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit): * src/IDBObjectStoreBackendProxy.h: (IDBObjectStoreBackendProxy): * src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit): * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): * src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): 2012-10-04 Simon Fraser Standardize on "flush" terminology for compositing layer flushing/syncing https://bugs.webkit.org/show_bug.cgi?id=98321 Reviewed by Simon Fraser. Rename compositing-related methods that refer to "syncing" to instead refer to "flushing". * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleCompositingLayerFlush): * src/ChromeClientImpl.h: (ChromeClientImpl): 2012-10-05 Kent Tamura [Chromium] Enable the multiple fields UI for input[type=date] https://bugs.webkit.org/show_bug.cgi?id=98351 Reviewed by Hajime Morita. * features.gypi: Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI. 2012-10-04 Kent Tamura Add code for input[type=date] with the multiple fields UI https://bugs.webkit.org/show_bug.cgi?id=98340 Reviewed by Hajime Morita. * features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android. 2012-10-03 Keishi Hattori Implement localizeValue for TimeInputType https://bugs.webkit.org/show_bug.cgi?id=98237 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: (LocaleMacTest::timeComponents): (LocaleMacTest): (LocaleMacTest::formatTime): Tests formatDateTime() for time. (TEST_F): 2012-10-03 Dirk Pranke Roll chromium to r160008 Unreviewed, deps roll. * DEPS: 2012-10-03 Adam Barth Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER) https://bugs.webkit.org/show_bug.cgi?id=98301 Reviewed by Eric Seidel. * features.gypi: 2012-10-03 Jeff Timanus [chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor. The flag defaults to disabled, so this change should be a no-op for scaling/scrolling behaviour. https://bugs.webkit.org/show_bug.cgi?id=93292 Reviewed by James Robinson. * public/WebSettings.h: * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setApplyPageScaleFactorInCompositor): (WebKit): (WebKit::WebSettingsImpl::applyPageScaleFactorInCompositor): * src/WebSettingsImpl.h: (WebSettingsImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setPageScaleFactor): (WebKit::WebViewImpl::applyScrollAndScale): 2012-10-03 Hans Wennborg Speech JavaScript API: Add SpeechRecognition.interimResults attribute https://bugs.webkit.org/show_bug.cgi?id=98279 Reviewed by Adam Barth. Plumb interimResults through to Chromium. * public/WebSpeechRecognitionParams.h: (WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams): (WebKit::WebSpeechRecognitionParams::interimResults): (WebSpeechRecognitionParams): * src/SpeechRecognitionClientProxy.cpp: (WebKit::SpeechRecognitionClientProxy::start): * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): 2012-10-03 Hans Wennborg Speech JavaScript API: Remove resultdeleted event https://bugs.webkit.org/show_bug.cgi?id=98272 Reviewed by Adam Barth. Remove didDeleteResult. This was never used, and has been removed from the spec draft. * public/WebSpeechRecognizerClient.h: * src/SpeechRecognitionClientProxy.cpp: * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): 2012-10-02 Anders Carlsson Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory https://bugs.webkit.org/show_bug.cgi?id=98217 Reviewed by Andreas Kling. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): 2012-10-03 Tommy Widenflycht MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation. https://bugs.webkit.org/show_bug.cgi?id=98149 Reviewed by Adam Barth. Adding willStartUsingPeerConnectionHandler to the WebFrameClient. * public/WebFrameClient.h: (WebKit): (WebFrameClient): (WebKit::WebFrameClient::willStartUsingPeerConnectionHandler): * src/FrameLoaderClientImpl.cpp: (WebKit): (WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler): * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): 2012-10-03 Peter Kotwicz WebImage::framesFromData should skip corrupted frames https://bugs.webkit.org/show_bug.cgi?id=98214 Reviewed by Adam Barth. WebImage::framesFromData() should only return bitmaps for valid frames of a .ico file. * src/WebImageSkia.cpp: (WebKit::WebImage::framesFromData): * tests/WebImageTest.cpp: (WebKit::TEST): (WebKit): * tests/data/valid_header_missing_bitmap.ico: Added. 2012-10-02 Yury Semikhatsky Provide memory instrumentation for HashCountedSet https://bugs.webkit.org/show_bug.cgi?id=98138 Reviewed by Pavel Feldman. Added unit test for HashCountedSet memory instrumentation. * tests/MemoryInstrumentationTest.cpp: 2012-10-02 Kent Tamura [Chromium-Win] Implement LocaleWin::dateFormat https://bugs.webkit.org/show_bug.cgi?id=98117 Reviewed by Kentaro Hara. * tests/LocaleWinTest.cpp: (TEST_F): Add tests for LocaleWin::dateFormat. == Rolled over to ChangeLog-2012-10-02 ==