// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "net/http/http_stream_parser.h" #include #include #include #include #include #include #include "base/files/file_path.h" #include "base/files/file_util.h" #include "base/files/scoped_temp_dir.h" #include "base/memory/ptr_util.h" #include "base/memory/ref_counted.h" #include "base/run_loop.h" #include "base/strings/string_piece.h" #include "base/threading/thread_task_runner_handle.h" #include "net/base/chunked_upload_data_stream.h" #include "net/base/elements_upload_data_stream.h" #include "net/base/io_buffer.h" #include "net/base/net_errors.h" #include "net/base/test_completion_callback.h" #include "net/base/upload_bytes_element_reader.h" #include "net/base/upload_file_element_reader.h" #include "net/http/http_request_headers.h" #include "net/http/http_request_info.h" #include "net/http/http_response_headers.h" #include "net/http/http_response_info.h" #include "net/socket/client_socket_handle.h" #include "net/socket/socket_test_util.h" #include "net/test/gtest_util.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "url/gurl.h" using net::test::IsError; using net::test::IsOk; namespace net { namespace { const size_t kOutputSize = 1024; // Just large enough for this test. // The number of bytes that can fit in a buffer of kOutputSize. const size_t kMaxPayloadSize = kOutputSize - HttpStreamParser::kChunkHeaderFooterSize; // Helper method to create a connected ClientSocketHandle using |data|. // Modifies |data|. std::unique_ptr CreateConnectedSocketHandle( SequencedSocketData* data) { data->set_connect_data(MockConnect(SYNCHRONOUS, OK)); std::unique_ptr socket( new MockTCPClientSocket(net::AddressList(), nullptr, data)); TestCompletionCallback callback; EXPECT_THAT(socket->Connect(callback.callback()), IsOk()); std::unique_ptr socket_handle(new ClientSocketHandle); socket_handle->SetSocket(std::move(socket)); return socket_handle; } class ReadErrorUploadDataStream : public UploadDataStream { public: enum class FailureMode { SYNC, ASYNC }; explicit ReadErrorUploadDataStream(FailureMode mode) : UploadDataStream(true, 0), async_(mode), weak_factory_(this) {} private: void CompleteRead() { UploadDataStream::OnReadCompleted(ERR_FAILED); } // UploadDataStream implementation: int InitInternal(const NetLogWithSource& net_log) override { return OK; } int ReadInternal(IOBuffer* buf, int buf_len) override { if (async_ == FailureMode::ASYNC) { base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&ReadErrorUploadDataStream::CompleteRead, weak_factory_.GetWeakPtr())); return ERR_IO_PENDING; } return ERR_FAILED; } void ResetInternal() override {} const FailureMode async_; base::WeakPtrFactory weak_factory_; DISALLOW_COPY_AND_ASSIGN(ReadErrorUploadDataStream); }; TEST(HttpStreamParser, DataReadErrorSynchronous) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "POST / HTTP/1.1\r\n"), MockWrite(SYNCHRONOUS, 1, "Content-Length: 12\r\n\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); ReadErrorUploadDataStream upload_data_stream( ReadErrorUploadDataStream::FailureMode::SYNC); // Test upload progress before init. UploadProgress progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); ASSERT_THAT(upload_data_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); // Test upload progress after init. progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); HttpRequestInfo request; request.method = "POST"; request.url = GURL("http://localhost"); request.upload_data_stream = &upload_data_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Content-Length", "12"); HttpResponseInfo response; TestCompletionCallback callback; int result = parser.SendRequest("POST / HTTP/1.1\r\n", headers, &response, callback.callback()); EXPECT_THAT(callback.GetResult(result), IsError(ERR_FAILED)); progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } TEST(HttpStreamParser, DataReadErrorAsynchronous) { MockWrite writes[] = { MockWrite(ASYNC, 0, "POST / HTTP/1.1\r\n"), MockWrite(ASYNC, 1, "Content-Length: 12\r\n\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); ReadErrorUploadDataStream upload_data_stream( ReadErrorUploadDataStream::FailureMode::ASYNC); ASSERT_THAT(upload_data_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); HttpRequestInfo request; request.method = "POST"; request.url = GURL("http://localhost"); request.upload_data_stream = &upload_data_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Content-Length", "12"); HttpResponseInfo response; TestCompletionCallback callback; int result = parser.SendRequest("POST / HTTP/1.1\r\n", headers, &response, callback.callback()); EXPECT_THAT(result, IsError(ERR_IO_PENDING)); UploadProgress progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); EXPECT_THAT(callback.GetResult(result), IsError(ERR_FAILED)); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } class InitAsyncUploadDataStream : public ChunkedUploadDataStream { public: explicit InitAsyncUploadDataStream(int64_t identifier) : ChunkedUploadDataStream(identifier), weak_factory_(this) {} private: void CompleteInit() { UploadDataStream::OnInitCompleted(OK); } int InitInternal(const NetLogWithSource& net_log) override { base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&InitAsyncUploadDataStream::CompleteInit, weak_factory_.GetWeakPtr())); return ERR_IO_PENDING; } base::WeakPtrFactory weak_factory_; DISALLOW_COPY_AND_ASSIGN(InitAsyncUploadDataStream); }; TEST(HttpStreamParser, InitAsynchronousUploadDataStream) { InitAsyncUploadDataStream upload_data_stream(0); TestCompletionCallback callback; int result = upload_data_stream.Init(callback.callback(), NetLogWithSource()); ASSERT_THAT(result, IsError(ERR_IO_PENDING)); // Should be empty progress while initialization is in progress. UploadProgress progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); EXPECT_THAT(callback.GetResult(result), IsOk()); // Initialization complete. progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); HttpRequestInfo request; request.method = "POST"; request.url = GURL("http://localhost"); request.upload_data_stream = &upload_data_stream; static const char kChunk[] = "Chunk 1"; MockWrite writes[] = { MockWrite(ASYNC, 0, "POST / HTTP/1.1\r\n"), MockWrite(ASYNC, 1, "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 2, "7\r\nChunk 1\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response; TestCompletionCallback callback1; int result1 = parser.SendRequest("POST / HTTP/1.1\r\n", headers, &response, callback1.callback()); EXPECT_EQ(ERR_IO_PENDING, result1); base::RunLoop().RunUntilIdle(); upload_data_stream.AppendData(kChunk, arraysize(kChunk) - 1, true); // Check progress after read completes. progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(7u, progress.position()); // Check progress after reset. upload_data_stream.Reset(); progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(0u, progress.position()); } // The empty payload is how the last chunk is encoded. TEST(HttpStreamParser, EncodeChunk_EmptyPayload) { char output[kOutputSize]; const base::StringPiece kPayload = ""; const base::StringPiece kExpected = "0\r\n\r\n"; const int num_bytes_written = HttpStreamParser::EncodeChunk(kPayload, output, sizeof(output)); ASSERT_EQ(kExpected.size(), static_cast(num_bytes_written)); EXPECT_EQ(kExpected, base::StringPiece(output, num_bytes_written)); } TEST(HttpStreamParser, EncodeChunk_ShortPayload) { char output[kOutputSize]; const std::string kPayload("foo\x00\x11\x22", 6); // 11 = payload size + sizeof("6") + CRLF x 2. const std::string kExpected("6\r\nfoo\x00\x11\x22\r\n", 11); const int num_bytes_written = HttpStreamParser::EncodeChunk(kPayload, output, sizeof(output)); ASSERT_EQ(kExpected.size(), static_cast(num_bytes_written)); EXPECT_EQ(kExpected, base::StringPiece(output, num_bytes_written)); } TEST(HttpStreamParser, EncodeChunk_LargePayload) { char output[kOutputSize]; const std::string kPayload(1000, '\xff'); // '\xff' x 1000. // 3E8 = 1000 in hex. const std::string kExpected = "3E8\r\n" + kPayload + "\r\n"; const int num_bytes_written = HttpStreamParser::EncodeChunk(kPayload, output, sizeof(output)); ASSERT_EQ(kExpected.size(), static_cast(num_bytes_written)); EXPECT_EQ(kExpected, base::StringPiece(output, num_bytes_written)); } TEST(HttpStreamParser, EncodeChunk_FullPayload) { char output[kOutputSize]; const std::string kPayload(kMaxPayloadSize, '\xff'); // 3F4 = 1012 in hex. const std::string kExpected = "3F4\r\n" + kPayload + "\r\n"; const int num_bytes_written = HttpStreamParser::EncodeChunk(kPayload, output, sizeof(output)); ASSERT_EQ(kExpected.size(), static_cast(num_bytes_written)); EXPECT_EQ(kExpected, base::StringPiece(output, num_bytes_written)); } TEST(HttpStreamParser, EncodeChunk_TooLargePayload) { char output[kOutputSize]; // The payload is one byte larger the output buffer size. const std::string kPayload(kMaxPayloadSize + 1, '\xff'); const int num_bytes_written = HttpStreamParser::EncodeChunk(kPayload, output, sizeof(output)); ASSERT_THAT(num_bytes_written, IsError(ERR_INVALID_ARGUMENT)); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_NoBody) { // Shouldn't be merged if upload data is non-existent. ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", NULL)); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_EmptyBody) { std::vector> element_readers; std::unique_ptr body( std::make_unique(std::move(element_readers), 0)); ASSERT_THAT(body->Init(CompletionCallback(), NetLogWithSource()), IsOk()); // Shouldn't be merged if upload data is empty. ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", body.get())); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_ChunkedBody) { const std::string payload = "123"; std::unique_ptr body(new ChunkedUploadDataStream(0)); body->AppendData(payload.data(), payload.size(), true); ASSERT_THAT( body->Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); // Shouldn't be merged if upload data carries chunked data. ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", body.get())); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_FileBody) { // Create an empty temporary file. base::ScopedTempDir temp_dir; ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); base::FilePath temp_file_path; ASSERT_TRUE( base::CreateTemporaryFileInDir(temp_dir.GetPath(), &temp_file_path)); { std::vector> element_readers; element_readers.push_back(std::make_unique( base::ThreadTaskRunnerHandle::Get().get(), temp_file_path, 0, 0, base::Time())); std::unique_ptr body( new ElementsUploadDataStream(std::move(element_readers), 0)); TestCompletionCallback callback; ASSERT_THAT(body->Init(callback.callback(), NetLogWithSource()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Shouldn't be merged if upload data carries a file, as it's not in-memory. ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", body.get())); } // UploadFileElementReaders may post clean-up tasks on destruction. base::RunLoop().RunUntilIdle(); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_SmallBodyInMemory) { std::vector> element_readers; const std::string payload = "123"; element_readers.push_back(std::make_unique( payload.data(), payload.size())); std::unique_ptr body( new ElementsUploadDataStream(std::move(element_readers), 0)); ASSERT_THAT(body->Init(CompletionCallback(), NetLogWithSource()), IsOk()); // Yes, should be merged if the in-memory body is small here. ASSERT_TRUE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", body.get())); } TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_LargeBodyInMemory) { std::vector> element_readers; const std::string payload(10000, 'a'); // 'a' x 10000. element_readers.push_back(std::make_unique( payload.data(), payload.size())); std::unique_ptr body( new ElementsUploadDataStream(std::move(element_readers), 0)); ASSERT_THAT(body->Init(CompletionCallback(), NetLogWithSource()), IsOk()); // Shouldn't be merged if the in-memory body is large here. ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody( "some header", body.get())); } TEST(HttpStreamParser, SentBytesNoHeaders) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request; request.method = "GET"; request.url = GURL("http://localhost"); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(OK, parser.SendRequest("GET / HTTP/1.1\r\n", HttpRequestHeaders(), &response, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } TEST(HttpStreamParser, SentBytesWithHeaders) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n" "Host: localhost\r\n" "Connection: Keep-Alive\r\n\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request; request.method = "GET"; request.url = GURL("http://localhost"); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Host", "localhost"); headers.SetHeader("Connection", "Keep-Alive"); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(OK, parser.SendRequest("GET / HTTP/1.1\r\n", headers, &response, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } TEST(HttpStreamParser, SentBytesWithHeadersMultiWrite) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n"), MockWrite(SYNCHRONOUS, 1, "Host: localhost\r\n"), MockWrite(SYNCHRONOUS, 2, "Connection: Keep-Alive\r\n\r\n"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request; request.method = "GET"; request.url = GURL("http://localhost"); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Host", "localhost"); headers.SetHeader("Connection", "Keep-Alive"); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(OK, parser.SendRequest("GET / HTTP/1.1\r\n", headers, &response, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } TEST(HttpStreamParser, SentBytesWithErrorWritingHeaders) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n"), MockWrite(SYNCHRONOUS, 1, "Host: localhost\r\n"), MockWrite(SYNCHRONOUS, ERR_CONNECTION_RESET, 2), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request; request.method = "GET"; request.url = GURL("http://localhost"); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Host", "localhost"); headers.SetHeader("Connection", "Keep-Alive"); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(ERR_CONNECTION_RESET, parser.SendRequest("GET / HTTP/1.1\r\n", headers, &response, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); } TEST(HttpStreamParser, SentBytesPost) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "POST / HTTP/1.1\r\n"), MockWrite(SYNCHRONOUS, 1, "Content-Length: 12\r\n\r\n"), MockWrite(SYNCHRONOUS, 2, "hello world!"), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); std::vector> element_readers; element_readers.push_back( std::make_unique("hello world!", 12)); ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); ASSERT_THAT(upload_data_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); HttpRequestInfo request; request.method = "POST"; request.url = GURL("http://localhost"); request.upload_data_stream = &upload_data_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Content-Length", "12"); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(OK, parser.SendRequest("POST / HTTP/1.1\r\n", headers, &response, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); UploadProgress progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(12u, progress.size()); EXPECT_EQ(12u, progress.position()); } TEST(HttpStreamParser, SentBytesChunkedPostError) { static const char kChunk[] = "Chunk 1"; MockWrite writes[] = { MockWrite(ASYNC, 0, "POST / HTTP/1.1\r\n"), MockWrite(ASYNC, 1, "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 2, "7\r\nChunk 1\r\n"), MockWrite(SYNCHRONOUS, ERR_FAILED, 3), }; SequencedSocketData data(nullptr, 0, writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); ChunkedUploadDataStream upload_data_stream(0); ASSERT_THAT(upload_data_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); HttpRequestInfo request; request.method = "POST"; request.url = GURL("http://localhost"); request.upload_data_stream = &upload_data_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders headers; headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response; TestCompletionCallback callback; EXPECT_EQ(ERR_IO_PENDING, parser.SendRequest("POST / HTTP/1.1\r\n", headers, &response, callback.callback())); base::RunLoop().RunUntilIdle(); upload_data_stream.AppendData(kChunk, arraysize(kChunk) - 1, false); base::RunLoop().RunUntilIdle(); // This write should fail. upload_data_stream.AppendData(kChunk, arraysize(kChunk) - 1, false); EXPECT_THAT(callback.WaitForResult(), IsError(ERR_FAILED)); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); UploadProgress progress = upload_data_stream.GetUploadProgress(); EXPECT_EQ(0u, progress.size()); EXPECT_EQ(14u, progress.position()); } // Test to ensure the HttpStreamParser state machine does not get confused // when sending a request with a chunked body with only one chunk that becomes // available asynchronously. TEST(HttpStreamParser, AsyncSingleChunkAndAsyncSocket) { static const char kChunk[] = "Chunk"; MockWrite writes[] = { MockWrite(ASYNC, 0, "GET /one.html HTTP/1.1\r\n" "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 1, "5\r\nChunk\r\n"), MockWrite(ASYNC, 2, "0\r\n\r\n"), }; // The size of the response body, as reflected in the Content-Length of the // MockRead below. static const int kBodySize = 8; MockRead reads[] = { MockRead(ASYNC, 3, "HTTP/1.1 200 OK\r\n"), MockRead(ASYNC, 4, "Content-Length: 8\r\n\r\n"), MockRead(ASYNC, 5, "one.html"), MockRead(SYNCHRONOUS, 0, 6), // EOF }; ChunkedUploadDataStream upload_stream(0); ASSERT_THAT(upload_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.upload_data_stream = &upload_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; request_headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response_info; TestCompletionCallback callback; // This will attempt to Write() the initial request and headers, which will // complete asynchronously. ASSERT_EQ(ERR_IO_PENDING, parser.SendRequest("GET /one.html HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); // Complete the initial request write. Callback should not have been invoked. base::RunLoop().RunUntilIdle(); ASSERT_FALSE(callback.have_result()); // Now append the only chunk and wait for the callback. upload_stream.AppendData(kChunk, arraysize(kChunk) - 1, true); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Attempt to read the response status and the response headers. ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Finally, attempt to read the response body. scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(ERR_IO_PENDING, parser.ReadResponseBody(body_buffer.get(), kBodySize, callback.callback())); ASSERT_EQ(kBodySize, callback.WaitForResult()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } // Test to ensure the HttpStreamParser state machine does not get confused // when sending a request with a chunked body with only one chunk that is // available synchronously. TEST(HttpStreamParser, SyncSingleChunkAndAsyncSocket) { static const char kChunk[] = "Chunk"; MockWrite writes[] = { MockWrite(ASYNC, 0, "GET /one.html HTTP/1.1\r\n" "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 1, "5\r\nChunk\r\n"), MockWrite(ASYNC, 2, "0\r\n\r\n"), }; // The size of the response body, as reflected in the Content-Length of the // MockRead below. static const int kBodySize = 8; MockRead reads[] = { MockRead(ASYNC, 3, "HTTP/1.1 200 OK\r\n"), MockRead(ASYNC, 4, "Content-Length: 8\r\n\r\n"), MockRead(ASYNC, 5, "one.html"), MockRead(SYNCHRONOUS, 0, 6), // EOF }; ChunkedUploadDataStream upload_stream(0); ASSERT_THAT(upload_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); // Append the only chunk. upload_stream.AppendData(kChunk, arraysize(kChunk) - 1, true); SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.upload_data_stream = &upload_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; request_headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response_info; TestCompletionCallback callback; // This will attempt to Write() the initial request and headers, which will // complete asynchronously. ASSERT_EQ(ERR_IO_PENDING, parser.SendRequest("GET /one.html HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Attempt to read the response status and the response headers. ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Finally, attempt to read the response body. scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(ERR_IO_PENDING, parser.ReadResponseBody(body_buffer.get(), kBodySize, callback.callback())); ASSERT_EQ(kBodySize, callback.WaitForResult()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } // Test to ensure the HttpStreamParser state machine does not get confused // when sending a request with a chunked body, where chunks become available // asynchronously, over a socket where writes may also complete // asynchronously. // This is a regression test for http://crbug.com/132243 TEST(HttpStreamParser, AsyncChunkAndAsyncSocketWithMultipleChunks) { // The chunks that will be written in the request, as reflected in the // MockWrites below. static const char kChunk1[] = "Chunk 1"; static const char kChunk2[] = "Chunky 2"; static const char kChunk3[] = "Test 3"; MockWrite writes[] = { MockWrite(ASYNC, 0, "GET /one.html HTTP/1.1\r\n" "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 1, "7\r\nChunk 1\r\n"), MockWrite(ASYNC, 2, "8\r\nChunky 2\r\n"), MockWrite(ASYNC, 3, "6\r\nTest 3\r\n"), MockWrite(ASYNC, 4, "0\r\n\r\n"), }; // The size of the response body, as reflected in the Content-Length of the // MockRead below. static const int kBodySize = 8; MockRead reads[] = { MockRead(ASYNC, 5, "HTTP/1.1 200 OK\r\n"), MockRead(ASYNC, 6, "Content-Length: 8\r\n\r\n"), MockRead(ASYNC, 7, "one.html"), MockRead(SYNCHRONOUS, 0, 8), // EOF }; ChunkedUploadDataStream upload_stream(0); upload_stream.AppendData(kChunk1, arraysize(kChunk1) - 1, false); ASSERT_THAT(upload_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.upload_data_stream = &upload_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; request_headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response_info; TestCompletionCallback callback; // This will attempt to Write() the initial request and headers, which will // complete asynchronously. ASSERT_EQ(ERR_IO_PENDING, parser.SendRequest("GET /one.html HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); ASSERT_FALSE(callback.have_result()); // Sending the request and the first chunk completes. base::RunLoop().RunUntilIdle(); ASSERT_FALSE(callback.have_result()); // Now append another chunk. upload_stream.AppendData(kChunk2, arraysize(kChunk2) - 1, false); ASSERT_FALSE(callback.have_result()); // Add the final chunk, while the write for the second is still pending, // which should not confuse the state machine. upload_stream.AppendData(kChunk3, arraysize(kChunk3) - 1, true); ASSERT_FALSE(callback.have_result()); // Wait for writes to complete. ASSERT_THAT(callback.WaitForResult(), IsOk()); // Attempt to read the response status and the response headers. ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Finally, attempt to read the response body. scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(ERR_IO_PENDING, parser.ReadResponseBody(body_buffer.get(), kBodySize, callback.callback())); ASSERT_EQ(kBodySize, callback.WaitForResult()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } // Test to ensure the HttpStreamParser state machine does not get confused // when there's only one "chunk" with 0 bytes, and is received from the // UploadStream only after sending the request headers successfully. TEST(HttpStreamParser, AsyncEmptyChunkedUpload) { MockWrite writes[] = { MockWrite(ASYNC, 0, "GET /one.html HTTP/1.1\r\n" "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 1, "0\r\n\r\n"), }; // The size of the response body, as reflected in the Content-Length of the // MockRead below. const int kBodySize = 8; MockRead reads[] = { MockRead(ASYNC, 2, "HTTP/1.1 200 OK\r\n"), MockRead(ASYNC, 3, "Content-Length: 8\r\n\r\n"), MockRead(ASYNC, 4, "one.html"), MockRead(SYNCHRONOUS, 0, 5), // EOF }; ChunkedUploadDataStream upload_stream(0); ASSERT_THAT(upload_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.upload_data_stream = &upload_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; request_headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response_info; TestCompletionCallback callback; // This will attempt to Write() the initial request and headers, which will // complete asynchronously. ASSERT_EQ(ERR_IO_PENDING, parser.SendRequest("GET /one.html HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); // Now append the terminal 0-byte "chunk". upload_stream.AppendData(nullptr, 0, true); ASSERT_FALSE(callback.have_result()); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Attempt to read the response status and the response headers. ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Finally, attempt to read the response body. scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(ERR_IO_PENDING, parser.ReadResponseBody(body_buffer.get(), kBodySize, callback.callback())); ASSERT_EQ(kBodySize, callback.WaitForResult()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } // Test to ensure the HttpStreamParser state machine does not get confused // when there's only one "chunk" with 0 bytes, which was already appended before // the request was started. TEST(HttpStreamParser, SyncEmptyChunkedUpload) { MockWrite writes[] = { MockWrite(ASYNC, 0, "GET /one.html HTTP/1.1\r\n" "Transfer-Encoding: chunked\r\n\r\n"), MockWrite(ASYNC, 1, "0\r\n\r\n"), }; // The size of the response body, as reflected in the Content-Length of the // MockRead below. const int kBodySize = 8; MockRead reads[] = { MockRead(ASYNC, 2, "HTTP/1.1 200 OK\r\n"), MockRead(ASYNC, 3, "Content-Length: 8\r\n\r\n"), MockRead(ASYNC, 4, "one.html"), MockRead(SYNCHRONOUS, 0, 5), // EOF }; ChunkedUploadDataStream upload_stream(0); ASSERT_THAT(upload_stream.Init(TestCompletionCallback().callback(), NetLogWithSource()), IsOk()); // Append final empty chunk. upload_stream.AppendData(nullptr, 0, true); SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.upload_data_stream = &upload_stream; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; request_headers.SetHeader("Transfer-Encoding", "chunked"); HttpResponseInfo response_info; TestCompletionCallback callback; // This will attempt to Write() the initial request and headers, which will // complete asynchronously. ASSERT_EQ(ERR_IO_PENDING, parser.SendRequest("GET /one.html HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); // Complete writing the request headers and body. ASSERT_THAT(callback.WaitForResult(), IsOk()); // Attempt to read the response status and the response headers. ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsError(ERR_IO_PENDING)); ASSERT_THAT(callback.WaitForResult(), IsOk()); // Finally, attempt to read the response body. scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(ERR_IO_PENDING, parser.ReadResponseBody(body_buffer.get(), kBodySize, callback.callback())); ASSERT_EQ(kBodySize, callback.WaitForResult()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } TEST(HttpStreamParser, TruncatedHeaders) { MockRead truncated_status_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 20"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead truncated_after_status_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 Ok\r\n"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead truncated_in_header_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 Ok\r\nHead"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead truncated_after_header_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 Ok\r\nHeader: foo\r\n"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead truncated_after_final_newline_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 Ok\r\nHeader: foo\r\n\r"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead not_truncated_reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 Ok\r\nHeader: foo\r\n\r\n"), MockRead(SYNCHRONOUS, 0, 2), // EOF }; MockRead* reads[] = { truncated_status_reads, truncated_after_status_reads, truncated_in_header_reads, truncated_after_header_reads, truncated_after_final_newline_reads, not_truncated_reads, }; MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n\r\n"), }; enum { HTTP = 0, HTTPS, NUM_PROTOCOLS, }; for (size_t protocol = 0; protocol < NUM_PROTOCOLS; protocol++) { SCOPED_TRACE(protocol); for (size_t i = 0; i < arraysize(reads); i++) { SCOPED_TRACE(i); SequencedSocketData data(reads[i], 2, writes, arraysize(writes)); std::unique_ptr socket_handle( CreateConnectedSocketHandle(&data)); HttpRequestInfo request_info; request_info.method = "GET"; if (protocol == HTTP) { request_info.url = GURL("http://localhost"); } else { request_info.url = GURL("https://localhost"); } request_info.load_flags = LOAD_NORMAL; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; HttpResponseInfo response_info; TestCompletionCallback callback; ASSERT_EQ(OK, parser.SendRequest("GET / HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); int rv = parser.ReadResponseHeaders(callback.callback()); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); if (i == arraysize(reads) - 1) { EXPECT_THAT(rv, IsOk()); EXPECT_TRUE(response_info.headers.get()); EXPECT_EQ(CountReadBytes(reads[i], 2), parser.received_bytes()); } else { if (protocol == HTTP) { EXPECT_THAT(rv, IsError(ERR_CONNECTION_CLOSED)); EXPECT_TRUE(response_info.headers.get()); EXPECT_EQ(CountReadBytes(reads[i], 2), parser.received_bytes()); } else { EXPECT_THAT(rv, IsError(ERR_RESPONSE_HEADERS_TRUNCATED)); EXPECT_FALSE(response_info.headers.get()); EXPECT_EQ(0, parser.received_bytes()); } } } } } // Confirm that on 101 response, the headers are parsed but the data that // follows remains in the buffer. TEST(HttpStreamParser, Websocket101Response) { MockRead reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 101 Switching Protocols\r\n" "Upgrade: websocket\r\n" "Connection: Upgrade\r\n" "\r\n" "a fake websocket frame"), }; MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET / HTTP/1.1\r\n\r\n"), }; SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); HttpRequestInfo request_info; request_info.method = "GET"; request_info.url = GURL("http://localhost"); request_info.load_flags = LOAD_NORMAL; scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), &request_info, read_buffer.get(), NetLogWithSource()); HttpRequestHeaders request_headers; HttpResponseInfo response_info; TestCompletionCallback callback; ASSERT_EQ(OK, parser.SendRequest("GET / HTTP/1.1\r\n", request_headers, &response_info, callback.callback())); EXPECT_THAT(parser.ReadResponseHeaders(callback.callback()), IsOk()); ASSERT_TRUE(response_info.headers.get()); EXPECT_EQ(101, response_info.headers->response_code()); EXPECT_TRUE(response_info.headers->HasHeaderValue("Connection", "Upgrade")); EXPECT_TRUE(response_info.headers->HasHeaderValue("Upgrade", "websocket")); EXPECT_EQ(read_buffer->capacity(), read_buffer->offset()); EXPECT_EQ("a fake websocket frame", base::StringPiece(read_buffer->StartOfBuffer(), read_buffer->capacity())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)) - static_cast(strlen("a fake websocket frame")), parser.received_bytes()); } // Helper class for constructing HttpStreamParser and running GET requests. class SimpleGetRunner { public: SimpleGetRunner() : url_("http://localhost"), http_09_on_non_default_ports_enabled_(false), read_buffer_(new GrowableIOBuffer), sequence_number_(0) { writes_.push_back(MockWrite( SYNCHRONOUS, sequence_number_++, "GET / HTTP/1.1\r\n\r\n")); } void set_url(const GURL& url) { url_ = url; } void set_http_09_on_non_default_ports_enabled( bool http_09_on_non_default_ports_enabled) { http_09_on_non_default_ports_enabled_ = http_09_on_non_default_ports_enabled; } HttpStreamParser* parser() { return parser_.get(); } GrowableIOBuffer* read_buffer() { return read_buffer_.get(); } HttpResponseInfo* response_info() { return &response_info_; } void AddInitialData(const std::string& data) { int offset = read_buffer_->offset(); int size = data.size(); read_buffer_->SetCapacity(offset + size); memcpy(read_buffer_->StartOfBuffer() + offset, data.data(), size); read_buffer_->set_offset(offset + size); } void AddRead(const std::string& data) { reads_.push_back(MockRead(SYNCHRONOUS, sequence_number_++, data.data())); } // Simple overload - the above method requires using std::strings that outlive // the function call. This version works with inlined C-style strings. void AddRead(const char* data) { reads_.push_back(MockRead(SYNCHRONOUS, sequence_number_++, data)); } void SetupParserAndSendRequest() { reads_.push_back(MockRead(SYNCHRONOUS, 0, sequence_number_++)); // EOF data_.reset(new SequencedSocketData(&reads_.front(), reads_.size(), &writes_.front(), writes_.size())); socket_handle_ = CreateConnectedSocketHandle(data_.get()); request_info_.method = "GET"; request_info_.url = url_; request_info_.load_flags = LOAD_NORMAL; parser_.reset(new HttpStreamParser(socket_handle_.get(), &request_info_, read_buffer(), NetLogWithSource())); parser_->set_http_09_on_non_default_ports_enabled( http_09_on_non_default_ports_enabled_); TestCompletionCallback callback; ASSERT_EQ(OK, parser_->SendRequest("GET / HTTP/1.1\r\n", request_headers_, &response_info_, callback.callback())); } void ReadHeadersExpectingError(Error error) { TestCompletionCallback callback; EXPECT_THAT(parser_->ReadResponseHeaders(callback.callback()), IsError(error)); } void ReadHeaders() { ReadHeadersExpectingError(OK); } void ReadBody(int user_buf_len, int* read_lengths) { TestCompletionCallback callback; scoped_refptr buffer = new IOBuffer(user_buf_len); int rv; int i = 0; while (true) { rv = parser_->ReadResponseBody( buffer.get(), user_buf_len, callback.callback()); EXPECT_EQ(read_lengths[i], rv); i++; if (rv <= 0) return; } } private: GURL url_; bool http_09_on_non_default_ports_enabled_; HttpRequestHeaders request_headers_; HttpResponseInfo response_info_; HttpRequestInfo request_info_; scoped_refptr read_buffer_; std::vector reads_; std::vector writes_; std::unique_ptr socket_handle_; std::unique_ptr data_; std::unique_ptr parser_; int sequence_number_; }; // Test that HTTP/0.9 works as expected, only on ports where it should be // enabled. TEST(HttpStreamParser, Http09PortTests) { struct TestCase { const char* url; bool http_09_on_non_default_ports_enabled; // Expected result when trying to read headers and response is an HTTP/0.9 // non-Shoutcast response. Error expected_09_header_error; // Expected result when trying to read headers for a shoutcast response. Error expected_shoutcast_header_error; }; const TestCase kTestCases[] = { // Default ports should work for HTTP/0.9, regardless of whether the port // is explicitly specified or not. {"http://foo.com/", false, OK, OK}, {"http://foo.com:80/", false, OK, OK}, {"https://foo.com/", false, OK, OK}, {"https://foo.com:443/", false, OK, OK}, // Non-standard ports should not support HTTP/0.9, by default. {"http://foo.com:8080/", false, ERR_INVALID_HTTP_RESPONSE, OK}, {"https://foo.com:8080/", false, ERR_INVALID_HTTP_RESPONSE, ERR_INVALID_HTTP_RESPONSE}, {"http://foo.com:443/", false, ERR_INVALID_HTTP_RESPONSE, OK}, {"https://foo.com:80/", false, ERR_INVALID_HTTP_RESPONSE, ERR_INVALID_HTTP_RESPONSE}, // Allowing non-default ports should not break the default ones. {"http://foo.com/", true, OK, OK}, {"http://foo.com:80/", true, OK, OK}, {"https://foo.com/", true, OK, OK}, {"https://foo.com:443/", true, OK, OK}, // Check that non-default ports works. {"http://foo.com:8080/", true, OK, OK}, {"https://foo.com:8080/", true, OK, OK}, {"http://foo.com:443/", true, OK, OK}, {"https://foo.com:80/", true, OK, OK}, }; const std::string kResponse = "hello\r\nworld\r\n"; for (const auto& test_case : kTestCases) { SimpleGetRunner get_runner; get_runner.set_url(GURL(test_case.url)); get_runner.set_http_09_on_non_default_ports_enabled( test_case.http_09_on_non_default_ports_enabled); get_runner.AddRead(kResponse); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeadersExpectingError(test_case.expected_09_header_error); if (test_case.expected_09_header_error != OK) continue; ASSERT_TRUE(get_runner.response_info()->headers); EXPECT_EQ("HTTP/0.9 200 OK", get_runner.response_info()->headers->GetStatusLine()); EXPECT_EQ(0, get_runner.parser()->received_bytes()); int read_lengths[] = {kResponse.size(), 0}; get_runner.ReadBody(kResponse.size(), read_lengths); EXPECT_EQ(kResponse.size(), static_cast(get_runner.parser()->received_bytes())); EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP0_9, get_runner.response_info()->connection_info); } const std::string kShoutcastResponse = "ICY 200 blah\r\n\r\n"; for (const auto& test_case : kTestCases) { SimpleGetRunner get_runner; get_runner.set_url(GURL(test_case.url)); get_runner.set_http_09_on_non_default_ports_enabled( test_case.http_09_on_non_default_ports_enabled); get_runner.AddRead(kShoutcastResponse); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeadersExpectingError( test_case.expected_shoutcast_header_error); if (test_case.expected_shoutcast_header_error != OK) continue; ASSERT_TRUE(get_runner.response_info()->headers); EXPECT_EQ("HTTP/0.9 200 OK", get_runner.response_info()->headers->GetStatusLine()); EXPECT_EQ(0, get_runner.parser()->received_bytes()); int read_lengths[] = {kShoutcastResponse.size(), 0}; get_runner.ReadBody(kShoutcastResponse.size(), read_lengths); EXPECT_EQ(kShoutcastResponse.size(), static_cast(get_runner.parser()->received_bytes())); EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP0_9, get_runner.response_info()->connection_info); } } // Make sure that Shoutcast is recognized when receiving one byte at a time. TEST(HttpStreamParser, ShoutcastSingleByteReads) { SimpleGetRunner get_runner; get_runner.set_url(GURL("http://foo.com:8080/")); get_runner.set_http_09_on_non_default_ports_enabled(false); get_runner.AddRead("i"); get_runner.AddRead("c"); get_runner.AddRead("Y"); // Needed because HttpStreamParser::Read returns ERR_CONNECTION_CLOSED on // small response headers, which HttpNetworkTransaction replaces with net::OK. // TODO(mmenke): Can we just change that behavior? get_runner.AddRead(" Extra stuff"); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeadersExpectingError(OK); EXPECT_EQ("HTTP/0.9 200 OK", get_runner.response_info()->headers->GetStatusLine()); } // Make sure that Shoutcast is recognized when receiving any string starting // with "ICY", regardless of capitalization, and without a space following it // (The latter behavior is just to match HTTP detection). TEST(HttpStreamParser, ShoutcastWeirdHeader) { SimpleGetRunner get_runner; get_runner.set_url(GURL("http://foo.com:8080/")); get_runner.set_http_09_on_non_default_ports_enabled(false); get_runner.AddRead("iCyCreamSundae"); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeadersExpectingError(OK); EXPECT_EQ("HTTP/0.9 200 OK", get_runner.response_info()->headers->GetStatusLine()); } // Make sure that HTTP/0.9 isn't allowed in the truncated header case on a weird // port. TEST(HttpStreamParser, Http09TruncatedHeaderPortTest) { SimpleGetRunner get_runner; get_runner.set_url(GURL("http://foo.com:8080/")); std::string response = "HT"; get_runner.AddRead(response); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeadersExpectingError(ERR_INVALID_HTTP_RESPONSE); } // Test basic case where there is no keep-alive or extra data from the socket, // and the entire response is received in a single read. TEST(HttpStreamParser, ReceivedBytesNormal) { std::string headers = "HTTP/1.0 200 OK\r\n" "Content-Length: 7\r\n\r\n"; std::string body = "content"; std::string response = headers + body; SimpleGetRunner get_runner; get_runner.AddRead(response); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); int64_t headers_size = headers.size(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int body_size = body.size(); int read_lengths[] = {body_size, 0}; get_runner.ReadBody(body_size, read_lengths); int64_t response_size = response.size(); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_0, get_runner.response_info()->connection_info); } // Test that bytes that represent "next" response are not counted // as current response "received_bytes". TEST(HttpStreamParser, ReceivedBytesExcludesNextResponse) { std::string headers = "HTTP/1.1 200 OK\r\n" "Content-Length: 8\r\n\r\n"; std::string body = "content8"; std::string response = headers + body; std::string next_response = "HTTP/1.1 200 OK\r\n\r\nFOO"; std::string data = response + next_response; SimpleGetRunner get_runner; get_runner.AddRead(data); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); EXPECT_EQ(39, get_runner.parser()->received_bytes()); int64_t headers_size = headers.size(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int body_size = body.size(); int read_lengths[] = {body_size, 0}; get_runner.ReadBody(body_size, read_lengths); int64_t response_size = response.size(); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); int64_t next_response_size = next_response.size(); EXPECT_EQ(next_response_size, get_runner.read_buffer()->offset()); EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, get_runner.response_info()->connection_info); } // Test that "received_bytes" calculation works fine when last read // contains more data than requested by user. // We send data in two reads: // 1) Headers + beginning of response // 2) remaining part of response + next response start // We setup user read buffer so it fully accepts the beginnig of response // body, but it is larger that remaining part of body. TEST(HttpStreamParser, ReceivedBytesMultiReadExcludesNextResponse) { std::string headers = "HTTP/1.1 200 OK\r\n" "Content-Length: 36\r\n\r\n"; int64_t user_buf_len = 32; std::string body_start = std::string(user_buf_len, '#'); int body_start_size = body_start.size(); EXPECT_EQ(user_buf_len, body_start_size); std::string response_start = headers + body_start; std::string body_end = "abcd"; std::string next_response = "HTTP/1.1 200 OK\r\n\r\nFOO"; std::string response_end = body_end + next_response; SimpleGetRunner get_runner; get_runner.AddRead(response_start); get_runner.AddRead(response_end); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); int64_t headers_size = headers.size(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int body_end_size = body_end.size(); int read_lengths[] = {body_start_size, body_end_size, 0}; get_runner.ReadBody(body_start_size, read_lengths); int64_t response_size = response_start.size() + body_end_size; EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); int64_t next_response_size = next_response.size(); EXPECT_EQ(next_response_size, get_runner.read_buffer()->offset()); } // Test that "received_bytes" calculation works fine when there is no // network activity at all; that is when all data is read from read buffer. // In this case read buffer contains two responses. We expect that only // bytes that correspond to the first one are taken into account. TEST(HttpStreamParser, ReceivedBytesFromReadBufExcludesNextResponse) { std::string headers = "HTTP/1.1 200 OK\r\n" "Content-Length: 7\r\n\r\n"; std::string body = "content"; std::string response = headers + body; std::string next_response = "HTTP/1.1 200 OK\r\n\r\nFOO"; std::string data = response + next_response; SimpleGetRunner get_runner; get_runner.AddInitialData(data); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); int64_t headers_size = headers.size(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int body_size = body.size(); int read_lengths[] = {body_size, 0}; get_runner.ReadBody(body_size, read_lengths); int64_t response_size = response.size(); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); int64_t next_response_size = next_response.size(); EXPECT_EQ(next_response_size, get_runner.read_buffer()->offset()); } // Test calculating "received_bytes" when part of request has been already // loaded and placed to read buffer by previous stream parser. TEST(HttpStreamParser, ReceivedBytesUseReadBuf) { std::string buffer = "HTTP/1.1 200 OK\r\n"; std::string remaining_headers = "Content-Length: 7\r\n\r\n"; int64_t headers_size = buffer.size() + remaining_headers.size(); std::string body = "content"; std::string response = remaining_headers + body; SimpleGetRunner get_runner; get_runner.AddInitialData(buffer); get_runner.AddRead(response); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int body_size = body.size(); int read_lengths[] = {body_size, 0}; get_runner.ReadBody(body_size, read_lengths); EXPECT_EQ(headers_size + body_size, get_runner.parser()->received_bytes()); EXPECT_EQ(0, get_runner.read_buffer()->offset()); } // Test the case when the resulting read_buf contains both unused bytes and // bytes ejected by chunked-encoding filter. TEST(HttpStreamParser, ReceivedBytesChunkedTransferExcludesNextResponse) { std::string response = "HTTP/1.1 200 OK\r\n" "Transfer-Encoding: chunked\r\n\r\n" "7\r\nChunk 1\r\n" "8\r\nChunky 2\r\n" "6\r\nTest 3\r\n" "0\r\n\r\n"; std::string next_response = "foo bar\r\n"; std::string data = response + next_response; SimpleGetRunner get_runner; get_runner.AddInitialData(data); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); int read_lengths[] = {4, 3, 6, 2, 6, 0}; get_runner.ReadBody(7, read_lengths); int64_t response_size = response.size(); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); int64_t next_response_size = next_response.size(); EXPECT_EQ(next_response_size, get_runner.read_buffer()->offset()); } // Test that data transfered in multiple reads is correctly processed. // We feed data into 4-bytes reads. Also we set length of read // buffer to 5-bytes to test all possible buffer misaligments. TEST(HttpStreamParser, ReceivedBytesMultipleReads) { std::string headers = "HTTP/1.1 200 OK\r\n" "Content-Length: 33\r\n\r\n"; std::string body = "foo bar baz\r\n" "sputnik mir babushka"; std::string response = headers + body; size_t receive_length = 4; std::vector blocks; for (size_t i = 0; i < response.size(); i += receive_length) { size_t length = std::min(receive_length, response.size() - i); blocks.push_back(response.substr(i, length)); } SimpleGetRunner get_runner; for (std::vector::size_type i = 0; i < blocks.size(); ++i) get_runner.AddRead(blocks[i]); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); int64_t headers_size = headers.size(); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int read_lengths[] = {1, 4, 4, 4, 4, 4, 4, 4, 4, 0}; get_runner.ReadBody(receive_length + 1, read_lengths); int64_t response_size = response.size(); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); } // Test that "continue" HTTP header is counted as "received_bytes". TEST(HttpStreamParser, ReceivedBytesIncludesContinueHeader) { std::string status100 = "HTTP/1.1 100 OK\r\n\r\n"; std::string headers = "HTTP/1.1 200 OK\r\n" "Content-Length: 7\r\n\r\n"; int64_t headers_size = status100.size() + headers.size(); std::string body = "content"; std::string response = headers + body; SimpleGetRunner get_runner; get_runner.AddRead(status100); get_runner.AddRead(response); get_runner.SetupParserAndSendRequest(); get_runner.ReadHeaders(); EXPECT_EQ(100, get_runner.response_info()->headers->response_code()); int64_t status100_size = status100.size(); EXPECT_EQ(status100_size, get_runner.parser()->received_bytes()); get_runner.ReadHeaders(); EXPECT_EQ(200, get_runner.response_info()->headers->response_code()); EXPECT_EQ(headers_size, get_runner.parser()->received_bytes()); int64_t response_size = headers_size + body.size(); int body_size = body.size(); int read_lengths[] = {body_size, 0}; get_runner.ReadBody(body_size, read_lengths); EXPECT_EQ(response_size, get_runner.parser()->received_bytes()); } // Test that an HttpStreamParser can be read from after it's received headers // and data structures owned by its owner have been deleted. This happens // when a ResponseBodyDrainer is used. TEST(HttpStreamParser, ReadAfterUnownedObjectsDestroyed) { MockWrite writes[] = { MockWrite(SYNCHRONOUS, 0, "GET /foo.html HTTP/1.1\r\n\r\n"), }; const int kBodySize = 1; MockRead reads[] = { MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 OK\r\n"), MockRead(SYNCHRONOUS, 2, "Content-Length: 1\r\n"), MockRead(SYNCHRONOUS, 3, "Connection: Keep-Alive\r\n\r\n"), MockRead(SYNCHRONOUS, 4, "1"), MockRead(SYNCHRONOUS, 0, 5), // EOF }; SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes)); std::unique_ptr socket_handle = CreateConnectedSocketHandle(&data); std::unique_ptr request_info(new HttpRequestInfo()); request_info->method = "GET"; request_info->url = GURL("http://somewhere/foo.html"); scoped_refptr read_buffer(new GrowableIOBuffer); HttpStreamParser parser(socket_handle.get(), request_info.get(), read_buffer.get(), NetLogWithSource()); std::unique_ptr request_headers(new HttpRequestHeaders()); std::unique_ptr response_info(new HttpResponseInfo()); TestCompletionCallback callback; ASSERT_EQ(OK, parser.SendRequest("GET /foo.html HTTP/1.1\r\n", *request_headers, response_info.get(), callback.callback())); ASSERT_THAT(parser.ReadResponseHeaders(callback.callback()), IsOk()); // If the object that owns the HttpStreamParser is deleted, it takes the // objects passed to the HttpStreamParser with it. request_info.reset(); request_headers.reset(); response_info.reset(); scoped_refptr body_buffer(new IOBuffer(kBodySize)); ASSERT_EQ(kBodySize, parser.ReadResponseBody( body_buffer.get(), kBodySize, callback.callback())); EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)), parser.sent_bytes()); EXPECT_EQ(CountReadBytes(reads, arraysize(reads)), parser.received_bytes()); } } // namespace } // namespace net