// Copyright 2014 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "extensions/browser/image_loader.h" #include #include "base/bind.h" #include "base/files/file_path.h" #include "base/json/json_file_value_serializer.h" #include "base/path_service.h" #include "base/run_loop.h" #include "base/stl_util.h" #include "base/strings/string_util.h" #include "content/public/test/test_browser_context.h" #include "extensions/browser/extension_registry.h" #include "extensions/browser/extensions_browser_client.h" #include "extensions/browser/extensions_test.h" #include "extensions/browser/unloaded_extension_reason.h" #include "extensions/common/constants.h" #include "extensions/common/extension.h" #include "extensions/common/extension_icon_set.h" #include "extensions/common/extension_paths.h" #include "extensions/common/extension_resource.h" #include "extensions/common/manifest.h" #include "extensions/common/manifest_handlers/icons_handler.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/skia/include/core/SkBitmap.h" #include "ui/gfx/geometry/size.h" #include "ui/gfx/image/image.h" #include "ui/gfx/image/image_family.h" #include "ui/gfx/image/image_skia.h" namespace extensions { class ImageLoaderTest : public ExtensionsTest { public: ImageLoaderTest() : image_loaded_count_(0), quit_in_image_loaded_(false) {} void OnImageLoaded(const gfx::Image& image) { image_loaded_count_++; if (quit_in_image_loaded_) base::RunLoop::QuitCurrentWhenIdleDeprecated(); image_ = image; } void OnImageFamilyLoaded(gfx::ImageFamily image_family) { image_loaded_count_++; if (quit_in_image_loaded_) base::RunLoop::QuitCurrentWhenIdleDeprecated(); image_family_ = std::move(image_family); } void WaitForImageLoad() { quit_in_image_loaded_ = true; base::RunLoop().Run(); quit_in_image_loaded_ = false; } int image_loaded_count() { int result = image_loaded_count_; image_loaded_count_ = 0; return result; } scoped_refptr CreateExtension(const char* dir_name, Manifest::Location location) { // Create and load an extension. base::FilePath extension_dir; if (!base::PathService::Get(DIR_TEST_DATA, &extension_dir)) { EXPECT_FALSE(true); return nullptr; } extension_dir = extension_dir.AppendASCII(dir_name); int error_code = 0; std::string error; JSONFileValueDeserializer deserializer( extension_dir.AppendASCII("manifest.json")); std::unique_ptr valid_value = base::DictionaryValue::From( deserializer.Deserialize(&error_code, &error)); EXPECT_EQ(0, error_code) << error; if (error_code != 0) return nullptr; EXPECT_TRUE(valid_value.get()); if (!valid_value) return nullptr; return Extension::Create( extension_dir, location, *valid_value, Extension::NO_FLAGS, &error); } gfx::Image image_; gfx::ImageFamily image_family_; private: int image_loaded_count_; bool quit_in_image_loaded_; }; // Tests loading an image works correctly. TEST_F(ImageLoaderTest, LoadImage) { scoped_refptr extension( CreateExtension("image_loader", Manifest::INVALID_LOCATION)); ASSERT_TRUE(extension.get() != nullptr); ExtensionResource image_resource = IconsInfo::GetIconResource(extension.get(), extension_misc::EXTENSION_ICON_SMALLISH, ExtensionIconSet::MATCH_EXACTLY); gfx::Size max_size(extension_misc::EXTENSION_ICON_SMALLISH, extension_misc::EXTENSION_ICON_SMALLISH); ImageLoader loader; loader.LoadImageAsync( extension.get(), image_resource, max_size, base::BindOnce(&ImageLoaderTest::OnImageLoaded, base::Unretained(this))); // The image isn't cached, so we should not have received notification. EXPECT_EQ(0, image_loaded_count()); WaitForImageLoad(); // We should have gotten the image. EXPECT_FALSE(image_.IsEmpty()); EXPECT_EQ(1, image_loaded_count()); // Check that the image was loaded. EXPECT_EQ(extension_misc::EXTENSION_ICON_SMALLISH, image_.ToSkBitmap()->width()); } // Tests deleting an extension while waiting for the image to load doesn't cause // problems. TEST_F(ImageLoaderTest, DeleteExtensionWhileWaitingForCache) { scoped_refptr extension( CreateExtension("image_loader", Manifest::INVALID_LOCATION)); ASSERT_TRUE(extension.get() != nullptr); ExtensionResource image_resource = IconsInfo::GetIconResource(extension.get(), extension_misc::EXTENSION_ICON_SMALLISH, ExtensionIconSet::MATCH_EXACTLY); gfx::Size max_size(extension_misc::EXTENSION_ICON_SMALLISH, extension_misc::EXTENSION_ICON_SMALLISH); ImageLoader loader; std::set sizes; sizes.insert(extension_misc::EXTENSION_ICON_SMALLISH); loader.LoadImageAsync( extension.get(), image_resource, max_size, base::BindOnce(&ImageLoaderTest::OnImageLoaded, base::Unretained(this))); // The image isn't cached, so we should not have received notification. EXPECT_EQ(0, image_loaded_count()); // Send out notification the extension was uninstalled. ExtensionRegistry::Get(browser_context()) ->TriggerOnUnloaded(extension.get(), UnloadedExtensionReason::UNINSTALL); // Chuck the extension, that way if anyone tries to access it we should crash // or get valgrind errors. extension = nullptr; WaitForImageLoad(); // Even though we deleted the extension, we should still get the image. // We should still have gotten the image. EXPECT_EQ(1, image_loaded_count()); // Check that the image was loaded. EXPECT_EQ(extension_misc::EXTENSION_ICON_SMALLISH, image_.ToSkBitmap()->width()); } // Tests loading multiple dimensions of the same image. TEST_F(ImageLoaderTest, MultipleImages) { scoped_refptr extension( CreateExtension("image_loader", Manifest::INVALID_LOCATION)); ASSERT_TRUE(extension.get() != nullptr); std::vector info_list; int sizes[] = {extension_misc::EXTENSION_ICON_BITTY, extension_misc::EXTENSION_ICON_SMALLISH, }; for (size_t i = 0; i < base::size(sizes); ++i) { ExtensionResource resource = IconsInfo::GetIconResource( extension.get(), sizes[i], ExtensionIconSet::MATCH_EXACTLY); info_list.push_back(ImageLoader::ImageRepresentation( resource, ImageLoader::ImageRepresentation::RESIZE_WHEN_LARGER, gfx::Size(sizes[i], sizes[i]), 1.f)); } ImageLoader loader; loader.LoadImagesAsync( extension.get(), info_list, base::BindOnce(&ImageLoaderTest::OnImageLoaded, base::Unretained(this))); // The image isn't cached, so we should not have received notification. EXPECT_EQ(0, image_loaded_count()); WaitForImageLoad(); // We should have gotten the image. EXPECT_EQ(1, image_loaded_count()); // Check that all images were loaded. std::vector image_reps = image_.ToImageSkia()->image_reps(); ASSERT_EQ(2u, image_reps.size()); const gfx::ImageSkiaRep* img_rep1 = &image_reps[0]; const gfx::ImageSkiaRep* img_rep2 = &image_reps[1]; EXPECT_EQ(extension_misc::EXTENSION_ICON_BITTY, img_rep1->pixel_width()); EXPECT_EQ(extension_misc::EXTENSION_ICON_SMALLISH, img_rep2->pixel_width()); } // Tests loading multiple dimensions of the same image into an image family. TEST_F(ImageLoaderTest, LoadImageFamily) { scoped_refptr extension( CreateExtension("image_loader", Manifest::INVALID_LOCATION)); ASSERT_TRUE(extension.get() != nullptr); std::vector info_list; int sizes[] = {extension_misc::EXTENSION_ICON_BITTY, extension_misc::EXTENSION_ICON_SMALLISH, }; for (size_t i = 0; i < base::size(sizes); ++i) { ExtensionResource resource = IconsInfo::GetIconResource( extension.get(), sizes[i], ExtensionIconSet::MATCH_EXACTLY); info_list.push_back(ImageLoader::ImageRepresentation( resource, ImageLoader::ImageRepresentation::NEVER_RESIZE, gfx::Size(sizes[i], sizes[i]), 1.f)); } // Add a second icon of 200P which should get grouped with the smaller icon's // ImageSkia. ExtensionResource resource = IconsInfo::GetIconResource(extension.get(), extension_misc::EXTENSION_ICON_SMALLISH, ExtensionIconSet::MATCH_EXACTLY); info_list.push_back(ImageLoader::ImageRepresentation( resource, ImageLoader::ImageRepresentation::NEVER_RESIZE, gfx::Size(extension_misc::EXTENSION_ICON_BITTY, extension_misc::EXTENSION_ICON_BITTY), 2.f)); ImageLoader loader; loader.LoadImageFamilyAsync( extension.get(), info_list, base::BindOnce(&ImageLoaderTest::OnImageFamilyLoaded, base::Unretained(this))); // The image isn't cached, so we should not have received notification. EXPECT_EQ(0, image_loaded_count()); WaitForImageLoad(); // We should have gotten the image. EXPECT_EQ(1, image_loaded_count()); // Check that all images were loaded. for (size_t i = 0; i < base::size(sizes); ++i) { const gfx::Image* image = image_family_.GetBest(sizes[i], sizes[i]); EXPECT_EQ(sizes[i], image->Width()); } // Check the smaller image has 2 representations of different scale factors. std::vector image_reps = image_family_.GetBest(extension_misc::EXTENSION_ICON_BITTY, extension_misc::EXTENSION_ICON_BITTY) ->ToImageSkia() ->image_reps(); ASSERT_EQ(2u, image_reps.size()); const gfx::ImageSkiaRep* img_rep1 = &image_reps[0]; const gfx::ImageSkiaRep* img_rep2 = &image_reps[1]; EXPECT_EQ(extension_misc::EXTENSION_ICON_BITTY, img_rep1->pixel_width()); EXPECT_EQ(1.0f, img_rep1->scale()); EXPECT_EQ(extension_misc::EXTENSION_ICON_SMALLISH, img_rep2->pixel_width()); EXPECT_EQ(2.0f, img_rep2->scale()); } } // namespace extensions