From 32f5a1c56531e4210bc4cf8d8c7825d66e081888 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Wed, 18 Nov 2020 16:35:47 +0100 Subject: BASELINE: Update Chromium to 87.0.4280.67 Change-Id: Ib157360be8c2ffb2c73125751a89f60e049c1d54 Reviewed-by: Allan Sandfeld Jensen --- chromium/styleguide/c++/c++11.html | 15 +++++++- chromium/styleguide/inclusive_code.md | 6 +-- chromium/styleguide/java/java.md | 3 +- chromium/styleguide/web/es.md | 69 --------------------------------- chromium/styleguide/web/web.md | 72 +++++++++++++++-------------------- 5 files changed, 49 insertions(+), 116 deletions(-) (limited to 'chromium/styleguide') diff --git a/chromium/styleguide/c++/c++11.html b/chromium/styleguide/c++/c++11.html index 633c649666b..1e4c7329bbd 100644 --- a/chromium/styleguide/c++/c++11.html +++ b/chromium/styleguide/c++/c++11.html @@ -51,7 +51,10 @@ The current status of existing standards and Abseil features is:
  • C++14: Default allowed; see banned features below
  • C++17: Not yet supported in Chromium, unlikely before mid-2021; tracking bug
  • C++20: Not yet standardized
    • -
  • Abseil: Initially supported July 31, 2020; see allowed/banned/TBD features below
    • +
  • Abseil: Initially supported July 31, 2020; see allowed/banned/TBD features below +
      +
    • absl::StatusOr: Initially supported September 3, 2020
      • +

    • @@ -405,7 +408,7 @@ absl::InlinedVector, absl::FixedArray auto it = absl::c_find(container, value); Container-based versions of algorithmic functions within C++ standard library. container.h -Overlaps with base/util/ranges/algorithm.h. +Overlaps with base/ranges/algorithm.h. @@ -441,6 +444,14 @@ size_t index = absl::Uniform(bitgen, 0u, elems.size()); + +StatusOr +absl::StatusOr<T> +An object that is either a usable value, or an error Status explaining why such a value is not present. +statusor.h + + + String Formatting absl::StrFormat diff --git a/chromium/styleguide/inclusive_code.md b/chromium/styleguide/inclusive_code.md index 22a03436b27..2626653d159 100644 --- a/chromium/styleguide/inclusive_code.md +++ b/chromium/styleguide/inclusive_code.md @@ -105,9 +105,9 @@ changing their meanings, but particular instances may need other replacements. For a long list of changes, see [this bug](https://crbug.com/842296). Some examples: -* ["Blacklist"->"Blocklist" in interventions-internals UI.](https://crrev.com/1055905) -* [Remove "whitelist" and "blacklist" from extension docs.](https://crrev.com/1056027) -* [Declarative Net Request: Replace usages of 'blacklist' and 'whitelist'.](https://crrev.com/1094141) +* ["Blacklist"->"Blocklist" in interventions-internals UI.](https://crrev.com/c/1055905) +* [Remove "whitelist" and "blacklist" from extension docs.](https://crrev.com/c/1056027) +* [Declarative Net Request: Replace usages of 'blacklist' and 'whitelist'.](https://crrev.com/c/1094141) ## Thanks diff --git a/chromium/styleguide/java/java.md b/chromium/styleguide/java/java.md index 36ebfcae49f..f5bc1b0d895 100644 --- a/chromium/styleguide/java/java.md +++ b/chromium/styleguide/java/java.md @@ -121,7 +121,8 @@ Custom finalizers: * causes additional garbage collector jank. Classes that need destructor logic should provide an explicit `destroy()` -method. +method. Use [LifetimeAssert](https://chromium.googlesource.com/chromium/src/+/master/base/android/java/src/org/chromium/base/LifetimeAssert.java) +to ensure in debug builds and tests that `destroy()` is called. ### Other Android Support Library Annotations * Use them! They are [documented here](https://developer.android.com/studio/write/annotations). diff --git a/chromium/styleguide/web/es.md b/chromium/styleguide/web/es.md index ab52d3fca29..3d7b2766c68 100644 --- a/chromium/styleguide/web/es.md +++ b/chromium/styleguide/web/es.md @@ -14,75 +14,6 @@ hyphen-hyphen-hyphen (change to actual hyphen) --> - - - - # ECMAScript Features in Chromium This doc extends the [style guide](web.md#JavaScript) by specifying which new diff --git a/chromium/styleguide/web/web.md b/chromium/styleguide/web/web.md index 344e87e6f88..bbf61f3ce65 100644 --- a/chromium/styleguide/web/web.md +++ b/chromium/styleguide/web/web.md @@ -1,13 +1,3 @@ - - # Chromium Web Development Style Guide [TOC] @@ -25,10 +15,10 @@ This guide follows and builds on: * [Google JavaScript Style Guide](https://google.github.io/styleguide/jsguide.html) * [Google Polymer Style Guide](http://go/polymer-style) -
    -Concerns for browser compatibility are usually not relevant for Chromium-only -code. -
    +*** aside +Note: Concerns for browser compatibility are usually not relevant for +Chromium-only code. +*** ## Separation of presentation and content @@ -73,14 +63,14 @@ document.querySelector('b').onclick = fireZeeMissiles; DON'T: ```html -LAUNCH BUTTON WARNING +LAUNCH BUTTON WARNING ``` -
    -For various technical and historical reasons, code using the Polymer library may -use on-event-style event listener wiring and -<style> tags that live inside of .html files. -
    +*** aside +Note: For various technical and historical reasons, code using the Polymer +library may use `on-event`-style event listener wiring and `