From 51f6c2793adab2d864b3d2b360000ef8db1d3e92 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Mon, 10 Dec 2018 16:19:40 +0100 Subject: BASELINE: Update Chromium to 71.0.3578.93 Change-Id: I6a32086c33670e1b033f8b10e6bf1fd4da1d105d Reviewed-by: Alexandru Croitor --- .../components/constrained_window/constrained_window_views.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'chromium/components/constrained_window/constrained_window_views.h') diff --git a/chromium/components/constrained_window/constrained_window_views.h b/chromium/components/constrained_window/constrained_window_views.h index 42e901854bd..d78c4d0d32d 100644 --- a/chromium/components/constrained_window/constrained_window_views.h +++ b/chromium/components/constrained_window/constrained_window_views.h @@ -51,12 +51,6 @@ content::WebContents* GetTopLevelWebContents( // notify via WillClose() when it is being destroyed. void ShowModalDialog(gfx::NativeWindow dialog, content::WebContents* web_contents); -#if defined(OS_MACOSX) -// Temporary shim for Polychrome. See bottom of first comment in -// https://crbug.com/804950 for details. -void ShowModalDialogCocoa(gfx::NativeWindow dialog, - content::WebContents* web_contents); -#endif // Calls CreateWebModalDialogViews, shows the dialog, and returns its widget. views::Widget* ShowWebModalDialogViews( @@ -84,6 +78,12 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog, // appropriately if |parent| is a valid browser window. Currently, |parent| may // be null for MODAL_TYPE_WINDOW, but that's a bug and callers shouldn't rely on // that working. See http://crbug.com/657293. +// For dialogs that may appear without direct user interaction (i.e., that may +// appear while a user is busily accomplishing some other task in the browser), +// consider providing an override of GetDefaultDialogButton on |dialog| to +// suppress the normal behavior of choosing a focused-by-default button. This is +// especially important if the action of the default button has consequences on +// the user's task at hand. views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog, gfx::NativeWindow parent); -- cgit v1.2.1