From 79e2dad9ede84883b66feb83a7334febf20f2748 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCri=20Valdmann?= Date: Mon, 27 Aug 2018 18:41:43 +0000 Subject: [Backport] Skip deleted object files in POSIX base::debug::StackTrace The file names read from /proc/self/maps can contain a special " (deleted)" suffix to indicate that the file has been deleted (unlinked). This is expected and should not trigger a LOG(WARNING). Change-Id: Ia96b3bf1894c8fbd6bfa0c217bc8a01bbb59d750 Reviewed-on: https://chromium-review.googlesource.com/1186622 Reviewed-by: Lei Zhang Commit-Queue: Lei Zhang Cr-Commit-Position: refs/heads/master@{#586334} Task-number: QTBUG-68547 Reviewed-by: Peter Varga --- chromium/base/debug/stack_trace_posix.cc | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'chromium/base') diff --git a/chromium/base/debug/stack_trace_posix.cc b/chromium/base/debug/stack_trace_posix.cc index f3f05dad26b..54a22c0cc9f 100644 --- a/chromium/base/debug/stack_trace_posix.cc +++ b/chromium/base/debug/stack_trace_posix.cc @@ -49,6 +49,7 @@ #include "base/numerics/safe_conversions.h" #include "base/posix/eintr_wrapper.h" #include "base/strings/string_number_conversions.h" +#include "base/strings/string_util.h" #include "build/build_config.h" #if defined(USE_SYMBOLIZE) @@ -690,6 +691,11 @@ class SandboxSymbolizeHelper { // Skip pseudo-paths, like [stack], [vdso], [heap], etc ... continue; } + if (base::EndsWith(region.path, " (deleted)", + base::CompareCase::SENSITIVE)) { + // Skip deleted files. + continue; + } // Avoid duplicates. if (modules_.find(region.path) == modules_.end()) { int fd = open(region.path.c_str(), O_RDONLY | O_CLOEXEC); -- cgit v1.2.1