From c30a6232df03e1efbd9f3b226777b07e087a1122 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Mon, 12 Oct 2020 14:27:29 +0200 Subject: BASELINE: Update Chromium to 85.0.4183.140 Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057 Reviewed-by: Allan Sandfeld Jensen --- chromium/base/containers/stack_container_unittest.cc | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'chromium/base/containers/stack_container_unittest.cc') diff --git a/chromium/base/containers/stack_container_unittest.cc b/chromium/base/containers/stack_container_unittest.cc index 7fa609556a7..e0f5dc5baeb 100644 --- a/chromium/base/containers/stack_container_unittest.cc +++ b/chromium/base/containers/stack_container_unittest.cc @@ -8,6 +8,7 @@ #include +#include "base/memory/aligned_memory.h" #include "base/memory/ref_counted.h" #include "build/build_config.h" #include "testing/gtest/include/gtest/gtest.h" @@ -16,14 +17,14 @@ namespace base { namespace { -class Dummy : public base::RefCounted { +class Dummy : public RefCounted { public: explicit Dummy(int* alive) : alive_(alive) { ++*alive_; } private: - friend class base::RefCounted; + friend class RefCounted; ~Dummy() { --*alive_; @@ -110,31 +111,28 @@ class AlignedData { alignas(alignment) char data_[alignment]; }; -} // anonymous namespace - -#define EXPECT_ALIGNED(ptr, align) \ - EXPECT_EQ(0u, reinterpret_cast(ptr) & (align - 1)) +} // namespace TEST(StackContainer, BufferAlignment) { StackVector text; text->push_back(L'A'); - EXPECT_ALIGNED(&text[0], alignof(wchar_t)); + EXPECT_TRUE(IsAligned(&text[0], alignof(wchar_t))); StackVector doubles; doubles->push_back(0.0); - EXPECT_ALIGNED(&doubles[0], alignof(double)); + EXPECT_TRUE(IsAligned(&doubles[0], alignof(double))); StackVector, 1> aligned16; aligned16->push_back(AlignedData<16>()); - EXPECT_ALIGNED(&aligned16[0], 16); + EXPECT_TRUE(IsAligned(&aligned16[0], 16)); #if !defined(__GNUC__) || defined(ARCH_CPU_X86_FAMILY) // It seems that non-X86 gcc doesn't respect greater than 16 byte alignment. // See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721 for details. - // TODO(sbc):re-enable this if GCC starts respecting higher alignments. + // TODO(sbc): Re-enable this if GCC starts respecting higher alignments. StackVector, 1> aligned256; aligned256->push_back(AlignedData<256>()); - EXPECT_ALIGNED(&aligned256[0], 256); + EXPECT_TRUE(IsAligned(&aligned256[0], 256)); #endif } -- cgit v1.2.1