From 1b5dc494c6547be044ab5fed57dc0419bba3f950 Mon Sep 17 00:00:00 2001 From: Peter Varga Date: Fri, 16 May 2014 13:34:31 +0200 Subject: Fix Renderer and GPU threads on windows These threads are using the UI message loop on Windows per default. This won't work since the UI message loop is handled by Qt and the Renderer and GPU threads won't work with it properly. Force these threads for using the default message loop as they use it on Linux platform. Change-Id: Ie3582583e5d1644faa2875e015a0908ba148d91f Reviewed-by: Andras Becsi Reviewed-by: Jocelyn Turcotte --- chromium/content/browser/gpu/gpu_process_host.cc | 6 ++++++ chromium/content/browser/renderer_host/render_process_host_impl.cc | 2 +- chromium/content/renderer/renderer_main.cc | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/chromium/content/browser/gpu/gpu_process_host.cc b/chromium/content/browser/gpu/gpu_process_host.cc index 1b7da1c8d7c..c28ba8b7499 100644 --- a/chromium/content/browser/gpu/gpu_process_host.cc +++ b/chromium/content/browser/gpu/gpu_process_host.cc @@ -577,7 +577,13 @@ bool GpuProcessHost::Init() { switches::kDisableGpuWatchdog); in_process_gpu_thread_.reset(g_gpu_main_thread_factory(channel_id)); +#if defined(OS_WIN) && defined(TOOLKIT_QT) + base::Thread::Options options; + options.message_loop_type = base::MessageLoop::TYPE_DEFAULT; + in_process_gpu_thread_->StartWithOptions(options); +#else in_process_gpu_thread_->Start(); +#endif OnProcessLaunched(); // Fake a callback that the process is ready. } else if (!LaunchGpuProcess(channel_id)) { diff --git a/chromium/content/browser/renderer_host/render_process_host_impl.cc b/chromium/content/browser/renderer_host/render_process_host_impl.cc index 5d975e9119d..b5a5c497106 100644 --- a/chromium/content/browser/renderer_host/render_process_host_impl.cc +++ b/chromium/content/browser/renderer_host/render_process_host_impl.cc @@ -512,7 +512,7 @@ bool RenderProcessHostImpl::Init() { in_process_renderer_.reset(g_renderer_main_thread_factory(channel_id)); base::Thread::Options options; -#if defined(OS_WIN) && !defined(OS_MACOSX) +#if defined(OS_WIN) && !defined(OS_MACOSX) && !defined(TOOLKIT_QT) // In-process plugins require this to be a UI message loop. options.message_loop_type = base::MessageLoop::TYPE_UI; #else diff --git a/chromium/content/renderer/renderer_main.cc b/chromium/content/renderer/renderer_main.cc index f0c16d27815..5330d21a564 100644 --- a/chromium/content/renderer/renderer_main.cc +++ b/chromium/content/renderer/renderer_main.cc @@ -161,6 +161,8 @@ int RendererMain(const MainFunctionParams& parameters) { // As long as we use Cocoa in the renderer (for the forseeable future as of // now; see http://crbug.com/306348 for info) we need to have a UI loop. base::MessageLoop main_message_loop(base::MessageLoop::TYPE_UI); +#elif defined(OS_WIN) && defined(TOOLKIT_QT) + base::MessageLoop main_message_loop(base::MessageLoop::TYPE_DEFAULT); #else // The main message loop of the renderer services doesn't have IO or UI tasks, // unless in-process-plugins is used. -- cgit v1.2.1