diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-07-17 13:57:45 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-07-19 13:44:40 +0000 |
| commit | 6ec7b8da05d21a3878bd21c691b41e675d74bb1c (patch) | |
| tree | b87f250bc19413750b9bb9cdbf2da20ef5014820 /chromium/third_party/checkstyle | |
| parent | ec02ee4181c49b61fce1c8fb99292dbb8139cc90 (diff) | |
| download | qtwebengine-chromium-6ec7b8da05d21a3878bd21c691b41e675d74bb1c.tar.gz | |
BASELINE: Update Chromium to 60.0.3112.70
Change-Id: I9911c2280a014d4632f254857876a395d4baed2d
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'chromium/third_party/checkstyle')
| -rw-r--r-- | chromium/third_party/checkstyle/OWNERS | 6 | ||||
| -rw-r--r-- | chromium/third_party/checkstyle/README.chromium | 22 | ||||
| -rw-r--r-- | chromium/third_party/checkstyle/checkstyle-6.5-all.jar | bin | 4822657 -> 0 bytes | |||
| -rw-r--r-- | chromium/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 | 1 |
4 files changed, 24 insertions, 5 deletions
diff --git a/chromium/third_party/checkstyle/OWNERS b/chromium/third_party/checkstyle/OWNERS index 812e8d9572e..3daedd9631e 100644 --- a/chromium/third_party/checkstyle/OWNERS +++ b/chromium/third_party/checkstyle/OWNERS @@ -1 +1,5 @@ -aurimas@chromium.org +agrieve@chromium.org +jbudorick@chromium.org +nyquist@chromium.org +zpeng@chromium.org + diff --git a/chromium/third_party/checkstyle/README.chromium b/chromium/third_party/checkstyle/README.chromium index e84fcf8fe8d..25b28ed4755 100644 --- a/chromium/third_party/checkstyle/README.chromium +++ b/chromium/third_party/checkstyle/README.chromium @@ -1,8 +1,8 @@ Name: Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. Short Name: checkstyle -URL: http://checkstyle.sourceforge.net/ -Version: 6.5 +URL: https://github.com/checkstyle/checkstyle +Version: 7.6.1 License: LGPL 2.1 License File: NOT_SHIPPED Security Critical: no @@ -11,5 +11,19 @@ Description: Checkstyle is used to validate Java code style on Chromium PRESUBMIT step. Local Modifications: -- Downloaded checkstyle-6.5-all.jar without source code development - documentation. +None + +Update instructions (requires @google.com account): +- Download fat jar from https://sourceforge.net/projects/checkstyle/files/checkstyle/ +- Modify tools/android/checkstyle/checkstyle.py and verify the new fat jar works +- Remove existing SHA1 file +- If gcloud auth tokens are not set up, run +$ download_from_google_storage --config +- Upload new fat jar to gcloud. In third_party/checkstyle, run +$ upload_to_google_storage.py -b chromium-android-tools/checkstyle {new_far_jar} +- Check in new SHA1 file +- Before submitting the change, verify presubmit works fine by: + 1) modifying a Java file and including it in the patch + 2) running the chromium_presubmit trybot in the CQ on the patch + 3) reverting the Java file change + diff --git a/chromium/third_party/checkstyle/checkstyle-6.5-all.jar b/chromium/third_party/checkstyle/checkstyle-6.5-all.jar Binary files differdeleted file mode 100644 index b4f571fc6d8..00000000000 --- a/chromium/third_party/checkstyle/checkstyle-6.5-all.jar +++ /dev/null diff --git a/chromium/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 b/chromium/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 new file mode 100644 index 00000000000..e0aec8e6dc3 --- /dev/null +++ b/chromium/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 @@ -0,0 +1 @@ +c6889fa07ec9afb0ca8029be75de31dc29dc4f05
\ No newline at end of file |