diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-05-03 13:42:47 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-05-15 10:27:51 +0000 |
commit | 8c5c43c7b138c9b4b0bf56d946e61d3bbc111bec (patch) | |
tree | d29d987c4d7b173cf853279b79a51598f104b403 /chromium/components/spellcheck/renderer/spellcheck.cc | |
parent | 830c9e163d31a9180fadca926b3e1d7dfffb5021 (diff) | |
download | qtwebengine-chromium-8c5c43c7b138c9b4b0bf56d946e61d3bbc111bec.tar.gz |
BASELINE: Update Chromium to 66.0.3359.156
Change-Id: I0c9831ad39911a086b6377b16f995ad75a51e441
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Diffstat (limited to 'chromium/components/spellcheck/renderer/spellcheck.cc')
-rw-r--r-- | chromium/components/spellcheck/renderer/spellcheck.cc | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/chromium/components/spellcheck/renderer/spellcheck.cc b/chromium/components/spellcheck/renderer/spellcheck.cc index 387beca7edc..3c0016d394b 100644 --- a/chromium/components/spellcheck/renderer/spellcheck.cc +++ b/chromium/components/spellcheck/renderer/spellcheck.cc @@ -7,6 +7,7 @@ #include <stddef.h> #include <stdint.h> #include <algorithm> +#include <memory> #include <utility> #include "base/bind.h" @@ -30,7 +31,6 @@ #include "content/public/renderer/render_frame.h" #include "content/public/renderer/render_frame_visitor.h" #include "content/public/renderer/render_thread.h" -#include "services/service_manager/public/cpp/binder_registry.h" #include "third_party/WebKit/public/platform/WebString.h" #include "third_party/WebKit/public/platform/WebVector.h" #include "third_party/WebKit/public/web/WebLocalFrame.h" @@ -171,22 +171,17 @@ class SpellCheck::SpellcheckRequest { // values. // TODO(groby): Simplify this. SpellCheck::SpellCheck( + service_manager::BinderRegistry* registry, service_manager::LocalInterfaceProvider* embedder_provider) - : embedder_provider_(embedder_provider), spellcheck_enabled_(true) { - if (!content::ChildThread::Get()) + : embedder_provider_(embedder_provider), + spellcheck_enabled_(true), + weak_factory_(this) { + DCHECK(embedder_provider); + if (!registry) return; // Can be NULL in tests. - - auto* service_manager_connection = - content::ChildThread::Get()->GetServiceManagerConnection(); - DCHECK(service_manager_connection); - - auto registry = base::MakeUnique<service_manager::BinderRegistry>(); registry->AddInterface(base::BindRepeating(&SpellCheck::SpellCheckerRequest, - base::Unretained(this)), + weak_factory_.GetWeakPtr()), base::ThreadTaskRunnerHandle::Get()); - - service_manager_connection->AddConnectionFilter( - base::MakeUnique<content::SimpleConnectionFilter>(std::move(registry))); } SpellCheck::~SpellCheck() { @@ -265,7 +260,7 @@ void SpellCheck::CustomDictionaryChanged( void SpellCheck::AddSpellcheckLanguage(base::File file, const std::string& language) { languages_.push_back( - base::MakeUnique<SpellcheckLanguage>(embedder_provider_)); + std::make_unique<SpellcheckLanguage>(embedder_provider_)); languages_.back()->Init(std::move(file), language); } |