From 23e8618566930a1fd9a67d8a659fc6d1d056f819 Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Thu, 20 Dec 2012 11:01:22 +0100 Subject: Fix crash when running in a QGuiApplication A QGuiApplication has no style so crashes on a null pointer or asserts in qtbase Changed test to not depend on widgets so we get a QGuiApplication instead of a QApplication Change-Id: Ib4dcc8f8679d3e6b8c11f7ccd5b2539c9de0803b Reviewed-by: Richard J. Moore Reviewed-by: David Faure (KDE) --- src/plugins/iconengines/svgiconengine/qsvgiconengine.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/plugins/iconengines/svgiconengine/qsvgiconengine.cpp b/src/plugins/iconengines/svgiconengine/qsvgiconengine.cpp index 902e59d..6d84df1 100644 --- a/src/plugins/iconengines/svgiconengine/qsvgiconengine.cpp +++ b/src/plugins/iconengines/svgiconengine/qsvgiconengine.cpp @@ -180,11 +180,13 @@ QPixmap QSvgIconEngine::pixmap(const QSize &size, QIcon::Mode mode, renderer.render(&p); p.end(); pm = QPixmap::fromImage(img); - QStyleOption opt(0); - opt.palette = QApplication::palette(); - QPixmap generated = QApplication::style()->generatedIconPixmap(mode, pm, &opt); - if (!generated.isNull()) - pm = generated; + if (qobject_cast(QCoreApplication::instance())) { + QStyleOption opt(0); + opt.palette = QGuiApplication::palette(); + QPixmap generated = QApplication::style()->generatedIconPixmap(mode, pm, &opt); + if (!generated.isNull()) + pm = generated; + } if (!pm.isNull()) QPixmapCache::insert(pmckey, pm); -- cgit v1.2.1 From 415553a7f63bcc5b86ee2b18569c3f984114a780 Mon Sep 17 00:00:00 2001 From: Sergio Ahumada Date: Sat, 22 Dec 2012 00:45:29 +0100 Subject: Bump Qt version to 5.0.1 Change-Id: If9d7570e83aea83399f306f4a21ea0e2c2ec0eab Reviewed-by: Thiago Macieira --- src/svg/doc/qtsvg.qdocconf | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/svg/doc/qtsvg.qdocconf b/src/svg/doc/qtsvg.qdocconf index 2758128..88fd510 100644 --- a/src/svg/doc/qtsvg.qdocconf +++ b/src/svg/doc/qtsvg.qdocconf @@ -4,7 +4,7 @@ include($QT_INSTALL_DOCS/global/qt-module-defaults.qdocconf) project = QtSvg description = Qt SVG Reference Documentation url = http://qt-project.org/doc/qtsvg -version = 5.0.0 +version = 5.0.1 qhp.projects = QtSvg @@ -14,9 +14,9 @@ qhp.QtSvg.virtualFolder = qtsvg qhp.QtSvg.indexTitle = Qt SVG qhp.QtSvg.indexRoot = -qhp.QtSvg.filterAttributes = qtsvg 5.0.0 qtrefdoc -qhp.QtSvg.customFilters.Qt.name = QtSvg 5.0.0 -qhp.QtSvg.customFilters.Qt.filterAttributes = qtsvg 5.0.0 +qhp.QtSvg.filterAttributes = qtsvg 5.0.1 qtrefdoc +qhp.QtSvg.customFilters.Qt.name = QtSvg 5.0.1 +qhp.QtSvg.customFilters.Qt.filterAttributes = qtsvg 5.0.1 qhp.QtSvg.subprojects = classes qhp.QtSvg.subprojects.classes.title = C++ Classes qhp.QtSvg.subprojects.classes.indexTitle = Qt SVG C++ Classes -- cgit v1.2.1 From fece2474fe7915db73c7cc4cc115cdac2f636377 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 21 Dec 2012 23:38:55 -0800 Subject: Fix a bad virtual override Problem found by Clang. It took me a while to notice the missing "s" qsvggenerator.cpp:177:10: error: 'QSvgPaintEngine::drawImage' hides overloaded virtual function [-Werror,-Woverloaded-virtual] Change-Id: If95e299f12dea62344efee4a2c542b6474314b0e Reviewed-by: Gunnar Sletta --- src/svg/qsvggenerator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/svg/qsvggenerator.cpp b/src/svg/qsvggenerator.cpp index 47f760b..74efc65 100644 --- a/src/svg/qsvggenerator.cpp +++ b/src/svg/qsvggenerator.cpp @@ -175,7 +175,7 @@ public: void drawPolygon(const QPointF *points, int pointCount, PolygonDrawMode mode); void drawTextItem(const QPointF &pt, const QTextItem &item); void drawImage(const QRectF &r, const QImage &pm, const QRectF &sr, - Qt::ImageConversionFlag = Qt::AutoColor); + Qt::ImageConversionFlags flags = Qt::AutoColor); QPaintEngine::Type type() const { return QPaintEngine::SVG; } @@ -907,7 +907,7 @@ void QSvgPaintEngine::drawPixmap(const QRectF &r, const QPixmap &pm, void QSvgPaintEngine::drawImage(const QRectF &r, const QImage &image, const QRectF &sr, - Qt::ImageConversionFlag flags) + Qt::ImageConversionFlags flags) { //Q_D(QSvgPaintEngine); -- cgit v1.2.1