summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2020-09-12 21:36:20 +0200
committerLars Knoll <lars.knoll@qt.io>2020-09-12 21:37:32 +0200
commit79dc1809151c572cf60f9e8c73c95983562b6100 (patch)
tree0dc63630ab3c6de74c50b6da8077d88ee1788cf9
parent73a95d9794f4fd5ea9f946f7a48b82e3675e3475 (diff)
downloadqtsvg-79dc1809151c572cf60f9e8c73c95983562b6100.tar.gz
Work around uninitialized variable in QRadialGradient
Specify the focal radius explicitly to avoid an uninitialized variable in QGradient. Change-Id: I40e44579e2364862a8bc23ef54a9e858c4ba837a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
-rw-r--r--src/svg/qsvghandler.cpp2
-rw-r--r--tests/auto/qsvggenerator/tst_qsvggenerator.cpp4
2 files changed, 3 insertions, 3 deletions
diff --git a/src/svg/qsvghandler.cpp b/src/svg/qsvghandler.cpp
index 15fb46b..523efa6 100644
--- a/src/svg/qsvghandler.cpp
+++ b/src/svg/qsvghandler.cpp
@@ -3013,7 +3013,7 @@ static QSvgStyleProperty *createRadialGradientNode(QSvgNode *node,
if (!fy.isEmpty())
nfy = toDouble(fy);
- QRadialGradient *grad = new QRadialGradient(ncx, ncy, nr, nfx, nfy);
+ QRadialGradient *grad = new QRadialGradient(ncx, ncy, nr, nfx, nfy, 0);
grad->setInterpolationMode(QGradient::ComponentInterpolation);
QSvgGradientStyle *prop = new QSvgGradientStyle(grad);
diff --git a/tests/auto/qsvggenerator/tst_qsvggenerator.cpp b/tests/auto/qsvggenerator/tst_qsvggenerator.cpp
index 1ad729c..4f626c3 100644
--- a/tests/auto/qsvggenerator/tst_qsvggenerator.cpp
+++ b/tests/auto/qsvggenerator/tst_qsvggenerator.cpp
@@ -270,7 +270,7 @@ void tst_QSvgGenerator::radialGradient()
generator.setFileName(fileName);
QCOMPARE(generator.fileName(), fileName);
- QRadialGradient gradient(QPointF(0.5, 0.5), 0.5, QPointF(0.5, 0.5));
+ QRadialGradient gradient(QPointF(0.5, 0.5), 0.5, QPointF(0.5, 0.5), 0);
gradient.setInterpolationMode(QGradient::ComponentInterpolation);
gradient.setColorAt(0, Qt::red);
gradient.setColorAt(1, Qt::blue);
@@ -279,7 +279,7 @@ void tst_QSvgGenerator::radialGradient()
QPainter painter(&generator);
painter.fillRect(0, 0, 100, 100, gradient);
- gradient = QRadialGradient(QPointF(150, 50), 50, QPointF(150, 50));
+ gradient = QRadialGradient(QPointF(150, 50), 50, QPointF(150, 50), 0);
gradient.setInterpolationMode(QGradient::ComponentInterpolation);
gradient.setColorAt(0, Qt::red);
gradient.setColorAt(1, Qt::blue);