From e0be9ed761e730bec7b26bcaba014f028f6340d0 Mon Sep 17 00:00:00 2001 From: Laszlo Papp Date: Sat, 23 Nov 2013 21:49:33 +0000 Subject: Fix the detection of PCI serial ports with sysfs and without udev Unfortunately, 0973537c5471288726b929250199a41435729bee caused a serious regression for obtaining detecting PCI serial ports without udev. This was working before since the hard coded fallback mechanism has been up to this task, but the sysfs alternative took the precedence over. A note has also been added to the udev part of the algorithm because we will need to obtain the vendor and product identifiers in a separate block in the future. The vid/pid will be fixed in a separate change once that is well-tested. This patch has no any risk as far as I can tell since it is just adding a new short block to the existing code without much implication. I have tested the change on Linux for my use cases with Qt 4 and then 5, and I cannot find any regression. Everything works as expected both with udev and without, i.e. with sysfs. Thanks go to Aaron Linville for reporting the issue. Task-number: QTBUG-35064 Change-Id: Ieae6f3e94559fb61ede67ff1d8810bb686d46383 Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov Reviewed-by: Aaron Linville --- dist/changes-5.2.0 | 3 +++ 1 file changed, 3 insertions(+) (limited to 'dist') diff --git a/dist/changes-5.2.0 b/dist/changes-5.2.0 index 20fd35c..7f3e4c2 100644 --- a/dist/changes-5.2.0 +++ b/dist/changes-5.2.0 @@ -121,3 +121,6 @@ information. /dev/ttyO* (native OMAP UART) is supported by that backend. - The lock file usage has been extended to support Android as there is no direct access to the usual Unix lock file system paths. The lock file is now placed into /data/local/tmp. + +- [QTBUG-35064] PCI support has been added to the sysfs backend on Linux to +support the enumeration of such devices. -- cgit v1.2.1 From f77043dbef5a2f2b3c81b07b95e1f63ea9921fd4 Mon Sep 17 00:00:00 2001 From: Laszlo Papp Date: Thu, 28 Nov 2013 03:48:05 +0000 Subject: Obsolete the isValid() method in QSerialPortInfo Task-number: QTBUG-35184 Change-Id: Ie822943bcaf071024bc4f9782441b0534fcbd43d Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- dist/changes-5.2.0 | 3 +++ 1 file changed, 3 insertions(+) (limited to 'dist') diff --git a/dist/changes-5.2.0 b/dist/changes-5.2.0 index 7f3e4c2..51e3d44 100644 --- a/dist/changes-5.2.0 +++ b/dist/changes-5.2.0 @@ -124,3 +124,6 @@ into /data/local/tmp. - [QTBUG-35064] PCI support has been added to the sysfs backend on Linux to support the enumeration of such devices. + +- [QTBUG-35184] Mark the isValid() method in QSerialPortInfo deprecated because +it has no common use case. -- cgit v1.2.1 From 5fabe1c180994dda64bae2a86a8a38bab6bef86b Mon Sep 17 00:00:00 2001 From: Laszlo Papp Date: Fri, 29 Nov 2013 06:17:49 +0000 Subject: Obsolete the QSerialPort::UnknownParity enum value in QSerialPort Task-number: QTBUG-35215 Change-Id: I53af65ba485216a6fde238245580fe0422a2ed9a Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- dist/changes-5.2.0 | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'dist') diff --git a/dist/changes-5.2.0 b/dist/changes-5.2.0 index 51e3d44..a51701e 100644 --- a/dist/changes-5.2.0 +++ b/dist/changes-5.2.0 @@ -127,3 +127,7 @@ support the enumeration of such devices. - [QTBUG-35184] Mark the isValid() method in QSerialPortInfo deprecated because it has no common use case. + +- [QTBUG-35215] Mark the QSerialPort::UnknownParity method in QSerialPort +deprecated because it has no use case, and was added mistakenly. There is no +such a "standard" serial port parity behavior. -- cgit v1.2.1 From fdd3876111605e84a1f7c31206e20cd99e13f1fb Mon Sep 17 00:00:00 2001 From: Laszlo Papp Date: Sat, 30 Nov 2013 19:21:37 +0000 Subject: Deprecate further Unknown* property values similarly to UnknownParity Task-number: QTBUG-35215 Change-Id: Id8175af00c431cc8f80f05d518b3a2ee0e8ac71b Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- dist/changes-5.2.0 | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'dist') diff --git a/dist/changes-5.2.0 b/dist/changes-5.2.0 index a51701e..dae347e 100644 --- a/dist/changes-5.2.0 +++ b/dist/changes-5.2.0 @@ -64,9 +64,6 @@ now. - [QTBUG-33774] Document that the serial port parameters cannot be set before opening. -- Add an "UnknownSignal" value for the pinout signals. This is now the returned -value when the pinout state of the signals cannot be detected properly. - - No more unnecessary syscalls (parameter settings, pinout signal query, etc) in the backend when the port is closed. This also means no improper errors are set accordingly. @@ -128,6 +125,7 @@ support the enumeration of such devices. - [QTBUG-35184] Mark the isValid() method in QSerialPortInfo deprecated because it has no common use case. -- [QTBUG-35215] Mark the QSerialPort::UnknownParity method in QSerialPort +- [QTBUG-35215] Mark the QSerialPort::Unknown* enumeration values in QSerialPort deprecated because it has no use case, and was added mistakenly. There is no -such a "standard" serial port parity behavior. +such "standard" serial port behavior general for these as "unknown". It is an +implementation detail for error reporting, and hence not recommended anymore. -- cgit v1.2.1