From 9b19e9ce6cb3ed753fee3a659534398d730fb629 Mon Sep 17 00:00:00 2001 From: Kai Koehne Date: Wed, 8 Jun 2016 13:17:57 +0200 Subject: Mention license change in 5.7.0 changelog. Change-Id: I8e9dc9b230b13e14deef912fedcc3f4cdde582e6 Task-number: QTBUG-53913 Reviewed-by: Denis Shienkov --- dist/changes-5.7.0 | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/dist/changes-5.7.0 b/dist/changes-5.7.0 index 27e9ddb..efe98ab 100644 --- a/dist/changes-5.7.0 +++ b/dist/changes-5.7.0 @@ -1,7 +1,7 @@ -QtSerialPort 5.7 introduces a few new features and improvements as well as -bugfixes over the 5.6.x series. For more details, refer to the online -documentation included in this distribution. The documentation is also available -online: +Qt 5.7 introduces many new features and improvements as well as bugfixes +over the 5.6.x series. Also, there is a change in the licensing terms. +For more details, refer to the online documentation included in this +distribution. The documentation is also available online: http://doc.qt.io/qt-5/index.html @@ -16,6 +16,21 @@ corresponding to tasks in the Qt Bug Tracker: Each of these identifiers can be entered in the bug tracker to obtain more information about a particular change. +**************************************************************************** +* Important License Changes * +**************************************************************************** + + This module is no longer available under LGPLv2.1. The libraries are + now available under the following licenses: + * Commercial License + * GNU General Public License v2.0 (LICENSE.GPL2) and later + * GNU Lesser General Public License v3.0 (LICENSE.LGPL3) + + The tools are now available under the following licenses: + * Commercial License + * GNU General Public License 3.0 (LICENSE.GPL3) with exceptions + described in The Qt Company GPL Exception 1.0 (LICENSE.GPL3-EXCEPT) + **************************************************************************** * Library * **************************************************************************** -- cgit v1.2.1 From 2430d5a36656ff4bc01b42f76d82e053608ad2eb Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Sat, 11 Jun 2016 16:11:13 +0300 Subject: Replace remaining foreach with range-based for Change-Id: I1fe4be17d8e998ba25ecb6dde53f487eacd2b128 Reviewed-by: Anton Kudryavtsev Reviewed-by: Oswald Buddenhagen --- examples/serialport/master/dialog.cpp | 3 ++- examples/serialport/slave/dialog.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/serialport/master/dialog.cpp b/examples/serialport/master/dialog.cpp index 2c92404..cd9615f 100644 --- a/examples/serialport/master/dialog.cpp +++ b/examples/serialport/master/dialog.cpp @@ -74,7 +74,8 @@ Dialog::Dialog(QWidget *parent) , statusLabel(new QLabel(tr("Status: Not running."))) , runButton(new QPushButton(tr("Start"))) { - foreach (const QSerialPortInfo &info, QSerialPortInfo::availablePorts()) + const auto infos = QSerialPortInfo::availablePorts(); + for (const QSerialPortInfo &info : infos) serialPortComboBox->addItem(info.portName()); waitResponseSpinBox->setRange(0, 10000); diff --git a/examples/serialport/slave/dialog.cpp b/examples/serialport/slave/dialog.cpp index 5bc0561..a4ce48a 100644 --- a/examples/serialport/slave/dialog.cpp +++ b/examples/serialport/slave/dialog.cpp @@ -77,7 +77,8 @@ Dialog::Dialog(QWidget *parent) waitRequestSpinBox->setRange(0, 10000); waitRequestSpinBox->setValue(20); - foreach (const QSerialPortInfo &info, QSerialPortInfo::availablePorts()) + const auto infos = QSerialPortInfo::availablePorts(); + for (const QSerialPortInfo &info : infos) serialPortComboBox->addItem(info.portName()); QGridLayout *mainLayout = new QGridLayout; -- cgit v1.2.1 From bfc1ed24bd2ebc94b3e0c5bd17d860fe251e2b30 Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Thu, 9 Jun 2016 21:39:49 +0300 Subject: Use auto in more cases Change-Id: Id4fd74d4d45b28ddc60de6308386728a0eda8bb7 Reviewed-by: Oswald Buddenhagen Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- examples/serialport/blockingmaster/dialog.cpp | 2 +- examples/serialport/blockingslave/dialog.cpp | 2 +- examples/serialport/enumerator/main.cpp | 6 +++--- examples/serialport/master/dialog.cpp | 2 +- examples/serialport/slave/dialog.cpp | 2 +- tests/auto/qserialport/tst_qserialport.cpp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/serialport/blockingmaster/dialog.cpp b/examples/serialport/blockingmaster/dialog.cpp index c1ca850..08403c3 100644 --- a/examples/serialport/blockingmaster/dialog.cpp +++ b/examples/serialport/blockingmaster/dialog.cpp @@ -81,7 +81,7 @@ Dialog::Dialog(QWidget *parent) waitResponseSpinBox->setRange(0, 10000); waitResponseSpinBox->setValue(1000); - QGridLayout *mainLayout = new QGridLayout; + auto mainLayout = new QGridLayout; mainLayout->addWidget(serialPortLabel, 0, 0); mainLayout->addWidget(serialPortComboBox, 0, 1); mainLayout->addWidget(waitResponseLabel, 1, 0); diff --git a/examples/serialport/blockingslave/dialog.cpp b/examples/serialport/blockingslave/dialog.cpp index 8550773..3bfd419 100644 --- a/examples/serialport/blockingslave/dialog.cpp +++ b/examples/serialport/blockingslave/dialog.cpp @@ -81,7 +81,7 @@ Dialog::Dialog(QWidget *parent) for (const QSerialPortInfo &info : infos) serialPortComboBox->addItem(info.portName()); - QGridLayout *mainLayout = new QGridLayout; + auto mainLayout = new QGridLayout; mainLayout->addWidget(serialPortLabel, 0, 0); mainLayout->addWidget(serialPortComboBox, 0, 1); mainLayout->addWidget(waitRequestLabel, 1, 0); diff --git a/examples/serialport/enumerator/main.cpp b/examples/serialport/enumerator/main.cpp index fa925da..d7622a2 100644 --- a/examples/serialport/enumerator/main.cpp +++ b/examples/serialport/enumerator/main.cpp @@ -62,7 +62,7 @@ int main(int argc, char *argv[]) { QApplication a(argc, argv); - QVBoxLayout *layout = new QVBoxLayout; + auto layout = new QVBoxLayout; const auto infos = QSerialPortInfo::availablePorts(); for (const QSerialPortInfo &info : infos) { @@ -75,11 +75,11 @@ int main(int argc, char *argv[]) + QObject::tr("Product Identifier: ") + (info.hasProductIdentifier() ? QString::number(info.productIdentifier(), 16) : QString()) + "\n" + QObject::tr("Busy: ") + (info.isBusy() ? QObject::tr("Yes") : QObject::tr("No")) + "\n"; - QLabel *label = new QLabel(s); + auto label = new QLabel(s); layout->addWidget(label); } - QWidget *workPage = new QWidget; + auto workPage = new QWidget; workPage->setLayout(layout); QScrollArea area; diff --git a/examples/serialport/master/dialog.cpp b/examples/serialport/master/dialog.cpp index cd9615f..4bed08b 100644 --- a/examples/serialport/master/dialog.cpp +++ b/examples/serialport/master/dialog.cpp @@ -81,7 +81,7 @@ Dialog::Dialog(QWidget *parent) waitResponseSpinBox->setRange(0, 10000); waitResponseSpinBox->setValue(100); - QGridLayout *mainLayout = new QGridLayout; + auto mainLayout = new QGridLayout; mainLayout->addWidget(serialPortLabel, 0, 0); mainLayout->addWidget(serialPortComboBox, 0, 1); mainLayout->addWidget(waitResponseLabel, 1, 0); diff --git a/examples/serialport/slave/dialog.cpp b/examples/serialport/slave/dialog.cpp index a4ce48a..d801052 100644 --- a/examples/serialport/slave/dialog.cpp +++ b/examples/serialport/slave/dialog.cpp @@ -81,7 +81,7 @@ Dialog::Dialog(QWidget *parent) for (const QSerialPortInfo &info : infos) serialPortComboBox->addItem(info.portName()); - QGridLayout *mainLayout = new QGridLayout; + auto mainLayout = new QGridLayout; mainLayout->addWidget(serialPortLabel, 0, 0); mainLayout->addWidget(serialPortComboBox, 0, 1); mainLayout->addWidget(waitRequestLabel, 1, 0); diff --git a/tests/auto/qserialport/tst_qserialport.cpp b/tests/auto/qserialport/tst_qserialport.cpp index b9d41b8..24c0134 100644 --- a/tests/auto/qserialport/tst_qserialport.cpp +++ b/tests/auto/qserialport/tst_qserialport.cpp @@ -995,7 +995,7 @@ private: void tst_QSerialPort::synchronousReadWriteAfterAsynchronousReadWrite() { MasterTransactor master(m_senderPortName); - SlaveTransactor *slave = new SlaveTransactor(m_receiverPortName); + auto slave = new SlaveTransactor(m_receiverPortName); QThread thread; slave->moveToThread(&thread); -- cgit v1.2.1 From 6dc22556f55dffc4c018e82f952a7cf6c8da66dd Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Sat, 4 Jun 2016 16:52:35 +0300 Subject: Replace 'Q_NULLPTR' and 'NULL' with 'nullptr' We can use nullptr since Qt 5.7. Change-Id: Id5354280d6a94b2c1f4c5967c65a22db878eca3e Reviewed-by: Anton Kudryavtsev Reviewed-by: Oswald Buddenhagen Reviewed-by: Denis Shienkov --- src/serialport/qserialport.h | 6 +++--- src/serialport/qserialport_unix.cpp | 6 +++--- src/serialport/qserialport_win.cpp | 18 +++++++++--------- src/serialport/qserialportinfo.cpp | 2 +- src/serialport/qserialportinfo_freebsd.cpp | 18 +++++++++--------- src/serialport/qserialportinfo_win.cpp | 12 ++++++------ src/serialport/qtudev_p.h | 2 +- 7 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h index 4772724..3289ca1 100644 --- a/src/serialport/qserialport.h +++ b/src/serialport/qserialport.h @@ -200,9 +200,9 @@ public: #endif #endif - explicit QSerialPort(QObject *parent = Q_NULLPTR); - explicit QSerialPort(const QString &name, QObject *parent = Q_NULLPTR); - explicit QSerialPort(const QSerialPortInfo &info, QObject *parent = Q_NULLPTR); + explicit QSerialPort(QObject *parent = nullptr); + explicit QSerialPort(const QString &name, QObject *parent = nullptr); + explicit QSerialPort(const QSerialPortInfo &info, QObject *parent = nullptr); virtual ~QSerialPort(); void setPortName(const QString &name); diff --git a/src/serialport/qserialport_unix.cpp b/src/serialport/qserialport_unix.cpp index 7078040..acc53c8 100644 --- a/src/serialport/qserialport_unix.cpp +++ b/src/serialport/qserialport_unix.cpp @@ -251,14 +251,14 @@ void QSerialPortPrivate::close() #endif delete readNotifier; - readNotifier = Q_NULLPTR; + readNotifier = nullptr; delete writeNotifier; - writeNotifier = Q_NULLPTR; + writeNotifier = nullptr; qt_safe_close(descriptor); - lockFileScopedPointer.reset(Q_NULLPTR); + lockFileScopedPointer.reset(nullptr); descriptor = -1; pendingBytesWritten = 0; diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp index b41af02..7cbb81d 100644 --- a/src/serialport/qserialport_win.cpp +++ b/src/serialport/qserialport_win.cpp @@ -94,7 +94,7 @@ bool QSerialPortPrivate::open(QIODevice::OpenMode mode) desiredAccess |= GENERIC_WRITE; handle = ::CreateFile(reinterpret_cast(systemLocation.utf16()), - desiredAccess, 0, Q_NULLPTR, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, Q_NULLPTR); + desiredAccess, 0, nullptr, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, nullptr); if (handle == INVALID_HANDLE_VALUE) { setError(getSystemError()); @@ -113,10 +113,10 @@ void QSerialPortPrivate::close() ::CancelIo(handle); delete notifier; - notifier = Q_NULLPTR; + notifier = nullptr; delete startAsyncWriteTimer; - startAsyncWriteTimer = Q_NULLPTR; + startAsyncWriteTimer = nullptr; communicationStarted = false; readStarted = false; @@ -154,9 +154,9 @@ QSerialPort::PinoutSignals QSerialPortPrivate::pinoutSignals() ret |= QSerialPort::DataCarrierDetectSignal; DWORD bytesReturned = 0; - if (!::DeviceIoControl(handle, IOCTL_SERIAL_GET_DTRRTS, Q_NULLPTR, 0, + if (!::DeviceIoControl(handle, IOCTL_SERIAL_GET_DTRRTS, nullptr, 0, &modemStat, sizeof(modemStat), - &bytesReturned, Q_NULLPTR)) { + &bytesReturned, nullptr)) { setError(getSystemError()); return ret; } @@ -507,7 +507,7 @@ bool QSerialPortPrivate::startAsyncRead() } ::ZeroMemory(&readCompletionOverlapped, sizeof(readCompletionOverlapped)); - if (::ReadFile(handle, readChunkBuffer.data(), bytesToRead, Q_NULLPTR, &readCompletionOverlapped)) { + if (::ReadFile(handle, readChunkBuffer.data(), bytesToRead, nullptr, &readCompletionOverlapped)) { readStarted = true; return true; } @@ -534,7 +534,7 @@ bool QSerialPortPrivate::_q_startAsyncWrite() const int writeBytes = writeBuffer.nextDataBlockSize(); ::ZeroMemory(&writeCompletionOverlapped, sizeof(writeCompletionOverlapped)); if (!::WriteFile(handle, writeBuffer.readPointer(), - writeBytes, Q_NULLPTR, &writeCompletionOverlapped)) { + writeBytes, nullptr, &writeCompletionOverlapped)) { QSerialPortErrorInfo error = getSystemError(); if (error.errorCode != QSerialPort::NoError) { @@ -598,7 +598,7 @@ OVERLAPPED *QSerialPortPrivate::waitForNotified(int msecs) OVERLAPPED *overlapped = notifier->waitForAnyNotified(msecs); if (!overlapped) { setError(getSystemError(WAIT_TIMEOUT)); - return Q_NULLPTR; + return nullptr; } return overlapped; } @@ -606,7 +606,7 @@ OVERLAPPED *QSerialPortPrivate::waitForNotified(int msecs) qint64 QSerialPortPrivate::queuedBytesCount(QSerialPort::Direction direction) const { COMSTAT comstat; - if (::ClearCommError(handle, Q_NULLPTR, &comstat) == 0) + if (::ClearCommError(handle, nullptr, &comstat) == 0) return -1; return (direction == QSerialPort::Input) ? comstat.cbInQue diff --git a/src/serialport/qserialportinfo.cpp b/src/serialport/qserialportinfo.cpp index acd0179..2b69966 100644 --- a/src/serialport/qserialportinfo.cpp +++ b/src/serialport/qserialportinfo.cpp @@ -79,7 +79,7 @@ QSerialPortInfo::QSerialPortInfo() Constructs a copy of \a other. */ QSerialPortInfo::QSerialPortInfo(const QSerialPortInfo &other) - : d_ptr(other.d_ptr ? new QSerialPortInfoPrivate(*other.d_ptr) : Q_NULLPTR) + : d_ptr(other.d_ptr ? new QSerialPortInfoPrivate(*other.d_ptr) : nullptr) { } diff --git a/src/serialport/qserialportinfo_freebsd.cpp b/src/serialport/qserialportinfo_freebsd.cpp index 291cfac..066290d 100644 --- a/src/serialport/qserialportinfo_freebsd.cpp +++ b/src/serialport/qserialportinfo_freebsd.cpp @@ -106,7 +106,7 @@ struct NodeInfo static QVector mibFromName(const QString &name) { size_t mibsize = 0; - if (::sysctlnametomib(name.toLocal8Bit().constData(), Q_NULLPTR, &mibsize) < 0 + if (::sysctlnametomib(name.toLocal8Bit().constData(), nullptr, &mibsize) < 0 || mibsize == 0) { return QVector(); } @@ -126,11 +126,11 @@ static QVector nextOid(const QVector &previousOid) mib.append(code); size_t requiredLength = 0; - if (::sysctl(&mib[0], mib.count(), Q_NULLPTR, &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), nullptr, &requiredLength, nullptr, 0) < 0) return QVector(); const size_t oidLength = requiredLength / sizeof(int); QVector oid(oidLength, 0); - if (::sysctl(&mib[0], mib.count(), &oid[0], &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), &oid[0], &requiredLength, nullptr, 0) < 0) return QVector(); if (previousOid.first() != oid.first()) @@ -149,27 +149,27 @@ static NodeInfo nodeForOid(const QVector &oid) // query node name size_t requiredLength = 0; - if (::sysctl(&mib[0], mib.count(), Q_NULLPTR, &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), nullptr, &requiredLength, nullptr, 0) < 0) return NodeInfo(); QByteArray name(requiredLength, 0); - if (::sysctl(&mib[0], mib.count(), name.data(), &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), name.data(), &requiredLength, nullptr, 0) < 0) return NodeInfo(); // query node value requiredLength = 0; - if (::sysctl(&oid[0], oid.count(), Q_NULLPTR, &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&oid[0], oid.count(), nullptr, &requiredLength, nullptr, 0) < 0) return NodeInfo(); QByteArray value(requiredLength, 0); - if (::sysctl(&oid[0], oid.count(), value.data(), &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&oid[0], oid.count(), value.data(), &requiredLength, nullptr, 0) < 0) return NodeInfo(); // query value format mib[1] = 4; // Magic undocumented code requiredLength = 0; - if (::sysctl(&mib[0], mib.count(), Q_NULLPTR, &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), nullptr, &requiredLength, nullptr, 0) < 0) return NodeInfo(); QByteArray buf(requiredLength, 0); - if (::sysctl(&mib[0], mib.count(), buf.data(), &requiredLength, Q_NULLPTR, 0) < 0) + if (::sysctl(&mib[0], mib.count(), buf.data(), &requiredLength, nullptr, 0) < 0) return NodeInfo(); QDataStream in(buf); diff --git a/src/serialport/qserialportinfo_win.cpp b/src/serialport/qserialportinfo_win.cpp index 4a80325..398666e 100644 --- a/src/serialport/qserialportinfo_win.cpp +++ b/src/serialport/qserialportinfo_win.cpp @@ -65,7 +65,7 @@ QT_BEGIN_NAMESPACE static QStringList portNamesFromHardwareDeviceMap() { - HKEY hKey = Q_NULLPTR; + HKEY hKey = nullptr; if (::RegOpenKeyEx(HKEY_LOCAL_MACHINE, L"HARDWARE\\DEVICEMAP\\SERIALCOMM", 0, KEY_QUERY_VALUE, &hKey) != ERROR_SUCCESS) return QStringList(); @@ -82,7 +82,7 @@ static QStringList portNamesFromHardwareDeviceMap() for (;;) { DWORD requiredValueNameChars = MaximumValueNameInChars; const LONG ret = ::RegEnumValue(hKey, index, &outputValueName[0], &requiredValueNameChars, - Q_NULLPTR, Q_NULLPTR, reinterpret_cast(&outputBuffer[0]), &bytesRequired); + nullptr, nullptr, reinterpret_cast(&outputBuffer[0]), &bytesRequired); if (ret == ERROR_MORE_DATA) { outputBuffer.resize(bytesRequired / sizeof(wchar_t) + 2, 0); } else if (ret == ERROR_SUCCESS) { @@ -166,7 +166,7 @@ static QString devicePortName(HDEVINFO deviceInfoSet, PSP_DEVINFO_DATA deviceInf std::vector outputBuffer(MAX_PATH + 1, 0); DWORD bytesRequired = MAX_PATH; for (;;) { - const LONG ret = ::RegQueryValueEx(key, keyTokens[i], Q_NULLPTR, &dataType, + const LONG ret = ::RegQueryValueEx(key, keyTokens[i], nullptr, &dataType, reinterpret_cast(&outputBuffer[0]), &bytesRequired); if (ret == ERROR_MORE_DATA) { outputBuffer.resize(bytesRequired / sizeof(wchar_t) + 2, 0); @@ -304,7 +304,7 @@ QList QSerialPortInfo::availablePorts() QList serialPortInfoList; for (int i = 0; i < SetupTokensCount; ++i) { - const HDEVINFO deviceInfoSet = ::SetupDiGetClassDevs(&setupTokens[i].guid, Q_NULLPTR, Q_NULLPTR, setupTokens[i].flags); + const HDEVINFO deviceInfoSet = ::SetupDiGetClassDevs(&setupTokens[i].guid, nullptr, nullptr, setupTokens[i].flags); if (deviceInfoSet == INVALID_HANDLE_VALUE) return serialPortInfoList; @@ -362,7 +362,7 @@ QList QSerialPortInfo::availablePorts() bool QSerialPortInfo::isBusy() const { const HANDLE handle = ::CreateFile(reinterpret_cast(systemLocation().utf16()), - GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, Q_NULLPTR); + GENERIC_READ | GENERIC_WRITE, 0, nullptr, OPEN_EXISTING, 0, nullptr); if (handle == INVALID_HANDLE_VALUE) { if (::GetLastError() == ERROR_ACCESS_DENIED) @@ -378,7 +378,7 @@ bool QSerialPortInfo::isBusy() const bool QSerialPortInfo::isValid() const { const HANDLE handle = ::CreateFile(reinterpret_cast(systemLocation().utf16()), - GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, Q_NULLPTR); + GENERIC_READ | GENERIC_WRITE, 0, nullptr, OPEN_EXISTING, 0, nullptr); if (handle == INVALID_HANDLE_VALUE) { if (::GetLastError() != ERROR_ACCESS_DENIED) diff --git a/src/serialport/qtudev_p.h b/src/serialport/qtudev_p.h index aad2dfe..af2dab2 100644 --- a/src/serialport/qtudev_p.h +++ b/src/serialport/qtudev_p.h @@ -74,7 +74,7 @@ struct udev; #define udev_list_entry_foreach(list_entry, first_entry) \ for (list_entry = first_entry; \ - list_entry != NULL; \ + list_entry != nullptr; \ list_entry = udev_list_entry_get_next(list_entry)) struct udev_device; -- cgit v1.2.1 From 118cc17c8637bd0b63b8ebda74624126c2cf5cd2 Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Sat, 18 Jun 2016 14:31:11 +0300 Subject: Add 'explicit' keyword where possible to the examples Change-Id: I7338288caf0d3fcb1ecd52d0e6724aa51c108505 Reviewed-by: Anton Kudryavtsev Reviewed-by: Sergey Belyashov Reviewed-by: Oswald Buddenhagen Reviewed-by: Denis Shienkov --- examples/serialport/blockingmaster/dialog.h | 2 +- examples/serialport/blockingmaster/masterthread.h | 2 +- examples/serialport/blockingslave/dialog.h | 2 +- examples/serialport/blockingslave/slavethread.h | 2 +- examples/serialport/creaderasync/serialportreader.h | 2 +- examples/serialport/cwriterasync/serialportwriter.h | 2 +- examples/serialport/master/dialog.h | 2 +- examples/serialport/slave/dialog.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/serialport/blockingmaster/dialog.h b/examples/serialport/blockingmaster/dialog.h index 4f0e331..6b6ba70 100644 --- a/examples/serialport/blockingmaster/dialog.h +++ b/examples/serialport/blockingmaster/dialog.h @@ -70,7 +70,7 @@ class Dialog : public QDialog Q_OBJECT public: - Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = 0); private slots: void transaction(); diff --git a/examples/serialport/blockingmaster/masterthread.h b/examples/serialport/blockingmaster/masterthread.h index ffb6602..acfd4d9 100644 --- a/examples/serialport/blockingmaster/masterthread.h +++ b/examples/serialport/blockingmaster/masterthread.h @@ -61,7 +61,7 @@ class MasterThread : public QThread Q_OBJECT public: - MasterThread(QObject *parent = 0); + explicit MasterThread(QObject *parent = 0); ~MasterThread(); void transaction(const QString &portName, int waitTimeout, const QString &request); diff --git a/examples/serialport/blockingslave/dialog.h b/examples/serialport/blockingslave/dialog.h index 4e01656..9f16c98 100644 --- a/examples/serialport/blockingslave/dialog.h +++ b/examples/serialport/blockingslave/dialog.h @@ -70,7 +70,7 @@ class Dialog : public QDialog Q_OBJECT public: - Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = 0); private slots: void startSlave(); diff --git a/examples/serialport/blockingslave/slavethread.h b/examples/serialport/blockingslave/slavethread.h index d678a7b..64ab13e 100644 --- a/examples/serialport/blockingslave/slavethread.h +++ b/examples/serialport/blockingslave/slavethread.h @@ -61,7 +61,7 @@ class SlaveThread : public QThread Q_OBJECT public: - SlaveThread(QObject *parent = 0); + explicit SlaveThread(QObject *parent = 0); ~SlaveThread(); void startSlave(const QString &portName, int waitTimeout, const QString &response); diff --git a/examples/serialport/creaderasync/serialportreader.h b/examples/serialport/creaderasync/serialportreader.h index 6c0a2c5..e723c8f 100644 --- a/examples/serialport/creaderasync/serialportreader.h +++ b/examples/serialport/creaderasync/serialportreader.h @@ -69,7 +69,7 @@ class SerialPortReader : public QObject Q_OBJECT public: - SerialPortReader(QSerialPort *serialPort, QObject *parent = 0); + explicit SerialPortReader(QSerialPort *serialPort, QObject *parent = 0); ~SerialPortReader(); private slots: diff --git a/examples/serialport/cwriterasync/serialportwriter.h b/examples/serialport/cwriterasync/serialportwriter.h index a4bc32e..347d005 100644 --- a/examples/serialport/cwriterasync/serialportwriter.h +++ b/examples/serialport/cwriterasync/serialportwriter.h @@ -69,7 +69,7 @@ class SerialPortWriter : public QObject Q_OBJECT public: - SerialPortWriter(QSerialPort *serialPort, QObject *parent = 0); + explicit SerialPortWriter(QSerialPort *serialPort, QObject *parent = 0); ~SerialPortWriter(); void write(const QByteArray &writeData); diff --git a/examples/serialport/master/dialog.h b/examples/serialport/master/dialog.h index b981943..d92a6e2 100644 --- a/examples/serialport/master/dialog.h +++ b/examples/serialport/master/dialog.h @@ -73,7 +73,7 @@ class Dialog : public QDialog Q_OBJECT public: - Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = 0); private slots: void sendRequest(); diff --git a/examples/serialport/slave/dialog.h b/examples/serialport/slave/dialog.h index d03c123..21e8bbe 100644 --- a/examples/serialport/slave/dialog.h +++ b/examples/serialport/slave/dialog.h @@ -73,7 +73,7 @@ class Dialog : public QDialog Q_OBJECT public: - Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = 0); private slots: void startSlave(); -- cgit v1.2.1 From 5939163c59f4df8a479913195ae5458614c0d1bc Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Mon, 20 Jun 2016 18:14:40 +0300 Subject: Add remaining 'Q_DECL_OVERRIDE' to the examples Change-Id: Ib9590b862413e66189b9f2fde9297af374981b4d Reviewed-by: Anton Kudryavtsev Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- examples/serialport/blockingmaster/masterthread.h | 2 +- examples/serialport/blockingslave/slavethread.h | 2 +- examples/serialport/terminal/console.h | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/serialport/blockingmaster/masterthread.h b/examples/serialport/blockingmaster/masterthread.h index acfd4d9..a00ad6a 100644 --- a/examples/serialport/blockingmaster/masterthread.h +++ b/examples/serialport/blockingmaster/masterthread.h @@ -65,7 +65,7 @@ public: ~MasterThread(); void transaction(const QString &portName, int waitTimeout, const QString &request); - void run(); + void run() Q_DECL_OVERRIDE; signals: void response(const QString &s); diff --git a/examples/serialport/blockingslave/slavethread.h b/examples/serialport/blockingslave/slavethread.h index 64ab13e..0d1ff2f 100644 --- a/examples/serialport/blockingslave/slavethread.h +++ b/examples/serialport/blockingslave/slavethread.h @@ -65,7 +65,7 @@ public: ~SlaveThread(); void startSlave(const QString &portName, int waitTimeout, const QString &response); - void run(); + void run() Q_DECL_OVERRIDE; signals: void request(const QString &s); diff --git a/examples/serialport/terminal/console.h b/examples/serialport/terminal/console.h index 03b0fb1..5805d8c 100644 --- a/examples/serialport/terminal/console.h +++ b/examples/serialport/terminal/console.h @@ -69,10 +69,10 @@ public: void setLocalEchoEnabled(bool set); protected: - virtual void keyPressEvent(QKeyEvent *e); - virtual void mousePressEvent(QMouseEvent *e); - virtual void mouseDoubleClickEvent(QMouseEvent *e); - virtual void contextMenuEvent(QContextMenuEvent *e); + void keyPressEvent(QKeyEvent *e) Q_DECL_OVERRIDE; + void mousePressEvent(QMouseEvent *e) Q_DECL_OVERRIDE; + void mouseDoubleClickEvent(QMouseEvent *e) Q_DECL_OVERRIDE; + void contextMenuEvent(QContextMenuEvent *e) Q_DECL_OVERRIDE; private: bool localEchoEnabled; -- cgit v1.2.1 From 9df15226d3e7cbf8e601432d706c199f6ec3d112 Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Fri, 24 Jun 2016 08:53:28 +0300 Subject: Replace remaining 0 to nullptr in the examples Change-Id: If867000fe1101c58bc9d48e3794536e46cde6fec Reviewed-by: Anton Kudryavtsev Reviewed-by: Sergey Belyashov Reviewed-by: Denis Shienkov --- examples/serialport/blockingmaster/dialog.h | 2 +- examples/serialport/blockingmaster/masterthread.h | 2 +- examples/serialport/blockingslave/dialog.h | 2 +- examples/serialport/blockingslave/slavethread.h | 2 +- examples/serialport/creaderasync/serialportreader.h | 2 +- examples/serialport/cwriterasync/serialportwriter.h | 2 +- examples/serialport/master/dialog.h | 2 +- examples/serialport/slave/dialog.h | 2 +- examples/serialport/terminal/console.h | 2 +- examples/serialport/terminal/mainwindow.h | 2 +- examples/serialport/terminal/settingsdialog.h | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/serialport/blockingmaster/dialog.h b/examples/serialport/blockingmaster/dialog.h index 6b6ba70..aff8177 100644 --- a/examples/serialport/blockingmaster/dialog.h +++ b/examples/serialport/blockingmaster/dialog.h @@ -70,7 +70,7 @@ class Dialog : public QDialog Q_OBJECT public: - explicit Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = nullptr); private slots: void transaction(); diff --git a/examples/serialport/blockingmaster/masterthread.h b/examples/serialport/blockingmaster/masterthread.h index a00ad6a..f23559f 100644 --- a/examples/serialport/blockingmaster/masterthread.h +++ b/examples/serialport/blockingmaster/masterthread.h @@ -61,7 +61,7 @@ class MasterThread : public QThread Q_OBJECT public: - explicit MasterThread(QObject *parent = 0); + explicit MasterThread(QObject *parent = nullptr); ~MasterThread(); void transaction(const QString &portName, int waitTimeout, const QString &request); diff --git a/examples/serialport/blockingslave/dialog.h b/examples/serialport/blockingslave/dialog.h index 9f16c98..0e59410 100644 --- a/examples/serialport/blockingslave/dialog.h +++ b/examples/serialport/blockingslave/dialog.h @@ -70,7 +70,7 @@ class Dialog : public QDialog Q_OBJECT public: - explicit Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = nullptr); private slots: void startSlave(); diff --git a/examples/serialport/blockingslave/slavethread.h b/examples/serialport/blockingslave/slavethread.h index 0d1ff2f..9a15e24 100644 --- a/examples/serialport/blockingslave/slavethread.h +++ b/examples/serialport/blockingslave/slavethread.h @@ -61,7 +61,7 @@ class SlaveThread : public QThread Q_OBJECT public: - explicit SlaveThread(QObject *parent = 0); + explicit SlaveThread(QObject *parent = nullptr); ~SlaveThread(); void startSlave(const QString &portName, int waitTimeout, const QString &response); diff --git a/examples/serialport/creaderasync/serialportreader.h b/examples/serialport/creaderasync/serialportreader.h index e723c8f..6698087 100644 --- a/examples/serialport/creaderasync/serialportreader.h +++ b/examples/serialport/creaderasync/serialportreader.h @@ -69,7 +69,7 @@ class SerialPortReader : public QObject Q_OBJECT public: - explicit SerialPortReader(QSerialPort *serialPort, QObject *parent = 0); + explicit SerialPortReader(QSerialPort *serialPort, QObject *parent = nullptr); ~SerialPortReader(); private slots: diff --git a/examples/serialport/cwriterasync/serialportwriter.h b/examples/serialport/cwriterasync/serialportwriter.h index 347d005..9fd305f 100644 --- a/examples/serialport/cwriterasync/serialportwriter.h +++ b/examples/serialport/cwriterasync/serialportwriter.h @@ -69,7 +69,7 @@ class SerialPortWriter : public QObject Q_OBJECT public: - explicit SerialPortWriter(QSerialPort *serialPort, QObject *parent = 0); + explicit SerialPortWriter(QSerialPort *serialPort, QObject *parent = nullptr); ~SerialPortWriter(); void write(const QByteArray &writeData); diff --git a/examples/serialport/master/dialog.h b/examples/serialport/master/dialog.h index d92a6e2..0bc1241 100644 --- a/examples/serialport/master/dialog.h +++ b/examples/serialport/master/dialog.h @@ -73,7 +73,7 @@ class Dialog : public QDialog Q_OBJECT public: - explicit Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = nullptr); private slots: void sendRequest(); diff --git a/examples/serialport/slave/dialog.h b/examples/serialport/slave/dialog.h index 21e8bbe..0405cf8 100644 --- a/examples/serialport/slave/dialog.h +++ b/examples/serialport/slave/dialog.h @@ -73,7 +73,7 @@ class Dialog : public QDialog Q_OBJECT public: - explicit Dialog(QWidget *parent = 0); + explicit Dialog(QWidget *parent = nullptr); private slots: void startSlave(); diff --git a/examples/serialport/terminal/console.h b/examples/serialport/terminal/console.h index 5805d8c..0674ded 100644 --- a/examples/serialport/terminal/console.h +++ b/examples/serialport/terminal/console.h @@ -62,7 +62,7 @@ signals: void getData(const QByteArray &data); public: - explicit Console(QWidget *parent = 0); + explicit Console(QWidget *parent = nullptr); void putData(const QByteArray &data); diff --git a/examples/serialport/terminal/mainwindow.h b/examples/serialport/terminal/mainwindow.h index 9e8c1c1..b792895 100644 --- a/examples/serialport/terminal/mainwindow.h +++ b/examples/serialport/terminal/mainwindow.h @@ -76,7 +76,7 @@ class MainWindow : public QMainWindow Q_OBJECT public: - explicit MainWindow(QWidget *parent = 0); + explicit MainWindow(QWidget *parent = nullptr); ~MainWindow(); private slots: diff --git a/examples/serialport/terminal/settingsdialog.h b/examples/serialport/terminal/settingsdialog.h index da17565..ea249c1 100644 --- a/examples/serialport/terminal/settingsdialog.h +++ b/examples/serialport/terminal/settingsdialog.h @@ -87,7 +87,7 @@ public: bool localEchoEnabled; }; - explicit SettingsDialog(QWidget *parent = 0); + explicit SettingsDialog(QWidget *parent = nullptr); ~SettingsDialog(); Settings settings() const; -- cgit v1.2.1