| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Listing important changes and bug-fixes.
Change-Id: If72171427d5cf3de39f9404e15dc3b394d78a265
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | |
| | |
| | |
| | | |
Change-Id: Ifc7f1e60966489b0352ef326a7fa5d141eee8d8f
|
| |/
| |
| |
| |
| |
| |
| |
| | |
'bytesToRead' takes the result of signed 64-bit computation which could
be negative. So, its type should be qint64.
Change-Id: Ib51129143fcb70475ad383df417ae4282c858e41
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This patch replicates commit 225ef1baeb0e49f157f3ba1271915e623bd27dd9
for Windows.
Change-Id: Ic4e3444183289e7ce1a487500633fb5ad95590b9
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the user calls setReadBufferSize() with a value lesser than the
current size of the read buffer, then we get UB in readNotification():
readFromPort(nullptr, some_negative_value);
Change-Id: Iddf5838c84c8615670285e9883c48f29faacc07e
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We should not add the size of the internal write buffer here because
QIODevice::bytesToWrite() already checks it. Also, take into account
the size of 'writeChunkBuffer' on Windows.
Change-Id: I87dfcb4dd1cd9d2bbb6f82a084d79fb4db9323d8
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This module is not yet supported on INTEGRITY and
therefore we'll exclude it from the CI build.
Change-Id: Ia08354f0680865f0a2e08a3a3e3f59a88e98bd4e
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
... as this function is implemented in cpp file.
Change-Id: Ia5a0c262ebdb4b98b4575c85ab45fdc93742731f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |\
| | |
| | |
| | | |
Change-Id: Ib336529542ae9b78937ad1573fde71ccfcc4c1ad
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The limitations were introduced by the commit 56c001b, but were not
documented.
Change-Id: I5e44ab78e2e5cce2477ebc1f83280fa8c22e0ef6
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added binary compatibility file for qtserialport
Change-Id: Ic676c4a92f798746e43e11bd61deb67a3ad9031b
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | |\
| | | |
| | | |
| | | | |
Change-Id: I589b584f7929c781c814a2e8da680917ec34012f
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ib60b1ce21226d5702ee7c999508a484d9596c9fd
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
... as there are plans to remove it from the QtCore.
Change-Id: I79a2250b7b392896fa1c7307488a74dd44d62736
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Read notifications should be enabled all the time while the device is
opened unless the buffer size limit is reached. To enable the read
notifier again, the user needs to read the data or enlarge the buffer
with a setReadBufferSize() call.
According to that scenario, it's very likely that the device will
toggle the state of notifier twice (on->off->on) in one notification
cycle. This patch prevents this unnecessary toggling by:
- unconditionally setting the notifier's state in setReadBufferSize()/
readData();
- deferring the notification disabling in readNotification() on Unix
and in completeAsyncRead() on Windows to the next notification
cycle.
Change-Id: I97fc041bb705c034a7e73d1437e64b9b34dc2c18
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reduces the number of syscalls and thus the CPU load when dealing
with fast ports. And 32KiB seems still small enough to be no concern on
modern hardware even if it's excessive for a given port.
Change-Id: I4749e4255627d3abf2393323216e01ac6436413b
Reviewed-by: Alex Trotsenko <alex1973tr@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We do not need to use the ifdef guards for the CBR_ constants,
because constants are standard and always exists in native API.
Change-Id: I75ae9ffc17b132786fe5e72791b3f7c82c72c76e
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
... otherwise, this notifier's instance will be active even
if the serial port is not open.
Change-Id: Ieebb894a048f3ed89ac5d1c259e21bc790f5d387
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The event mask variable is used only once in process of initialization,
so we do not need to keep this variable as the class member.
Change-Id: I1f97a312cc92345d435dee821fefb8c2de33665e
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ia9b0851ea7259bc4bc1aa709992b5eb215144a77
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I0dc20fa836888d3caa678fd8f5b620625e00ec92
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
|\ \ \ \
| |/ / /
| | | |
| | | | |
Change-Id: Ie98fd0ed952ab6d863b02b5de1e93a205871b6db
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I77f015100f2b9ed5e1a16ebd1ba0b28216282085
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If it doesn't work on iOS, it won't work on those platforms either.
Change-Id: Ie4109eda9ce83339435fb3e221e4bcbbeadac821
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
|/ / /
| | |
| | |
| | | |
Change-Id: Iaf9a626f80652a3b60568dc0ed61d958107713cc
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
Change-Id: Ie713faf0d6395f11477fceb35c93388756e33fae
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
... where has been added the '\c' tag where it is required.
Change-Id: Ie346fc147deb535501eb365693a2ff5fe22a98f9
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | |
| | |
| | |
| | | |
Change-Id: Ia0a76e03ab9484c6664615c67a66c8696eabae06
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
qserialport.cpp: In member function 'void QSerialPort::setSettingsRestoredOnClose(bool)':
qserialport.cpp:627:9: warning: 'void QSerialPort::settingsRestoredOnCloseChanged(bool)' is deprecated [-Wdeprecated-declarations]
Change-Id: I4ed17403cd1692c4f965a69be711f0c5b03a8376
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| |/
| |
| |
| |
| |
| |
| |
| | |
This patch corrects the connect statement used to show the settings
dialog.
Change-Id: I6318e18f7a281d8ddb118ef1f1d2d18e86df9b22
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |\
| | |
| | |
| | | |
Change-Id: Ia83609bd366762621857a6c63bf935a6cd230742
|
| | |\
| | | |
| | | |
| | | | |
Change-Id: Icc6c6b9251819451d7ac170bc1c518a094878743
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the CI obtains them from the qt5 super repo nowadays.
Change-Id: Ibde79e1be1701519505020d31c6d713ae2af4830
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I85decd74c3fff4ee1710af8c38b435f57da3b610
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Changing any of serial port properties drops RTS, which has
been set earlier, since the fRtsControl field of DCB structure
always has RTS_CONTROL_DISABLE value (except hardware flow
control).
Thus, using one EscapeCommFunction() function inside of
QSP::setRequestToSend() method is not enough. We need set
there also the fRtsControl field to RTS_CONTROL_ENABLE(DISABLE)
value and keep it unchanged.
Task-number: QTBUG-55907
Change-Id: I7e407b0de9f970f5d11f61c0e360d4735a0acb84
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When the user calls QSP::close() in a slot which is connected to the
QSP::error() signal, then the application is crashed. The reason is that
we emit the QSP::error() signal before than we call QRingBuffer::chop()
of an internal read buffer, which becomes invalid after the
QIODevice::close() called. Therefore, we need just call
QRingBuffer::chop() before than the QSP::error() signal will be emitted.
Task-number: QTBUG-55847
Change-Id: If536f9cf5cbc1b813d3642bdf9be0867e06368e8
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Alex Trotsenko <alex1973tr@gmail.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
|\ \ \ \
| |/ / /
| | | |
| | | | |
Change-Id: I96ee91aacae9d2768238dd3368771c26c3e02709
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Just follow 669add9 in qtbase.
Change-Id: I080d6272541bf8bd8a209ffbf257578aa6a57ae8
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
By wrapping the kIOConstants in the CFSTR macro, this also prevents the
creation of temporary QString objects.
Change-Id: I04baf9e3f3076f0134e5eb924c2dbf5da011acad
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com>
|
|\ \ \ \
| |/ / /
| | | |
| | | | |
Change-Id: Ib1ba5b90b0e3f911c00eb19e19ac2c92ca363ab8
|
| |\ \ \
| | |/ /
| | | |
| | | | |
Change-Id: I4f2c44fa70f4f0905daf22c619c597a4a1972c85
|
| | |\ \
| | | |/
| | | |
| | | | |
Change-Id: I3c5b0052f5645ead630e33bce46b360fa0135061
|
| | | |\
| | | | |
| | | | |
| | | | | |
Change-Id: I32be772e436bdf252ce286c059825b2f112d5d1f
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I026f40dd689220352ce7cd364401c22451bf2a2c
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | | |/
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Added binary compatibility data files for tst_bic test
Change-Id: I0c3c4fc4e7d48fdcd1bec4a65a51a79f1a1a88ca
Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
... otherwise the snippet with the blocking reading does not
make sense logically.
Change-Id: I5a037e7c44f50e57a1c48ab37764f9e7367a6dec
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Added the generated data files for the binary compatibility tests
for QtSerialPort for Qt 5.7.
Change-Id: I5db1fb0e22e0ba62b7c82cbe028b6d4acc215e9d
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|
|/ / /
| | |
| | |
| | | |
Change-Id: I460524fce4d30852303a5d1213c0c86d7081d012
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie6e27e8ae0dce6892ee6ab7561876bc439aed073
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make the name of the signal and the name of the getter unambiguous,
which in turn allows the easy use of Qt 5-style connects.
This commit message was taken from commit qtbase/4672e31.
[ChangeLog][QtSerialPort][QSerialPort] Deprecated QSP::error()
signal in favor of new QSP::errorOccurred() one.
Change-Id: I3f04bb8b1ae686d5368d43741cd0e97748b31b8f
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
|