From 751c105984532f41de4c5f712f36f4c2579a60b7 Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Fri, 12 Feb 2016 16:37:01 +0100 Subject: consistently put {qt,qml}_{module,plugin} at the end of project files this fixes static builds by ensuring that all dependencies are exported. Task-number: QTBUG-51071 Change-Id: I0cb70c7954b4f23778279d9c6bd8c558b6825d98 Reviewed-by: Simon Hausmann --- src/plugins/script/qtdbus/qtdbus.pro | 8 ++++---- src/script/script.pro | 4 ++-- src/scripttools/scripttools.pro | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/script/qtdbus/qtdbus.pro b/src/plugins/script/qtdbus/qtdbus.pro index e37bf26..1b06f27 100644 --- a/src/plugins/script/qtdbus/qtdbus.pro +++ b/src/plugins/script/qtdbus/qtdbus.pro @@ -1,11 +1,11 @@ TARGET = qtscriptdbus -PLUGIN_TYPE = script -PLUGIN_CLASS_NAME = QtDBusScriptPlugin -load(qt_plugin) - QT = core gui script CONFIG += qdbus SOURCES += main.cpp HEADERS += main.h + +PLUGIN_TYPE = script +PLUGIN_CLASS_NAME = QtDBusScriptPlugin +load(qt_plugin) diff --git a/src/script/script.pro b/src/script/script.pro index e48abac..dec4a4f 100644 --- a/src/script/script.pro +++ b/src/script/script.pro @@ -8,8 +8,6 @@ DEFINES += QLALR_NO_QSCRIPTGRAMMAR_DEBUG_INFO QMAKE_DOCS = $$PWD/doc/qtscript.qdocconf -load(qt_module) - CONFIG += building-libs WEBKITDIR = $$PWD/../3rdparty/javascriptcore @@ -76,3 +74,5 @@ integrity { } TR_EXCLUDE = $$WEBKITDIR/* + +load(qt_module) diff --git a/src/scripttools/scripttools.pro b/src/scripttools/scripttools.pro index 9b786ec..fb4343a 100644 --- a/src/scripttools/scripttools.pro +++ b/src/scripttools/scripttools.pro @@ -10,6 +10,6 @@ DEFINES += QT_NO_USING_NAMESPACE QMAKE_DOCS = $$PWD/doc/qtscripttools.qdocconf -load(qt_module) - include(debugging/debugging.pri) + +load(qt_module) -- cgit v1.2.1 From 0a29d74a5e875ad2e0229ed2c8e48344f87a45e0 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sun, 6 Mar 2016 12:20:49 +0100 Subject: Make public headers compile with -Wzero-as-null-pointer-constant ... or equivalent. QtBase 5.6 headers already compile that way, so let the other modules follow suit. Change-Id: I7e007ee907c479320a885af329745563c080467d Task-number: QTBUG-45291 Reviewed-by: Lars Knoll --- src/script/api/qscriptengine.h | 6 +++--- src/script/api/qscriptextensionplugin.h | 2 +- src/script/api/qscriptstring.h | 2 +- src/scripttools/debugging/qscriptenginedebugger.h | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/script/api/qscriptengine.h b/src/script/api/qscriptengine.h index f7f8411..c9c0f7d 100644 --- a/src/script/api/qscriptengine.h +++ b/src/script/api/qscriptengine.h @@ -184,10 +184,10 @@ public: #ifndef QT_NO_QOBJECT QScriptValue newQObject(QObject *object, ValueOwnership ownership = QtOwnership, - const QObjectWrapOptions &options = 0); + const QObjectWrapOptions &options = QObjectWrapOptions()); QScriptValue newQObject(const QScriptValue &scriptObject, QObject *qtObject, ValueOwnership ownership = QtOwnership, - const QObjectWrapOptions &options = 0); + const QObjectWrapOptions &options = QObjectWrapOptions()); QScriptValue newQMetaObject(const QMetaObject *metaObject, const QScriptValue &ctor = QScriptValue()); @@ -264,7 +264,7 @@ protected: QScriptEngine(QScriptEnginePrivate &dd); #else - QScriptEngine(QScriptEnginePrivate &dd, QObject *parent = 0); + QScriptEngine(QScriptEnginePrivate &dd, QObject *parent = Q_NULLPTR); #endif private: diff --git a/src/script/api/qscriptextensionplugin.h b/src/script/api/qscriptextensionplugin.h index a31487a..8fd1618 100644 --- a/src/script/api/qscriptextensionplugin.h +++ b/src/script/api/qscriptextensionplugin.h @@ -39,7 +39,7 @@ class Q_SCRIPT_EXPORT QScriptExtensionPlugin : public QObject, Q_OBJECT Q_INTERFACES(QScriptExtensionInterface:QFactoryInterface) public: - explicit QScriptExtensionPlugin(QObject *parent = 0); + explicit QScriptExtensionPlugin(QObject *parent = Q_NULLPTR); ~QScriptExtensionPlugin(); virtual QStringList keys() const = 0; diff --git a/src/script/api/qscriptstring.h b/src/script/api/qscriptstring.h index c4047f2..eed4a1e 100644 --- a/src/script/api/qscriptstring.h +++ b/src/script/api/qscriptstring.h @@ -47,7 +47,7 @@ public: bool operator==(const QScriptString &other) const; bool operator!=(const QScriptString &other) const; - quint32 toArrayIndex(bool *ok = 0) const; + quint32 toArrayIndex(bool *ok = Q_NULLPTR) const; QString toString() const; operator QString() const; diff --git a/src/scripttools/debugging/qscriptenginedebugger.h b/src/scripttools/debugging/qscriptenginedebugger.h index 0286072..7fd5c77 100644 --- a/src/scripttools/debugging/qscriptenginedebugger.h +++ b/src/scripttools/debugging/qscriptenginedebugger.h @@ -89,7 +89,7 @@ public: SuspendedState }; - QScriptEngineDebugger(QObject *parent = 0); + QScriptEngineDebugger(QObject *parent = Q_NULLPTR); ~QScriptEngineDebugger(); void attachTo(QScriptEngine *engine); @@ -101,8 +101,8 @@ public: #ifndef QT_NO_MAINWINDOW QMainWindow *standardWindow() const; #endif - QToolBar *createStandardToolBar(QWidget *parent = 0); - QMenu *createStandardMenu(QWidget *parent = 0); + QToolBar *createStandardToolBar(QWidget *parent = Q_NULLPTR); + QMenu *createStandardMenu(QWidget *parent = Q_NULLPTR); QWidget *widget(DebuggerWidget widget) const; QAction *action(DebuggerAction action) const; -- cgit v1.2.1 From f5e16ab0e1e153ec86f0d8651571e176ac6caa7c Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sun, 6 Mar 2016 12:21:30 +0100 Subject: Make more ctors explicit Added explicit where it was missing. This is not a source- incompatible change, because code that breaks by this is a bug. Let's not have this sitting around in an LTS. One is even a protected ctor. Change-Id: I114b26332ba0e2752f5d02ebcd6090fc2b562b40 Reviewed-by: Lars Knoll --- src/script/api/qscriptengine.h | 2 +- src/scripttools/debugging/qscriptenginedebugger.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/script/api/qscriptengine.h b/src/script/api/qscriptengine.h index c9c0f7d..80a2869 100644 --- a/src/script/api/qscriptengine.h +++ b/src/script/api/qscriptengine.h @@ -264,7 +264,7 @@ protected: QScriptEngine(QScriptEnginePrivate &dd); #else - QScriptEngine(QScriptEnginePrivate &dd, QObject *parent = Q_NULLPTR); + explicit QScriptEngine(QScriptEnginePrivate &dd, QObject *parent = Q_NULLPTR); #endif private: diff --git a/src/scripttools/debugging/qscriptenginedebugger.h b/src/scripttools/debugging/qscriptenginedebugger.h index 7fd5c77..a56a833 100644 --- a/src/scripttools/debugging/qscriptenginedebugger.h +++ b/src/scripttools/debugging/qscriptenginedebugger.h @@ -89,7 +89,7 @@ public: SuspendedState }; - QScriptEngineDebugger(QObject *parent = Q_NULLPTR); + explicit QScriptEngineDebugger(QObject *parent = Q_NULLPTR); ~QScriptEngineDebugger(); void attachTo(QScriptEngine *engine); -- cgit v1.2.1