delta/qt5/qtquickcontrols.git, branch old/5.1 code.qt.io: qt/qtquickcontrols.git SplitView: fix hidden item after fillWidth item bug 2013-09-19T07:17:24+00:00 Richard Moe Gustavsen richard.gustavsen@digia.com 2013-09-18T08:22:39+00:00 09a74592234c84b3e428b452d844eaa1f6451040 Some of the calculations in SplitView assumed that if item with index i was hidden, then so was handle at index i as well. This is not correct. The reason is that a the handle at i belongs to either item i or item i+1, depending on where the fillWidth item is. And this caused a bug when hiding the item to the right of the fillWidth item. Conflicts: tests/auto/controls/data/tst_splitview.qml Change-Id: I59967813f264a856181c57e32c4820d09d7eb363 Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> 
Some of the calculations in SplitView assumed that if
item with index i was hidden, then so was handle at
index i as well. This is not correct. The reason is
that a the handle at i belongs to either item i
or item i+1, depending on where the fillWidth item is.
And this caused a bug when hiding the item to the
right of the fillWidth item.

Conflicts:
	tests/auto/controls/data/tst_splitview.qml

Change-Id: I59967813f264a856181c57e32c4820d09d7eb363
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Fix Tab ownership issue that has been blocking stable->dev merge 2013-09-18T11:59:19+00:00 J-P Nurmi jpnurmi@digia.com 2013-09-18T11:43:59+00:00 04e000d2b1719696581bb4ae6ec21e39236ef38c Change-Id: Ifcae96687bcc54486d7f16b1e1002e54394b914d Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com> 
Change-Id: Ifcae96687bcc54486d7f16b1e1002e54394b914d
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Menu: Enable mnemonic menu navigation 2013-09-13T12:56:38+00:00 Gabriel de Dietrich gabriel.dedietrich@digia.com 2013-09-05T15:29:10+00:00 4eb3400843cafcedffa47fb8a272704bca4e9473 We also added a new mnemonic specific shortcut context matcher. This prevents two menu items with the same mnemonic but within different menus to be reported as ambiguous. Task-number: QTBUG-33030 ChangeLog: Added mnemonic navigation for menus Change-Id: I192c9aacba4d15851fe65bf9201251962fe976d5 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> 
We also added a new mnemonic specific shortcut context matcher. This
prevents two menu items with the same mnemonic but within different
menus to be reported as ambiguous.

Task-number: QTBUG-33030
ChangeLog: Added mnemonic navigation for menus
Change-Id: I192c9aacba4d15851fe65bf9201251962fe976d5
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Menu: Fix keyboard navigation on Windows 2013-09-12T17:16:36+00:00 Gabriel de Dietrich gabriel.dedietrich@digia.com 2013-09-05T15:28:06+00:00 82081e737038262c82c2e408d412fc80a607bf9f The Windows QPA plugin doesn't trigger activated window events for popups, resulting on the popup window not being the application focus window, and therefore, the popup window's content item not getting focus. This results in key pressed events not being sent to the menu item. We workaround this by emitting the window activated event ourselves right after the popup window is exposed. Task-number: QTBUG-33175 Change-Id: I77d1eb33b71af2232a6be6d0f7c6b480bffc10d4 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> 
The Windows QPA plugin doesn't trigger activated window events for popups,
resulting on the popup window not being the application focus window, and
therefore, the popup window's content item not getting focus. This results
in key pressed events not being sent to the menu item.

We workaround this by emitting the window activated event ourselves right
after the popup window is exposed.

Task-number: QTBUG-33175
Change-Id: I77d1eb33b71af2232a6be6d0f7c6b480bffc10d4
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Fix incorrect spinbox validation at startup 2013-09-10T14:20:24+00:00 Jens Bache-Wiig jens.bache-wiig@digia.com 2013-09-10T10:44:35+00:00 6bcacdecb8445a5ad9a31f6bdac99cde076e6295 The problem was that the validator was applied during the object creation which means the incorrect decimal values were applied and the initial value was incorrectly changed. Task-number: QTBUG-33309 Change-Id: Ic1ace174b9059b9c6ce24fd88b81c5edd7318e80 Reviewed-by: Caroline Chao <caroline.chao@digia.com> Reviewed-by: J-P Nurmi <jpnurmi@digia.com> 
The problem was that the validator was applied during the
object creation which means the incorrect decimal values were applied
and the initial value was incorrectly changed.

Task-number: QTBUG-33309
Change-Id: Ic1ace174b9059b9c6ce24fd88b81c5edd7318e80
Reviewed-by: Caroline Chao <caroline.chao@digia.com>
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Set the menu role for the QPlatformMenuItem to the default 2013-09-06T08:37:12+00:00 Andy Shaw andy.shaw@digia.com 2013-09-06T08:16:23+00:00 5520918af2cfb00618765820df2a28916a12c626 QAction has a default menu role which is passed on to the QPlatformMenuItem. But as QtQuickControls does not use QAction, we need to set the default menu role explicitly to TextHeuristicRole. This fixes the merging of menu items on Mac. Task-number: QTBUG-31883 Change-Id: I24f0e265f8ceca376db9970d62e8f79a646fef3b Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com> 
QAction has a default menu role which is passed on to the
QPlatformMenuItem. But as QtQuickControls does not use QAction, we need
to set the default menu role explicitly to TextHeuristicRole. This fixes
the merging of menu items on Mac.

Task-number: QTBUG-31883
Change-Id: I24f0e265f8ceca376db9970d62e8f79a646fef3b
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Menu: Fix popup closing when moving mouse to submenu 2013-09-04T16:11:06+00:00 Gabriel de Dietrich gabriel.dedietrich@digia.com 2013-09-04T15:35:35+00:00 9548940ced977afe6949121ae106154320f6a0b1 Task-number: QTBUG-32673 Change-Id: I1a083f6d7b231b1e3d60012306faf5ad4c573f5e Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> 
Task-number: QTBUG-32673
Change-Id: I1a083f6d7b231b1e3d60012306faf5ad4c573f5e
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
TabView: fix dynamic tab handling 2013-09-03T16:51:13+00:00 J-P Nurmi jpnurmi@digia.com 2013-08-27T12:50:59+00:00 53fa52bb604ab28ee37aba26e155486e94c66dec Task-number: QTBUG-33162 Change-Id: I873b37bd157230f80237fd40f3e5149fbd0207ca Reviewed-by: Volker Krause <volker.krause@kdab.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> 
Task-number: QTBUG-33162
Change-Id: I873b37bd157230f80237fd40f3e5149fbd0207ca
Reviewed-by: Volker Krause <volker.krause@kdab.com>
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Fix scroll bar behavior when clickToPosition is enabled 2013-08-27T15:02:16+00:00 Jens Bache-Wiig jens.bache-wiig@digia.com 2013-08-27T08:50:42+00:00 c304d741a27b5822a35d1fb83f8f5e65719907ce There were two issues with the scrollbar when using this behavior: Issue 1 - The scroll bar did not account for the grooveRect position, so the handle was not centered correctly around the mouse cursor. Issue 2 - When click-and-holding outside the handle area, you could not continue to move the handle afterwards. Task-number: QTBUG-33133 Change-Id: I251f684f767ce5a372eb0d2b5e6c421f88ac7fbe Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com> 
There were two issues with the scrollbar when using this behavior:

Issue 1 - The scroll bar did not account for the grooveRect position,
so the handle was not centered correctly around the mouse cursor.

Issue 2 - When click-and-holding outside the handle area, you could not
continue to move the handle afterwards.

Task-number: QTBUG-33133

Change-Id: I251f684f767ce5a372eb0d2b5e6c421f88ac7fbe
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Cleanup and improve the SplitView auto test 2013-08-23T12:47:29+00:00 J-P Nurmi jpnurmi@digia.com 2013-08-23T12:33:57+00:00 4031642ed61892bba4a7e56294085676924adce4 Change-Id: Ia6ccc71f36c78af933305207a7e05d2e484bd752 Reviewed-by: Caroline Chao <caroline.chao@digia.com> 
Change-Id: Ia6ccc71f36c78af933305207a7e05d2e484bd752
Reviewed-by: Caroline Chao <caroline.chao@digia.com>