<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/qt5/qtquickcontrols.git, branch 5.13</title>
<subtitle>code.qt.io: qt/qtquickcontrols.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/'/>
<entry>
<title>Merge remote-tracking branch 'origin/5.13.2' into 5.13</title>
<updated>2019-10-30T09:38:37+00:00</updated>
<author>
<name>Qt Forward Merge Bot</name>
<email>qt_forward_merge_bot@qt-project.org</email>
</author>
<published>2019-10-30T09:38:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=cdbe52a8f511e28ec0256c242d93f025fd21c55b'/>
<id>cdbe52a8f511e28ec0256c242d93f025fd21c55b</id>
<content type='text'>
Change-Id: Icb6da7c1d662261ec1b80fbd54d1b9dc7b573824
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Icb6da7c1d662261ec1b80fbd54d1b9dc7b573824
</pre>
</div>
</content>
</entry>
<entry>
<title>QQuickTreeModelAdaptor1: fix updating of ModelIndex role</title>
<updated>2019-10-29T05:07:09+00:00</updated>
<author>
<name>Alberto Mardegan</name>
<email>mardy@users.sourceforge.net</email>
</author>
<published>2019-10-24T20:06:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=c2b6aa5e513a47939bad3703c6b0d984faff9d2a'/>
<id>c2b6aa5e513a47939bad3703c6b0d984faff9d2a</id>
<content type='text'>
The decision to store the original QModelIndex as a role has the
unfortunate consequence that we need to emit the dataChanged() signal
whenever its value change. The previous implementation of the "move
rows" operation failed in delivering this update in most cases.

While addressing that, this commit also fixes some similar issues with
the HasChildren role not being notified in certain scenarios.

Also, when the last child of an expanded item gets moved away and later
placed back in the original position, the item should not remember its
expanded state, but rather accept the children while staying collapsed.

Last but not least, it's important that the endMoveRows() protected
method is called *after* the original tree model has completed its
movement, because otherwise its elements might be accessed while in the
wrong state.
Similarly, we don't want the dataChanged() signals to be emitted while
rows are moved or removed; we queue up these events and fire them only
after the item indexes have settled.

Fixes: QTBUG-59606
Change-Id: Ib981c912ea19908e1283cc463331c3053d4d6e7d
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The decision to store the original QModelIndex as a role has the
unfortunate consequence that we need to emit the dataChanged() signal
whenever its value change. The previous implementation of the "move
rows" operation failed in delivering this update in most cases.

While addressing that, this commit also fixes some similar issues with
the HasChildren role not being notified in certain scenarios.

Also, when the last child of an expanded item gets moved away and later
placed back in the original position, the item should not remember its
expanded state, but rather accept the children while staying collapsed.

Last but not least, it's important that the endMoveRows() protected
method is called *after* the original tree model has completed its
movement, because otherwise its elements might be accessed while in the
wrong state.
Similarly, we don't want the dataChanged() signals to be emitted while
rows are moved or removed; we queue up these events and fire them only
after the item indexes have settled.

Fixes: QTBUG-59606
Change-Id: Ib981c912ea19908e1283cc463331c3053d4d6e7d
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add changes file for Qt 5.13.2</title>
<updated>2019-10-17T04:16:56+00:00</updated>
<author>
<name>Antti Kokko</name>
<email>antti.kokko@qt.io</email>
</author>
<published>2019-10-14T07:28:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=9a5e84b8f9ca0eeda8170eb93c093f3ab25de988'/>
<id>9a5e84b8f9ca0eeda8170eb93c093f3ab25de988</id>
<content type='text'>
+ b37db1f31b3248e9d32d0ccbb42e77035fa5b340 Add changes file for Qt 5.12.5
+ da94d6586cbe6b9c12dec8ecc0f842aad807b0d3 Only calculate the height of the ListView when there are model entries
+ 7f61a351148c7d67f8f4ee6f2d2c4a9c53766297 Remove test_resizeAfterFlicking from tst_tumbler

Change-Id: I7bd32e2f04223df753615b0b3315244cef46e316
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
+ b37db1f31b3248e9d32d0ccbb42e77035fa5b340 Add changes file for Qt 5.12.5
+ da94d6586cbe6b9c12dec8ecc0f842aad807b0d3 Only calculate the height of the ListView when there are model entries
+ 7f61a351148c7d67f8f4ee6f2d2c4a9c53766297 Remove test_resizeAfterFlicking from tst_tumbler

Change-Id: I7bd32e2f04223df753615b0b3315244cef46e316
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump version</title>
<updated>2019-10-14T07:42:10+00:00</updated>
<author>
<name>Frederik Gladhorn</name>
<email>frederik.gladhorn@qt.io</email>
</author>
<published>2019-10-14T07:42:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=43a843142f0dfc43089594caaa2d5174498ffd91'/>
<id>43a843142f0dfc43089594caaa2d5174498ffd91</id>
<content type='text'>
Change-Id: I6de0ffd4952bcecbcf92ff925d450ba4c4beb45f
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I6de0ffd4952bcecbcf92ff925d450ba4c4beb45f
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove test_resizeAfterFlicking from tst_tumbler</title>
<updated>2019-10-09T09:02:32+00:00</updated>
<author>
<name>Mitch Curtis</name>
<email>mitch.curtis@qt.io</email>
</author>
<published>2019-10-09T08:42:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=7f61a351148c7d67f8f4ee6f2d2c4a9c53766297'/>
<id>7f61a351148c7d67f8f4ee6f2d2c4a9c53766297</id>
<content type='text'>
This is causing flakiness in CI, and tests a weird edge case, so
its value as a test is very low.

Change-Id: Iaeb2633bd270dc8e88420ace5efe9ab156339733
Reviewed-by: Shawn Rutledge &lt;shawn.rutledge@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is causing flakiness in CI, and tests a weird edge case, so
its value as a test is very low.

Change-Id: Iaeb2633bd270dc8e88420ace5efe9ab156339733
Reviewed-by: Shawn Rutledge &lt;shawn.rutledge@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Only calculate the height of the ListView when there are model entries</title>
<updated>2019-09-25T08:50:15+00:00</updated>
<author>
<name>Andy Shaw</name>
<email>andy.shaw@qt.io</email>
</author>
<published>2019-09-25T08:21:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=da94d6586cbe6b9c12dec8ecc0f842aad807b0d3'/>
<id>da94d6586cbe6b9c12dec8ecc0f842aad807b0d3</id>
<content type='text'>
When it tries to calculate the height of the listview then it depends
on the model having entries. If there is no model or no entries in it
then it will cause a warning to be outputted indicating that the
model size is less than 0. This prevents it from occurring as a result.

Fixes: QTBUG-72543
Change-Id: I7155a3a240fdcdf93caddfce332f0cc6bb0f0ec0
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When it tries to calculate the height of the listview then it depends
on the model having entries. If there is no model or no entries in it
then it will cause a warning to be outputted indicating that the
model size is less than 0. This prevents it from occurring as a result.

Fixes: QTBUG-72543
Change-Id: I7155a3a240fdcdf93caddfce332f0cc6bb0f0ec0
Reviewed-by: Mitch Curtis &lt;mitch.curtis@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Merge remote-tracking branch 'origin/5.12' into 5.13"</title>
<updated>2019-09-08T09:32:45+00:00</updated>
<author>
<name>Qt Forward Merge Bot</name>
<email>qt_forward_merge_bot@qt-project.org</email>
</author>
<published>2019-09-08T09:32:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=ac9f2e582dc6c0f740b8c5b225bc65a8c1b35e9e'/>
<id>ac9f2e582dc6c0f740b8c5b225bc65a8c1b35e9e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'origin/5.12' into 5.13</title>
<updated>2019-09-08T09:32:39+00:00</updated>
<author>
<name>Qt Forward Merge Bot</name>
<email>qt_forward_merge_bot@qt-project.org</email>
</author>
<published>2019-09-08T09:32:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=a27e80f4ed0a529ae0260e199f0bc4a1894e81ed'/>
<id>a27e80f4ed0a529ae0260e199f0bc4a1894e81ed</id>
<content type='text'>
Change-Id: I9632a4f67cd4f96b0b5ad8010266463525f1f6e7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I9632a4f67cd4f96b0b5ad8010266463525f1f6e7
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Merge remote-tracking branch 'origin/5.12.5' into 5.12"</title>
<updated>2019-09-07T11:11:21+00:00</updated>
<author>
<name>Qt Forward Merge Bot</name>
<email>qt_forward_merge_bot@qt-project.org</email>
</author>
<published>2019-09-07T11:11:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=baf7f594a254a56ae94bb01c808c8c72df735745'/>
<id>baf7f594a254a56ae94bb01c808c8c72df735745</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'origin/5.12.5' into 5.12</title>
<updated>2019-09-07T11:11:15+00:00</updated>
<author>
<name>Qt Forward Merge Bot</name>
<email>qt_forward_merge_bot@qt-project.org</email>
</author>
<published>2019-09-07T11:11:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/qt5/qtquickcontrols.git/commit/?id=00c1e44509e50ea91f9f7ea8444be4fe0fa4d0b6'/>
<id>00c1e44509e50ea91f9f7ea8444be4fe0fa4d0b6</id>
<content type='text'>
Change-Id: Ia5eba4c810e06c4b73daf6e27a8c5ce141ce6ebb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia5eba4c810e06c4b73daf6e27a8c5ce141ce6ebb
</pre>
</div>
</content>
</entry>
</feed>
