From 4ae65d3c93bd1f87ac8003a7f244285a1ba624b6 Mon Sep 17 00:00:00 2001 From: Oliver Wolff Date: Mon, 16 Apr 2018 14:47:42 +0200 Subject: DirectShowUtils::findUnconnectedPin: Try other pins if matchPin fails If matchPin fails for one of the pins (for whatever reason), the loop can just continue and check whether another unconnected pin can be found. If this check fails for every pin, false will be returned in the end. Change-Id: I1a58a26633b43052f3963212932d789d4800c714 Reviewed-by: Friedemann Kleint Reviewed-by: VaL Doroshchuk --- src/plugins/directshow/common/directshowutils.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/plugins/directshow/common/directshowutils.cpp b/src/plugins/directshow/common/directshowutils.cpp index 989239b88..8f3f321e7 100644 --- a/src/plugins/directshow/common/directshowutils.cpp +++ b/src/plugins/directshow/common/directshowutils.cpp @@ -183,9 +183,6 @@ bool DirectShowUtils::findUnconnectedPin(IBaseFilter *filter, PIN_DIRECTION pinD (*pin)->AddRef(); return true; } - - if (FAILED(*hrOut)) - return false; } qCDebug(qtDirectShowPlugin, "No unconnected pins found"); -- cgit v1.2.1