From e27168074c9062f453059a6d95d1d99ca05b166c Mon Sep 17 00:00:00 2001 From: Sergio Ahumada Date: Fri, 6 Feb 2015 20:05:44 +0100 Subject: Use single-char QString operations for efficiency Change-Id: I45cf92e81e94cf62a21de2e01d9f8039ec1f2672 Reviewed-by: Alex Blasche --- src/plugins/geoservices/nokia/qgeocodexmlparser.cpp | 2 +- .../geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp | 10 +++++----- src/plugins/geoservices/nokia/qgeouriprovider.cpp | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'src/plugins/geoservices/nokia') diff --git a/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp b/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp index 7862c470..fec7ba30 100644 --- a/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp +++ b/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp @@ -412,7 +412,7 @@ bool QGeoCodeXmlParser::parseAddress(QGeoAddress *address) } if (inThoroughfare && (m_reader->name() == "number")) { - address->setStreet(m_reader->readElementText() + " " + address->street()); + address->setStreet(m_reader->readElementText() + ' ' + address->street()); if (!m_reader->readNextStartElement()) inThoroughfare = false; } diff --git a/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp b/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp index ce4deaef..f8c29c7b 100644 --- a/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp +++ b/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp @@ -246,7 +246,7 @@ QStringList QGeoRoutingManagerEngineNokia::calculateRouteRequestString(const QGe baseRequest += QString::number(i); baseRequest += QStringLiteral("=geo!"); baseRequest += trimDouble(request.waypoints().at(i).latitude()); - baseRequest += ","; + baseRequest += ','; baseRequest += trimDouble(request.waypoints().at(i).longitude()); } @@ -283,7 +283,7 @@ QStringList QGeoRoutingManagerEngineNokia::updateRouteRequestString(const QGeoRo baseRequest += "&pos="; baseRequest += QString::number(position.latitude()); - baseRequest += ","; + baseRequest += ','; baseRequest += QString::number(position.longitude()); QGeoRouteRequest::RouteOptimizations optimization = route.request().routeOptimization(); @@ -328,7 +328,7 @@ QString QGeoRoutingManagerEngineNokia::modesRequestString(const QGeoRouteRequest QString weightString = ""; switch (weight) { case QGeoRouteRequest::PreferFeatureWeight: - weightString = "1"; + weightString = '1'; break; case QGeoRouteRequest::AvoidFeatureWeight: weightString = "-1"; @@ -370,9 +370,9 @@ QString QGeoRoutingManagerEngineNokia::modesRequestString(const QGeoRouteRequest } requestString += "&mode="; - requestString += optimization + ";" + modes.join(","); + requestString += optimization + ';' + modes.join(','); if (featureStrings.count()) - requestString += ";" + featureStrings.join(","); + requestString += ';' + featureStrings.join(','); return requestString; } diff --git a/src/plugins/geoservices/nokia/qgeouriprovider.cpp b/src/plugins/geoservices/nokia/qgeouriprovider.cpp index 932818a5..ceb86cf8 100644 --- a/src/plugins/geoservices/nokia/qgeouriprovider.cpp +++ b/src/plugins/geoservices/nokia/qgeouriprovider.cpp @@ -83,7 +83,7 @@ QString QGeoUriProvider::getCurrentHost() const { if (m_maxSubdomains) { QString result(m_firstSubdomain.toLatin1() + qrand() % m_maxSubdomains); - result += "." + m_currentHost; + result += '.' + m_currentHost; return result; } return m_currentHost; -- cgit v1.2.1