From 4cb1cbe5e0b8fab5a8145a00d6d79205148d8971 Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Sat, 8 Oct 2022 14:42:22 +0200 Subject: Remove parameterization functionality The abstraction of plugin-specific parameters makes little sense if we don't want to provide a cross-backend API. So remove this for now. If in the future we want to attach meta-data or backend-specific properties to values or element types, then we might be able to use existing QVariantMap type properties (like QGeoRouteRequest's extraParameters, via QDeclarativeGeoRouteQuery::extraParameters), or register backend specific QML types that applications can opt in to use. This requires a bit of research and experimenting based on specific use cases. If we can't come up with anything better, then bringing back a, perhaps simplified, version of the infrastructure removed here will still be an option. Change-Id: If590a35f2ffb80b0c918d866e88913a9caf75d2b Reviewed-by: Alex Blasche --- src/location/maps/qgeomap.cpp | 37 ------------------------------------- 1 file changed, 37 deletions(-) (limited to 'src/location/maps/qgeomap.cpp') diff --git a/src/location/maps/qgeomap.cpp b/src/location/maps/qgeomap.cpp index 54ba9bbb..1dafbe1b 100644 --- a/src/location/maps/qgeomap.cpp +++ b/src/location/maps/qgeomap.cpp @@ -54,7 +54,6 @@ QGeoMap::QGeoMap(QGeoMapPrivate &dd, QObject *parent) QGeoMap::~QGeoMap() { - clearParameters(); } void QGeoMap::setViewportSize(const QSize& size) @@ -225,32 +224,6 @@ void QGeoMap::clearData() } -void QGeoMap::addParameter(QGeoMapParameter *param) -{ - Q_D(QGeoMap); - if (param && !d->m_mapParameters.contains(param)) { - d->m_mapParameters.append(param); - d->addParameter(param); - } -} - -void QGeoMap::removeParameter(QGeoMapParameter *param) -{ - Q_D(QGeoMap); - if (param && d->m_mapParameters.contains(param)) { - d->removeParameter(param); - d->m_mapParameters.removeOne(param); - } -} - -void QGeoMap::clearParameters() -{ - Q_D(QGeoMap); - for (QGeoMapParameter *p : qAsConst(d->m_mapParameters)) - d->removeParameter(p); - d->m_mapParameters.clear(); -} - QGeoMap::ItemTypes QGeoMap::supportedMapItemTypes() const { Q_D(const QGeoMap); @@ -363,16 +336,6 @@ const QGeoMapPrivate *QGeoMapPrivate::get(const QGeoMap &map) return map.d_func(); } -void QGeoMapPrivate::addParameter(QGeoMapParameter *param) -{ - Q_UNUSED(param); -} - -void QGeoMapPrivate::removeParameter(QGeoMapParameter *param) -{ - Q_UNUSED(param); -} - QGeoMap::ItemTypes QGeoMapPrivate::supportedMapItemTypes() const { return QGeoMap::NoItem; -- cgit v1.2.1