diff options
author | abcd <amos.choy@nokia.com> | 2011-11-02 19:01:44 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-11-07 02:51:40 +0100 |
commit | c3853d1eb5d2d20cc041abe705d92bce931d8888 (patch) | |
tree | 9a2da92f8972f3b2e4028e3d2b8a880a74f0eeaf /tests/auto/qplacecontentrequest | |
parent | 3e2e863b147e8d75a860893cc8f74f7729a7e041 (diff) | |
download | qtlocation-c3853d1eb5d2d20cc041abe705d92bce931d8888.tar.gz |
Docs for request classes + refactor
Documentation for the content and search request classes.
There is no need for the request classes to inherit off a
base request class. Currently the base class has limit and offset
fields, but if for example there is an image submission request class
the limit and offset become meaningless.
The content reply class should have a field for the content request
just like the search reply has a field for the search request.
Change-Id: I8d9dfe8a31806c6bb3b31f66d1338c2999e27ce2
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Diffstat (limited to 'tests/auto/qplacecontentrequest')
-rw-r--r-- | tests/auto/qplacecontentrequest/tst_qplacecontentrequest.cpp | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/tests/auto/qplacecontentrequest/tst_qplacecontentrequest.cpp b/tests/auto/qplacecontentrequest/tst_qplacecontentrequest.cpp index 596145d4..8a34b416 100644 --- a/tests/auto/qplacecontentrequest/tst_qplacecontentrequest.cpp +++ b/tests/auto/qplacecontentrequest/tst_qplacecontentrequest.cpp @@ -65,7 +65,6 @@ tst_QPlaceContentRequest::tst_QPlaceContentRequest() void tst_QPlaceContentRequest::contentTest() { QPlaceContentRequest req; - QCOMPARE(req.type(), QPlaceRequest::ContentRequest); QCOMPARE(req.limit(), -1); QCOMPARE(req.offset(), 0); QCOMPARE(req.contentType(), QPlaceContent::InvalidType); @@ -87,18 +86,11 @@ void tst_QPlaceContentRequest::contentTest() QCOMPARE(req.limit(), 10); QCOMPARE(req.offset(), 15); QCOMPARE(req.contentType(), QPlaceContent::ReviewType); - - //check assigningment to a base class instance and comparison - QPlaceRequest plainReq(otherReq); - QVERIFY(req == otherReq); - - //check assignment from base class to derived class - QPlaceContentRequest contentReq = plainReq; - QCOMPARE(contentReq, req); + QCOMPARE(req, otherReq); //check that comparison will fail if one the fields are different - contentReq.setLimit(9000); - QVERIFY(contentReq != req); + req.setLimit(9000); + QVERIFY(req != otherReq); } void tst_QPlaceContentRequest::clearTest() |