diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-07-29 10:59:47 +0200 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-08-03 07:35:50 +0200 |
| commit | 117d4bf2bd04fb9702938233a00052b965c724a8 (patch) | |
| tree | a3ea5b405e8a6b98c953a70dda0a183d9cc5ebe8 /src/location/maps/qgeomaneuver.h | |
| parent | 43dde53b5b0dfae14bf0bde97bf4709344131acd (diff) | |
| download | qtlocation-117d4bf2bd04fb9702938233a00052b965c724a8.tar.gz | |
Clean up mix of polymorph and value semantics
QGeoManeuver had a protected constructor only to allow the test to
replace the private implementation, which is polymorph. There is no use
of this possibility to override the implementation of the class outside
the test.
If we want to bring this back, then a factory that the service provider
plugins implement and through which the framework creates the
implementations would be the typical architecture, without forcing the
subclassing of value types with the risk for slicing or memory leaks
when destructors are not virtual.
Pick-to: 6.2
Task-number: QTBUG-105206
Change-Id: I3358da3939c43dfb83c4b2b10a792044590263f7
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/location/maps/qgeomaneuver.h')
| -rw-r--r-- | src/location/maps/qgeomaneuver.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/location/maps/qgeomaneuver.h b/src/location/maps/qgeomaneuver.h index e9a65927..ce81949c 100644 --- a/src/location/maps/qgeomaneuver.h +++ b/src/location/maps/qgeomaneuver.h @@ -106,9 +106,6 @@ public: void setExtendedAttributes(const QVariantMap &extendedAttributes); QVariantMap extendedAttributes() const; -protected: - QGeoManeuver(const QSharedDataPointer<QGeoManeuverPrivate> &dd); - private: QSharedDataPointer<QGeoManeuverPrivate> d_ptr; |