From 7d1911572000d1353c1c0109402431323fcd8639 Mon Sep 17 00:00:00 2001 From: Ander Conselvan de Oliveira Date: Fri, 22 Feb 2019 09:31:21 +0200 Subject: [core] Don't use exceptions in MapObserver::onDidFailLoadingMap Using different exception pointers to specify the loading failure makes an awkward API. Most users rethrow the exception only to figure out what type of error happened so it can be reported properly. So replace the exception pointer with a enum an string description of the failure. --- test/src/mbgl/test/stub_map_observer.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test') diff --git a/test/src/mbgl/test/stub_map_observer.hpp b/test/src/mbgl/test/stub_map_observer.hpp index 1371577473..00a039e732 100644 --- a/test/src/mbgl/test/stub_map_observer.hpp +++ b/test/src/mbgl/test/stub_map_observer.hpp @@ -20,7 +20,7 @@ public: } } - void onDidFailLoadingMap(std::exception_ptr) final { + void onDidFailLoadingMap(MapLoadError, const std::string&) final { if (didFailLoadingMapCallback) { didFailLoadingMapCallback(); } -- cgit v1.2.1