From 65c06e62707a9982dedf39a88904bce04df1e227 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Tue, 23 Feb 2016 14:19:50 -0800 Subject: =?UTF-8?q?[core]=20status.requiredResourceCountIsIndeterminate=20?= =?UTF-8?q?=E2=87=A2=20status.requiredResourceCountIsPrecise?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change the name and reverse the sense. Naming things in the positive is better than naming them in the negative. --- test/storage/offline_download.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'test') diff --git a/test/storage/offline_download.cpp b/test/storage/offline_download.cpp index 6de14d37b2..33c9c5a95d 100644 --- a/test/storage/offline_download.cpp +++ b/test/storage/offline_download.cpp @@ -63,7 +63,7 @@ TEST(OfflineDownload, NoSubresources) { if (status.complete()) { EXPECT_EQ(1, status.completedResourceCount); EXPECT_EQ(test.size, status.completedResourceSize); - EXPECT_FALSE(status.requiredResourceCountIsIndeterminate); + EXPECT_TRUE(status.requiredResourceCountIsPrecise); test.loop.stop(); } }; @@ -102,7 +102,7 @@ TEST(OfflineDownload, InlineSource) { if (status.complete()) { EXPECT_EQ(2, status.completedResourceCount); EXPECT_EQ(test.size, status.completedResourceSize); - EXPECT_FALSE(status.requiredResourceCountIsIndeterminate); + EXPECT_TRUE(status.requiredResourceCountIsPrecise); test.loop.stop(); } }; @@ -136,7 +136,7 @@ TEST(OfflineDownload, GeoJSONSource) { if (status.complete()) { EXPECT_EQ(2, status.completedResourceCount); EXPECT_EQ(test.size, status.completedResourceSize); - EXPECT_FALSE(status.requiredResourceCountIsIndeterminate); + EXPECT_TRUE(status.requiredResourceCountIsPrecise); test.loop.stop(); } }; @@ -200,7 +200,7 @@ TEST(OfflineDownload, Activate) { EXPECT_EQ(status.requiredResourceCount, computedStatus.requiredResourceCount); EXPECT_EQ(status.completedResourceCount, computedStatus.completedResourceCount); EXPECT_EQ(status.completedResourceSize, computedStatus.completedResourceSize); - EXPECT_FALSE(status.requiredResourceCountIsIndeterminate); + EXPECT_TRUE(status.requiredResourceCountIsPrecise); test.loop.stop(); } @@ -224,7 +224,7 @@ TEST(OfflineDownload, GetStatusNoResources) { EXPECT_EQ(0, status.completedResourceCount); EXPECT_EQ(0, status.completedResourceSize); EXPECT_EQ(1, status.requiredResourceCount); - EXPECT_TRUE(status.requiredResourceCountIsIndeterminate); + EXPECT_FALSE(status.requiredResourceCountIsPrecise); EXPECT_FALSE(status.complete()); } @@ -245,7 +245,7 @@ TEST(OfflineDownload, GetStatusStyleComplete) { EXPECT_EQ(1, status.completedResourceCount); EXPECT_EQ(test.size, status.completedResourceSize); EXPECT_EQ(260, status.requiredResourceCount); - EXPECT_TRUE(status.requiredResourceCountIsIndeterminate); + EXPECT_FALSE(status.requiredResourceCountIsPrecise); EXPECT_FALSE(status.complete()); } @@ -270,7 +270,7 @@ TEST(OfflineDownload, GetStatusStyleAndSourceComplete) { EXPECT_EQ(2, status.completedResourceCount); EXPECT_EQ(test.size, status.completedResourceSize); EXPECT_EQ(261, status.requiredResourceCount); - EXPECT_FALSE(status.requiredResourceCountIsIndeterminate); + EXPECT_TRUE(status.requiredResourceCountIsPrecise); EXPECT_FALSE(status.complete()); } -- cgit v1.2.1