From 1a684c1f48ef9fdc40ffcaacf1abe33b28370562 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Konstantin=20K=C3=A4fer?= Date: Fri, 15 Sep 2017 23:35:26 +0200 Subject: [core] keep tiles renderable even if a subsequent error occurs Since 9a9408e8111bcdcd0fcb9a93112d61ab8fce0601, we marked tiles as non-renderable if an error occured. This lead to situations where a tile was loaded + parsed successfully, then a revalidation attempt occured (e.g. because the resource was stale) which failed. In this case, we used to mark the tile as non-renderable although we could've used the perfectly parsed (stale) resource. --- src/mbgl/tile/geometry_tile.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/mbgl/tile/geometry_tile.cpp') diff --git a/src/mbgl/tile/geometry_tile.cpp b/src/mbgl/tile/geometry_tile.cpp index 017861884b..fafd9f7ae7 100644 --- a/src/mbgl/tile/geometry_tile.cpp +++ b/src/mbgl/tile/geometry_tile.cpp @@ -79,7 +79,6 @@ void GeometryTile::markObsolete() { void GeometryTile::setError(std::exception_ptr err) { loaded = true; - renderable = false; observer->onTileError(*this, err); } @@ -174,7 +173,6 @@ void GeometryTile::onPlacement(PlacementResult result) { void GeometryTile::onError(std::exception_ptr err) { loaded = true; pending = false; - renderable = false; observer->onTileError(*this, err); } -- cgit v1.2.1