From c39232a89f1feb18454d88f2908f5cbef306b065 Mon Sep 17 00:00:00 2001
From: Chris Loer <chris.loer@gmail.com>
Date: Mon, 13 Nov 2017 11:12:03 -0800
Subject: [core] Cleanup in response to review comments.

---
 src/mbgl/text/collision_index.cpp | 43 ++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 19 deletions(-)

(limited to 'src/mbgl/text/collision_index.cpp')

diff --git a/src/mbgl/text/collision_index.cpp b/src/mbgl/text/collision_index.cpp
index 72a2d1af4e..fee28b5873 100644
--- a/src/mbgl/text/collision_index.cpp
+++ b/src/mbgl/text/collision_index.cpp
@@ -241,6 +241,25 @@ void CollisionIndex::insertFeature(CollisionFeature& feature, bool ignorePlaceme
     }
 }
 
+bool polygonIntersectsBox(const LineString<float>& polygon, const GridIndex<IndexedSubfeature>::BBox& bbox) {
+    // This is just a wrapper that allows us to use the integer-based util::polygonIntersectsPolygon
+    // Conversion limits our query accuracy to single-pixel resolution
+    GeometryCoordinates integerPolygon;
+    for (const auto& point : polygon) {
+        integerPolygon.push_back(convertPoint<int16_t>(point));
+    }
+    int16_t minX1 = bbox.min.x;
+    int16_t maxY1 = bbox.max.y;
+    int16_t minY1 = bbox.min.y;
+    int16_t maxX1 = bbox.max.x;
+
+    auto bboxPoints = GeometryCoordinates {
+        { minX1, minY1 }, { maxX1, minY1 }, { maxX1, maxY1 }, { minX1, maxY1 }
+    };
+    
+    return util::polygonIntersectsPolygon(integerPolygon, bboxPoints);
+}
+
 std::vector<IndexedSubfeature> CollisionIndex::queryRenderedSymbols(const GeometryCoordinates& queryGeometry, const UnwrappedTileID& tileID, const std::string& sourceID) const {
     std::vector<IndexedSubfeature> result;
     if (queryGeometry.empty() || (collisionGrid.empty() && ignoredGrid.empty())) {
@@ -253,14 +272,10 @@ std::vector<IndexedSubfeature> CollisionIndex::queryRenderedSymbols(const Geomet
     transformState.matrixFor(posMatrix, tileID);
     matrix::multiply(posMatrix, projMatrix, posMatrix);
 
-    // Two versions of the query here just because util::polygonIntersectsPolygon requires
-    // GeometryCoordinates (based on int16_t). Otherwise, work with floats.
-    GeometryCoordinates projectedPolygon;
+    // queryGeometry is specified in integer tile units, but in projecting we switch to float pixels
     LineString<float> projectedQuery;
-
     for (const auto& point : queryGeometry) {
         auto projected = projectPoint(posMatrix, convertPoint<float>(point));
-        projectedPolygon.push_back(convertPoint<int16_t>(projected));
         projectedQuery.push_back(projected);
     }
     
@@ -273,8 +288,7 @@ std::vector<IndexedSubfeature> CollisionIndex::queryRenderedSymbols(const Geomet
 
     for (auto& queryResult : features) {
         auto& feature = queryResult.first;
-        CanonicalTileID featureTileID(feature.z, feature.x, feature.y);
-        if (feature.sourceID == sourceID && featureTileID == tileID.canonical) {
+        if (feature.sourceID == sourceID && feature.tileID == tileID.canonical) {
             // We only have to filter on the canonical ID because even if the feature is showing multiple times
             // we treat it as one feature.
             thisTileFeatures.push_back(queryResult);
@@ -284,8 +298,7 @@ std::vector<IndexedSubfeature> CollisionIndex::queryRenderedSymbols(const Geomet
     std::vector<QueryResult> ignoredFeatures = ignoredGrid.queryWithBoxes(envelope);
     for (auto& queryResult : ignoredFeatures) {
         auto& feature = queryResult.first;
-        CanonicalTileID featureTileID(feature.z, feature.x, feature.y);
-        if (feature.sourceID == sourceID && featureTileID == tileID.canonical) {
+        if (feature.sourceID == sourceID && feature.tileID == tileID.canonical) {
             thisTileFeatures.push_back(queryResult);
         }
     }
@@ -301,18 +314,10 @@ std::vector<IndexedSubfeature> CollisionIndex::queryRenderedSymbols(const Geomet
             continue;
 
         seenFeatures.insert(feature.index);
-
-        int16_t minX1 = bbox.min.x;
-        int16_t maxY1 = bbox.max.y;
-        int16_t minY1 = bbox.min.y;
-        int16_t maxX1 = bbox.max.x;
-
-        auto bboxPoints = GeometryCoordinates {
-            { minX1, minY1 }, { maxX1, minY1 }, { maxX1, maxY1 }, { minX1, maxY1 }
-        };
         
-        if (!util::polygonIntersectsPolygon(projectedPolygon, bboxPoints))
+        if (!polygonIntersectsBox(projectedQuery, bbox)) {
             continue;
+        }
 
         result.push_back(feature);
     }
-- 
cgit v1.2.1