From 41e30343f7c9772ba0a3dfa1497dd5657b18aca1 Mon Sep 17 00:00:00 2001 From: Mikhail Pozdnyakov Date: Mon, 29 Jul 2019 12:00:36 +0300 Subject: [core] Shrink RenderOrchestrator::filteredLayersForSource in reduceMemoryUse() Before this change, `RenderOrchestrator::filteredLayersForSource` shrank inside `createRenderTree()`, which potentially might have affected rendering performance. --- src/mbgl/renderer/render_orchestrator.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/mbgl/renderer/render_orchestrator.cpp') diff --git a/src/mbgl/renderer/render_orchestrator.cpp b/src/mbgl/renderer/render_orchestrator.cpp index 4d8ef77302..5b6b27c185 100644 --- a/src/mbgl/renderer/render_orchestrator.cpp +++ b/src/mbgl/renderer/render_orchestrator.cpp @@ -274,9 +274,6 @@ std::unique_ptr RenderOrchestrator::createRenderTree(const UpdatePar // Reserve size for filteredLayersForSource if there are sources. if (!sourceImpls->empty()) { filteredLayersForSource.reserve(layerImpls->size()); - if (filteredLayersForSource.capacity() > layerImpls->size()) { - filteredLayersForSource.shrink_to_fit(); - } } // Update all sources and initialize renderItems. @@ -561,6 +558,7 @@ FeatureExtensionValue RenderOrchestrator::queryFeatureExtensions(const std::stri } void RenderOrchestrator::reduceMemoryUse() { + filteredLayersForSource.shrink_to_fit(); for (const auto& entry : renderSources) { entry.second->reduceMemoryUse(); } -- cgit v1.2.1