From da863c6e52f656bd35c3d3346093a24d747d0bbd Mon Sep 17 00:00:00 2001 From: Bruno de Oliveira Abinader Date: Mon, 20 Jun 2016 10:54:13 +0300 Subject: [build] Added 'lint' Make target --- scripts/clang-tools.sh | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100755 scripts/clang-tools.sh (limited to 'scripts/clang-tools.sh') diff --git a/scripts/clang-tools.sh b/scripts/clang-tools.sh new file mode 100755 index 0000000000..23d5b289ef --- /dev/null +++ b/scripts/clang-tools.sh @@ -0,0 +1,66 @@ +#!/usr/bin/env bash + +set -e +set -o pipefail + +export PATH="`pwd`/.mason:${PATH}" MASON_DIR="`pwd`/.mason" + +CLANG_TIDY=${CLANG_TIDY:-$(mason prefix clang-tidy 3.8.0)/bin/clang-tidy} +CLANG_FORMAT=${CLANG_FORMAT:-$(mason prefix clang-format 3.8.0)/bin/clang-format} + +command -v ${CLANG_TIDY} >/dev/null 2>&1 || { + echo "Can't find ${CLANG_TIDY} in PATH." + if [ -z ${CLANG_TIDY} ]; then + echo "Alternatively, you can set CLANG_TIDY to point to clang-tidy." + fi + exit 1 +} + +cd $1 + +function check_tidy() { + echo "Running clang-tidy on $0..." + if [ -n $1 ] && [ $1 == "--fix" ]; then + OUTPUT=$(${CLANG_TIDY} -p=$PWD -fix -fix-errors $0 2>/dev/null) + else + OUTPUT=$(${CLANG_TIDY} -p=$PWD $0 2>/dev/null) + fi + if [[ -n $OUTPUT ]]; then + echo "Caught clang-tidy warning/error:" + echo -e "$OUTPUT" + exit 1 + fi +} + +function check_format() { + echo "Running clang-format on $0..." + ${CLANG_FORMAT} -i ../../../$0 +} + +export CLANG_TIDY CLANG_FORMAT +export -f check_tidy check_format + +git diff-index --quiet HEAD || { + echo "Your repository contains unstaged and/or uncommitted changes." + echo "Please commit all changes before proceeding." + exit 1 +} + +echo "Running clang checks... (this might take a while)" + +if [ -n $2 ] && [ $2 == "--diff" ]; then + DIFF_FILES=$(for file in `git diff origin/master..HEAD --name-only | grep "pp$"`; do echo $file; done) + if [[ -n $DIFF_FILES ]]; then + echo "${DIFF_FILES}" | xargs -I{} -P ${JOBS} bash -c 'check_tidy --fix' {} + # XXX disabled until we run clang-format over the entire codebase. + #echo "${DIFF_FILES}" | xargs -I{} -P ${JOBS} bash -c 'check_format' {} + git diff-index --quiet HEAD || { + echo "Changes were made to source files - please review them before committing." + exit 1 + } + fi + echo "All looks good!" +else + git ls-files '../../../src/mbgl/*.cpp' '../../../platform/*.cpp' '../../../test/*.cpp' | \ + xargs -I{} -P ${JOBS} bash -c 'check_tidy' {} +fi -- cgit v1.2.1