From 026e6a75600f7109828fc33ff97b117a3a5090a7 Mon Sep 17 00:00:00 2001 From: jaumeolba Date: Tue, 26 Jan 2016 13:40:37 +0100 Subject: Fix Memory leak caused by duplicated add in LocationListener list The addLocationListener method didn't check if the LocationListener was already in the list. From MapView, if we call setMyLocationEnabled(true), it adds a LocationListener and onResume adds the same LocationListener again, but is just removed by onPause. So LocationListener is added twice but removed just once, so LocationServices singleton keeps an instance of the the LocationListener that is never released. --- .../src/main/java/com/mapbox/mapboxsdk/location/LocationServices.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'platform') diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationServices.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationServices.java index 74a68c3722..ac2ab64076 100644 --- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationServices.java +++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationServices.java @@ -117,7 +117,9 @@ public class LocationServices implements com.mapzen.android.lost.api.LocationLis * @param locationListener LocationListener */ public void addLocationListener(@NonNull LocationListener locationListener) { - this.locationListeners.add(locationListener); + if(!this.locationListeners.contains(locationListener)){ + this.locationListeners.add(locationListener); + } } /** -- cgit v1.2.1