From 879c44f661c5eb762c93a721b657859a71aabfc7 Mon Sep 17 00:00:00 2001 From: Alexander Shalamov Date: Fri, 4 Oct 2019 15:02:01 +0300 Subject: [core] Modularize FileSource codebase (#15768) * [core] Introduce FileSourceManager and use it for default platform impl - Add `FileSourceManager` interface that provides access to `FileSource` instances and means of registering / unregistering `FileSource` factories - Split `DefaultFileSource` into smaller parts - Add `DatabaseFileSource` interface and it's default implementation - Remove inter-dependencies between concrete `FileSource` classes * [build] Add files to next build system * [core] Add generic property setters / getters * [core] Remove setOnlineStatus from OnlineFileSource interface * [core] Hide threading implementation details from DatabaseFileSource interface * [core] Make DB file source methods virtual * [core] Add documentation for DatabaseFileSource and rename one method * [core] Use simple callback instead of ActorRef * [core] Remove ActorRef from OnlineFileSource public header * [core] Add callback to FileSource::forward async API * [core] Pass OfflineRegionDefinition by value * [core] Update tests to use modular file sources * [core] Update unit tests * [core] Update unit tests after rebase * [core] Backport low prio fix for cached requests * [core] Backport pack database * [core] Return removed factory from unRegisterFileSourceFactory * [core] Rename shadowed args in onlinefilesource * [core] Remove simple std::function callback aliases * [core] Expose online file source property keys in public header file * [test-runner] Add proxy file source test runner * [cache] Update mbgl-cache utility to use new file source * [metrics] Rebaseline binary size metrics * [offline] Update offline utility * [core] Update changelog --- metrics/next-binary-size/linux-clang8/metrics.json | 6 +++--- metrics/next-binary-size/linux-gcc8/metrics.json | 6 +++--- metrics/next-binary-size/macos-xcode11/metrics.json | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) (limited to 'metrics') diff --git a/metrics/next-binary-size/linux-clang8/metrics.json b/metrics/next-binary-size/linux-clang8/metrics.json index ef40eb2ea7..c1e7c84271 100644 --- a/metrics/next-binary-size/linux-clang8/metrics.json +++ b/metrics/next-binary-size/linux-clang8/metrics.json @@ -3,17 +3,17 @@ [ "mbgl-glfw", "/tmp/attach/install/next-linux-clang8-release/bin/mbgl-glfw", - 6380744 + 6442184 ], [ "mbgl-offline", "/tmp/attach/install/next-linux-clang8-release/bin/mbgl-offline", - 5651144 + 5720776 ], [ "mbgl-render", "/tmp/attach/install/next-linux-clang8-release/bin/mbgl-render", - 6282152 + 6343592 ] ] } \ No newline at end of file diff --git a/metrics/next-binary-size/linux-gcc8/metrics.json b/metrics/next-binary-size/linux-gcc8/metrics.json index e7c8cb0d08..d46a45d2ba 100644 --- a/metrics/next-binary-size/linux-gcc8/metrics.json +++ b/metrics/next-binary-size/linux-gcc8/metrics.json @@ -3,17 +3,17 @@ [ "mbgl-glfw", "/tmp/attach/install/next-linux-gcc8-release/bin/mbgl-glfw", - 7369032 + 7475528 ], [ "mbgl-offline", "/tmp/attach/install/next-linux-gcc8-release/bin/mbgl-offline", - 6463720 + 6570216 ], [ "mbgl-render", "/tmp/attach/install/next-linux-gcc8-release/bin/mbgl-render", - 7254344 + 7360840 ] ] } \ No newline at end of file diff --git a/metrics/next-binary-size/macos-xcode11/metrics.json b/metrics/next-binary-size/macos-xcode11/metrics.json index f516ca94ff..27b3e3b452 100644 --- a/metrics/next-binary-size/macos-xcode11/metrics.json +++ b/metrics/next-binary-size/macos-xcode11/metrics.json @@ -3,17 +3,17 @@ [ "mbgl-glfw", "/tmp/attach/install/next-macos-xcode11-release/bin/mbgl-glfw", - 5529484 + 5562556 ], [ "mbgl-offline", "/tmp/attach/install/next-macos-xcode11-release/bin/mbgl-offline", - 5389808 + 5427032 ], [ "mbgl-render", "/tmp/attach/install/next-macos-xcode11-release/bin/mbgl-render", - 5444188 + 5477244 ] ] -} \ No newline at end of file +} -- cgit v1.2.1