From 65c06e62707a9982dedf39a88904bce04df1e227 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Tue, 23 Feb 2016 14:19:50 -0800 Subject: =?UTF-8?q?[core]=20status.requiredResourceCountIsIndeterminate=20?= =?UTF-8?q?=E2=87=A2=20status.requiredResourceCountIsPrecise?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change the name and reverse the sense. Naming things in the positive is better than naming them in the negative. --- include/mbgl/storage/offline.hpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'include') diff --git a/include/mbgl/storage/offline.hpp b/include/mbgl/storage/offline.hpp index dd63cf968f..2bc286dbab 100644 --- a/include/mbgl/storage/offline.hpp +++ b/include/mbgl/storage/offline.hpp @@ -99,20 +99,21 @@ public: /** * The number of resources that are known to be required for this region. See the - * documentation for `requiredResourceCountIsIndeterminate` for an important caveat + * documentation for `requiredResourceCountIsPrecise` for an important caveat * about this number. */ uint64_t requiredResourceCount = 0; /** - * This property is true during early phases of an offline download, when the total - * required resource count is unknown and requiredResourceCount is merely a lower + * This property is true when the value of requiredResourceCount is a precise + * count of the number of required resources, and false when it is merely a lower * bound. * - * Specifically, it is true before until the style and tile sources have been - * downloaded, and false thereafter. + * Specifically, it is false during early phases of an offline download. Once + * style and tile sources have been downloaded, it is possible to calculate the + * precise number of required resources, at which point it is set to true. */ - bool requiredResourceCountIsIndeterminate = true; + bool requiredResourceCountIsPrecise = false; bool complete() const { return completedResourceCount == requiredResourceCount; -- cgit v1.2.1